From nishit.jain at oracle.com  Mon Nov  7 07:51:28 2016
From: nishit.jain at oracle.com (Nishit Jain)
Date: Mon, 7 Nov 2016 13:21:28 +0530
Subject: <i18n dev> Review Request for JDK-8166994: Improve
	sun.util.locale.LocaleMatcher
Message-ID: <3153b0c6-2c56-badb-def1-ee38da1a712b@oracle.com>

Hi,

Please review the fix for JDK-8166994

Bug: https://bugs.openjdk.java.net/browse/JDK-8166994
Webrev: http://cr.openjdk.java.net/~nishjain/8166994/webrev.02/

Fix: Modified values of LocaleEquivalentMaps.multiEquivsMap is stored in 
a temp array which is then returned, so that it does not behave 
differently in second invocation. Changed String.replace* methods with 
String.replace() at places where it is dealing with a literal string not 
with a regular expression.


Regards,
Nishit Jain

From ramanand.patil at oracle.com  Mon Nov  7 10:43:11 2016
From: ramanand.patil at oracle.com (Ramanand Patil)
Date: Mon, 7 Nov 2016 02:43:11 -0800 (PST)
Subject: <i18n dev> RFR: 8169191: (tz) Support tzdata2016i
Message-ID: <f347b8d2-83ed-46cb-a7dd-995c29b7de7c@default>

Hi all,
Please review the latest TZDATA integration (tzdata2016i) to JDK9.
Bug: https://bugs.openjdk.java.net/browse/JDK-8169191
Webrev: http://cr.openjdk.java.net/~rpatil/8169191/webrev.00/

All the TimeZone related tests are passed after integration.

Regards,
Ramanand.

From martinrb at google.com  Mon Nov  7 16:36:24 2016
From: martinrb at google.com (Martin Buchholz)
Date: Mon, 7 Nov 2016 08:36:24 -0800
Subject: <i18n dev> RFR: 8169191: (tz) Support tzdata2016i
In-Reply-To: <f347b8d2-83ed-46cb-a7dd-995c29b7de7c@default>
References: <f347b8d2-83ed-46cb-a7dd-995c29b7de7c@default>
Message-ID: <CA+kOe0-WQO4T+w_W0sbiCnq1f-rD4ZgWKhC+LUygrctQpMeXhw@mail.gmail.com>

Looks good to me!

On Mon, Nov 7, 2016 at 2:43 AM, Ramanand Patil <ramanand.patil at oracle.com>
wrote:

> Hi all,
> Please review the latest TZDATA integration (tzdata2016i) to JDK9.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8169191
> Webrev: http://cr.openjdk.java.net/~rpatil/8169191/webrev.00/
>
> All the TimeZone related tests are passed after integration.
>
> Regards,
> Ramanand.
>

From masayoshi.okutsu at oracle.com  Tue Nov  8 00:34:13 2016
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Tue, 8 Nov 2016 09:34:13 +0900
Subject: <i18n dev> Review Request for JDK-8166994: Improve
 sun.util.locale.LocaleMatcher
In-Reply-To: <3153b0c6-2c56-badb-def1-ee38da1a712b@oracle.com>
References: <3153b0c6-2c56-badb-def1-ee38da1a712b@oracle.com>
Message-ID: <3d284e8e-8c8b-a0b7-91d5-62282c6a72e7@oracle.com>

Looks good to me.

Masayoshi


On 11/7/2016 4:51 PM, Nishit Jain wrote:
> Hi,
>
> Please review the fix for JDK-8166994
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8166994
> Webrev: http://cr.openjdk.java.net/~nishjain/8166994/webrev.02/
>
> Fix: Modified values of LocaleEquivalentMaps.multiEquivsMap is stored 
> in a temp array which is then returned, so that it does not behave 
> differently in second invocation. Changed String.replace* methods with 
> String.replace() at places where it is dealing with a literal string 
> not with a regular expression.
>
>
> Regards,
> Nishit Jain


From naoto.sato at oracle.com  Tue Nov  8 00:38:59 2016
From: naoto.sato at oracle.com (Naoto Sato)
Date: Mon, 7 Nov 2016 16:38:59 -0800
Subject: <i18n dev> Review Request for JDK-8166994: Improve
 sun.util.locale.LocaleMatcher
In-Reply-To: <3153b0c6-2c56-badb-def1-ee38da1a712b@oracle.com>
References: <3153b0c6-2c56-badb-def1-ee38da1a712b@oracle.com>
Message-ID: <73b9942e-bebf-c685-9f64-a61e35b7b25c@oracle.com>

+1

Naoto

On 11/6/16 11:51 PM, Nishit Jain wrote:
> Hi,
>
> Please review the fix for JDK-8166994
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8166994
> Webrev: http://cr.openjdk.java.net/~nishjain/8166994/webrev.02/
>
> Fix: Modified values of LocaleEquivalentMaps.multiEquivsMap is stored in
> a temp array which is then returned, so that it does not behave
> differently in second invocation. Changed String.replace* methods with
> String.replace() at places where it is dealing with a literal string not
> with a regular expression.
>
>
> Regards,
> Nishit Jain

From masayoshi.okutsu at oracle.com  Tue Nov  8 04:26:42 2016
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Tue, 8 Nov 2016 13:26:42 +0900
Subject: <i18n dev> RFR: 8169191: (tz) Support tzdata2016i
In-Reply-To: <CA+kOe0-WQO4T+w_W0sbiCnq1f-rD4ZgWKhC+LUygrctQpMeXhw@mail.gmail.com>
References: <f347b8d2-83ed-46cb-a7dd-995c29b7de7c@default>
	<CA+kOe0-WQO4T+w_W0sbiCnq1f-rD4ZgWKhC+LUygrctQpMeXhw@mail.gmail.com>
Message-ID: <c7c34845-3e97-4caa-d5f9-d5aa79eba821@oracle.com>

+1

On 11/8/2016 1:36 AM, Martin Buchholz wrote:
> Looks good to me!
>
> On Mon, Nov 7, 2016 at 2:43 AM, Ramanand Patil <ramanand.patil at oracle.com>
> wrote:
>
>> Hi all,
>> Please review the latest TZDATA integration (tzdata2016i) to JDK9.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8169191
>> Webrev: http://cr.openjdk.java.net/~rpatil/8169191/webrev.00/
>>
>> All the TimeZone related tests are passed after integration.
>>
>> Regards,
>> Ramanand.
>>


From ramanand.patil at oracle.com  Thu Nov 10 09:48:00 2016
From: ramanand.patil at oracle.com (Ramanand Patil)
Date: Thu, 10 Nov 2016 01:48:00 -0800 (PST)
Subject: <i18n dev> RFR: jdk8u-dev Backport of 8169191: (tz) Support
	tzdata2016i
Message-ID: <e6fa8311-8ec9-462a-b02a-4afce32134fa@default>

Hi all,
Please review the latest TZDATA integration (tzdata2016i) to JDK8U.
Since tzdata is cumulative, this bug fix backports both the tzdata versions(tzdata2016h+tzdata2016i) into jdk8u.

Bug: https://bugs.openjdk.java.net/browse/JDK-8169191
Webrev: http://cr.openjdk.java.net/~rpatil/8169537/webrev.00/

Jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7f7091c1dd33

For reference:
Jdk9 changeset for tzdata2016h integration(JDK-8168512): http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/3192d7aa428d

All the TimeZone related tests are passed after integration.


Regards,
Ramanand.

From martinrb at google.com  Thu Nov 10 16:48:32 2016
From: martinrb at google.com (Martin Buchholz)
Date: Thu, 10 Nov 2016 08:48:32 -0800
Subject: <i18n dev> RFR: jdk8u-dev Backport of 8169191: (tz) Support
	tzdata2016i
In-Reply-To: <e6fa8311-8ec9-462a-b02a-4afce32134fa@default>
References: <e6fa8311-8ec9-462a-b02a-4afce32134fa@default>
Message-ID: <CA+kOe08SQr3u-6vAo3F3JurDtq=2Dqqcta1zC5jQ2Lf92rAoLA@mail.gmail.com>

Looks good!

On Thu, Nov 10, 2016 at 1:48 AM, Ramanand Patil <ramanand.patil at oracle.com>
wrote:

> Hi all,
> Please review the latest TZDATA integration (tzdata2016i) to JDK8U.
> Since tzdata is cumulative, this bug fix backports both the tzdata
> versions(tzdata2016h+tzdata2016i) into jdk8u.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8169191
> Webrev: http://cr.openjdk.java.net/~rpatil/8169537/webrev.00/
>
> Jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7f7091c1dd33
>
> For reference:
> Jdk9 changeset for tzdata2016h integration(JDK-8168512):
> http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/3192d7aa428d
>
> All the TimeZone related tests are passed after integration.
>
>
> Regards,
> Ramanand.
>

From masayoshi.okutsu at oracle.com  Thu Nov 10 23:15:19 2016
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Fri, 11 Nov 2016 08:15:19 +0900
Subject: <i18n dev> RFR: jdk8u-dev Backport of 8169191: (tz) Support
	tzdata2016i
In-Reply-To: <CA+kOe08SQr3u-6vAo3F3JurDtq=2Dqqcta1zC5jQ2Lf92rAoLA@mail.gmail.com>
References: <e6fa8311-8ec9-462a-b02a-4afce32134fa@default>
	<CA+kOe08SQr3u-6vAo3F3JurDtq=2Dqqcta1zC5jQ2Lf92rAoLA@mail.gmail.com>
Message-ID: <32d01d3a-decf-9750-32be-ad532612e4a7@oracle.com>

+1


On 11/11/2016 1:48 AM, Martin Buchholz wrote:
> Looks good!
>
> On Thu, Nov 10, 2016 at 1:48 AM, Ramanand Patil <ramanand.patil at oracle.com>
> wrote:
>
>> Hi all,
>> Please review the latest TZDATA integration (tzdata2016i) to JDK8U.
>> Since tzdata is cumulative, this bug fix backports both the tzdata
>> versions(tzdata2016h+tzdata2016i) into jdk8u.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8169191
>> Webrev: http://cr.openjdk.java.net/~rpatil/8169537/webrev.00/
>>
>> Jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7f7091c1dd33
>>
>> For reference:
>> Jdk9 changeset for tzdata2016h integration(JDK-8168512):
>> http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/3192d7aa428d
>>
>> All the TimeZone related tests are passed after integration.
>>
>>
>> Regards,
>> Ramanand.
>>


From rachna.goel at oracle.com  Mon Nov 14 07:12:14 2016
From: rachna.goel at oracle.com (Rachna Goel)
Date: Mon, 14 Nov 2016 12:42:14 +0530
Subject: <i18n dev> RFR:JDK-8168906-Tighten permissions granted to the
 jdk.localedata module
Message-ID: <1d18d1ad-cf80-8131-afcd-c8654f3c191c@oracle.com>

Hi,

Kindly review fix for JDK-8168906. 
https://bugs.openjdk.java.net/browse/JDK-8168906

Patch :http://cr.openjdk.java.net/~rgoel/JDK-8168906/webrev/

fix: As jdk.localedata module does read any system properties, tightened 
permissions for same.

Thanks,
Rachna

From nancy.nigam at oracle.com  Mon Nov 14 07:13:19 2016
From: nancy.nigam at oracle.com (Nancy Nigam)
Date: Mon, 14 Nov 2016 12:43:19 +0530
Subject: <i18n dev> Request for Review: JDK-8165296: update i18n test cases
 in test/java/util/
Message-ID: <70647e53-22f1-e1c9-3398-73fc3a05e2d0@oracle.com>

Hi,

Please review the fix for JDK-8165296.

Bug : https://bugs.openjdk.java.net/browse/JDK-8165296 
<https://bugs.openjdk.java.net/browse/JDK-8164791>

Webrev: http://cr.openjdk.java.net/~nishjain/Nancy/8165296/webrev.07/

Fix : Updated I18n test cases in test/java/util/ for deprecated APIs and 
data structures. Generics, Lambda Expressions, Streams and 
AutoBoxing/Unboxing are used wherever necessary.
Some formatting changes have also been done as per the current style 
guidelines.

Regards,
Nancy Nigam

From Alan.Bateman at oracle.com  Mon Nov 14 07:16:56 2016
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Mon, 14 Nov 2016 07:16:56 +0000
Subject: <i18n dev> RFR:JDK-8168906-Tighten permissions granted to the
 jdk.localedata module
In-Reply-To: <1d18d1ad-cf80-8131-afcd-c8654f3c191c@oracle.com>
References: <1d18d1ad-cf80-8131-afcd-c8654f3c191c@oracle.com>
Message-ID: <e3379094-a829-eeee-28d7-36d01cfc1bc7@oracle.com>

On 14/11/2016 07:12, Rachna Goel wrote:

> Hi,
>
> Kindly review fix for JDK-8168906. 
> https://bugs.openjdk.java.net/browse/JDK-8168906
>
> Patch :http://cr.openjdk.java.net/~rgoel/JDK-8168906/webrev/
>
> fix: As jdk.localedata module does read any system properties, 
> tightened permissions for same.
If you are sure it doesn't read any properties (or call anything that 
read properties without wrapping it in a privileged block) then it looks 
good.

-Alan

From rachna.goel at oracle.com  Mon Nov 14 07:27:35 2016
From: rachna.goel at oracle.com (Rachna Goel)
Date: Mon, 14 Nov 2016 12:57:35 +0530
Subject: <i18n dev> RFR:JDK-8168906-Tighten permissions granted to the
 jdk.localedata module
In-Reply-To: <1d18d1ad-cf80-8131-afcd-c8654f3c191c@oracle.com>
References: <1d18d1ad-cf80-8131-afcd-c8654f3c191c@oracle.com>
Message-ID: <7da1a463-a876-8385-af18-8c5f41cd1f7c@oracle.com>

sorry, correction to typo

As jdk.localedata module does  *not* read any system properties, 
tightened permissions for same.


On 14/11/16 12:42 PM, Rachna Goel wrote:
> Hi,
>
> Kindly review fix for JDK-8168906. 
> https://bugs.openjdk.java.net/browse/JDK-8168906
>
> Patch :http://cr.openjdk.java.net/~rgoel/JDK-8168906/webrev/
>
> fix: As jdk.localedata module does read any system properties, 
> tightened permissions for same.
>
> Thanks,
> Rachna


From sean.mullan at oracle.com  Mon Nov 14 14:59:22 2016
From: sean.mullan at oracle.com (Sean Mullan)
Date: Mon, 14 Nov 2016 09:59:22 -0500
Subject: <i18n dev> RFR:JDK-8168906-Tighten permissions granted to the
 jdk.localedata module
In-Reply-To: <7da1a463-a876-8385-af18-8c5f41cd1f7c@oracle.com>
References: <1d18d1ad-cf80-8131-afcd-c8654f3c191c@oracle.com>
	<7da1a463-a876-8385-af18-8c5f41cd1f7c@oracle.com>
Message-ID: <b73d1f8b-8bcd-e53b-1c74-48ba5d368862@oracle.com>

Looks good. Are there any regression tests for this component that run 
with a SecurityManager? If not, it would be useful to add some to ensure 
that the proper permissions are being granted to this module.

--Sean

On 11/14/16 2:27 AM, Rachna Goel wrote:
> sorry, correction to typo
>
> As jdk.localedata module does  *not* read any system properties,
> tightened permissions for same.
>
>
> On 14/11/16 12:42 PM, Rachna Goel wrote:
>> Hi,
>>
>> Kindly review fix for JDK-8168906.
>> https://bugs.openjdk.java.net/browse/JDK-8168906
>>
>> Patch :http://cr.openjdk.java.net/~rgoel/JDK-8168906/webrev/
>>
>> fix: As jdk.localedata module does read any system properties,
>> tightened permissions for same.
>>
>> Thanks,
>> Rachna
>

From naoto.sato at oracle.com  Mon Nov 14 16:07:32 2016
From: naoto.sato at oracle.com (Naoto Sato)
Date: Mon, 14 Nov 2016 08:07:32 -0800
Subject: <i18n dev> RFR:JDK-8168906-Tighten permissions granted to the
 jdk.localedata module
In-Reply-To: <1d18d1ad-cf80-8131-afcd-c8654f3c191c@oracle.com>
References: <1d18d1ad-cf80-8131-afcd-c8654f3c191c@oracle.com>
Message-ID: <5f378665-d589-08d7-59fa-c8ed9638e4a9@oracle.com>

+1

Naoto

On 11/13/16 11:12 PM, Rachna Goel wrote:
> Hi,
>
> Kindly review fix for JDK-8168906.
> https://bugs.openjdk.java.net/browse/JDK-8168906
>
> Patch :http://cr.openjdk.java.net/~rgoel/JDK-8168906/webrev/
>
> fix: As jdk.localedata module does read any system properties, tightened
> permissions for same.
>
> Thanks,
> Rachna

From masayoshi.okutsu at oracle.com  Wed Nov 16 15:21:56 2016
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Thu, 17 Nov 2016 00:21:56 +0900
Subject: <i18n dev> Request for Review: JDK-8165296: update i18n test
 cases in test/java/util/
In-Reply-To: <70647e53-22f1-e1c9-3398-73fc3a05e2d0@oracle.com>
References: <70647e53-22f1-e1c9-3398-73fc3a05e2d0@oracle.com>
Message-ID: <6f9b1e81-ce53-5729-f911-d11d6dd317b3@oracle.com>

Looks good to me.

Masayoshi


On 11/14/2016 4:13 PM, Nancy Nigam wrote:
> Hi,
>
> Please review the fix for JDK-8165296.
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8165296 
> <https://bugs.openjdk.java.net/browse/JDK-8164791>
>
> Webrev: http://cr.openjdk.java.net/~nishjain/Nancy/8165296/webrev.07/
>
> Fix : Updated I18n test cases in test/java/util/ for deprecated APIs 
> and data structures. Generics, Lambda Expressions, Streams and 
> AutoBoxing/Unboxing are used wherever necessary.
> Some formatting changes have also been done as per the current style 
> guidelines.
>
> Regards,
> Nancy Nigam


From masayoshi.okutsu at oracle.com  Thu Nov 17 00:04:29 2016
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Thu, 17 Nov 2016 09:04:29 +0900
Subject: <i18n dev> RFR:JDK-8168906-Tighten permissions granted to the
 jdk.localedata module
In-Reply-To: <b73d1f8b-8bcd-e53b-1c74-48ba5d368862@oracle.com>
References: <1d18d1ad-cf80-8131-afcd-c8654f3c191c@oracle.com>
	<7da1a463-a876-8385-af18-8c5f41cd1f7c@oracle.com>
	<b73d1f8b-8bcd-e53b-1c74-48ba5d368862@oracle.com>
Message-ID: <6706e4e5-be1d-8d61-c1b7-a7249a955011@oracle.com>

test/sun/util/locale/provider/Bug8152817.java is a test with a 
SecurityManager. I18n SQE should have some.

Masayoshi


On 11/14/2016 11:59 PM, Sean Mullan wrote:
> Looks good. Are there any regression tests for this component that run 
> with a SecurityManager? If not, it would be useful to add some to 
> ensure that the proper permissions are being granted to this module.
>
> --Sean
>
> On 11/14/16 2:27 AM, Rachna Goel wrote:
>> sorry, correction to typo
>>
>> As jdk.localedata module does  *not* read any system properties,
>> tightened permissions for same.
>>
>>
>> On 14/11/16 12:42 PM, Rachna Goel wrote:
>>> Hi,
>>>
>>> Kindly review fix for JDK-8168906.
>>> https://bugs.openjdk.java.net/browse/JDK-8168906
>>>
>>> Patch :http://cr.openjdk.java.net/~rgoel/JDK-8168906/webrev/
>>>
>>> fix: As jdk.localedata module does read any system properties,
>>> tightened permissions for same.
>>>
>>> Thanks,
>>> Rachna
>>


From masayoshi.okutsu at oracle.com  Thu Nov 17 00:04:58 2016
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Thu, 17 Nov 2016 09:04:58 +0900
Subject: <i18n dev> RFR:JDK-8168906-Tighten permissions granted to the
 jdk.localedata module
In-Reply-To: <5f378665-d589-08d7-59fa-c8ed9638e4a9@oracle.com>
References: <1d18d1ad-cf80-8131-afcd-c8654f3c191c@oracle.com>
	<5f378665-d589-08d7-59fa-c8ed9638e4a9@oracle.com>
Message-ID: <cf5ed967-c345-755d-e280-f86f20d9c08c@oracle.com>

+1

Masayoshi


On 11/15/2016 1:07 AM, Naoto Sato wrote:
> +1
>
> Naoto
>
> On 11/13/16 11:12 PM, Rachna Goel wrote:
>> Hi,
>>
>> Kindly review fix for JDK-8168906.
>> https://bugs.openjdk.java.net/browse/JDK-8168906
>>
>> Patch :http://cr.openjdk.java.net/~rgoel/JDK-8168906/webrev/
>>
>> fix: As jdk.localedata module does read any system properties, tightened
>> permissions for same.
>>
>> Thanks,
>> Rachna


From rachna.goel at oracle.com  Fri Nov 18 10:31:57 2016
From: rachna.goel at oracle.com (Rachna Goel)
Date: Fri, 18 Nov 2016 16:01:57 +0530
Subject: <i18n dev> RFR: JDK-8071929-Locale.getISOCountries() has
 inconsistent behaviour for "AN", "BU" and "CS" country codes
Message-ID: <8eab8241-f504-c08c-340d-77b26e2b614d@oracle.com>

Hi,

Please review fix for JDK-8071929.

Bug :  https://bugs.openjdk.java.net/browse/JDK-8071929

patch : http://cr.openjdk.java.net/~rgoel/JDK-8071929/webrev.01/

Fix is to remove obsolete country code "AN" and provide support for 
retrieving of ISO3166-1 alpha-2, ISO3166-1 alpha-3, ISO3166-3 country codes.

Thanks,
Rachna



From rachna.goel at oracle.com  Tue Nov 22 09:30:08 2016
From: rachna.goel at oracle.com (Rachna Goel)
Date: Tue, 22 Nov 2016 15:00:08 +0530
Subject: <i18n dev> RFR: JDK-8075577: java.time does not support HOST
	provider
Message-ID: <ee93bd98-649f-17af-15c3-1727950953ff@oracle.com>

Hi,

Please review fix for JDK-8075577.

Bug : https://bugs.openjdk.java.net/browse/JDK-8075577

webrev : http://cr.openjdk.java.net/~rgoel/JDK-8075577/webrev.01/

Fix is to introduce new private spi 
"sun.text.spi.JavaTimeDateTimePatternProvider.java"  to retrieve 
LocaleProvider specific Date/Time Patterns for "java.time" .

Thanks,
Rachna




From ramanand.patil at oracle.com  Mon Nov 28 09:24:25 2016
From: ramanand.patil at oracle.com (Ramanand Patil)
Date: Mon, 28 Nov 2016 01:24:25 -0800 (PST)
Subject: <i18n dev> RFR: 8169191: (tz) Support tzdata2016j
Message-ID: <31739ca3-0ad5-418e-963b-be01ac2ef6c4@default>

Hi all,
Please review the latest TZDATA integration (tzdata2016j) to JDK9.
Bug: https://bugs.openjdk.java.net/browse/JDK-8170316
Webrev: http://cr.openjdk.java.net/~rpatil/8170316/webrev.00/

All the TimeZone related tests are passed after integration.

Regards,
Ramanand.

From martinrb at google.com  Mon Nov 28 19:28:30 2016
From: martinrb at google.com (Martin Buchholz)
Date: Mon, 28 Nov 2016 11:28:30 -0800
Subject: <i18n dev> RFR: 8169191: (tz) Support tzdata2016j
In-Reply-To: <31739ca3-0ad5-418e-963b-be01ac2ef6c4@default>
References: <31739ca3-0ad5-418e-963b-be01ac2ef6c4@default>
Message-ID: <CA+kOe0_MRx72HDTXpoMED2O24AD5GaNXGTHn5yrxzLwTbrMC_Q@mail.gmail.com>

Thanks as always for keeping the tzdata pipeline moving!
Looks good to me.

On Mon, Nov 28, 2016 at 1:24 AM, Ramanand Patil <ramanand.patil at oracle.com>
wrote:

> Hi all,
> Please review the latest TZDATA integration (tzdata2016j) to JDK9.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8170316
> Webrev: http://cr.openjdk.java.net/~rpatil/8170316/webrev.00/
>
> All the TimeZone related tests are passed after integration.
>
> Regards,
> Ramanand.
>

From rachna.goel at oracle.com  Tue Nov 29 09:07:51 2016
From: rachna.goel at oracle.com (Rachna Goel)
Date: Tue, 29 Nov 2016 14:37:51 +0530
Subject: <i18n dev> Request for Review : JDK-8071929
 -Locale.getISOCountries() has inconsistent behaviour for "AN",
 "BU" and "CS" country codes.
Message-ID: <27108efc-2ff4-368a-8fc6-c8ded5689a45@oracle.com>

Hi,

Please review fix for JDK-8071929.

Bug : https://bugs.openjdk.java.net/browse/JDK-8071929

patch : http://cr.openjdk.java.net/~rgoel/JDK_8071929/webrev.02/

Fix is to remove obsolete country code "AN" and provide support for 
retrieving of ISO3166-1 alpha-2,  ISO3166-1 alpha-3, ISO3166-3 country 
codes.

Thanks,
Rachna


From naoto.sato at oracle.com  Tue Nov 29 17:28:07 2016
From: naoto.sato at oracle.com (Naoto Sato)
Date: Tue, 29 Nov 2016 09:28:07 -0800
Subject: <i18n dev> Request for Review : JDK-8071929
 -Locale.getISOCountries() has inconsistent behaviour for "AN",
 "BU" and "CS" country codes.
In-Reply-To: <27108efc-2ff4-368a-8fc6-c8ded5689a45@oracle.com>
References: <27108efc-2ff4-368a-8fc6-c8ded5689a45@oracle.com>
Message-ID: <6835e1e9-0b11-9c4a-db0d-2d0ec7d09630@oracle.com>

Looks good to me.

Naoto

On 11/29/16 1:07 AM, Rachna Goel wrote:
> Hi,
>
> Please review fix for JDK-8071929.
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8071929
>
> patch : http://cr.openjdk.java.net/~rgoel/JDK_8071929/webrev.02/
>
> Fix is to remove obsolete country code "AN" and provide support for
> retrieving of ISO3166-1 alpha-2,  ISO3166-1 alpha-3, ISO3166-3 country
> codes.
>
> Thanks,
> Rachna
>

From scolebourne at joda.org  Tue Nov 29 21:45:18 2016
From: scolebourne at joda.org (Stephen Colebourne)
Date: Tue, 29 Nov 2016 21:45:18 +0000
Subject: <i18n dev> Request for Review : JDK-8071929
 -Locale.getISOCountries() has inconsistent behaviour for "AN",
 "BU" and "CS" country codes.
In-Reply-To: <27108efc-2ff4-368a-8fc6-c8ded5689a45@oracle.com>
References: <27108efc-2ff4-368a-8fc6-c8ded5689a45@oracle.com>
Message-ID: <CACzrW9By4kcALojo_-VowJ0640fpwQe0HzNsXAREkvaqiGm0HA@mail.gmail.com>

I'm concerned that this is not the friendliest of new APIs. There is
little description of the meaning of the ISO-3166 parts - what is
being added is directly exposing the underlying data rather than
providing any kind of abstraction.

There is also an inconsistency between "ISO" and "Iso" in the class/method names

Stephen


On 29 November 2016 at 09:07, Rachna Goel <rachna.goel at oracle.com> wrote:
> Hi,
>
> Please review fix for JDK-8071929.
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8071929
>
> patch : http://cr.openjdk.java.net/~rgoel/JDK_8071929/webrev.02/
>
> Fix is to remove obsolete country code "AN" and provide support for
> retrieving of ISO3166-1 alpha-2,  ISO3166-1 alpha-3, ISO3166-3 country
> codes.
>
> Thanks,
> Rachna
>

From masayoshi.okutsu at oracle.com  Wed Nov 30 04:12:42 2016
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Wed, 30 Nov 2016 13:12:42 +0900
Subject: <i18n dev> Request for Review : JDK-8071929
 -Locale.getISOCountries() has inconsistent behaviour for "AN",
 "BU" and "CS" country codes.
In-Reply-To: <27108efc-2ff4-368a-8fc6-c8ded5689a45@oracle.com>
References: <27108efc-2ff4-368a-8fc6-c8ded5689a45@oracle.com>
Message-ID: <fa571969-c7e6-864c-3c08-ef9b9712d760@oracle.com>

Hi Rachna,

It's still unclear for me how this addition will be useful for 
applications. But here are my comments on the implementation.

src/java.base/share/classes/java/util/LocaleISOData.java:
- iso3166CodesMap has to use a ConcurrentHashMap.
- The following code should use AssertionError rather than assert.

509 default:
510 // should not happen
511 assert false;
512 return Collections.emptySet();

- Another implementation option would be to move the new get* methods 
and the cache to Locale.IsoCountryCode so that the default case can be 
avoided.

Thanks,
Masayoshi

On 11/29/2016 6:07 PM, Rachna Goel wrote:
> Hi,
>
> Please review fix for JDK-8071929.
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8071929
>
> patch : http://cr.openjdk.java.net/~rgoel/JDK_8071929/webrev.02/
>
> Fix is to remove obsolete country code "AN" and provide support for 
> retrieving of ISO3166-1 alpha-2,  ISO3166-1 alpha-3, ISO3166-3 country 
> codes.
>
> Thanks,
> Rachna
>


From masayoshi.okutsu at oracle.com  Wed Nov 30 04:37:52 2016
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Wed, 30 Nov 2016 13:37:52 +0900
Subject: <i18n dev> RFR: 8169191: (tz) Support tzdata2016j
In-Reply-To: <CA+kOe0_MRx72HDTXpoMED2O24AD5GaNXGTHn5yrxzLwTbrMC_Q@mail.gmail.com>
References: <31739ca3-0ad5-418e-963b-be01ac2ef6c4@default>
	<CA+kOe0_MRx72HDTXpoMED2O24AD5GaNXGTHn5yrxzLwTbrMC_Q@mail.gmail.com>
Message-ID: <852b8995-4c71-7b8f-29a6-d09872a8ba4d@oracle.com>

Sorry, but I was confused with the wrong bug ID in Subject...

Looks good to me.

Masayoshi


On 11/29/2016 4:28 AM, Martin Buchholz wrote:
> Thanks as always for keeping the tzdata pipeline moving!
> Looks good to me.
>
> On Mon, Nov 28, 2016 at 1:24 AM, Ramanand Patil <ramanand.patil at oracle.com>
> wrote:
>
>> Hi all,
>> Please review the latest TZDATA integration (tzdata2016j) to JDK9.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8170316
>> Webrev: http://cr.openjdk.java.net/~rpatil/8170316/webrev.00/
>>
>> All the TimeZone related tests are passed after integration.
>>
>> Regards,
>> Ramanand.
>>


From ramanand.patil at oracle.com  Wed Nov 30 05:24:49 2016
From: ramanand.patil at oracle.com (Ramanand Patil)
Date: Tue, 29 Nov 2016 21:24:49 -0800 (PST)
Subject: <i18n dev> RFR: 8170316: (tz) Support tzdata2016j
Message-ID: <ba1da6ef-4349-4ea2-8f42-89db4430a686@default>

Hi Masayoshi,

Sorry, that was an error from my side. Thank you for pointing that out and for your review.

[Changed the BugID in Subject now].

Regards,
Ramanand.

-----Original Message-----
From: Masayoshi Okutsu 
Sent: Wednesday, November 30, 2016 10:08 AM
To: Ramanand Patil <ramanand.patil at oracle.com>
Cc: Martin Buchholz <martinrb at google.com>; core-libs-dev <core-libs-dev at openjdk.java.net>; i18n-dev at openjdk.java.net
Subject: Re: <i18n dev> RFR: 8169191: (tz) Support tzdata2016j

Sorry, but I was confused with the wrong bug ID in Subject...

Looks good to me.

Masayoshi


On 11/29/2016 4:28 AM, Martin Buchholz wrote:
> Thanks as always for keeping the tzdata pipeline moving!
> Looks good to me.
>
> On Mon, Nov 28, 2016 at 1:24 AM, Ramanand Patil <ramanand.patil at oracle.com>
> wrote:
>
>> Hi all,
>> Please review the latest TZDATA integration (tzdata2016j) to JDK9.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8170316
>> Webrev: http://cr.openjdk.java.net/~rpatil/8170316/webrev.00/
>>
>> All the TimeZone related tests are passed after integration.
>>
>> Regards,
>> Ramanand.
>>


From ramanand.patil at oracle.com  Wed Nov 30 05:24:58 2016
From: ramanand.patil at oracle.com (Ramanand Patil)
Date: Tue, 29 Nov 2016 21:24:58 -0800 (PST)
Subject: <i18n dev> RFR: 8170316: (tz) Support tzdata2016j
Message-ID: <1b639ecd-8af9-4693-8b22-dae8750d0980@default>

Thank you Martin.

?

Regards,

Ramanand.

From: Martin Buchholz [mailto:martinrb at google.com] 
Sent: Tuesday, November 29, 2016 12:59 AM
To: Ramanand Patil <ramanand.patil at oracle.com>
Cc: i18n-dev at openjdk.java.net; core-libs-dev <core-libs-dev at openjdk.java.net>
Subject: Re: <i18n dev> RFR: 8169191: (tz) Support tzdata2016j

?

Thanks as always for keeping the tzdata pipeline moving!

Looks good to me.

?

On Mon, Nov 28, 2016 at 1:24 AM, Ramanand Patil <HYPERLINK "mailto:ramanand.patil at oracle.com"ramanand.patil at oracle.com> wrote:

Hi all,
Please review the latest TZDATA integration (tzdata2016j) to JDK9.
Bug: https://bugs.openjdk.java.net/browse/JDK-8170316
Webrev: http://cr.openjdk.java.net/~rpatil/8170316/webrev.00/

All the TimeZone related tests are passed after integration.

Regards,
Ramanand.

?

From rachna.goel at oracle.com  Wed Nov 30 09:31:57 2016
From: rachna.goel at oracle.com (Rachna Goel)
Date: Wed, 30 Nov 2016 15:01:57 +0530
Subject: <i18n dev> Request for Review : JDK-8071929
 -Locale.getISOCountries() has inconsistent behaviour for "AN",
 "BU" and "CS" country codes.
In-Reply-To: <CACzrW9By4kcALojo_-VowJ0640fpwQe0HzNsXAREkvaqiGm0HA@mail.gmail.com>
References: <27108efc-2ff4-368a-8fc6-c8ded5689a45@oracle.com>
	<CACzrW9By4kcALojo_-VowJ0640fpwQe0HzNsXAREkvaqiGm0HA@mail.gmail.com>
Message-ID: <dc76bfcc-1dd4-6216-e528-e63d1a7926f0@oracle.com>

Hi Stephen,

Thanks a lot for the review.

On 30/11/16 3:15 AM, Stephen Colebourne wrote:
> I'm concerned that this is not the friendliest of new APIs. There is
> little description of the meaning of the ISO-3166 parts - what is
> being added is directly exposing the underlying data rather than
> providing any kind of abstraction.
Could you throw more light on this? Country code data is already 
encapsulated, and there is no direct reference to map accessing those data.
If you have some suggestions on improving it, kindly share.
> There is also an inconsistency between "ISO" and "Iso" in the class/method names.
There has been lot of discussion regarding "ISO" and "Iso". CCC has 
suggested use of "IsoCountryCode" for enum name which I proposed to be 
"ISOCountrycode" .

I have tried to keep constants as "ISO", variables as "iso" as per with 
JDK naming conventions. But Locale class has methods names with  "ISO", 
So I think I will update all internal method names to have "ISO".

Thanks,
Rachna

>
> Stephen
>
>
> On 29 November 2016 at 09:07, Rachna Goel<rachna.goel at oracle.com>  wrote:
>> Hi,
>>
>> Please review fix for JDK-8071929.
>>
>> Bug :https://bugs.openjdk.java.net/browse/JDK-8071929
>>
>> patch :http://cr.openjdk.java.net/~rgoel/JDK_8071929/webrev.02/
>>
>> Fix is to remove obsolete country code "AN" and provide support for
>> retrieving of ISO3166-1 alpha-2,  ISO3166-1 alpha-3, ISO3166-3 country
>> codes.
>>
>> Thanks,
>> Rachna
>>


From masayoshi.okutsu at oracle.com  Wed Nov 30 09:39:04 2016
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Wed, 30 Nov 2016 18:39:04 +0900
Subject: <i18n dev> RFR: JDK-8075577: java.time does not support HOST
	provider
In-Reply-To: <ee93bd98-649f-17af-15c3-1727950953ff@oracle.com>
References: <ee93bd98-649f-17af-15c3-1727950953ff@oracle.com>
Message-ID: <59be845e-7afa-45c7-a7b1-6fe6e01c4edc@oracle.com>

Looks good to me.

Masayoshi


On 11/22/2016 6:30 PM, Rachna Goel wrote:
> Hi,
>
> Please review fix for JDK-8075577.
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8075577
>
> webrev : http://cr.openjdk.java.net/~rgoel/JDK-8075577/webrev.01/
>
> Fix is to introduce new private spi 
> "sun.text.spi.JavaTimeDateTimePatternProvider.java"  to retrieve 
> LocaleProvider specific Date/Time Patterns for "java.time" .
>
> Thanks,
> Rachna
>
>
>


From scolebourne at joda.org  Wed Nov 30 11:37:55 2016
From: scolebourne at joda.org (Stephen Colebourne)
Date: Wed, 30 Nov 2016 11:37:55 +0000
Subject: <i18n dev> Request for Review : JDK-8071929
 -Locale.getISOCountries() has inconsistent behaviour for "AN",
 "BU" and "CS" country codes.
In-Reply-To: <dc76bfcc-1dd4-6216-e528-e63d1a7926f0@oracle.com>
References: <27108efc-2ff4-368a-8fc6-c8ded5689a45@oracle.com>
	<CACzrW9By4kcALojo_-VowJ0640fpwQe0HzNsXAREkvaqiGm0HA@mail.gmail.com>
	<dc76bfcc-1dd4-6216-e528-e63d1a7926f0@oracle.com>
Message-ID: <CACzrW9A2zcZ1Z6X_Avs3R0_OOSy1SWqOkD3KgjdPGH4MEet0rw@mail.gmail.com>

The ISO-3166-3 code is of a complex form and not widely used as far as
I know. As far as I can tell, it is not legal to create a Locale
instance using the ISO-3166-3 code as the country.

At the very least, the PART3 constant should describe the meaning and
structure of the codes.

What might be useful would be a much more detailed result, where a
user could lookup an old code and find out when it expired, and what
replaced it.

Stephen


On 30 November 2016 at 09:31, Rachna Goel <rachna.goel at oracle.com> wrote:
> Hi Stephen,
>
> Thanks a lot for the review.
>
> On 30/11/16 3:15 AM, Stephen Colebourne wrote:
>
> I'm concerned that this is not the friendliest of new APIs. There is
> little description of the meaning of the ISO-3166 parts - what is
> being added is directly exposing the underlying data rather than
> providing any kind of abstraction.
>
> Could you throw more light on this? Country code data is already
> encapsulated, and there is no direct reference to map accessing those data.
> If you have some suggestions on improving it, kindly share.
>
> There is also an inconsistency between "ISO" and "Iso" in the class/method
> names.
>
> There has been lot of discussion regarding "ISO" and "Iso". CCC has
> suggested use of "IsoCountryCode" for enum name which I proposed to be
> "ISOCountrycode" .
>
> I have tried to keep constants as "ISO", variables as "iso" as per with JDK
> naming conventions. But Locale class has methods names with  "ISO", So I
> think I will update all internal method names to have "ISO".
>
> Thanks,
> Rachna
>
>
> Stephen
>
>
> On 29 November 2016 at 09:07, Rachna Goel <rachna.goel at oracle.com> wrote:
>
> Hi,
>
> Please review fix for JDK-8071929.
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8071929
>
> patch : http://cr.openjdk.java.net/~rgoel/JDK_8071929/webrev.02/
>
> Fix is to remove obsolete country code "AN" and provide support for
> retrieving of ISO3166-1 alpha-2,  ISO3166-1 alpha-3, ISO3166-3 country
> codes.
>
> Thanks,
> Rachna
>
>

From rachna.goel at oracle.com  Wed Nov 30 15:33:11 2016
From: rachna.goel at oracle.com (Rachna Goel)
Date: Wed, 30 Nov 2016 21:03:11 +0530
Subject: <i18n dev> Request for Review : JDK-8071929
 -Locale.getISOCountries() has inconsistent behaviour for "AN",
 "BU" and "CS" country codes.
In-Reply-To: <CACzrW9A2zcZ1Z6X_Avs3R0_OOSy1SWqOkD3KgjdPGH4MEet0rw@mail.gmail.com>
References: <27108efc-2ff4-368a-8fc6-c8ded5689a45@oracle.com>
	<CACzrW9By4kcALojo_-VowJ0640fpwQe0HzNsXAREkvaqiGm0HA@mail.gmail.com>
	<dc76bfcc-1dd4-6216-e528-e63d1a7926f0@oracle.com>
	<CACzrW9A2zcZ1Z6X_Avs3R0_OOSy1SWqOkD3KgjdPGH4MEet0rw@mail.gmail.com>
Message-ID: <31fbe667-8ca5-ab9d-617a-5cd100848d41@oracle.com>

  Hi Stephen,

Please find my comments inlined.

On 30/11/16 5:07 PM, Stephen Colebourne wrote:
> The ISO-3166-3 code is of a complex form and not widely used as far as
> I know. As far as I can tell, it is not legal to create a Locale
> instance using the ISO-3166-3 code as the country.
Yes, Agreed..API doc of Locale constructors mentions that, which type of 
country codes are valid input.
> At the very least, the PART3 constant should describe the meaning and
> structure of the codes.
I think, API doc of getISOCountries() to be updated mentions that :


* ISO3166-3 codes which designate country codes for those obsolete codes,
      * can be retrieved from {@link 
#getISOCountries(Locale.IsoCountryCode type)} with
       * {@code type}  {@link IsoCountryCode#PART3}.
>
> What might be useful would be a much more detailed result, where a
> user could lookup an old code and find out when it expired, and what
> replaced it.
I think that again depends on applications requirements.
For this new method may need to be added, may be handled under separate 
JBS entry.
> Stephen
>
>
> On 30 November 2016 at 09:31, Rachna Goel <rachna.goel at oracle.com> wrote:
>> Hi Stephen,
>>
>> Thanks a lot for the review.
>>
>> On 30/11/16 3:15 AM, Stephen Colebourne wrote:
>>
>> I'm concerned that this is not the friendliest of new APIs. There is
>> little description of the meaning of the ISO-3166 parts - what is
>> being added is directly exposing the underlying data rather than
>> providing any kind of abstraction.
>>
>> Could you throw more light on this? Country code data is already
>> encapsulated, and there is no direct reference to map accessing those data.
>> If you have some suggestions on improving it, kindly share.
>>
>> There is also an inconsistency between "ISO" and "Iso" in the class/method
>> names.
>>
>> There has been lot of discussion regarding "ISO" and "Iso". CCC has
>> suggested use of "IsoCountryCode" for enum name which I proposed to be
>> "ISOCountrycode" .
>>
>> I have tried to keep constants as "ISO", variables as "iso" as per with JDK
>> naming conventions. But Locale class has methods names with  "ISO", So I
>> think I will update all internal method names to have "ISO".
>>
>> Thanks,
>> Rachna
>>
>>
>> Stephen
>>
>>
>> On 29 November 2016 at 09:07, Rachna Goel <rachna.goel at oracle.com> wrote:
>>
>> Hi,
>>
>> Please review fix for JDK-8071929.
>>
>> Bug : https://bugs.openjdk.java.net/browse/JDK-8071929
>>
>> patch : http://cr.openjdk.java.net/~rgoel/JDK_8071929/webrev.02/
>>
>> Fix is to remove obsolete country code "AN" and provide support for
>> retrieving of ISO3166-1 alpha-2,  ISO3166-1 alpha-3, ISO3166-3 country
>> codes.
>>
>> Thanks,
>> Rachna
>>
>>


From li.jiang at oracle.com  Wed Nov 30 16:16:17 2016
From: li.jiang at oracle.com (Leo Jiang)
Date: Thu, 1 Dec 2016 00:16:17 +0800
Subject: <i18n dev> RFR: 7037368: Currency names missing in some locales
Message-ID: <0d1d973e-3dce-d7fe-3fa7-f8e30f640ba3@oracle.com>

Hi,

Please review
http://cr.openjdk.java.net/~ljiang/7037368/

for bug
https://bugs.openjdk.java.net/browse/JDK-7037368

I checked the currency names listed in the bug description, and got the fix according to CLDR data.

Thanks,
Leo

From masayoshi.okutsu at oracle.com  Wed Nov 30 23:59:08 2016
From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu)
Date: Thu, 1 Dec 2016 08:59:08 +0900
Subject: <i18n dev> Resigning as the Internationalization Group Lead
Message-ID: <bdf48e41-7b3b-60c0-9baa-9422d935646e@oracle.com>

I am resigning as the lead of this group because I'm leaving the company.

Thanks,
Masayoshi