<i18n dev> Review Request for JDK-8165984: ResourceBundle lookup fields not completely thread-safe

Naoto Sato naoto.sato at oracle.com
Fri Sep 16 17:00:48 UTC 2016


Looks good.

BTW, I believe making it "final" means to make sure every threads are 
guaranteed to see the same value, not because it is not changed after 
the construction.

Naoto

On 9/16/16 2:09 AM, Nishit Jain wrote:
> Hi,
>
> Please review the fix for JDK-8165984
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8165984
> Webrev: http://cr.openjdk.java.net/~nishjain/8165984/webrev.01/
>
> Fix: the private lookup variable is made final in PropertyResourceBundle
> as after initialization it is not changed anywhere. lookup variable is
> made volatile in ListResourceBundle to make sure that multiple threads
> read the value from main memory.
>
> Regards,
> Nishit Jain


More information about the i18n-dev mailing list