From naoto.sato at oracle.com  Wed Apr  5 21:14:55 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Wed, 5 Apr 2017 14:14:55 -0700
Subject: <i18n dev> [8u] RFR: 8177776: Create an equivalent test case
 for JDK9's SupplementalJapaneseEraTest
In-Reply-To: <69774039-1980-882f-2f89-fac194fd7fa7@oracle.com>
References: <69774039-1980-882f-2f89-fac194fd7fa7@oracle.com>
Message-ID: <d424dc05-691c-c9a2-8b45-4d73c2a70375@oracle.com>

I revised the test case not to rely on shell script. Please review.

http://cr.openjdk.java.net/~naoto/8177776/webrev.01/

Naoto

On 3/30/17 2:10 PM, Naoto Sato wrote:
> Hello,
>
> Please review the changes to the following issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8177776
>
> The proposed change is located at:
>
> http://cr.openjdk.java.net/~naoto/8177776/webrev.00/
>
> This is for backporting fixes for JapaneseEra related issues (8054214,
> 8173423). The original fixes in JDK9 included a test case,
> SupplementalJapaneseEraTest which is intended for the system property
> testing. The above proposed fix intends to adapt that test case into
> JDK8, where calendars.properties file is used instead of the system
> property. The test is pretty much identical to JDK9's. The difference is
> to deal with the calendars.properties file and removed some
> non-applicable cases in JDK8.
>
> Naoto

From brent.christian at oracle.com  Thu Apr  6 20:08:23 2017
From: brent.christian at oracle.com (Brent Christian)
Date: Thu, 6 Apr 2017 13:08:23 -0700
Subject: <i18n dev> [8u] RFR: 8177776: Create an equivalent test case
 for JDK9's SupplementalJapaneseEraTest
In-Reply-To: <d424dc05-691c-c9a2-8b45-4d73c2a70375@oracle.com>
References: <69774039-1980-882f-2f89-fac194fd7fa7@oracle.com>
 <d424dc05-691c-c9a2-8b45-4d73c2a70375@oracle.com>
Message-ID: <5a64d6fc-9cf2-6a04-9f92-fd7d75c957bd@oracle.com>

Hi, Naoto

On 4/5/17 2:14 PM, Naoto Sato wrote:
> I revised the test case not to rely on shell script.

Yay!  Hopefully this can also happen sometime for JDK 9+.

> http://cr.openjdk.java.net/~naoto/8177776/webrev.01/

Looks fine to me, Naoto.  A few comments:

* I presume additional @bug values will be added as other fixes are 
backported (e.g. 8054214).

* On

   73         Path dst = Paths.get("testjava").toAbsolutePath();

This places "dst" within the scratch directory, then?  (I thought there 
was a jtreg system property for the scratch directory, but I can't find 
it so I think I'm mis-remembering).

I agree with letting jtreg take care of cleaning up "scratch".

If anything goes wrong with copying of the JDK (e.g. full disk), 
hopefully it would be easy to diagnose, with an IOException with a full 
stack trace.

* Have you confirmed (if it's practical to do so) that this test fails 
when expected (detects a bug)?

Thanks,
-Brent

> On 3/30/17 2:10 PM, Naoto Sato wrote:
>> Hello,
>>
>> Please review the changes to the following issue:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8177776
>>
>> The proposed change is located at:
>>
>> http://cr.openjdk.java.net/~naoto/8177776/webrev.00/
>>
>> This is for backporting fixes for JapaneseEra related issues (8054214,
>> 8173423). The original fixes in JDK9 included a test case,
>> SupplementalJapaneseEraTest which is intended for the system property
>> testing. The above proposed fix intends to adapt that test case into
>> JDK8, where calendars.properties file is used instead of the system
>> property. The test is pretty much identical to JDK9's. The difference is
>> to deal with the calendars.properties file and removed some
>> non-applicable cases in JDK8.
>>
>> Naoto

From naoto.sato at oracle.com  Thu Apr  6 20:29:01 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Thu, 6 Apr 2017 13:29:01 -0700
Subject: <i18n dev> [8u] RFR: 8177776: Create an equivalent test case
 for JDK9's SupplementalJapaneseEraTest
In-Reply-To: <5a64d6fc-9cf2-6a04-9f92-fd7d75c957bd@oracle.com>
References: <69774039-1980-882f-2f89-fac194fd7fa7@oracle.com>
 <d424dc05-691c-c9a2-8b45-4d73c2a70375@oracle.com>
 <5a64d6fc-9cf2-6a04-9f92-fd7d75c957bd@oracle.com>
Message-ID: <e90172b1-213b-a463-d24b-2b6f573bba98@oracle.com>

Hi Brent, thank you for the review.

On 4/6/17 1:08 PM, Brent Christian wrote:
> Hi, Naoto
>
> On 4/5/17 2:14 PM, Naoto Sato wrote:
>> I revised the test case not to rely on shell script.
>
> Yay!  Hopefully this can also happen sometime for JDK 9+.

Sure. Will work on it.

>
>> http://cr.openjdk.java.net/~naoto/8177776/webrev.01/
>
> Looks fine to me, Naoto.  A few comments:
>
> * I presume additional @bug values will be added as other fixes are
> backported (e.g. 8054214).

Good point. Will add those bug ids on push.

>
> * On
>
>   73         Path dst = Paths.get("testjava").toAbsolutePath();
>
> This places "dst" within the scratch directory, then?  (I thought there
> was a jtreg system property for the scratch directory, but I can't find
> it so I think I'm mis-remembering).
>
> I agree with letting jtreg take care of cleaning up "scratch".

Yes, "dst" will be "scratch". Not aware of any system property to 
designate the output directory, other than "-w" command option to 
specify the JTwork dir.

>
> If anything goes wrong with copying of the JDK (e.g. full disk),
> hopefully it would be easy to diagnose, with an IOException with a full
> stack trace.
>
> * Have you confirmed (if it's practical to do so) that this test fails
> when expected (detects a bug)?

Yes. Without those backports, the test will fail as expected.

Naoto

>
> Thanks,
> -Brent
>
>> On 3/30/17 2:10 PM, Naoto Sato wrote:
>>> Hello,
>>>
>>> Please review the changes to the following issue:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8177776
>>>
>>> The proposed change is located at:
>>>
>>> http://cr.openjdk.java.net/~naoto/8177776/webrev.00/
>>>
>>> This is for backporting fixes for JapaneseEra related issues (8054214,
>>> 8173423). The original fixes in JDK9 included a test case,
>>> SupplementalJapaneseEraTest which is intended for the system property
>>> testing. The above proposed fix intends to adapt that test case into
>>> JDK8, where calendars.properties file is used instead of the system
>>> property. The test is pretty much identical to JDK9's. The difference is
>>> to deal with the calendars.properties file and removed some
>>> non-applicable cases in JDK8.
>>>
>>> Naoto

From naoto.sato at oracle.com  Tue Apr 25 18:08:02 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Tue, 25 Apr 2017 11:08:02 -0700
Subject: <i18n dev> [9] RFR: 8178412: Doc link updates for i18n
Message-ID: <01cc583d-8b4c-8048-9915-2e9cefd5d181@oracle.com>

Hi Kumar,

Would you please review the changes to the following issue?

https://bugs.openjdk.java.net/browse/JDK-8178412

The proposed changeset is located at:

http://cr.openjdk.java.net/~naoto/8178412/webrev.00/

It is basically replacing the i18n related doc links in the JDK javadoc 
with the new @extLink tag to refer to the external documents, enabled 
with your change (8178725).

Naoto

From kumar.x.srinivasan at oracle.com  Tue Apr 25 18:27:33 2017
From: kumar.x.srinivasan at oracle.com (Kumar Srinivasan)
Date: Tue, 25 Apr 2017 11:27:33 -0700
Subject: <i18n dev> [9] RFR: 8178412: Doc link updates for i18n
In-Reply-To: <01cc583d-8b4c-8048-9915-2e9cefd5d181@oracle.com>
References: <01cc583d-8b4c-8048-9915-2e9cefd5d181@oracle.com>
Message-ID: <58FF9515.9050501@oracle.com>

Hi Naoto,

I understand the docs team have created the key, also
the description need not be in quotes, for future reference,
if that was intentional that is fine.

Changes look fine to me.

Thanks
Kumar

> Hi Kumar,
>
> Would you please review the changes to the following issue?
>
> https://bugs.openjdk.java.net/browse/JDK-8178412
>
> The proposed changeset is located at:
>
> http://cr.openjdk.java.net/~naoto/8178412/webrev.00/
>
> It is basically replacing the i18n related doc links in the JDK 
> javadoc with the new @extLink tag to refer to the external documents, 
> enabled with your change (8178725).
>
> Naoto


From naoto.sato at oracle.com  Tue Apr 25 19:58:18 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Tue, 25 Apr 2017 12:58:18 -0700
Subject: <i18n dev> [9] RFR: 8178412: Doc link updates for i18n
In-Reply-To: <58FF9515.9050501@oracle.com>
References: <01cc583d-8b4c-8048-9915-2e9cefd5d181@oracle.com>
 <58FF9515.9050501@oracle.com>
Message-ID: <cc940cb2-c8c8-9873-fc37-53f57194d22f@oracle.com>

Thanks, Kumar. I will remove those double quotes before the push.

Naoto

On 4/25/17 11:27 AM, Kumar Srinivasan wrote:
> Hi Naoto,
>
> I understand the docs team have created the key, also
> the description need not be in quotes, for future reference,
> if that was intentional that is fine.
>
> Changes look fine to me.
>
> Thanks
> Kumar
>
>> Hi Kumar,
>>
>> Would you please review the changes to the following issue?
>>
>> https://bugs.openjdk.java.net/browse/JDK-8178412
>>
>> The proposed changeset is located at:
>>
>> http://cr.openjdk.java.net/~naoto/8178412/webrev.00/
>>
>> It is basically replacing the i18n related doc links in the JDK
>> javadoc with the new @extLink tag to refer to the external documents,
>> enabled with your change (8178725).
>>
>> Naoto
>