From mandy.chung at oracle.com  Tue Aug  1 02:38:37 2017
From: mandy.chung at oracle.com (Mandy Chung)
Date: Mon, 31 Jul 2017 19:38:37 -0700
Subject: <i18n dev> [10] RFR (XS): 8185251:
	java/util/ResourceBundle/modules/layer/run.sh failed on
	Japanese locale.
In-Reply-To: <0e3d1d11-c410-eca5-6ed7-50447bd3df32@oracle.com>
References: <0e3d1d11-c410-eca5-6ed7-50447bd3df32@oracle.com>
Message-ID: <CB26B537-5463-48CF-871F-7D6209C71F89@oracle.com>


> On Jul 31, 2017, at 3:51 PM, Naoto Sato <naoto.sato at oracle.com> wrote:
> 
> Hi Mandy,
> 
> Would you please review the fix to the following issue?
> 
> https://bugs.openjdk.java.net/browse/JDK-8185251
> 
> The proposed fix is located at:
> 
> http://cr.openjdk.java.net/~naoto/8185251/webrev.00/
> 
> The test assumed the resources in the root bundle is used for English locale in m1 module, which is not the case if there's other resource bundles available for the default locale (in the test case, Japanese). To fix this, provide an empty English resource bundle for m1 test module.

Can you explain how this fixes it when the default locale is Japanese?

Is there other new test running into similar issue?

Mandy

From naoto.sato at oracle.com  Tue Aug  1 04:20:45 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Mon, 31 Jul 2017 21:20:45 -0700
Subject: <i18n dev> [10] RFR (XS): 8185251:
 java/util/ResourceBundle/modules/layer/run.sh failed on Japanese locale.
In-Reply-To: <CB26B537-5463-48CF-871F-7D6209C71F89@oracle.com>
References: <0e3d1d11-c410-eca5-6ed7-50447bd3df32@oracle.com>
 <CB26B537-5463-48CF-871F-7D6209C71F89@oracle.com>
Message-ID: <c7916d21-aacf-ca82-20c7-89b62e6a35db@oracle.com>



On 7/31/17 7:38 PM, Mandy Chung wrote:
> Can you explain how this fixes it when the default locale is Japanese?

The bundle lookup searches for bundles in the order of en_US -> en -> 
ja_JP -> ja -> (root). Since m2 provides ja bundle, it will be returned 
for this lookup, instead of m1's root bundle. By providing en bundle in 
m1 fixes the issue.

> 
> Is there other new test running into similar issue?

Not that I know of.

Naoto

From mandy.chung at oracle.com  Tue Aug  1 04:55:06 2017
From: mandy.chung at oracle.com (Mandy Chung)
Date: Mon, 31 Jul 2017 21:55:06 -0700
Subject: <i18n dev> [10] RFR (XS): 8185251:
	java/util/ResourceBundle/modules/layer/run.sh failed on
	Japanese locale.
In-Reply-To: <c7916d21-aacf-ca82-20c7-89b62e6a35db@oracle.com>
References: <0e3d1d11-c410-eca5-6ed7-50447bd3df32@oracle.com>
 <CB26B537-5463-48CF-871F-7D6209C71F89@oracle.com>
 <c7916d21-aacf-ca82-20c7-89b62e6a35db@oracle.com>
Message-ID: <F12948E6-9844-4A86-B9F1-9944843BFB11@oracle.com>


> On Jul 31, 2017, at 9:20 PM, Naoto Sato <naoto.sato at oracle.com> wrote:
> 
> 
> 
> On 7/31/17 7:38 PM, Mandy Chung wrote:
>> Can you explain how this fixes it when the default locale is Japanese?
> 
> The bundle lookup searches for bundles in the order of en_US -> en -> ja_JP -> ja -> (root). Since m2 provides ja bundle, it will be returned for this lookup, instead of m1's root bundle. By providing en bundle in m1 fixes the issue.


Thanks for the explanation.  Your patch looks fine.

Mandy

From nishit.jain at oracle.com  Mon Aug 21 08:48:06 2017
From: nishit.jain at oracle.com (Nishit Jain)
Date: Mon, 21 Aug 2017 14:18:06 +0530
Subject: <i18n dev> [10] RFR JDK-6609718: [Fmt-Ch] uninformative exception
 in ChoiceFormat.applyPattern(String)
Message-ID: <c6986a03-307f-1658-5184-7468566a51ca@oracle.com>

Hi,

Please review the fix for JDK-6609718

Bug: https://bugs.openjdk.java.net/browse/JDK-6609718
Webrev: http://cr.openjdk.java.net/~nishjain/6609718/webrev.01/

Fix: source updated to provide information about the cause of exception.

Regards,
Nishit Jain

From naoto.sato at oracle.com  Mon Aug 21 16:08:13 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Mon, 21 Aug 2017 09:08:13 -0700
Subject: <i18n dev> [10] RFR JDK-6609718: [Fmt-Ch] uninformative
 exception in ChoiceFormat.applyPattern(String)
In-Reply-To: <c6986a03-307f-1658-5184-7468566a51ca@oracle.com>
References: <c6986a03-307f-1658-5184-7468566a51ca@oracle.com>
Message-ID: <2cd83da5-7838-6b17-dead-d34783280441@oracle.com>

Looks good.

Naoto

On 8/21/17 1:48 AM, Nishit Jain wrote:
> Hi,
> 
> Please review the fix for JDK-6609718
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-6609718
> Webrev: http://cr.openjdk.java.net/~nishjain/6609718/webrev.01/
> 
> Fix: source updated to provide information about the cause of exception.
> 
> Regards,
> Nishit Jain

From nishit.jain at oracle.com  Thu Aug 24 07:06:14 2017
From: nishit.jain at oracle.com (Nishit Jain)
Date: Thu, 24 Aug 2017 12:36:14 +0530
Subject: <i18n dev> [10] RFR JDK-8186713: Document default rounding mode in
	NumberFormat
Message-ID: <7126fad3-3d2d-2855-97fd-5a3723b7807b@oracle.com>

Hi,

Please review the fix for JDK-8186713

Bug: https://bugs.openjdk.java.net/browse/JDK-8186713
Webrev: http://cr.openjdk.java.net/~nishjain/8186713/webrev.00/
CSR: https://bugs.openjdk.java.net/browse/JDK-8185777

Fix: Updated the specification of NumberFormat about the default 
rounding mode used while formatting the numbers. Also, in the 
specification of java.util.Formatter, changed the reference of the 
deprecated BigDecimal.ROUND_HALF_UP,with java.math.RoundingMode.HALF_UP.

Regards,
Nishit Jain

From naoto.sato at oracle.com  Thu Aug 24 15:50:35 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Thu, 24 Aug 2017 08:50:35 -0700
Subject: <i18n dev> [10] RFR JDK-8186713: Document default rounding mode
 in NumberFormat
In-Reply-To: <7126fad3-3d2d-2855-97fd-5a3723b7807b@oracle.com>
References: <7126fad3-3d2d-2855-97fd-5a3723b7807b@oracle.com>
Message-ID: <42706169-9f3f-a332-a77d-939c63f3f4d4@oracle.com>

Looks good.

Naoto

On 8/24/17 12:06 AM, Nishit Jain wrote:
> Hi,
> 
> Please review the fix for JDK-8186713
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8186713
> Webrev: http://cr.openjdk.java.net/~nishjain/8186713/webrev.00/
> CSR: https://bugs.openjdk.java.net/browse/JDK-8185777
> 
> Fix: Updated the specification of NumberFormat about the default 
> rounding mode used while formatting the numbers. Also, in the 
> specification of java.util.Formatter, changed the reference of the 
> deprecated BigDecimal.ROUND_HALF_UP,with java.math.RoundingMode.HALF_UP.
> 
> Regards,
> Nishit Jain

From brian.burkhalter at oracle.com  Thu Aug 24 19:25:01 2017
From: brian.burkhalter at oracle.com (Brian Burkhalter)
Date: Thu, 24 Aug 2017 12:25:01 -0700
Subject: <i18n dev> [10] RFR JDK-8186713: Document default rounding mode
	in NumberFormat
In-Reply-To: <7126fad3-3d2d-2855-97fd-5a3723b7807b@oracle.com>
References: <7126fad3-3d2d-2855-97fd-5a3723b7807b@oracle.com>
Message-ID: <3BA60415-0E48-4AC3-99EB-992224AEAF00@oracle.com>

A few minor comments:

L178-195: Is a list necessary here?

L186: I don?t think ?<b>Rounding</b>: " is necessary.

L187: s/the numbers/numbers/

L188: s/uses/uses the/

L191: s/its/the/

Thanks,

Brian

On Aug 24, 2017, at 12:06 AM, Nishit Jain <nishit.jain at oracle.com> wrote:

> Webrev:http://cr.openjdk.java.net/~nishjain/8186713/webrev.00/


From naoto.sato at oracle.com  Fri Aug 25 17:43:09 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Fri, 25 Aug 2017 10:43:09 -0700
Subject: <i18n dev> [10] RFR 8171049: Era.getDisplayName doesn't work with
 non-IsoChronology
Message-ID: <1443a241-c475-add2-5948-358ca27b78e6@oracle.com>

Hi,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8171049

The proposed fix is located at:

http://cr.openjdk.java.net/~naoto/8171049/webrev.00/

The fix is to implement Era.getDisplayName() in each Era enum.

Naoto

From nishit.jain at oracle.com  Mon Aug 28 07:43:55 2017
From: nishit.jain at oracle.com (Nishit Jain)
Date: Mon, 28 Aug 2017 13:13:55 +0530
Subject: <i18n dev> [10] RFR JDK-8186713: Document default rounding mode
 in NumberFormat
In-Reply-To: <3BA60415-0E48-4AC3-99EB-992224AEAF00@oracle.com>
References: <7126fad3-3d2d-2855-97fd-5a3723b7807b@oracle.com>
 <3BA60415-0E48-4AC3-99EB-992224AEAF00@oracle.com>
Message-ID: <00578dfc-c71f-c975-ba23-7529ab9e0473@oracle.com>

Hi Brian,

 > L178-195: Is a list necessary here?
The list approach is used to clearly mention that these two points are 
under "Implementation Requirements". If it does not look good, another 
way could be to use @implSpec tag for individual points, separated by 
<p>. Please check if this is fine.

Also updated the webrev with other suggested changes.

http://cr.openjdk.java.net/~nishjain/8186713/webrev.01/

Regards,
Nishit Jain
On 25-08-2017 00:55, Brian Burkhalter wrote:
> A few minor comments:
>
> L178-195: Is a list necessary here?
>
> L186: I don?t think ?<b>Rounding</b>: " is necessary.
>
> L187: s/the numbers/numbers/
>
> L188: s/uses/uses the/
>
> L191: s/its/the/
>
> Thanks,
>
> Brian
>
> On Aug 24, 2017, at 12:06 AM, Nishit Jain <nishit.jain at oracle.com 
> <mailto:nishit.jain at oracle.com>> wrote:
>
>> Webrev:http://cr.openjdk.java.net/~nishjain/8186713/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Enishjain/8186713/webrev.00/>
>


From brian.burkhalter at oracle.com  Mon Aug 28 23:26:25 2017
From: brian.burkhalter at oracle.com (Brian Burkhalter)
Date: Mon, 28 Aug 2017 16:26:25 -0700
Subject: <i18n dev> [10] RFR JDK-8186713: Document default rounding mode
	in NumberFormat
In-Reply-To: <00578dfc-c71f-c975-ba23-7529ab9e0473@oracle.com>
References: <7126fad3-3d2d-2855-97fd-5a3723b7807b@oracle.com>
 <3BA60415-0E48-4AC3-99EB-992224AEAF00@oracle.com>
 <00578dfc-c71f-c975-ba23-7529ab9e0473@oracle.com>
Message-ID: <20140827-8825-464A-A5C2-EA1A50E4DF42@oracle.com>

Hi Nishit,

I suggest these changes in NumberFormat.java:

184:		delete the line
186:		s/{@code NumberFormat}/The default implementation/
187-188:	s/By default, it uses/It uses/

With these changes I am fine with the patch and no need to send an updated webrev unless you prefer.

Thanks,

Brian

On Aug 28, 2017, at 12:43 AM, Nishit Jain <nishit.jain at oracle.com> wrote:

> > L178-195: Is a list necessary here?
> The list approach is used to clearly mention that these two points are under "Implementation Requirements". If it does not look good, another way could be to use @implSpec tag for individual points, separated by <p>. Please check if this is fine.
> 
> Also updated the webrev with other suggested changes.
> 
> http://cr.openjdk.java.net/~nishjain/8186713/webrev.01/


From nishit.jain at oracle.com  Tue Aug 29 07:23:07 2017
From: nishit.jain at oracle.com (Nishit Jain)
Date: Tue, 29 Aug 2017 12:53:07 +0530
Subject: <i18n dev> [10] RFR JDK-8186713: Document default rounding mode
 in NumberFormat
In-Reply-To: <20140827-8825-464A-A5C2-EA1A50E4DF42@oracle.com>
References: <7126fad3-3d2d-2855-97fd-5a3723b7807b@oracle.com>
 <3BA60415-0E48-4AC3-99EB-992224AEAF00@oracle.com>
 <00578dfc-c71f-c975-ba23-7529ab9e0473@oracle.com>
 <20140827-8825-464A-A5C2-EA1A50E4DF42@oracle.com>
Message-ID: <aa5b7e9b-e1fb-545d-bcef-6825a6e17a17@oracle.com>

Thanks Brian, Naoto for the review. The below updated patch is pushed to 
the repository.

http://cr.openjdk.java.net/~nishjain/8186713/webrev.02/

Regards,
Nishit Jain
On 29-08-2017 04:56, Brian Burkhalter wrote:
> Hi Nishit,
>
> I suggest these changes in NumberFormat.java:
>
> 184:delete the line
> 186:s/{@code NumberFormat}/The default implementation/
> 187-188:s/By default, it uses/It uses/
>
> With these changes I am fine with the patch and no need to send an 
> updated webrev unless you prefer.
>
> Thanks,
>
> Brian
>
> On Aug 28, 2017, at 12:43 AM, Nishit Jain <nishit.jain at oracle.com 
> <mailto:nishit.jain at oracle.com>> wrote:
>
>> >L178-195: Is a list necessary here?
>> The list approach is used to clearly mention that these two points 
>> are under "Implementation Requirements". If it does not look good, 
>> another way could be to use @implSpec tag for individual points, 
>> separated by <p>. Please check if this is fine.
>>
>> Also updated the webrev with other suggested changes.
>>
>> http://cr.openjdk.java.net/~nishjain/8186713/webrev.01/
>


From naoto.sato at oracle.com  Wed Aug 30 00:26:01 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Tue, 29 Aug 2017 17:26:01 -0700
Subject: <i18n dev> [10] RFR (XXS) 8179246: &nbsp; /&thinsp;
 are literally visible in javadoc
Message-ID: <e677022a-55c4-17d8-7c09-87b6aa3e12f1@oracle.com>

Hi,

Please review this very small fix to javadoc for this issue:

https://bugs.openjdk.java.net/browse/JDK-8179246

Here is the proposed fix:

diff -r 0bc7e9acd67b 
src/java.base/share/classes/java/util/spi/AbstractResourceBundleProvider.java
--- 
a/src/java.base/share/classes/java/util/spi/AbstractResourceBundleProvider.java
+++ 
b/src/java.base/share/classes/java/util/spi/AbstractResourceBundleProvider.java
@@ -137,9 +137,10 @@
       *
       * <p>For example, if {@code baseName} is {@code 
"p.resources.Bundle"} then
       * the resource bundle name of {@code "p.resources.Bundle"} of
-     * {@code Locale("ja",&nbsp;"",&nbsp;"XX")} and {@code Locale("en")}
-     * could be {@code "p.resources.ja.Bundle_ja_&thinsp;_XX"} and
-     * {@code p.resources.Bundle_en"} respectively
+     * <code style="white-space:nowrap">Locale("ja", "", "XX")</code>
+     * and {@code Locale("en")} could be <code style="white-space:nowrap">
+     * "p.resources.ja.Bundle_ja_&thinsp;_XX"</code> and
+     * {@code "p.resources.Bundle_en"} respectively.
       *
       * <p> This method is called from the default implementation of the
       * {@link #getBundle(String, Locale)} method.


Naoto

From jonathan.gibbons at oracle.com  Wed Aug 30 18:26:12 2017
From: jonathan.gibbons at oracle.com (Jonathan Gibbons)
Date: Wed, 30 Aug 2017 11:26:12 -0700
Subject: <i18n dev> [10] RFR (XXS) 8179246: &nbsp; /&thinsp;
 are literally visible in javadoc
In-Reply-To: <e677022a-55c4-17d8-7c09-87b6aa3e12f1@oracle.com>
References: <e677022a-55c4-17d8-7c09-87b6aa3e12f1@oracle.com>
Message-ID: <59A70344.5020807@oracle.com>

Looks OK to me,

-- Jon

On 08/29/2017 05:26 PM, Naoto Sato wrote:
> Hi,
>
> Please review this very small fix to javadoc for this issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8179246
>
> Here is the proposed fix:
>
> diff -r 0bc7e9acd67b 
> src/java.base/share/classes/java/util/spi/AbstractResourceBundleProvider.java
> --- 
> a/src/java.base/share/classes/java/util/spi/AbstractResourceBundleProvider.java
> +++ 
> b/src/java.base/share/classes/java/util/spi/AbstractResourceBundleProvider.java
> @@ -137,9 +137,10 @@
>       *
>       * <p>For example, if {@code baseName} is {@code 
> "p.resources.Bundle"} then
>       * the resource bundle name of {@code "p.resources.Bundle"} of
> -     * {@code Locale("ja",&nbsp;"",&nbsp;"XX")} and {@code Locale("en")}
> -     * could be {@code "p.resources.ja.Bundle_ja_&thinsp;_XX"} and
> -     * {@code p.resources.Bundle_en"} respectively
> +     * <code style="white-space:nowrap">Locale("ja", "", "XX")</code>
> +     * and {@code Locale("en")} could be <code 
> style="white-space:nowrap">
> +     * "p.resources.ja.Bundle_ja_&thinsp;_XX"</code> and
> +     * {@code "p.resources.Bundle_en"} respectively.
>       *
>       * <p> This method is called from the default implementation of the
>       * {@link #getBundle(String, Locale)} method.
>
>
> Naoto


From naoto.sato at oracle.com  Wed Aug 30 22:55:56 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Wed, 30 Aug 2017 15:55:56 -0700
Subject: <i18n dev> [10] RFR 8180469: Wrong short form text for supplemental
	Japanese era
Message-ID: <04f6fa07-019f-27f3-5971-b2b27d40ca0c@oracle.com>

Hi,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8180469

The proposed changeset is located at:

http://cr.openjdk.java.net/~naoto/8180469/webrev.00/

The problem was caused by the difference of the Era display name for 
"SHORT" style between java.time and java.util.Calendar.

Naoto

From nishit.jain at oracle.com  Thu Aug 31 11:36:22 2017
From: nishit.jain at oracle.com (Nishit Jain)
Date: Thu, 31 Aug 2017 17:06:22 +0530
Subject: <i18n dev> [10] RFR 8180469: Wrong short form text for
 supplemental Japanese era
In-Reply-To: <04f6fa07-019f-27f3-5971-b2b27d40ca0c@oracle.com>
References: <04f6fa07-019f-27f3-5971-b2b27d40ca0c@oracle.com>
Message-ID: <7c40deb9-a930-2343-8aa3-adb0011e76bb@oracle.com>

Looks good to me. I am not a reviewer, though.

Regards,
Nishit Jain
On 31-08-2017 04:25, Naoto Sato wrote:
> Hi,
>
> Please review the fix to the following issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8180469
>
> The proposed changeset is located at:
>
> http://cr.openjdk.java.net/~naoto/8180469/webrev.00/
>
> The problem was caused by the difference of the Era display name for 
> "SHORT" style between java.time and java.util.Calendar.
>
> Naoto