<i18n dev> [10] RFR JDK-8177472: Remove hard-coded IANA Subtag Registry map in LocaleEquivalentMap.java

Nishit Jain nishit.jain at oracle.com
Tue Jul 25 17:16:43 UTC 2017


Hi Roger,

CLDR converter generate the copyright year by the current date in which 
it is getting executed. I think the copyright year in 
LocaleEquivalentMaps.java should be the year in which the lsr data is 
last updated in jdk i.e. the year in which LocaleEquivalentMaps.java is 
last modified. This makes it difficult to compute the year automatically 
unless someone specifies it while updating the data.

 > Can the latest copyright date be taken from the File-Date field of 
the subtag-registry?
This may not be necessarily same as the year in which lsr data is 
updated in jdk.

Regards,
Nishit Jain
On 25-07-2017 21:28, Roger Riggs wrote:
> Hi Nishit,
>
> Can the hardcoded copyright be made more automatic?
>
> I see the make/src/classes/build/tools/cldrconverter has functions to 
> create/convert copyrights.
> Can that be leveraged to generate the needed copyright and reduce some 
> potential maintenance
> of the copyright date and or contents?
>
> Can the latest copyright date be taken from the File-Date field of the 
> subtag-registry?
>
> Thanks, Roger
>
> On 7/20/2017 1:33 AM, Nishit Jain wrote:
>> Hi,
>>
>> Please review the fix for JDK-8177472
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8177472
>> Webrev: http://cr.openjdk.java.net/~nishjain/8177472/webrev.05/
>>
>> Issue:The existing process of updating the LSR data requires manual 
>> execution of EquivMapsGenerator.java for generation of the updated maps.
>> Fix:The execution of EquivMapsGenerator.javafor generation of maps is 
>> included in the JDK build process. After this change updation of LSR 
>> data will mostly require replacement of old 
>> language-subtag-registry.txt file with the new one and changing the 
>> copyright year in EquivMapsGenerator.java (if required) for the 
>> generated maps file.
>>
>> Regards,
>> Nishit Jain
>



More information about the i18n-dev mailing list