<i18n dev> JDK 10 Review Request for JDK-8176583: Move currency data to /lib

Naoto Sato naoto.sato at oracle.com
Mon Jun 12 16:51:05 UTC 2017


Looks good.

Naoto

On 6/12/17 2:01 AM, Nishit Jain wrote:
> Thanks Naoto,
> 
> Please check the updated webrev
> http://cr.openjdk.java.net/~nishjain/8176583/webrev.02/
> 
> Changes:
> - merged the try blocks in Currency.java
> - replaced the try block in CheckDataVersion.java with try-with-resource 
> and a small indentation change at line 82.
> 
> Regards,
> Nishit Jain
> On 09-06-2017 23:20, Naoto Sato wrote:
>> Hi Nishit,
>>
>> In Currency.java, there seems to be a redundant try block (line 206). 
>> Is it possible to merge it with the try block at line 205?
>>
>> Otherwise it looks good to me.
>>
>> Naoto
>>
>> On 6/8/17 11:59 PM, Nishit Jain wrote:
>>> Hi,
>>>
>>> Please review the fix for JDK-8176583
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8176583
>>> Webrev: http://cr.openjdk.java.net/~nishjain/8176583/webrev.01/
>>>
>>> Fix: Relocated currency.data from java.base module 
>>> (/java.base/java/util/currency.data) to /lib directory
>>>
>>> Regards,
>>> Nishit Jain
> 


More information about the i18n-dev mailing list