<i18n dev> [9] RFR: 8174736: [JCP] [Mac]Cannot launch JCP on Mac os with language set to "Chinese, Simplified" while region is not China

Brent Christian brent.christian at oracle.com
Mon Mar 6 23:21:46 UTC 2017


Hi, Naoto

That fix looks fine.

The "Portuguese (Brazil)" fix now happens before the Language ID fix, 
but that shouldn't matter, as the "pt_BR" ID won't trigger that code 
anyway (doesn't contain '-').

One very mall nit I noticed: one more space on line 97 will realign it 
with line 96, which now has an additional '!' character.

That's my small-'r'-review.

-Brent

On 03/03/17 13:19, Naoto Sato wrote:
> Hello,
>
> Please review the fix to the following issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8174736
>
> The proposed fix is located at:
>
> http://cr.openjdk.java.net/~naoto/8174736/webrev.00/
>
> This is a follow-on fix to 8174779 [1]. The previous fix addresses the
> issue for the default locale, and this one is to address the default
> format locale in order to handle locales with script codes on macOS.
>
> Naoto
> [1] https://bugs.openjdk.java.net/browse/JDK-8174779


More information about the i18n-dev mailing list