From naoto.sato at oracle.com  Thu Nov  2 21:42:10 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Thu, 2 Nov 2017 14:42:10 -0700
Subject: <i18n dev> [10] RFR 8176841: Additional Unicode Language-Tag
	Extensions
Message-ID: <5caff010-ef03-b62f-2041-3f57f126ae97@oracle.com>

Hello,

Please review the proposed changes for the following issues:

8176841: Additional Unicode Language-Tag Extensions
8189134: New system properties for the default Locale extensions

The proposed changeset is located at:

http://cr.openjdk.java.net/~naoto/8176841/webrev.03/

This serves as the implementation of JEP 314.

Naoto




From ramanand.patil at oracle.com  Mon Nov  6 14:06:30 2017
From: ramanand.patil at oracle.com (Ramanand Patil)
Date: Mon, 6 Nov 2017 06:06:30 -0800 (PST)
Subject: <i18n dev> JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c and
 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c
Message-ID: <e0b6ec8c-9d01-4c57-8a49-884bb2317e6d@default>

Hi all,
Please review the latest TZDATA integration (tzdata2017c) to JDK10.
Bugs:
https://bugs.openjdk.java.net/browse/JDK-8190258
https://bugs.openjdk.java.net/browse/JDK-8190259

Webrev: http://cr.openjdk.java.net/~rpatil/8190258+8190259/webrev.00/

All the TimeZone related tests are passed after integration.

Regards,
Ramanand.

From naoto.sato at oracle.com  Mon Nov  6 23:48:15 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Mon, 6 Nov 2017 15:48:15 -0800
Subject: <i18n dev> JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c
 and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c
In-Reply-To: <e0b6ec8c-9d01-4c57-8a49-884bb2317e6d@default>
References: <e0b6ec8c-9d01-4c57-8a49-884bb2317e6d@default>
Message-ID: <1ec07748-3b87-5ec1-ff59-5da026807520@oracle.com>

Hi Ramanand,

In java/time/format/ZoneName.java, should the zid for Africa_Central map 
to "Africa/Maputo"?

Naoto

On 11/6/17 6:06 AM, Ramanand Patil wrote:
> Hi all,
> Please review the latest TZDATA integration (tzdata2017c) to JDK10.
> Bugs:
> https://bugs.openjdk.java.net/browse/JDK-8190258
> https://bugs.openjdk.java.net/browse/JDK-8190259
> 
> Webrev: http://cr.openjdk.java.net/~rpatil/8190258+8190259/webrev.00/
> 
> All the TimeZone related tests are passed after integration.
> 
> Regards,
> Ramanand.
> 

From martinrb at google.com  Tue Nov  7 03:38:18 2017
From: martinrb at google.com (Martin Buchholz)
Date: Mon, 6 Nov 2017 19:38:18 -0800
Subject: <i18n dev> RFR: JDK-8190816 : PropertiesTest.sh fails to make
	$WRITABLEJDK writable
Message-ID: <CA+kOe09uGWs+aj=8_56ZX0qP-gQw_ROLCqhuC=mX8PCWGiwP9w@mail.gmail.com>

http://cr.openjdk.java.net/~martin/webrevs/openjdk10/Currency-PropertiesTest/

From rachna.goel at oracle.com  Tue Nov  7 11:31:50 2017
From: rachna.goel at oracle.com (Rachna Goel)
Date: Tue, 7 Nov 2017 17:01:50 +0530
Subject: <i18n dev> RFR: JDK-8190816 : PropertiesTest.sh fails to make
 $WRITABLEJDK writable
In-Reply-To: <CA+kOe09uGWs+aj=8_56ZX0qP-gQw_ROLCqhuC=mX8PCWGiwP9w@mail.gmail.com>
References: <CA+kOe09uGWs+aj=8_56ZX0qP-gQw_ROLCqhuC=mX8PCWGiwP9w@mail.gmail.com>
Message-ID: <83c5af0a-fda7-ec38-7bbd-e57507ec463a@oracle.com>

Hi Martin,

I am not a reviewer though, your fix looks good  to me.

Thanks,

Rachna


On 07/11/17 9:08 AM, Martin Buchholz wrote:
> http://cr.openjdk.java.net/~martin/webrevs/openjdk10/Currency-PropertiesTest/ 
> <http://cr.openjdk.java.net/%7Emartin/webrevs/openjdk10/Currency-PropertiesTest/>

-- 
Thanks,
Rachna


From ramanand.patil at oracle.com  Tue Nov  7 11:41:42 2017
From: ramanand.patil at oracle.com (Ramanand Patil)
Date: Tue, 7 Nov 2017 03:41:42 -0800 (PST)
Subject: <i18n dev> JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c
 and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c
In-Reply-To: <1ec07748-3b87-5ec1-ff59-5da026807520@oracle.com>
References: <e0b6ec8c-9d01-4c57-8a49-884bb2317e6d@default>
 <1ec07748-3b87-5ec1-ff59-5da026807520@oracle.com>
Message-ID: <17f3b700-4c79-4cb7-b869-7943a9b87854@default>

Hi Naoto,
Thank you for pointing that. I have modified both the affected files(ZoneName.java from src and test).
Here is the updated Webrev: http://cr.openjdk.java.net/~rpatil/8190258+8190259/webrev.01/

Regards,
Ramanand.

> -----Original Message-----
> From: Naoto Sato
> Sent: Tuesday, November 07, 2017 5:18 AM
> To: Ramanand Patil <ramanand.patil at oracle.com>; core-libs-dev <core-libs-
> dev at openjdk.java.net>; i18n-dev at openjdk.java.net
> Subject: Re: <i18n dev> JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c
> and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c
> 
> Hi Ramanand,
> 
> In java/time/format/ZoneName.java, should the zid for Africa_Central map
> to "Africa/Maputo"?
> 
> Naoto
> 
> On 11/6/17 6:06 AM, Ramanand Patil wrote:
> > Hi all,
> > Please review the latest TZDATA integration (tzdata2017c) to JDK10.
> > Bugs:
> > https://bugs.openjdk.java.net/browse/JDK-8190258
> > https://bugs.openjdk.java.net/browse/JDK-8190259
> >
> > Webrev: http://cr.openjdk.java.net/~rpatil/8190258+8190259/webrev.00/
> >
> > All the TimeZone related tests are passed after integration.
> >
> > Regards,
> > Ramanand.
> >

From naoto.sato at oracle.com  Tue Nov  7 17:21:22 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Tue, 7 Nov 2017 09:21:22 -0800
Subject: <i18n dev> RFR: JDK-8190816 : PropertiesTest.sh fails to make
 $WRITABLEJDK writable
In-Reply-To: <CA+kOe09uGWs+aj=8_56ZX0qP-gQw_ROLCqhuC=mX8PCWGiwP9w@mail.gmail.com>
References: <CA+kOe09uGWs+aj=8_56ZX0qP-gQw_ROLCqhuC=mX8PCWGiwP9w@mail.gmail.com>
Message-ID: <3b96bc4e-aaf6-881d-a919-1c3f54808935@oracle.com>

Looks good. Thanks for fixing this obvious mistake.

Naoto

On 11/6/17 7:38 PM, Martin Buchholz wrote:
> http://cr.openjdk.java.net/~martin/webrevs/openjdk10/Currency-PropertiesTest/

From naoto.sato at oracle.com  Tue Nov  7 18:38:10 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Tue, 7 Nov 2017 10:38:10 -0800
Subject: <i18n dev> JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c
 and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c
In-Reply-To: <17f3b700-4c79-4cb7-b869-7943a9b87854@default>
References: <e0b6ec8c-9d01-4c57-8a49-884bb2317e6d@default>
 <1ec07748-3b87-5ec1-ff59-5da026807520@oracle.com>
 <17f3b700-4c79-4cb7-b869-7943a9b87854@default>
Message-ID: <8bc77da3-515f-6bca-22b3-82bd6685bff2@oracle.com>

Looks good.

Naoto

On 11/7/17 3:41 AM, Ramanand Patil wrote:
> Hi Naoto,
> Thank you for pointing that. I have modified both the affected files(ZoneName.java from src and test).
> Here is the updated Webrev: http://cr.openjdk.java.net/~rpatil/8190258+8190259/webrev.01/
> 
> Regards,
> Ramanand.
> 
>> -----Original Message-----
>> From: Naoto Sato
>> Sent: Tuesday, November 07, 2017 5:18 AM
>> To: Ramanand Patil <ramanand.patil at oracle.com>; core-libs-dev <core-libs-
>> dev at openjdk.java.net>; i18n-dev at openjdk.java.net
>> Subject: Re: <i18n dev> JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c
>> and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c
>>
>> Hi Ramanand,
>>
>> In java/time/format/ZoneName.java, should the zid for Africa_Central map
>> to "Africa/Maputo"?
>>
>> Naoto
>>
>> On 11/6/17 6:06 AM, Ramanand Patil wrote:
>>> Hi all,
>>> Please review the latest TZDATA integration (tzdata2017c) to JDK10.
>>> Bugs:
>>> https://bugs.openjdk.java.net/browse/JDK-8190258
>>> https://bugs.openjdk.java.net/browse/JDK-8190259
>>>
>>> Webrev: http://cr.openjdk.java.net/~rpatil/8190258+8190259/webrev.00/
>>>
>>> All the TimeZone related tests are passed after integration.
>>>
>>> Regards,
>>> Ramanand.
>>>

From martinrb at google.com  Tue Nov  7 18:48:11 2017
From: martinrb at google.com (Martin Buchholz)
Date: Tue, 7 Nov 2017 10:48:11 -0800
Subject: <i18n dev> JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c
 and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c
In-Reply-To: <17f3b700-4c79-4cb7-b869-7943a9b87854@default>
References: <e0b6ec8c-9d01-4c57-8a49-884bb2317e6d@default>
 <1ec07748-3b87-5ec1-ff59-5da026807520@oracle.com>
 <17f3b700-4c79-4cb7-b869-7943a9b87854@default>
Message-ID: <CA+kOe0-3ckvbbHqSCQFQ67iwbvmWoOit+7vKH1h6wNMD0xyy2Q@mail.gmail.com>

Looks good to me too.

I've always wondered about how the corresponding java source files are
maintained.  Is it all manual or do y'all have some magic script to help
keep IANA data and java data aligned?  Do we need more testing that
mistakes don't creep in?

On Tue, Nov 7, 2017 at 3:41 AM, Ramanand Patil <ramanand.patil at oracle.com>
wrote:

> Hi Naoto,
> Thank you for pointing that. I have modified both the affected
> files(ZoneName.java from src and test).
> Here is the updated Webrev: http://cr.openjdk.java.net/~
> rpatil/8190258+8190259/webrev.01/
>
> Regards,
> Ramanand.
>
> > -----Original Message-----
> > From: Naoto Sato
> > Sent: Tuesday, November 07, 2017 5:18 AM
> > To: Ramanand Patil <ramanand.patil at oracle.com>; core-libs-dev
> <core-libs-
> > dev at openjdk.java.net>; i18n-dev at openjdk.java.net
> > Subject: Re: <i18n dev> JDK10 RFR of JDK-8190258: (tz) Support
> tzdata2017c
> > and 8190259: test tck.java.time.zone.TCKZoneRules is broken by
> tzdata2017c
> >
> > Hi Ramanand,
> >
> > In java/time/format/ZoneName.java, should the zid for Africa_Central map
> > to "Africa/Maputo"?
> >
> > Naoto
> >
> > On 11/6/17 6:06 AM, Ramanand Patil wrote:
> > > Hi all,
> > > Please review the latest TZDATA integration (tzdata2017c) to JDK10.
> > > Bugs:
> > > https://bugs.openjdk.java.net/browse/JDK-8190258
> > > https://bugs.openjdk.java.net/browse/JDK-8190259
> > >
> > > Webrev: http://cr.openjdk.java.net/~rpatil/8190258+8190259/webrev.00/
> > >
> > > All the TimeZone related tests are passed after integration.
> > >
> > > Regards,
> > > Ramanand.
> > >
>

From ramanand.patil at oracle.com  Wed Nov  8 07:14:07 2017
From: ramanand.patil at oracle.com (Ramanand Patil)
Date: Tue, 7 Nov 2017 23:14:07 -0800 (PST)
Subject: <i18n dev> JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c
 and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c
In-Reply-To: <CA+kOe0-3ckvbbHqSCQFQ67iwbvmWoOit+7vKH1h6wNMD0xyy2Q@mail.gmail.com>
References: <e0b6ec8c-9d01-4c57-8a49-884bb2317e6d@default>
 <1ec07748-3b87-5ec1-ff59-5da026807520@oracle.com>
 <17f3b700-4c79-4cb7-b869-7943a9b87854@default>
 <CA+kOe0-3ckvbbHqSCQFQ67iwbvmWoOit+7vKH1h6wNMD0xyy2Q@mail.gmail.com>
Message-ID: <05a9ea38-66b5-4cbb-bedd-b3273bcba494@default>

Thank you Martin for your review.

?

For the java file updates, currently I don?t use any script but just simple ?find and replace? whenever possible and rest is manual. I run all the TZ related tests locally on Ubuntu and use JPRT for all other platforms.

?

?

Regards,

Ramanand.

?

From: Martin Buchholz [mailto:martinrb at google.com] 
Sent: Wednesday, November 08, 2017 12:18 AM
To: Ramanand Patil <ramanand.patil at oracle.com>
Cc: Naoto Sato <naoto.sato at oracle.com>; core-libs-dev <core-libs-dev at openjdk.java.net>; i18n-dev at openjdk.java.net
Subject: Re: <i18n dev> JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c

?

Looks good to me too.

?

I've always wondered about how the corresponding java source files are maintained.? Is it all manual or do y'all have some magic script to help keep IANA data and java data aligned?? Do we need more testing that mistakes don't creep in?

?

On Tue, Nov 7, 2017 at 3:41 AM, Ramanand Patil <HYPERLINK "mailto:ramanand.patil at oracle.com"ramanand.patil at oracle.com> wrote:

Hi Naoto,
Thank you for pointing that. I have modified both the affected files(ZoneName.java from src and test).
Here is the updated Webrev: http://cr.openjdk.java.net/~rpatil/8190258+8190259/webrev.01/

Regards,
Ramanand.


> -----Original Message-----
> From: Naoto Sato
> Sent: Tuesday, November 07, 2017 5:18 AM
> To: Ramanand Patil <HYPERLINK "mailto:ramanand.patil at oracle.com"ramanand.patil at oracle.com>; core-libs-dev <core-libs-
> HYPERLINK "mailto:dev at openjdk.java.net"dev at openjdk.java.net>; HYPERLINK "mailto:i18n-dev at openjdk.java.net"i18n-dev at openjdk.java.net
> Subject: Re: <i18n dev> JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c
> and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c
>
> Hi Ramanand,
>
> In java/time/format/ZoneName.java, should the zid for Africa_Central map
> to "Africa/Maputo"?
>
> Naoto
>
> On 11/6/17 6:06 AM, Ramanand Patil wrote:
> > Hi all,
> > Please review the latest TZDATA integration (tzdata2017c) to JDK10.
> > Bugs:
> > https://bugs.openjdk.java.net/browse/JDK-8190258
> > https://bugs.openjdk.java.net/browse/JDK-8190259
> >
> > Webrev: http://cr.openjdk.java.net/~rpatil/8190258+8190259/webrev.00/
> >
> > All the TimeZone related tests are passed after integration.
> >
> > Regards,
> > Ramanand.
> >

?

From naoto.sato at oracle.com  Thu Nov  9 23:34:35 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Thu, 9 Nov 2017 15:34:35 -0800
Subject: <i18n dev> [10] RFR 8176841: Additional Unicode Language-Tag
	Extensions
In-Reply-To: <5caff010-ef03-b62f-2041-3f57f126ae97@oracle.com>
References: <5caff010-ef03-b62f-2041-3f57f126ae97@oracle.com>
Message-ID: <d17ec439-110a-36e5-9575-d79f74592d51@oracle.com>

Kindly requesting reviews. I incorporated a fix to the following issue 
raised by the test team:

https://bugs.openjdk.java.net/browse/JDK-8190918

Here is the updated webrev:

http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918/webrev.04/

And the webrev since the one below (to address 8190918):

http://cr.openjdk.java.net/~naoto/8190918/

Naoto



On 11/2/17 2:42 PM, Naoto Sato wrote:
> Hello,
> 
> Please review the proposed changes for the following issues:
> 
> 8176841: Additional Unicode Language-Tag Extensions
> 8189134: New system properties for the default Locale extensions
> 
> The proposed changeset is located at:
> 
> http://cr.openjdk.java.net/~naoto/8176841/webrev.03/
> 
> This serves as the implementation of JEP 314.
> 
> Naoto
> 
> 
> 

From nishit.jain at oracle.com  Thu Nov 16 11:47:11 2017
From: nishit.jain at oracle.com (Nishit Jain)
Date: Thu, 16 Nov 2017 17:17:11 +0530
Subject: <i18n dev> [10] RFR 8191404: Upgrading JDK with latest available
 LSR data from IANA.
Message-ID: <38d7fa00-252f-cd42-500a-deda1fef843f@oracle.com>

Hi,

Please review the fix for JDK-8191404

Bug: https://bugs.openjdk.java.net/browse/JDK-8191404
Webrev: http://cr.openjdk.java.net/~nishjain/8191404/webrev.00/

Fix: Updated the LSR data with the version: 2017-08-15

Regards,
Nishit Jain

From rachna.goel at oracle.com  Fri Nov 17 05:49:18 2017
From: rachna.goel at oracle.com (Rachna Goel)
Date: Fri, 17 Nov 2017 11:19:18 +0530
Subject: <i18n dev> JDK10 RFR of JDK-JDK-8168767: java.awt.im.InputContext
 API doc has a reference to extensions
Message-ID: <9b87292f-65dc-1c8c-4887-0769a7419f7e@oracle.com>

Hi,

Kindly review API Doc fix for java.awt.im.InputContext.

JBS Issue : https://bugs.openjdk.java.net/browse/JDK-8168767

Webrev: http://cr.openjdk.java.net/~rgoel/8191123/webrev/

CSR: https://bugs.openjdk.java.net/browse/JDK-8191123

-- 
Thanks,
Rachna


From nishit.jain at oracle.com  Fri Nov 17 06:52:36 2017
From: nishit.jain at oracle.com (Nishit Jain)
Date: Fri, 17 Nov 2017 12:22:36 +0530
Subject: <i18n dev> [10] RFR 6354947: [Fmt-*] DecimalFormat ignores
 FieldPosition settings on input, contrary to Javadocs
Message-ID: <156741f0-36df-03cb-e30f-e2c41d0fc3ef@oracle.com>

Hi,

Please review the fix for JDK-6354947

Bug: https://bugs.openjdk.java.net/browse/JDK-6354947
Webrev: http://cr.openjdk.java.net/~nishjain/6354947/webrev.02/
CSR: https://bugs.openjdk.java.net/browse/JDK-8191014

Fix: Clarified handling of the FieldPosition settings in the 
java.text.Format APIs specification.

Regards,
Nishit Jain

From naoto.sato at oracle.com  Sat Nov 18 00:20:16 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Fri, 17 Nov 2017 16:20:16 -0800
Subject: <i18n dev> JDK10 RFR of JDK-JDK-8168767:
 java.awt.im.InputContext API doc has a reference to extensions
In-Reply-To: <9b87292f-65dc-1c8c-4887-0769a7419f7e@oracle.com>
References: <9b87292f-65dc-1c8c-4887-0769a7419f7e@oracle.com>
Message-ID: <81ea46fa-d340-3c85-6c31-285fb2ab343b@oracle.com>

+1

Naoto

On 11/16/17 9:49 PM, Rachna Goel wrote:
> Hi,
> 
> Kindly review API Doc fix for java.awt.im.InputContext.
> 
> JBS Issue : https://bugs.openjdk.java.net/browse/JDK-8168767
> 
> Webrev: http://cr.openjdk.java.net/~rgoel/8191123/webrev/
> 
> CSR: https://bugs.openjdk.java.net/browse/JDK-8191123
> 

From naoto.sato at oracle.com  Sat Nov 18 00:21:37 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Fri, 17 Nov 2017 16:21:37 -0800
Subject: <i18n dev> [10] RFR 6354947: [Fmt-*] DecimalFormat ignores
 FieldPosition settings on input, contrary to Javadocs
In-Reply-To: <156741f0-36df-03cb-e30f-e2c41d0fc3ef@oracle.com>
References: <156741f0-36df-03cb-e30f-e2c41d0fc3ef@oracle.com>
Message-ID: <91cfcd2f-97ba-dda8-eb2d-9c4bd0f05f29@oracle.com>

+1

Naoto

On 11/16/17 10:52 PM, Nishit Jain wrote:
> Hi,
> 
> Please review the fix for JDK-6354947
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-6354947
> Webrev: http://cr.openjdk.java.net/~nishjain/6354947/webrev.02/
> CSR: https://bugs.openjdk.java.net/browse/JDK-8191014
> 
> Fix: Clarified handling of the FieldPosition settings in the 
> java.text.Format APIs specification.
> 
> Regards,
> Nishit Jain

From naoto.sato at oracle.com  Tue Nov 21 23:17:42 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Tue, 21 Nov 2017 15:17:42 -0800
Subject: <i18n dev> [10] RFR 8191404: Upgrading JDK with latest
 available LSR data from IANA.
In-Reply-To: <38d7fa00-252f-cd42-500a-deda1fef843f@oracle.com>
References: <38d7fa00-252f-cd42-500a-deda1fef843f@oracle.com>
Message-ID: <a528efb8-12d2-8a3c-e802-64e3d7355042@oracle.com>

Hi Nishit,

One nit in the test. At line 71, probably the original intention of 
"str" is to list the accept languages in alphabetic order. Would you 
change it?

I have not looked into actual tags in the test. Did  you modify them 
manually? If so, it would be desirable to make it automated.

Naoto

On 11/16/17 3:47 AM, Nishit Jain wrote:
> Hi,
> 
> Please review the fix for JDK-8191404
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8191404
> Webrev: http://cr.openjdk.java.net/~nishjain/8191404/webrev.00/
> 
> Fix: Updated the LSR data with the version: 2017-08-15
> 
> Regards,
> Nishit Jain

From nishit.jain at oracle.com  Wed Nov 22 08:13:01 2017
From: nishit.jain at oracle.com (Nishit Jain)
Date: Wed, 22 Nov 2017 13:43:01 +0530
Subject: <i18n dev> [10] RFR 8191404: Upgrading JDK with latest
 available LSR data from IANA.
In-Reply-To: <a528efb8-12d2-8a3c-e802-64e3d7355042@oracle.com>
References: <38d7fa00-252f-cd42-500a-deda1fef843f@oracle.com>
 <a528efb8-12d2-8a3c-e802-64e3d7355042@oracle.com>
Message-ID: <194793aa-d9b3-2d1d-5772-62b05cad7ff8@oracle.com>

Thanks Naoto,

 > One nit in the test. At line 71, probably the original intention of 
"str" is to list the accept languages in alphabetic order. Would you 
change it?
Yes, it is sorted according to weight then alphabetically. Updated the 
test case.

http://cr.openjdk.java.net/~nishjain/8191404/webrev.01/

 > I have not looked into actual tags in the test. Did you modify them 
manually? If so, it would be desirable to make it automated.
Yes, currently the updated tags are added in the test case manually. 
Making it automated is in the target list, will file/take it as a 
separate issue.
I would like to bring one point to notice that, I have not added all the 
new tags (which are added in this version) in the test case, just few of 
them are added to test that LocaleEquivalentMaps are properly updated. 
Hope that is fine.

Regards,
Nishit Jain
On 22-11-2017 04:47, Naoto Sato wrote:
> Hi Nishit,
>
> One nit in the test. At line 71, probably the original intention of 
> "str" is to list the accept languages in alphabetic order. Would you 
> change it?
>
> I have not looked into actual tags in the test. Did? you modify them 
> manually? If so, it would be desirable to make it automated.
>
> Naoto
>
> On 11/16/17 3:47 AM, Nishit Jain wrote:
>> Hi,
>>
>> Please review the fix for JDK-8191404
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8191404
>> Webrev: http://cr.openjdk.java.net/~nishjain/8191404/webrev.00/
>>
>> Fix: Updated the LSR data with the version: 2017-08-15
>>
>> Regards,
>> Nishit Jain


From naoto.sato at oracle.com  Wed Nov 22 17:18:27 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Wed, 22 Nov 2017 09:18:27 -0800
Subject: <i18n dev> [10] RFR 8191404: Upgrading JDK with latest
 available LSR data from IANA.
In-Reply-To: <194793aa-d9b3-2d1d-5772-62b05cad7ff8@oracle.com>
References: <38d7fa00-252f-cd42-500a-deda1fef843f@oracle.com>
 <a528efb8-12d2-8a3c-e802-64e3d7355042@oracle.com>
 <194793aa-d9b3-2d1d-5772-62b05cad7ff8@oracle.com>
Message-ID: <1e987494-0ecd-8446-3cef-48b0aa5920dc@oracle.com>

Looks good. As long as sampling the test data is meaningful, I think 
it's OK.

Naoto

On 11/22/17 12:13 AM, Nishit Jain wrote:
> Thanks Naoto,
> 
>  > One nit in the test. At line 71, probably the original intention of 
> "str" is to list the accept languages in alphabetic order. Would you 
> change it?
> Yes, it is sorted according to weight then alphabetically. Updated the 
> test case.
> 
> http://cr.openjdk.java.net/~nishjain/8191404/webrev.01/
> 
>  > I have not looked into actual tags in the test. Did you modify them 
> manually? If so, it would be desirable to make it automated.
> Yes, currently the updated tags are added in the test case manually. 
> Making it automated is in the target list, will file/take it as a 
> separate issue.
> I would like to bring one point to notice that, I have not added all the 
> new tags (which are added in this version) in the test case, just few of 
> them are added to test that LocaleEquivalentMaps are properly updated. 
> Hope that is fine.
> 
> Regards,
> Nishit Jain
> On 22-11-2017 04:47, Naoto Sato wrote:
>> Hi Nishit,
>>
>> One nit in the test. At line 71, probably the original intention of 
>> "str" is to list the accept languages in alphabetic order. Would you 
>> change it?
>>
>> I have not looked into actual tags in the test. Did? you modify them 
>> manually? If so, it would be desirable to make it automated.
>>
>> Naoto
>>
>> On 11/16/17 3:47 AM, Nishit Jain wrote:
>>> Hi,
>>>
>>> Please review the fix for JDK-8191404
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8191404
>>> Webrev: http://cr.openjdk.java.net/~nishjain/8191404/webrev.00/
>>>
>>> Fix: Updated the LSR data with the version: 2017-08-15
>>>
>>> Regards,
>>> Nishit Jain
> 

From naoto.sato at oracle.com  Wed Nov 22 19:04:39 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Wed, 22 Nov 2017 11:04:39 -0800
Subject: <i18n dev> [10] RFR 8176841: Additional Unicode Language-Tag
	Extensions
In-Reply-To: <d17ec439-110a-36e5-9575-d79f74592d51@oracle.com>
References: <5caff010-ef03-b62f-2041-3f57f126ae97@oracle.com>
 <d17ec439-110a-36e5-9575-d79f74592d51@oracle.com>
Message-ID: <03d177e8-ae43-6692-80f5-34dcc402ae51@oracle.com>

I revised the proposed changes, including java.time changes suggested by 
Stephen (CSR is still in progress):

https://bugs.openjdk.java.net/browse/JDK-8191349

The entire webrev is located at:

http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918.8191349/webrev.05/

And the diff webrev from the last one is located at:

http://cr.openjdk.java.net/~naoto/8191349/webrev.04-05/

I'd appreciate your reviews.

Naoto


On 11/9/17 3:34 PM, Naoto Sato wrote:
> Kindly requesting reviews. I incorporated a fix to the following issue 
> raised by the test team:
> 
> https://bugs.openjdk.java.net/browse/JDK-8190918
> 
> Here is the updated webrev:
> 
> http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918/webrev.04/
> 
> And the webrev since the one below (to address 8190918):
> 
> http://cr.openjdk.java.net/~naoto/8190918/
> 
> Naoto
> 
> 
> 
> On 11/2/17 2:42 PM, Naoto Sato wrote:
>> Hello,
>>
>> Please review the proposed changes for the following issues:
>>
>> 8176841: Additional Unicode Language-Tag Extensions
>> 8189134: New system properties for the default Locale extensions
>>
>> The proposed changeset is located at:
>>
>> http://cr.openjdk.java.net/~naoto/8176841/webrev.03/
>>
>> This serves as the implementation of JEP 314.
>>
>> Naoto
>>
>>
>>

From naoto.sato at oracle.com  Mon Nov 27 20:54:17 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Mon, 27 Nov 2017 12:54:17 -0800
Subject: <i18n dev> [10] RFR 8176841: Additional Unicode Language-Tag
 Extensions
In-Reply-To: <CACzrW9A6GAWv=UUAsJ-xHivGp-RkjJvv2riXjYhyaoC-u4TeuQ@mail.gmail.com>
References: <5caff010-ef03-b62f-2041-3f57f126ae97@oracle.com>
 <d17ec439-110a-36e5-9575-d79f74592d51@oracle.com>
 <03d177e8-ae43-6692-80f5-34dcc402ae51@oracle.com>
 <CACzrW9A6GAWv=UUAsJ-xHivGp-RkjJvv2riXjYhyaoC-u4TeuQ@mail.gmail.com>
Message-ID: <f32d69be-effa-d08e-6745-c3beb5b86504@oracle.com>

Thanks, Stephen. Here is the updated webrev:

http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918.8191349/webrev.06/

Naoto

On 11/23/17 8:13 AM, Stephen Colebourne wrote:
> In DateTimeFormatter line 1508, this would be preferred:
> 
>    return  new DateTimeFormatter(printerParser, locale, ds,
> resolverStyle, resolverFields, c, z);
> 
> In DateTimeFormatterBuilder.getLocalizedDateTimePattern() there is no
> spec change wrt using "rg".
> 
> Should findRegionOverride() just return a Locale instead of am
> Optional<Locale>? It always seems to have an orElse(locale).
> 
> Java-Time tests look good.
> 
> thanks
> Stephen
> 
> 
> On 22 November 2017 at 19:04, Naoto Sato <naoto.sato at oracle.com> wrote:
>> I revised the proposed changes, including java.time changes suggested by
>> Stephen (CSR is still in progress):
>>
>> https://bugs.openjdk.java.net/browse/JDK-8191349
>>
>> The entire webrev is located at:
>>
>> http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918.8191349/webrev.05/
>>
>> And the diff webrev from the last one is located at:
>>
>> http://cr.openjdk.java.net/~naoto/8191349/webrev.04-05/
>>
>> I'd appreciate your reviews.
>>
>> Naoto
>>
>>
>>
>> On 11/9/17 3:34 PM, Naoto Sato wrote:
>>>
>>> Kindly requesting reviews. I incorporated a fix to the following issue
>>> raised by the test team:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8190918
>>>
>>> Here is the updated webrev:
>>>
>>> http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918/webrev.04/
>>>
>>> And the webrev since the one below (to address 8190918):
>>>
>>> http://cr.openjdk.java.net/~naoto/8190918/
>>>
>>> Naoto
>>>
>>>
>>>
>>> On 11/2/17 2:42 PM, Naoto Sato wrote:
>>>>
>>>> Hello,
>>>>
>>>> Please review the proposed changes for the following issues:
>>>>
>>>> 8176841: Additional Unicode Language-Tag Extensions
>>>> 8189134: New system properties for the default Locale extensions
>>>>
>>>> The proposed changeset is located at:
>>>>
>>>> http://cr.openjdk.java.net/~naoto/8176841/webrev.03/
>>>>
>>>> This serves as the implementation of JEP 314.
>>>>
>>>> Naoto
>>>>
>>>>
>>>>
>>

From lance.andersen at oracle.com  Tue Nov 28 19:50:42 2017
From: lance.andersen at oracle.com (Lance Andersen)
Date: Tue, 28 Nov 2017 14:50:42 -0500
Subject: <i18n dev> [10] RFR 8176841: Additional Unicode Language-Tag
	Extensions
In-Reply-To: <03d177e8-ae43-6692-80f5-34dcc402ae51@oracle.com>
References: <5caff010-ef03-b62f-2041-3f57f126ae97@oracle.com>
 <d17ec439-110a-36e5-9575-d79f74592d51@oracle.com>
 <03d177e8-ae43-6692-80f5-34dcc402ae51@oracle.com>
Message-ID: <DF76AB8D-9A50-4345-B718-736216C547EA@oracle.com>

+1
> On Nov 22, 2017, at 2:04 PM, Naoto Sato <naoto.sato at oracle.com> wrote:
> 
> I revised the proposed changes, including java.time changes suggested by Stephen (CSR is still in progress):
> 
> https://bugs.openjdk.java.net/browse/JDK-8191349
> 
> The entire webrev is located at:
> 
> http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918.8191349/webrev.05/
> 
> And the diff webrev from the last one is located at:
> 
> http://cr.openjdk.java.net/~naoto/8191349/webrev.04-05/
> 
> I'd appreciate your reviews.
> 
> Naoto
> 
> 
> On 11/9/17 3:34 PM, Naoto Sato wrote:
>> Kindly requesting reviews. I incorporated a fix to the following issue raised by the test team:
>> https://bugs.openjdk.java.net/browse/JDK-8190918
>> Here is the updated webrev:
>> http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918/webrev.04/
>> And the webrev since the one below (to address 8190918):
>> http://cr.openjdk.java.net/~naoto/8190918/
>> Naoto
>> On 11/2/17 2:42 PM, Naoto Sato wrote:
>>> Hello,
>>> 
>>> Please review the proposed changes for the following issues:
>>> 
>>> 8176841: Additional Unicode Language-Tag Extensions
>>> 8189134: New system properties for the default Locale extensions
>>> 
>>> The proposed changeset is located at:
>>> 
>>> http://cr.openjdk.java.net/~naoto/8176841/webrev.03/
>>> 
>>> This serves as the implementation of JEP 314.
>>> 
>>> Naoto
>>> 
>>> 
>>> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>




From naoto.sato at oracle.com  Tue Nov 28 23:27:23 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Tue, 28 Nov 2017 15:27:23 -0800
Subject: <i18n dev> [10] RFR 8176841: Additional Unicode Language-Tag
 Extensions
In-Reply-To: <CACzrW9AiYD9whXokNvCqyXf_+F+PyNpEXWGSLOqLzv3-NfjW4A@mail.gmail.com>
References: <5caff010-ef03-b62f-2041-3f57f126ae97@oracle.com>
 <d17ec439-110a-36e5-9575-d79f74592d51@oracle.com>
 <03d177e8-ae43-6692-80f5-34dcc402ae51@oracle.com>
 <CACzrW9A6GAWv=UUAsJ-xHivGp-RkjJvv2riXjYhyaoC-u4TeuQ@mail.gmail.com>
 <f32d69be-effa-d08e-6745-c3beb5b86504@oracle.com>
 <CACzrW9AiYD9whXokNvCqyXf_+F+PyNpEXWGSLOqLzv3-NfjW4A@mail.gmail.com>
Message-ID: <64fbb071-cb5a-5961-e4d6-68db2c4b255b@oracle.com>

I've got some internal comments (two editorial fixes and java time test 
location move) and reflected them to the existing fix. Updated webrevs 
are located at:

http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918.8191349/webrev.07/
http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918.8191349/webrev.06-07/ 
(from v.06)

Naoto

On 11/27/17 1:26 PM, Stephen Colebourne wrote:
> This fixes my previous points, so fine by me. But I am not an OpenJDK reviewer.
> Stephen
> 
> On 27 November 2017 at 20:54, Naoto Sato <naoto.sato at oracle.com> wrote:
>> Thanks, Stephen. Here is the updated webrev:
>>
>> http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918.8191349/webrev.06/
>>
>> Naoto
>>
>>
>> On 11/23/17 8:13 AM, Stephen Colebourne wrote:
>>>
>>> In DateTimeFormatter line 1508, this would be preferred:
>>>
>>>     return  new DateTimeFormatter(printerParser, locale, ds,
>>> resolverStyle, resolverFields, c, z);
>>>
>>> In DateTimeFormatterBuilder.getLocalizedDateTimePattern() there is no
>>> spec change wrt using "rg".
>>>
>>> Should findRegionOverride() just return a Locale instead of am
>>> Optional<Locale>? It always seems to have an orElse(locale).
>>>
>>> Java-Time tests look good.
>>>
>>> thanks
>>> Stephen
>>>
>>>
>>> On 22 November 2017 at 19:04, Naoto Sato <naoto.sato at oracle.com> wrote:
>>>>
>>>> I revised the proposed changes, including java.time changes suggested by
>>>> Stephen (CSR is still in progress):
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8191349
>>>>
>>>> The entire webrev is located at:
>>>>
>>>>
>>>> http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918.8191349/webrev.05/
>>>>
>>>> And the diff webrev from the last one is located at:
>>>>
>>>> http://cr.openjdk.java.net/~naoto/8191349/webrev.04-05/
>>>>
>>>> I'd appreciate your reviews.
>>>>
>>>> Naoto
>>>>
>>>>
>>>>
>>>> On 11/9/17 3:34 PM, Naoto Sato wrote:
>>>>>
>>>>>
>>>>> Kindly requesting reviews. I incorporated a fix to the following issue
>>>>> raised by the test team:
>>>>>
>>>>> https://bugs.openjdk.java.net/browse/JDK-8190918
>>>>>
>>>>> Here is the updated webrev:
>>>>>
>>>>> http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918/webrev.04/
>>>>>
>>>>> And the webrev since the one below (to address 8190918):
>>>>>
>>>>> http://cr.openjdk.java.net/~naoto/8190918/
>>>>>
>>>>> Naoto
>>>>>
>>>>>
>>>>>
>>>>> On 11/2/17 2:42 PM, Naoto Sato wrote:
>>>>>>
>>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> Please review the proposed changes for the following issues:
>>>>>>
>>>>>> 8176841: Additional Unicode Language-Tag Extensions
>>>>>> 8189134: New system properties for the default Locale extensions
>>>>>>
>>>>>> The proposed changeset is located at:
>>>>>>
>>>>>> http://cr.openjdk.java.net/~naoto/8176841/webrev.03/
>>>>>>
>>>>>> This serves as the implementation of JEP 314.
>>>>>>
>>>>>> Naoto
>>>>>>
>>>>>>
>>>>>>
>>>>
>>

From lance.andersen at oracle.com  Wed Nov 29 00:00:20 2017
From: lance.andersen at oracle.com (Lance Andersen)
Date: Tue, 28 Nov 2017 19:00:20 -0500
Subject: <i18n dev> [10] RFR 8176841: Additional Unicode Language-Tag
 Extensions
In-Reply-To: <64fbb071-cb5a-5961-e4d6-68db2c4b255b@oracle.com>
References: <5caff010-ef03-b62f-2041-3f57f126ae97@oracle.com>
 <d17ec439-110a-36e5-9575-d79f74592d51@oracle.com>
 <03d177e8-ae43-6692-80f5-34dcc402ae51@oracle.com>
 <CACzrW9A6GAWv=UUAsJ-xHivGp-RkjJvv2riXjYhyaoC-u4TeuQ@mail.gmail.com>
 <f32d69be-effa-d08e-6745-c3beb5b86504@oracle.com>
 <CACzrW9AiYD9whXokNvCqyXf_+F+PyNpEXWGSLOqLzv3-NfjW4A@mail.gmail.com>
 <64fbb071-cb5a-5961-e4d6-68db2c4b255b@oracle.com>
Message-ID: <A705C1D1-8C9B-42C9-B9ED-6870559D73D3@oracle.com>

Updates look good :-)
> On Nov 28, 2017, at 6:27 PM, Naoto Sato <naoto.sato at oracle.com> wrote:
> 
> I've got some internal comments (two editorial fixes and java time test location move) and reflected them to the existing fix. Updated webrevs are located at:
> 
> http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918.8191349/webrev.07/
> http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918.8191349/webrev.06-07/ (from v.06)
> 
> Naoto
> 
> On 11/27/17 1:26 PM, Stephen Colebourne wrote:
>> This fixes my previous points, so fine by me. But I am not an OpenJDK reviewer.
>> Stephen
>> On 27 November 2017 at 20:54, Naoto Sato <naoto.sato at oracle.com> wrote:
>>> Thanks, Stephen. Here is the updated webrev:
>>> 
>>> http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918.8191349/webrev.06/
>>> 
>>> Naoto
>>> 
>>> 
>>> On 11/23/17 8:13 AM, Stephen Colebourne wrote:
>>>> 
>>>> In DateTimeFormatter line 1508, this would be preferred:
>>>> 
>>>>    return  new DateTimeFormatter(printerParser, locale, ds,
>>>> resolverStyle, resolverFields, c, z);
>>>> 
>>>> In DateTimeFormatterBuilder.getLocalizedDateTimePattern() there is no
>>>> spec change wrt using "rg".
>>>> 
>>>> Should findRegionOverride() just return a Locale instead of am
>>>> Optional<Locale>? It always seems to have an orElse(locale).
>>>> 
>>>> Java-Time tests look good.
>>>> 
>>>> thanks
>>>> Stephen
>>>> 
>>>> 
>>>> On 22 November 2017 at 19:04, Naoto Sato <naoto.sato at oracle.com> wrote:
>>>>> 
>>>>> I revised the proposed changes, including java.time changes suggested by
>>>>> Stephen (CSR is still in progress):
>>>>> 
>>>>> https://bugs.openjdk.java.net/browse/JDK-8191349
>>>>> 
>>>>> The entire webrev is located at:
>>>>> 
>>>>> 
>>>>> http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918.8191349/webrev.05/
>>>>> 
>>>>> And the diff webrev from the last one is located at:
>>>>> 
>>>>> http://cr.openjdk.java.net/~naoto/8191349/webrev.04-05/
>>>>> 
>>>>> I'd appreciate your reviews.
>>>>> 
>>>>> Naoto
>>>>> 
>>>>> 
>>>>> 
>>>>> On 11/9/17 3:34 PM, Naoto Sato wrote:
>>>>>> 
>>>>>> 
>>>>>> Kindly requesting reviews. I incorporated a fix to the following issue
>>>>>> raised by the test team:
>>>>>> 
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8190918
>>>>>> 
>>>>>> Here is the updated webrev:
>>>>>> 
>>>>>> http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918/webrev.04/
>>>>>> 
>>>>>> And the webrev since the one below (to address 8190918):
>>>>>> 
>>>>>> http://cr.openjdk.java.net/~naoto/8190918/
>>>>>> 
>>>>>> Naoto
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> On 11/2/17 2:42 PM, Naoto Sato wrote:
>>>>>>> 
>>>>>>> 
>>>>>>> Hello,
>>>>>>> 
>>>>>>> Please review the proposed changes for the following issues:
>>>>>>> 
>>>>>>> 8176841: Additional Unicode Language-Tag Extensions
>>>>>>> 8189134: New system properties for the default Locale extensions
>>>>>>> 
>>>>>>> The proposed changeset is located at:
>>>>>>> 
>>>>>>> http://cr.openjdk.java.net/~naoto/8176841/webrev.03/
>>>>>>> 
>>>>>>> This serves as the implementation of JEP 314.
>>>>>>> 
>>>>>>> Naoto
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>> 
>>> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>




From Roger.Riggs at Oracle.com  Wed Nov 29 15:05:53 2017
From: Roger.Riggs at Oracle.com (Roger Riggs)
Date: Wed, 29 Nov 2017 10:05:53 -0500
Subject: <i18n dev> [10] RFR 6354947: [Fmt-*] DecimalFormat ignores
 FieldPosition settings on input, contrary to Javadocs
In-Reply-To: <91cfcd2f-97ba-dda8-eb2d-9c4bd0f05f29@oracle.com>
References: <156741f0-36df-03cb-e30f-e2c41d0fc3ef@oracle.com>
 <91cfcd2f-97ba-dda8-eb2d-9c4bd0f05f29@oracle.com>
Message-ID: <d7bc5240-369f-88f6-8e46-d3e38152c2db@Oracle.com>

Hi Nishit,

The webrev and updates to the javadoc look fine.

However, the summary of the issue does not reflect the issue and implies 
the implementation is wrong;
but it is the javadoc that need clarification.

Please change the issue summary (on both the CSR and the issue) to 
reflect the true cause, something like:

[Fmt-*] Clarify DecimalFormat description of FieldPosition use

Thanks, Roger


On 11/17/2017 7:21 PM, Naoto Sato wrote:
> +1
>
> Naoto
>
> On 11/16/17 10:52 PM, Nishit Jain wrote:
>> Hi,
>>
>> Please review the fix for JDK-6354947
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-6354947
>> Webrev: http://cr.openjdk.java.net/~nishjain/6354947/webrev.02/
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8191014
>>
>> Fix: Clarified handling of the FieldPosition settings in the 
>> java.text.Format APIs specification.
>>
>> Regards,
>> Nishit Jain


From nishit.jain at oracle.com  Thu Nov 30 06:00:31 2017
From: nishit.jain at oracle.com (Nishit Jain)
Date: Thu, 30 Nov 2017 11:30:31 +0530
Subject: <i18n dev> [10] RFR 6354947: [Fmt-*] DecimalFormat ignores
 FieldPosition settings on input, contrary to Javadocs
In-Reply-To: <d7bc5240-369f-88f6-8e46-d3e38152c2db@Oracle.com>
References: <156741f0-36df-03cb-e30f-e2c41d0fc3ef@oracle.com>
 <91cfcd2f-97ba-dda8-eb2d-9c4bd0f05f29@oracle.com>
 <d7bc5240-369f-88f6-8e46-d3e38152c2db@Oracle.com>
Message-ID: <105a30a7-fc82-3080-42af-269f00903f62@oracle.com>

Thanks Naoto, Roger for the review.

 > the summary of the issue does not reflect the issue and implies the 
implementation is wrong; but it is the javadoc that need clarification.
It is probably because when this bug was filed, it was not clear whether 
implementation will be changed as per javadoc or the javadoc will be 
changed.

 > Please change the issue summary (on both the CSR and the issue) to 
reflect the true cause.
Done

Regards,
Nishit Jain
On 29-11-2017 20:35, Roger Riggs wrote:
> Hi Nishit,
>
> The webrev and updates to the javadoc look fine.
>
> However, the summary of the issue does not reflect the issue and 
> implies the implementation is wrong;
> but it is the javadoc that need clarification.
>
> Please change the issue summary (on both the CSR and the issue) to 
> reflect the true cause, something like:
>
> [Fmt-*] Clarify DecimalFormat description of FieldPosition use
>
> Thanks, Roger
>
>
> On 11/17/2017 7:21 PM, Naoto Sato wrote:
>> +1
>>
>> Naoto
>>
>> On 11/16/17 10:52 PM, Nishit Jain wrote:
>>> Hi,
>>>
>>> Please review the fix for JDK-6354947
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-6354947
>>> Webrev: http://cr.openjdk.java.net/~nishjain/6354947/webrev.02/
>>> CSR: https://bugs.openjdk.java.net/browse/JDK-8191014
>>>
>>> Fix: Clarified handling of the FieldPosition settings in the 
>>> java.text.Format APIs specification.
>>>
>>> Regards,
>>> Nishit Jain
>