<i18n dev> JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c

[Ramanand Patil]

Thank you Martin for your review.

 

For the java file updates, currently I don’t use any script but just simple “find and replace” whenever possible and rest is manual. I run all the TZ related tests locally on Ubuntu and use JPRT for all other platforms.

 

 

Regards,

Ramanand.

 

From: Martin Buchholz [mailto:martinrb at google.com] 
Sent: Wednesday, November 08, 2017 12:18 AM
To: Ramanand Patil <ramanand.patil at oracle.com>
Cc: Naoto Sato <naoto.sato at oracle.com>; core-libs-dev <core-libs-dev at openjdk.java.net>; i18n-dev at openjdk.java.net
Subject: Re: <i18n dev> JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c

 

Looks good to me too.

 

I've always wondered about how the corresponding java source files are maintained.  Is it all manual or do y'all have some magic script to help keep IANA data and java data aligned?  Do we need more testing that mistakes don't creep in?

 

On Tue, Nov 7, 2017 at 3:41 AM, Ramanand Patil <HYPERLINK "mailto:ramanand.patil at oracle.com"ramanand.patil at oracle.com> wrote:

Hi Naoto,
Thank you for pointing that. I have modified both the affected files(ZoneName.java from src and test).
Here is the updated Webrev: http://cr.openjdk.java.net/~rpatil/8190258+8190259/webrev.01/

Regards,
Ramanand.


> -----Original Message-----
> From: Naoto Sato
> Sent: Tuesday, November 07, 2017 5:18 AM
> To: Ramanand Patil <HYPERLINK "mailto:ramanand.patil at oracle.com"ramanand.patil at oracle.com>; core-libs-dev <core-libs-
> HYPERLINK "mailto:dev at openjdk.java.net"dev at openjdk.java.net>; HYPERLINK "mailto:i18n-dev at openjdk.java.net"i18n-dev at openjdk.java.net
> Subject: Re: <i18n dev> JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c
> and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c
>
> Hi Ramanand,
>
> In java/time/format/ZoneName.java, should the zid for Africa_Central map
> to "Africa/Maputo"?
>
> Naoto
>
> On 11/6/17 6:06 AM, Ramanand Patil wrote:
> > Hi all,
> > Please review the latest TZDATA integration (tzdata2017c) to JDK10.
> > Bugs:
> > https://bugs.openjdk.java.net/browse/JDK-8190258
> > https://bugs.openjdk.java.net/browse/JDK-8190259
> >
> > Webrev: http://cr.openjdk.java.net/~rpatil/8190258+8190259/webrev.00/
> >
> > All the TimeZone related tests are passed after integration.
> >
> > Regards,
> > Ramanand.
> >