From ying.z.zhou at oracle.com  Tue Aug  7 07:31:00 2018
From: ying.z.zhou at oracle.com (Ying Zhou)
Date: Tue, 7 Aug 2018 15:31:00 +0800
Subject: <i18n dev> [12]RFR 8208656: Move
 java/util/Calendar/CalendarTestScripts tests into OpenJDK
Message-ID: <564a5be8-df5a-69a8-8fb4-9dc2f8015503@oracle.com>

Hello,

Please help review the patch to move some tests to OpenJDK. Thank you!

Bug: https://bugs.openjdk.java.net/browse/JDK-8208656

Webrev: http://cr.openjdk.java.net/~dzhou/8208656/webrev.00/ 
<http://cr.openjdk.java.net/%7Edzhou/8208656/webrev.00/>

Regards,

Daisy


From naoto.sato at oracle.com  Wed Aug  8 18:13:50 2018
From: naoto.sato at oracle.com (naoto.sato at oracle.com)
Date: Wed, 8 Aug 2018 11:13:50 -0700
Subject: <i18n dev> [12]RFR 8208656: Move
 java/util/Calendar/CalendarTestScripts tests into OpenJDK
In-Reply-To: <564a5be8-df5a-69a8-8fb4-9dc2f8015503@oracle.com>
References: <564a5be8-df5a-69a8-8fb4-9dc2f8015503@oracle.com>
Message-ID: <a91d5bee-51c8-cf0f-2d63-f8335402ac3a@oracle.com>

Looks good. Please add "noreg-self" label to the issue.

Naoto

On 8/7/18 12:31 AM, Ying Zhou wrote:
> Hello,
> 
> Please help review the patch to move some tests to OpenJDK. Thank you!
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8208656
> 
> Webrev: http://cr.openjdk.java.net/~dzhou/8208656/webrev.00/ 
> <http://cr.openjdk.java.net/%7Edzhou/8208656/webrev.00/>
> 
> Regards,
> 
> Daisy
> 

From martinrb at google.com  Fri Aug 10 19:57:05 2018
From: martinrb at google.com (Martin Buchholz)
Date: Fri, 10 Aug 2018 12:57:05 -0700
Subject: <i18n dev> RFR 8209184: JDK8 ResourceBundle vulnerable to GC
	(fix included)
In-Reply-To: <OF73090A20.AEC24ED7-ON002582E5.00555A7E-802582E5.00563E62@notes.na.collabserv.com>
References: <OF73090A20.AEC24ED7-ON002582E5.00555A7E-802582E5.00563E62@notes.na.collabserv.com>
Message-ID: <CA+kOe092Su=ghCsXy7mov_hntNL3UC+rnpk+3Ly2Z9eTx6nXWA@mail.gmail.com>

retargeted bug to java.util:i18n, the right mailing list seems to be
i18n-dev.

On Fri, Aug 10, 2018 at 8:42 AM, Adam Farley8 <adam.farley at uk.ibm.com>
wrote:

> Hi All,
>
> This bug could be fixed by comparing the Class Loader with a blank
> static volatile Object (defined outside the method scope) at the
> end of the getBundleImpl class.
>
> E.g.
>
> -----------------------------------------
> +1322
>     /**
>      * volatile reference object to guard the ClassLoader object
>      * being garbage collected before getBundleImpl() method completes
>      * the caching and retrieving of requested Resourcebundle object
>      */
>     private static volatile Object vo = new Object();
>
>
> +1400
> //Should never be true. Using the loader here prevents it being GC'd.
>             if (loader == vo) throw new Error("Unexpected error.");
> -----------------------------------------
>
> Will upload a webrev after debate.
>
> - Adam
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>

From rachna.goel at oracle.com  Mon Aug 13 09:48:24 2018
From: rachna.goel at oracle.com (Rachna Goel)
Date: Mon, 13 Aug 2018 15:18:24 +0530
Subject: <i18n dev> [11] RFR: 8209047:"Illegal pattern character 'B'"
 IllegalArgumentException with Burmese locales
Message-ID: <334cc1c4-3b95-aee3-f7f6-60860aa61715@oracle.com>

Hi,

Kindly review the fix to JDK-8209047.

Bug: https://bugs.openjdk.java.net/browse/JDK-8209047
webrev: http://cr.openjdk.java.net/~rgoel/JDK-8209047/webrev.03/

It is a regression caused by JDK-8202537. Because of the 'B' character 
introduced in the CLDR time patterns "B HH:mm:ss", "B H:mm" (where B 
represents the 'day period') for "my" (Burmese) locale. Since, this 
character is not supported in java.text.SimpleDateFormat and in 
java.time.DateTimeFormatter, it is throwing IllegalArgumentException. 
Fix is to change time pattern to previous CLDR's version i.e 29, until 
'B' character is supported via JDK-8209175.

-- 
Thanks,
Rachna


From naoto.sato at oracle.com  Mon Aug 13 15:28:31 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Mon, 13 Aug 2018 08:28:31 -0700
Subject: <i18n dev> [11] RFR: 8209047:"Illegal pattern character 'B'"
 IllegalArgumentException with Burmese locales
In-Reply-To: <334cc1c4-3b95-aee3-f7f6-60860aa61715@oracle.com>
References: <334cc1c4-3b95-aee3-f7f6-60860aa61715@oracle.com>
Message-ID: <bd17bdca-6860-41e5-1570-d6c8f52d654f@oracle.com>

Looks good.

Naoto

On 8/13/18 2:48 AM, Rachna Goel wrote:
> Hi,
> 
> Kindly review the fix to JDK-8209047.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8209047
> webrev: http://cr.openjdk.java.net/~rgoel/JDK-8209047/webrev.03/
> 
> It is a regression caused by JDK-8202537. Because of the 'B' character 
> introduced in the CLDR time patterns "B HH:mm:ss", "B H:mm" (where B 
> represents the 'day period') for "my" (Burmese) locale. Since, this 
> character is not supported in java.text.SimpleDateFormat and in 
> java.time.DateTimeFormatter, it is throwing IllegalArgumentException. 
> Fix is to change time pattern to previous CLDR's version i.e 29, until 
> 'B' character is supported via JDK-8209175.
> 

From mandy.chung at oracle.com  Tue Aug 14 15:24:36 2018
From: mandy.chung at oracle.com (mandy chung)
Date: Tue, 14 Aug 2018 08:24:36 -0700
Subject: <i18n dev> RFR 8209184: JDK8 ResourceBundle vulnerable to GC
	(fix included)
In-Reply-To: <OF73090A20.AEC24ED7-ON002582E5.00555A7E-802582E5.00563E62@notes.na.collabserv.com>
References: <OF73090A20.AEC24ED7-ON002582E5.00555A7E-802582E5.00563E62@notes.na.collabserv.com>
Message-ID: <cccb972f-ba27-686f-2c38-aab5644d779e@oracle.com>

Hi Adam,

Have you tried Peter's suggestion if an empty static method taking an
Object parameter?  Does it work for you?

Your proposed approach seems fine and I would suggest to put the
check in a static keepAlive method that will make it explicitly.

Mandy

On 8/10/18 8:42 AM, Adam Farley8 wrote:
> Hi All,
> 
> This bug could be fixed by comparing the Class Loader with a blank
> static volatile Object (defined outside the method scope) at the
> end of the getBundleImpl class.
> 
> E.g.
> 
> -----------------------------------------
> +1322
>      /**
>       * volatile reference object to guard the ClassLoader object
>       * being garbage collected before getBundleImpl() method completes
>       * the caching and retrieving of requested Resourcebundle object
>       */
>      private static volatile Object vo = new Object();
> 
> 
> +1400
> //Should never be true. Using the loader here prevents it being GC'd.
>              if (loader == vo) throw new Error("Unexpected error.");
> -----------------------------------------
> 
> Will upload a webrev after debate.
> 
> - Adam
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
> 

From mandy.chung at oracle.com  Tue Aug 14 23:54:53 2018
From: mandy.chung at oracle.com (mandy chung)
Date: Tue, 14 Aug 2018 16:54:53 -0700
Subject: <i18n dev> RFR 8209184: JDK8 ResourceBundle vulnerable to GC
	(fix included)
In-Reply-To: <CAMOCf+jNLxR=0on74C476-5fi9Cgn--WvZPZTtqobRWK5LaMow@mail.gmail.com>
References: <OF73090A20.AEC24ED7-ON002582E5.00555A7E-802582E5.00563E62@notes.na.collabserv.com>
 <cccb972f-ba27-686f-2c38-aab5644d779e@oracle.com>
 <CAMOCf+jNLxR=0on74C476-5fi9Cgn--WvZPZTtqobRWK5LaMow@mail.gmail.com>
Message-ID: <5d38fbd7-816d-9dfb-10a0-e018a1ba7f8f@oracle.com>

Thanks for the information.  Not sure what's the best option we can do
in 8u.  I think it's acceptable to have a fix that works in the
current context (like empty static method).

Thoughts?

Mandy

On 8/14/18 4:22 PM, Hans Boehm wrote:
> I haven't looked at the details here, but comparing against a volatile 
> is not in general a portable way to keep an object live. Like empty 
> static methods, it may be fine in the current (OpenJDK) context.
> 
> Volatile loads have roach motel semantics and can be advanced past other 
> operations. The comparison can be done early, too, keeping only the 
> condition code. There is no guarantee the reference will still be around 
> when you expect it.
> 
> I haven't come up with a great compiler-independent replacement for 
> reachabilityFence.
> 
> On Tue, Aug 14, 2018 at 8:25 AM mandy chung <mandy.chung at oracle.com 
> <mailto:mandy.chung at oracle.com>> wrote:
> 
>     Hi Adam,
> 
>     Have you tried Peter's suggestion if an empty static method taking an
>     Object parameter?? Does it work for you?
> 
>     Your proposed approach seems fine and I would suggest to put the
>     check in a static keepAlive method that will make it explicitly.
> 
>     Mandy
> 
>     On 8/10/18 8:42 AM, Adam Farley8 wrote:
>      > Hi All,
>      >
>      > This bug could be fixed by comparing the Class Loader with a blank
>      > static volatile Object (defined outside the method scope) at the
>      > end of the getBundleImpl class.
>      >
>      > E.g.
>      >
>      > -----------------------------------------
>      > +1322
>      >? ? ? /**
>      >? ? ? ?* volatile reference object to guard the ClassLoader object
>      >? ? ? ?* being garbage collected before getBundleImpl() method
>     completes
>      >? ? ? ?* the caching and retrieving of requested Resourcebundle object
>      >? ? ? ?*/
>      >? ? ? private static volatile Object vo = new Object();
>      >
>      >
>      > +1400
>      > //Should never be true. Using the loader here prevents it being GC'd.
>      >? ? ? ? ? ? ? if (loader == vo) throw new Error("Unexpected error.");
>      > -----------------------------------------
>      >
>      > Will upload a webrev after debate.
>      >
>      > - Adam
>      > Unless stated otherwise above:
>      > IBM United Kingdom Limited - Registered in England and Wales with
>     number
>      > 741598.
>      > Registered office: PO Box 41, North Harbour, Portsmouth,
>     Hampshire PO6 3AU
>      >
> 

From adam.farley at uk.ibm.com  Wed Aug 15 15:45:03 2018
From: adam.farley at uk.ibm.com (Adam Farley8)
Date: Wed, 15 Aug 2018 16:45:03 +0100
Subject: <i18n dev> RFR 8209184: JDK8 ResourceBundle vulnerable to GC
	(fix included)
In-Reply-To: <OF892E1194.0FD5391B-ON002582EA.0053B9BA-802582EA.005521F5@LocalDomain>
References: <OF73090A20.AEC24ED7-ON002582E5.00555A7E-802582E5.00563E62@notes.na.collabserv.com>
 <cccb972f-ba27-686f-2c38-aab5644d779e@oracle.com>
 <CAMOCf+jNLxR=0on74C476-5fi9Cgn--WvZPZTtqobRWK5LaMow@mail.gmail.com>
 <5d38fbd7-816d-9dfb-10a0-e018a1ba7f8f@oracle.com>
 <CAMOCf+hOQFF+Ym=4KgkMCt=ViLMP7Oj3bfvZLULkYQ2v4Q3UvQ@mail.gmail.com>
 <OF892E1194.0FD5391B-ON002582EA.0053B9BA-802582EA.005521F5@LocalDomain>
Message-ID: <OFD5CD6047.36213180-ON002582EA.00567837-802582EA.0056863C@notes.na.collabserv.com>

Hi Mandy, Hans,

Tried out the below (after removing my previous fix, the volatile 
compare), and it appears to solve the problem just fine. 

If I generate a webrev and get it attached to the bug, would one of you 
mind approving the change?

----------...at the end of getBundleImpl in jdk8  ------------
        keepAlive(loader);
        return bundle;
}

//To keep the argument ClassLoader alive.
private static void keepAlive(ClassLoader loaderone){
            //Do nothing.
}
----------------------

Best Regards

Adam Farley 

Hans Boehm <hboehm at google.com> wrote on 15/08/2018 06:44:08:

> From: Hans Boehm <hboehm at google.com>
> To: Mandy Chung <mandy.chung at oracle.com>
> Cc: adam.farley at uk.ibm.com, core-libs-dev <core-libs-
> dev at openjdk.java.net>, i18n-dev at openjdk.java.net
> Date: 15/08/2018 06:44
> Subject: Re: RFR 8209184: JDK8 ResourceBundle vulnerable to GC (fix 
included)
> 
> FWIW, since there was agreement that empty static methods should 
> work in this context, that seems like the best option to me.
> 
> On Tue, Aug 14, 2018 at 4:54 PM mandy chung <mandy.chung at oracle.com> 
wrote:
> Thanks for the information.  Not sure what's the best option we can do
> in 8u.  I think it's acceptable to have a fix that works in the
> current context (like empty static method).
> 
> Thoughts?
> 
> Mandy
> 
> On 8/14/18 4:22 PM, Hans Boehm wrote:
> > I haven't looked at the details here, but comparing against a volatile 

> > is not in general a portable way to keep an object live. Like empty 
> > static methods, it may be fine in the current (OpenJDK) context.
> > 
> > Volatile loads have roach motel semantics and can be advanced past 
other 
> > operations. The comparison can be done early, too, keeping only the 
> > condition code. There is no guarantee the reference will still be 
around 
> > when you expect it.
> > 
> > I haven't come up with a great compiler-independent replacement for 
> > reachabilityFence.
> > 
> > On Tue, Aug 14, 2018 at 8:25 AM mandy chung <mandy.chung at oracle.com 
> > <mailto:mandy.chung at oracle.com>> wrote:
> > 
> >     Hi Adam,
> > 
> >     Have you tried Peter's suggestion if an empty static method taking 
an
> >     Object parameter?  Does it work for you?
> > 
> >     Your proposed approach seems fine and I would suggest to put the
> >     check in a static keepAlive method that will make it explicitly.
> > 
> >     Mandy
> > 
> >     On 8/10/18 8:42 AM, Adam Farley8 wrote:
> >      > Hi All,
> >      >
> >      > This bug could be fixed by comparing the Class Loader with a 
blank
> >      > static volatile Object (defined outside the method scope) at 
the
> >      > end of the getBundleImpl class.
> >      >
> >      > E.g.
> >      >
> >      > -----------------------------------------
> >      > +1322
> >      >      /**
> >      >       * volatile reference object to guard the ClassLoader 
object
> >      >       * being garbage collected before getBundleImpl() method
> >     completes
> >      >       * the caching and retrieving of requested Resourcebundle 
object
> >      >       */
> >      >      private static volatile Object vo = new Object();
> >      >
> >      >
> >      > +1400
> >      > //Should never be true. Using the loader here prevents it being 
GC'd.
> >      >              if (loader == vo) throw new Error("Unexpected 
error.");
> >      > -----------------------------------------
> >      >
> >      > Will upload a webrev after debate.
> >      >
> >      > - Adam
> >      > Unless stated otherwise above:
> >      > IBM United Kingdom Limited - Registered in England and Wales 
with
> >     number
> >      > 741598.
> >      > Registered office: PO Box 41, North Harbour, Portsmouth,
> >     Hampshire PO6 3AU
> >      >
> > 
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

From mandy.chung at oracle.com  Wed Aug 15 16:49:51 2018
From: mandy.chung at oracle.com (mandy chung)
Date: Wed, 15 Aug 2018 09:49:51 -0700
Subject: <i18n dev> RFR 8209184: JDK8 ResourceBundle vulnerable to GC
	(fix included)
In-Reply-To: <OFD5CD6047.36213180-ON002582EA.00567837-802582EA.0056863C@notes.na.collabserv.com>
References: <OF73090A20.AEC24ED7-ON002582E5.00555A7E-802582E5.00563E62@notes.na.collabserv.com>
 <cccb972f-ba27-686f-2c38-aab5644d779e@oracle.com>
 <CAMOCf+jNLxR=0on74C476-5fi9Cgn--WvZPZTtqobRWK5LaMow@mail.gmail.com>
 <5d38fbd7-816d-9dfb-10a0-e018a1ba7f8f@oracle.com>
 <CAMOCf+hOQFF+Ym=4KgkMCt=ViLMP7Oj3bfvZLULkYQ2v4Q3UvQ@mail.gmail.com>
 <OF892E1194.0FD5391B-ON002582EA.0053B9BA-802582EA.005521F5@LocalDomain>
 <OFD5CD6047.36213180-ON002582EA.00567837-802582EA.0056863C@notes.na.collabserv.com>
Message-ID: <e9e19390-a0ca-9bf8-24b7-3b033a676680@oracle.com>

Hi Adam,

This fix is JDK 8u only and so you will need to request for 8u approval.

The proposed empty static method is fine with me.  Please fix the format 
and indentation before you post the review.

Since this patch is small, you can inline the diff in the RFR mail.
I can review it when you send the review request out.

Mandy
[1] http://openjdk.java.net/projects/jdk8u/approval-template.html

On 8/15/18 8:45 AM, Adam Farley8 wrote:
> Hi Mandy, Hans,
> 
> Tried out the below (after removing my previous fix, the volatile 
> compare), and it appears to solve the problem just fine.
> 
> If I generate a webrev and get it attached to the bug, would one of you 
> mind approving the change?
> 
> ----------...at the end of getBundleImpl in jdk8 ?------------
>  ? ? keepAlive(loader);
>  ? ? return bundle;
> }
> 
> //To keep the argument ClassLoader alive.
> private static void keepAlive(ClassLoader loaderone){
>  ? ? ? ? //Do nothing.
> }
> ----------------------
> 
> Best Regards
> 
> Adam Farley
> 
> Hans Boehm <hboehm at google.com> wrote on 15/08/2018 06:44:08:
> 
>> From: Hans Boehm <hboehm at google.com>
>> To: Mandy Chung <mandy.chung at oracle.com>
>> Cc: adam.farley at uk.ibm.com,  core-libs-dev <core-libs-
>> dev at openjdk.java.net>, i18n-dev at openjdk.java.net
>> Date: 15/08/2018 06:44
>> Subject: Re: RFR 8209184: JDK8  ResourceBundle vulnerable to GC (fix included)
>> 
>> FWIW, since there was agreement that empty static methods should 
>> work in this context, that seems like the best option to me.
>> 
>> On Tue, Aug 14, 2018 at 4:54 PM mandy chung <mandy.chung at oracle.com>  wrote:
>> Thanks for the information. Not sure what's the best option we can do
>> in 8u.? I think it's acceptable to have a fix that works in the
>> current context (like empty static method).
>> 
>> Thoughts?
>> 
>> Mandy
>> 
>> On 8/14/18 4:22 PM, Hans Boehm wrote:
>> > I haven't looked at the details here, but comparing against a  volatile
>> > is not in general a portable way to keep an object live. Like  empty
>> > static methods, it may be fine in the current (OpenJDK) context.
>> > 
>> > Volatile loads have roach motel semantics and can be advanced  past other
>> > operations. The comparison can be done early, too, keeping only  the
>> > condition code. There is no guarantee the reference will still  be around
>> > when you expect it.
>> > 
>> > I haven't come up with a great compiler-independent replacement  for
>> > reachabilityFence.
>> > 
>> > On Tue, Aug 14, 2018 at 8:25 AM mandy chung <mandy.chung at oracle.com
>> > <mailto:mandy.chung at oracle.com>> wrote:
>> > 
>> >? ? ?Hi Adam,
>> > 
>> >? ? ?Have you tried Peter's suggestion if an empty  static method taking an
>> >? ? ?Object parameter?? Does it work for you?
>> > 
>> >? ? ?Your proposed approach seems fine and I would  suggest to put the
>> >? ? ?check in a static keepAlive method that will  make it explicitly.
>> > 
>> >? ? ?Mandy
>> > 
>> >? ? ?On 8/10/18 8:42 AM, Adam Farley8 wrote:
>> >? ? ? > Hi All,
>> >? ? ? >
>> >? ? ? > This bug could be fixed by comparing  the Class Loader with a blank
>> >? ? ? > static volatile Object (defined outside  the method scope) at the
>> >? ? ? > end of the getBundleImpl class.
>> >? ? ? >
>> >? ? ? > E.g.
>> >? ? ? >
>> >? ? ? > -----------------------------------------
>> >? ? ? > +1322
>> >? ? ? >? ? ? /**
>> >? ? ? >? ? ? ?* volatile  reference object to guard the ClassLoader object
>> >? ? ? >? ? ? ?* being garbage  collected before getBundleImpl() method
>> >? ? ?completes
>> >? ? ? >? ? ? ?* the caching  and retrieving of requested Resourcebundle object
>> >? ? ? >? ? ? ?*/
>> >? ? ? >? ? ? private static volatile  Object vo = new Object();
>> >? ? ? >
>> >? ? ? >
>> >? ? ? > +1400
>> >? ? ? > //Should never be true. Using the loader  here prevents it being GC'd.
>> >? ? ? >            ? if (loader == vo) throw new Error("Unexpected error.");
>> >? ? ? > -----------------------------------------
>> >? ? ? >
>> >? ? ? > Will upload a webrev after debate.
>> >? ? ? >
>> >? ? ? > - Adam
>> >? ? ? > Unless stated otherwise above:
>> >? ? ? > IBM United Kingdom Limited - Registered  in England and Wales with
>> >? ? ?number
>> >? ? ? > 741598.
>> >? ? ? > Registered office: PO Box 41, North  Harbour, Portsmouth,
>> >? ? ?Hampshire PO6 3AU
>> >? ? ? >
>> > 
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number 
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

From adam.farley at uk.ibm.com  Thu Aug 16 09:16:21 2018
From: adam.farley at uk.ibm.com (Adam Farley8)
Date: Thu, 16 Aug 2018 10:16:21 +0100
Subject: <i18n dev> RFR 8209184: JDK8 ResourceBundle vulnerable to GC
	(fix included)
In-Reply-To: <e9e19390-a0ca-9bf8-24b7-3b033a676680@oracle.com>
References: <OF73090A20.AEC24ED7-ON002582E5.00555A7E-802582E5.00563E62@notes.na.collabserv.com>
 <cccb972f-ba27-686f-2c38-aab5644d779e@oracle.com>
 <CAMOCf+jNLxR=0on74C476-5fi9Cgn--WvZPZTtqobRWK5LaMow@mail.gmail.com>
 <5d38fbd7-816d-9dfb-10a0-e018a1ba7f8f@oracle.com>
 <CAMOCf+hOQFF+Ym=4KgkMCt=ViLMP7Oj3bfvZLULkYQ2v4Q3UvQ@mail.gmail.com>
 <OF892E1194.0FD5391B-ON002582EA.0053B9BA-802582EA.005521F5@LocalDomain>
 <OFD5CD6047.36213180-ON002582EA.00567837-802582EA.0056863C@notes.na.collabserv.com>
 <e9e19390-a0ca-9bf8-24b7-3b033a676680@oracle.com>
Message-ID: <OFE236AB4F.C720ABBD-ON002582EB.0030A93D-802582EB.0032F109@notes.na.collabserv.com>

Hi Mandy,

I request that you review this for 8u.

------------------------------------------------------
@@ -1398,10 +1398,18 @@
             bundle = baseBundle;
         }

+        keepAlive(loader);
         return bundle;
     }

     /**
+     * Keeps the argument ClassLoader alive.
+     */
+    private static void keepAlive(ClassLoader loaderone){
+        //Do nothing.
+    }
+
+    /**
      * Checks if the given <code>List</code> is not null, not empty,
      * not having null in its elements.
      */
------------------------------------------------------


Best Regards

Adam Farley 


mandy chung <mandy.chung at oracle.com> wrote on 15/08/2018 17:49:51:

> From: mandy chung <mandy.chung at oracle.com>
> To: Adam Farley8 <adam.farley at uk.ibm.com>, Hans Boehm 
<hboehm at google.com>
> Cc: core-libs-dev <core-libs-dev at openjdk.java.net>, 
i18n-dev at openjdk.java.net
> Date: 15/08/2018 17:50
> Subject: Re: RFR 8209184: JDK8 ResourceBundle vulnerable to GC (fix 
included)
> 
> Hi Adam,
> 
> This fix is JDK 8u only and so you will need to request for 8u approval.
> 
> The proposed empty static method is fine with me.  Please fix the format 

> and indentation before you post the review.
> 
> Since this patch is small, you can inline the diff in the RFR mail.
> I can review it when you send the review request out.
> 
> Mandy
> [1] INVALID URI REMOVED
> 
u=http-3A__openjdk.java.net_projects_jdk8u_approval-2Dtemplate.html&d=DwID-
> g&c=jf_iaSHvJObTbx-siA1ZOg&r=P5m8KWUXJf-
> 
CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=LNli6mMzg3GKad9dsE3XbXBnzTk9woUBJ7J4LmWSCoM&s=7qqktTwgCMn4ZPhTnzh9Dfla2kn9iTtZxT47FUZ6otQ&e=
> 
> On 8/15/18 8:45 AM, Adam Farley8 wrote:
> > Hi Mandy, Hans,
> > 
> > Tried out the below (after removing my previous fix, the volatile 
> > compare), and it appears to solve the problem just fine.
> > 
> > If I generate a webrev and get it attached to the bug, would one of 
you 
> > mind approving the change?
> > 
> > ----------...at the end of getBundleImpl in jdk8  ------------
> >      keepAlive(loader);
> >      return bundle;
> > }
> > 
> > //To keep the argument ClassLoader alive.
> > private static void keepAlive(ClassLoader loaderone){
> >          //Do nothing.
> > }
> > ----------------------
> > 
> > Best Regards
> > 
> > Adam Farley
> > 
> > Hans Boehm <hboehm at google.com> wrote on 15/08/2018 06:44:08:
> > 
> >> From: Hans Boehm <hboehm at google.com>
> >> To: Mandy Chung <mandy.chung at oracle.com>
> >> Cc: adam.farley at uk.ibm.com,  core-libs-dev <core-libs-
> >> dev at openjdk.java.net>, i18n-dev at openjdk.java.net
> >> Date: 15/08/2018 06:44
> >> Subject: Re: RFR 8209184: JDK8  ResourceBundle vulnerable to GC 
> (fix included)
> >> 
> >> FWIW, since there was agreement that empty static methods should 
> >> work in this context, that seems like the best option to me.
> >> 
> >> On Tue, Aug 14, 2018 at 4:54 PM mandy chung 
> <mandy.chung at oracle.com>  wrote:
> >> Thanks for the information. Not sure what's the best option we can do
> >> in 8u.  I think it's acceptable to have a fix that works in the
> >> current context (like empty static method).
> >> 
> >> Thoughts?
> >> 
> >> Mandy
> >> 
> >> On 8/14/18 4:22 PM, Hans Boehm wrote:
> >> > I haven't looked at the details here, but comparing against a 
volatile
> >> > is not in general a portable way to keep an object live. Like empty
> >> > static methods, it may be fine in the current (OpenJDK) context.
> >> > 
> >> > Volatile loads have roach motel semantics and can be advanced  past 
other
> >> > operations. The comparison can be done early, too, keeping only the
> >> > condition code. There is no guarantee the reference will still be 
around
> >> > when you expect it.
> >> > 
> >> > I haven't come up with a great compiler-independent replacement for
> >> > reachabilityFence.
> >> > 
> >> > On Tue, Aug 14, 2018 at 8:25 AM mandy chung <mandy.chung at oracle.com
> >> > <mailto:mandy.chung at oracle.com>> wrote:
> >> > 
> >> >     Hi Adam,
> >> > 
> >> >     Have you tried Peter's suggestion if an empty  static 
> method taking an
> >> >     Object parameter?  Does it work for you?
> >> > 
> >> >     Your proposed approach seems fine and I would  suggest to put 
the
> >> >     check in a static keepAlive method that will  make it 
explicitly.
> >> > 
> >> >     Mandy
> >> > 
> >> >     On 8/10/18 8:42 AM, Adam Farley8 wrote:
> >> >      > Hi All,
> >> >      >
> >> >      > This bug could be fixed by comparing  the Class Loader 
> with a blank
> >> >      > static volatile Object (defined outside  the method scope) 
at the
> >> >      > end of the getBundleImpl class.
> >> >      >
> >> >      > E.g.
> >> >      >
> >> >      > -----------------------------------------
> >> >      > +1322
> >> >      >      /**
> >> >      >       * volatile  reference object to guard the ClassLoader 
object
> >> >      >       * being garbage  collected before getBundleImpl() 
method
> >> >     completes
> >> >      >       * the caching  and retrieving of requested 
> Resourcebundle object
> >> >      >       */
> >> >      >      private static volatile  Object vo = new Object();
> >> >      >
> >> >      >
> >> >      > +1400
> >> >      > //Should never be true. Using the loader  here prevents 
> it being GC'd.
> >> >      >              if (loader == vo) throw new Error
> ("Unexpected error.");
> >> >      > -----------------------------------------
> >> >      >
> >> >      > Will upload a webrev after debate.
> >> >      >
> >> >      > - Adam
> >> >      > Unless stated otherwise above:
> >> >      > IBM United Kingdom Limited - Registered  in England and 
Wales with
> >> >     number
> >> >      > 741598.
> >> >      > Registered office: PO Box 41, North  Harbour, Portsmouth,
> >> >     Hampshire PO6 3AU
> >> >      >
> >> > 
> > Unless stated otherwise above:
> > IBM United Kingdom Limited - Registered in England and Wales with 
number 
> > 741598.
> > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 
3AU
> 

Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

From mandy.chung at oracle.com  Thu Aug 16 17:57:01 2018
From: mandy.chung at oracle.com (mandy chung)
Date: Thu, 16 Aug 2018 10:57:01 -0700
Subject: <i18n dev> RFR 8209184: JDK8 ResourceBundle vulnerable to GC
	(fix included)
In-Reply-To: <OFE236AB4F.C720ABBD-ON002582EB.0030A93D-802582EB.0032F109@notes.na.collabserv.com>
References: <OF73090A20.AEC24ED7-ON002582E5.00555A7E-802582E5.00563E62@notes.na.collabserv.com>
 <cccb972f-ba27-686f-2c38-aab5644d779e@oracle.com>
 <CAMOCf+jNLxR=0on74C476-5fi9Cgn--WvZPZTtqobRWK5LaMow@mail.gmail.com>
 <5d38fbd7-816d-9dfb-10a0-e018a1ba7f8f@oracle.com>
 <CAMOCf+hOQFF+Ym=4KgkMCt=ViLMP7Oj3bfvZLULkYQ2v4Q3UvQ@mail.gmail.com>
 <OF892E1194.0FD5391B-ON002582EA.0053B9BA-802582EA.005521F5@LocalDomain>
 <OFD5CD6047.36213180-ON002582EA.00567837-802582EA.0056863C@notes.na.collabserv.com>
 <e9e19390-a0ca-9bf8-24b7-3b033a676680@oracle.com>
 <OFE236AB4F.C720ABBD-ON002582EB.0030A93D-802582EB.0032F109@notes.na.collabserv.com>
Message-ID: <e6867747-c062-8f81-df35-7d9c62970016@oracle.com>



On 8/16/18 2:16 AM, Adam Farley8 wrote:
> Hi Mandy,
> 
> I request that you review this for 8u.
> 
> ------------------------------------------------------
> @@ -1398,10 +1398,18 @@
>  ? ? ? ? ?bundle = baseBundle;
>  ? ? ?}
> 
> + ? ?keepAlive(loader);
>  ? ? ?return bundle;
>  ?}
> 
>  ?/**
> + * Keeps the argument ClassLoader alive.
> + */
> + ? ?private static void keepAlive(ClassLoader loaderone){
> + ? ?//Do nothing.
> + ? ?}
> +
> + ? ?/**
>  ? * Checks if the given <code>List</code> is not null, not empty,
>  ? * not having null in its elements.
>  ? */
> ------------------------------------------------------

Looks fine. Nit: a space before "Do nothing" comment would be good.
No need for a new diff.

Mandy

From adam.farley at uk.ibm.com  Fri Aug 17 09:58:34 2018
From: adam.farley at uk.ibm.com (Adam Farley8)
Date: Fri, 17 Aug 2018 10:58:34 +0100
Subject: <i18n dev> RFR 8209184: JDK8 ResourceBundle vulnerable to GC
	(fix included)
In-Reply-To: <e6867747-c062-8f81-df35-7d9c62970016@oracle.com>
References: <OF73090A20.AEC24ED7-ON002582E5.00555A7E-802582E5.00563E62@notes.na.collabserv.com>
 <cccb972f-ba27-686f-2c38-aab5644d779e@oracle.com>
 <CAMOCf+jNLxR=0on74C476-5fi9Cgn--WvZPZTtqobRWK5LaMow@mail.gmail.com>
 <5d38fbd7-816d-9dfb-10a0-e018a1ba7f8f@oracle.com>
 <CAMOCf+hOQFF+Ym=4KgkMCt=ViLMP7Oj3bfvZLULkYQ2v4Q3UvQ@mail.gmail.com>
 <OF892E1194.0FD5391B-ON002582EA.0053B9BA-802582EA.005521F5@LocalDomain>
 <OFD5CD6047.36213180-ON002582EA.00567837-802582EA.0056863C@notes.na.collabserv.com>
 <e9e19390-a0ca-9bf8-24b7-3b033a676680@oracle.com>
 <OFE236AB4F.C720ABBD-ON002582EB.0030A93D-802582EB.0032F109@notes.na.collabserv.com>
 <e6867747-c062-8f81-df35-7d9c62970016@oracle.com>
Message-ID: <OF96C75547.8EBEB0E5-ON002582EC.0036A41C-802582EC.0036CD21@notes.na.collabserv.com>

Hi Mandy,

The extra space is fine.

In hindsight, you could probably rename "loaderone" to just "loader" too.

Thanks for helping with this. :)

Best Regards

Adam Farley 
OpenJDK Team 
Runtimes 
IBM 


mandy chung <mandy.chung at oracle.com> wrote on 16/08/2018 18:57:01:

> From: mandy chung <mandy.chung at oracle.com>
> To: Adam Farley8 <adam.farley at uk.ibm.com>
> Cc: core-libs-dev <core-libs-dev at openjdk.java.net>, Hans Boehm 
> <hboehm at google.com>, i18n-dev at openjdk.java.net
> Date: 16/08/2018 18:57
> Subject: Re: RFR 8209184: JDK8 ResourceBundle vulnerable to GC (fix 
included)
> 
> 
> 
> On 8/16/18 2:16 AM, Adam Farley8 wrote:
> > Hi Mandy,
> > 
> > I request that you review this for 8u.
> > 
> > ------------------------------------------------------
> > @@ -1398,10 +1398,18 @@
> >           bundle = baseBundle;
> >       }
> > 
> > +    keepAlive(loader);
> >       return bundle;
> >   }
> > 
> >   /**
> > + * Keeps the argument ClassLoader alive.
> > + */
> > +    private static void keepAlive(ClassLoader loaderone){
> > +    //Do nothing.
> > +    }
> > +
> > +    /**
> >    * Checks if the given <code>List</code> is not null, not empty,
> >    * not having null in its elements.
> >    */
> > ------------------------------------------------------
> 
> Looks fine. Nit: a space before "Do nothing" comment would be good.
> No need for a new diff.
> 
> Mandy
> 

Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

From li.jiang at oracle.com  Tue Aug 28 14:56:09 2018
From: li.jiang at oracle.com (li.jiang at oracle.com)
Date: Tue, 28 Aug 2018 22:56:09 +0800
Subject: <i18n dev> RFR: 8208746 8209775 : ISO 4217 Amendment #168 #169
	Update
Message-ID: <067281cf-544a-aa87-b2e2-6c1b3030ed5a@oracle.com>

Hi,

Please review the changes for ISO 4217 Amendment #168 #169.

Bugs:
https://bugs.openjdk.java.net/browse/JDK-8208746   168
https://bugs.openjdk.java.net/browse/JDK-8209775   169

Only in amendment #168 has real currency data update for Java, but I 
also updated the data version to #169 for consistent.


Changes include:

  - Update the currency for VENEZUELA (BOLIVARIAN REPUBLIC OF), VES 928 
minor 2
  - Update the currency name to 'Bol?var Soberano'
  - Move the currency VEF to historical currencies
  - Correct the currency name for PHILIPPINES (THE): Philippine Peso 
(instead of Piso)
  - Change the country name: SWAZILAND to ESWATINI

Webrev:
http://cr.openjdk.java.net/~ljiang/8208746/webrev.00/

Build and test passed on mach5 for all platforms.

Thanks,
Leo




From naoto.sato at oracle.com  Tue Aug 28 17:09:34 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Tue, 28 Aug 2018 10:09:34 -0700
Subject: <i18n dev> RFR: 8208746 8209775 : ISO 4217 Amendment #168 #169
	Update
In-Reply-To: <067281cf-544a-aa87-b2e2-6c1b3030ed5a@oracle.com>
References: <067281cf-544a-aa87-b2e2-6c1b3030ed5a@oracle.com>
Message-ID: <d03793a5-c07c-bbc3-fd23-1e3b6b9181c1@oracle.com>

Hi Leo,

Looks good to me. Also, please work with sustaining wrt backports.

Naoto

On 8/28/18 7:56 AM, li.jiang at oracle.com wrote:
> Hi,
> 
> Please review the changes for ISO 4217 Amendment #168 #169.
> 
> Bugs:
> https://bugs.openjdk.java.net/browse/JDK-8208746?? 168
> https://bugs.openjdk.java.net/browse/JDK-8209775?? 169
> 
> Only in amendment #168 has real currency data update for Java, but I 
> also updated the data version to #169 for consistent.
> 
> 
> Changes include:
> 
>  ?- Update the currency for VENEZUELA (BOLIVARIAN REPUBLIC OF), VES 928 
> minor 2
>  ?- Update the currency name to 'Bol?var Soberano'
>  ?- Move the currency VEF to historical currencies
>  ?- Correct the currency name for PHILIPPINES (THE): Philippine Peso 
> (instead of Piso)
>  ?- Change the country name: SWAZILAND to ESWATINI
> 
> Webrev:
> http://cr.openjdk.java.net/~ljiang/8208746/webrev.00/
> 
> Build and test passed on mach5 for all platforms.
> 
> Thanks,
> Leo
> 
> 
> 

From joe.darcy at oracle.com  Wed Aug 29 01:33:20 2018
From: joe.darcy at oracle.com (joe darcy)
Date: Tue, 28 Aug 2018 18:33:20 -0700
Subject: <i18n dev> RFR: 8208746 8209775 : ISO 4217 Amendment #168 #169
	Update
In-Reply-To: <d03793a5-c07c-bbc3-fd23-1e3b6b9181c1@oracle.com>
References: <067281cf-544a-aa87-b2e2-6c1b3030ed5a@oracle.com>
 <d03793a5-c07c-bbc3-fd23-1e3b6b9181c1@oracle.com>
Message-ID: <5d5267f7-357f-8039-568a-ecfd45cdd7ec@oracle.com>

Hello,

Should these changes have CSR requests?

Cheers,

-Joe


On 8/28/2018 10:09 AM, Naoto Sato wrote:
> Hi Leo,
>
> Looks good to me. Also, please work with sustaining wrt backports.
>
> Naoto
>
> On 8/28/18 7:56 AM, li.jiang at oracle.com wrote:
>> Hi,
>>
>> Please review the changes for ISO 4217 Amendment #168 #169.
>>
>> Bugs:
>> https://bugs.openjdk.java.net/browse/JDK-8208746?? 168
>> https://bugs.openjdk.java.net/browse/JDK-8209775?? 169
>>
>> Only in amendment #168 has real currency data update for Java, but I 
>> also updated the data version to #169 for consistent.
>>
>>
>> Changes include:
>>
>> ??- Update the currency for VENEZUELA (BOLIVARIAN REPUBLIC OF), VES 
>> 928 minor 2
>> ??- Update the currency name to 'Bol?var Soberano'
>> ??- Move the currency VEF to historical currencies
>> ??- Correct the currency name for PHILIPPINES (THE): Philippine Peso 
>> (instead of Piso)
>> ??- Change the country name: SWAZILAND to ESWATINI
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ljiang/8208746/webrev.00/
>>
>> Build and test passed on mach5 for all platforms.
>>
>> Thanks,
>> Leo
>>
>>
>>


From naoto.sato at oracle.com  Wed Aug 29 01:44:39 2018
From: naoto.sato at oracle.com (naoto.sato at oracle.com)
Date: Tue, 28 Aug 2018 18:44:39 -0700
Subject: <i18n dev> RFR: 8208746 8209775 : ISO 4217 Amendment #168 #169
	Update
In-Reply-To: <5d5267f7-357f-8039-568a-ecfd45cdd7ec@oracle.com>
References: <067281cf-544a-aa87-b2e2-6c1b3030ed5a@oracle.com>
 <d03793a5-c07c-bbc3-fd23-1e3b6b9181c1@oracle.com>
 <5d5267f7-357f-8039-568a-ecfd45cdd7ec@oracle.com>
Message-ID: <e1109981-8db6-1e11-c716-a2194286f065@oracle.com>

Hi Joe,

This is a typical currency data change, and does not involve any public 
interface changes, so I think CSR is not needed. We haven't filed CSRs 
for such changes in the past.

Naoto

On 8/28/18 6:33 PM, joe darcy wrote:
> Hello,
> 
> Should these changes have CSR requests?
> 
> Cheers,
> 
> -Joe
> 
> 
> On 8/28/2018 10:09 AM, Naoto Sato wrote:
>> Hi Leo,
>>
>> Looks good to me. Also, please work with sustaining wrt backports.
>>
>> Naoto
>>
>> On 8/28/18 7:56 AM, li.jiang at oracle.com wrote:
>>> Hi,
>>>
>>> Please review the changes for ISO 4217 Amendment #168 #169.
>>>
>>> Bugs:
>>> https://bugs.openjdk.java.net/browse/JDK-8208746?? 168
>>> https://bugs.openjdk.java.net/browse/JDK-8209775?? 169
>>>
>>> Only in amendment #168 has real currency data update for Java, but I 
>>> also updated the data version to #169 for consistent.
>>>
>>>
>>> Changes include:
>>>
>>> ??- Update the currency for VENEZUELA (BOLIVARIAN REPUBLIC OF), VES 
>>> 928 minor 2
>>> ??- Update the currency name to 'Bol?var Soberano'
>>> ??- Move the currency VEF to historical currencies
>>> ??- Correct the currency name for PHILIPPINES (THE): Philippine Peso 
>>> (instead of Piso)
>>> ??- Change the country name: SWAZILAND to ESWATINI
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~ljiang/8208746/webrev.00/
>>>
>>> Build and test passed on mach5 for all platforms.
>>>
>>> Thanks,
>>> Leo
>>>
>>>
>>>
> 

From li.jiang at oracle.com  Wed Aug 29 23:41:53 2018
From: li.jiang at oracle.com (li.jiang at oracle.com)
Date: Thu, 30 Aug 2018 07:41:53 +0800
Subject: <i18n dev> RFR: 8210153 :
 java/text/Format/NumberFormat/CurrencyFormat.java failed
Message-ID: <6542027f-4ca5-2a78-a13f-0c497aed4cc3@oracle.com>

Hi Naoto,

Please review the fix to update the currency symbol for VES.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8210153

Webrev:
http://cr.openjdk.java.net/~ljiang/8210153/webrev/

Built and tier1~tier3 tests passed on mach5.

Thanks,
Leo

From joe.darcy at oracle.com  Thu Aug 30 01:17:13 2018
From: joe.darcy at oracle.com (Joseph D. Darcy)
Date: Wed, 29 Aug 2018 18:17:13 -0700
Subject: <i18n dev> RFR: 8208746 8209775 : ISO 4217 Amendment #168 #169
	Update
In-Reply-To: <e1109981-8db6-1e11-c716-a2194286f065@oracle.com>
References: <067281cf-544a-aa87-b2e2-6c1b3030ed5a@oracle.com>
 <d03793a5-c07c-bbc3-fd23-1e3b6b9181c1@oracle.com>
 <5d5267f7-357f-8039-568a-ecfd45cdd7ec@oracle.com>
 <e1109981-8db6-1e11-c716-a2194286f065@oracle.com>
Message-ID: <5B874599.8080706@oracle.com>

Hi Naoto,

Thanks for checking; cheers,

-Joe

On 8/28/2018 6:44 PM, naoto.sato at oracle.com wrote:
> Hi Joe,
>
> This is a typical currency data change, and does not involve any 
> public interface changes, so I think CSR is not needed. We haven't 
> filed CSRs for such changes in the past.
>
> Naoto
>
> On 8/28/18 6:33 PM, joe darcy wrote:
>> Hello,
>>
>> Should these changes have CSR requests?
>>
>> Cheers,
>>
>> -Joe
>>
>>
>> On 8/28/2018 10:09 AM, Naoto Sato wrote:
>>> Hi Leo,
>>>
>>> Looks good to me. Also, please work with sustaining wrt backports.
>>>
>>> Naoto
>>>
>>> On 8/28/18 7:56 AM, li.jiang at oracle.com wrote:
>>>> Hi,
>>>>
>>>> Please review the changes for ISO 4217 Amendment #168 #169.
>>>>
>>>> Bugs:
>>>> https://bugs.openjdk.java.net/browse/JDK-8208746   168
>>>> https://bugs.openjdk.java.net/browse/JDK-8209775   169
>>>>
>>>> Only in amendment #168 has real currency data update for Java, but 
>>>> I also updated the data version to #169 for consistent.
>>>>
>>>>
>>>> Changes include:
>>>>
>>>>   - Update the currency for VENEZUELA (BOLIVARIAN REPUBLIC OF), VES 
>>>> 928 minor 2
>>>>   - Update the currency name to 'Bol?var Soberano'
>>>>   - Move the currency VEF to historical currencies
>>>>   - Correct the currency name for PHILIPPINES (THE): Philippine 
>>>> Peso (instead of Piso)
>>>>   - Change the country name: SWAZILAND to ESWATINI
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~ljiang/8208746/webrev.00/
>>>>
>>>> Build and test passed on mach5 for all platforms.
>>>>
>>>> Thanks,
>>>> Leo
>>>>
>>>>
>>>>
>>


From naoto.sato at oracle.com  Thu Aug 30 01:19:01 2018
From: naoto.sato at oracle.com (naoto.sato at oracle.com)
Date: Wed, 29 Aug 2018 18:19:01 -0700
Subject: <i18n dev> RFR: 8210153 :
 java/text/Format/NumberFormat/CurrencyFormat.java failed
In-Reply-To: <6542027f-4ca5-2a78-a13f-0c497aed4cc3@oracle.com>
References: <6542027f-4ca5-2a78-a13f-0c497aed4cc3@oracle.com>
Message-ID: <6a320d3c-6389-14b4-869e-bb1da2f21b2b@oracle.com>

Please update the copyright year to "2018".  Otherwise looks good to me. 
No further review is needed.

Naoto

On 8/29/18 4:41 PM, li.jiang at oracle.com wrote:
> Hi Naoto,
> 
> Please review the fix to update the currency symbol for VES.
> 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8210153
> 
> Webrev:
> http://cr.openjdk.java.net/~ljiang/8210153/webrev/
> 
> Built and tier1~tier3 tests passed on mach5.
> 
> Thanks,
> Leo