From Sergey.Bylokhov at oracle.com Sat Dec 1 00:49:13 2018 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 30 Nov 2018 16:49:13 -0800 Subject: RFR: X11 default visual support for IM status window on VNC In-Reply-To: <47596f79d10fcfac856172db4d8cffd2@linux.vnet.ibm.com> References: <46b05293c2bab165a413ac1ac18e0703@linux.vnet.ibm.com> <4cb2abda-706f-8b1a-320c-64285ebfafae@oracle.com> <34954ce768b5b3254a3122cb8c0ed268@linux.vnet.ibm.com> <2f1d4840-7140-861e-cdac-5bfac039a5c4@oracle.com> <068fccf8-05a9-0e32-0540-551ade446f96@oracle.com> <5B2A6160.5000107@oracle.com> <674fa1d548764758a051953ce9a97d95@linux.vnet.ibm.com> <47596f79d10fcfac856172db4d8cffd2@linux.vnet.ibm.com> Message-ID: <533c8ab5-31d9-58bd-4250-03e1c24f6f23@oracle.com> Looks fine, if there are no other comments I'll push the fix. On 26/11/2018 05:02, Ichiroh Takiguchi wrote: > Hello. > > Could you review the fix ? > > Bug:??? https://bugs.openjdk.java.net/browse/JDK-8212677 > Change: https://cr.openjdk.java.net/~itakiguchi/8212677/webrev.00/ > > Screen shots are in JDK-8212677. > > I'd like to obtain a sponsor for this issue. > > Thanks, > Ichiroh Takiguchi > IBM Japan, Ltd. > > On 2018-06-21 21:58, Ichiroh Takiguchi wrote: >> Hello Phil. >> >> I'm sorry, I forgot to put my comment against your question. >> >>> Is this changing the default visual? for all WIndows, not just the IM status window? >>> I think we need to understand the implications before this can be accepted. >> I put following debug code: >> ======= >> diff -r e1b3def12624 >> src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c >> --- a/src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c >> ?Wed Jun 13 06:35:04 2018 +0200 >> +++ b/src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c >> ?Thu Jun 21 21:23:11 2018 +0900 >> @@ -667,6 +667,7 @@ >> ???????????????????????????? InputOutput, >> ???????????????????????????? adata->awt_visInfo.visual, >> ???????????????????????????? attribmask, &attrib); >> +??? fprintf(stderr, "status window id = 0x%X\n", status); >> ???? XSelectInput(dpy, status, >> ????????????????? ExposureMask | StructureNotifyMask | EnterWindowMask | >> ????????????????? LeaveWindowMask | VisibilityChangeMask); >> @@ -680,6 +681,21 @@ >> ???? statusWindow->fontset = XCreateFontSet(dpy, >> >> "-*-*-medium-r-normal-*-*-120-*-*-*-*", >> ??????????????????????????????????????????? &mclr, &mccr, &dsr); >> +??? { >> +??????? int cntFonts; >> +??????? for(cntFonts = 0; cntFonts < mccr; cntFonts++) { >> +??????????? fprintf(stderr, "[M][%d] %s\n", cntFonts, mclr[cntFonts]); >> +??????? } >> +??? } >> +??? { >> +??????? XFontStruct **font_struct_list; >> +??????? char **font_name_list; >> +??????? int cntFonts; >> +??????? int numFonts = XFontsOfFontSet(statusWindow->fontset, >> &font_struct_list, &font_name_list); >> +??????? for(cntFonts = 0; cntFonts < numFonts; cntFonts++) { >> +??????????? fprintf(stderr, "[L][%d] %s\n", cntFonts, >> font_name_list[cntFonts]); >> +??????? } >> +??? } >> ???? /* In case we didn't find the font set, release the list of >> missing characters */ >> ???? if (mccr > 0) { >> ???????? XFreeStringList(mclr); >> ======= >> >> I tested it on RHEL7. >> I thought since window id was assigned, but it was gone on current code. >> ======= >> $ java -jar Notepad.jar >> status window id = 0x4000055 >> ... >> $ xwininfo -id 0x4000055 >> X Error: 9: Bad Drawable: 0x4000055 >> ? Request Major code: 14 >> ? Request serial number: 3 >> xwininfo: error: No such window with id 0x4000055. >> ======= >> >> ======= >> $ java -jar Notepad.jar >> status window id = 0x40000CA >> ... >> $ xwininfo -id 0x40000CA >> >> xwininfo: Window id: 0x40000ca (has no name) >> >> ? Absolute upper-left X:? 0 >> ? Absolute upper-left Y:? 600 >> ? Relative upper-left X:? 0 >> ? Relative upper-left Y:? 600 >> ? Width: 80 >> ? Height: 22 >> ? Depth: 24 >> ? Visual: 0x21 >> ? Visual Class: TrueColor >> ? Border width: 0 >> ? Class: InputOutput >> ? Colormap: 0x20 (installed) >> ? Bit Gravity State: ForgetGravity >> ? Window Gravity State: NorthWestGravity >> ? Backing Store State: NotUseful >> ? Save Under State: no >> ? Map State: IsUnMapped >> ? Override Redirect State: yes >> ? Corners:? +0+600? -944+600? -944-146? +0-146 >> ? -geometry 80x22+0+600 >> ======= >> >> According to main window: (Left side: without fix, right side: with fix) >> ======= >> xwininfo: Window id: 0x4000009 " (failure?? |?? xwininfo: Window id: >> 0x460007e " (failure >> >> ? Absolute upper-left X:? 4?????????????????????? Absolute upper-left X:? 4 >> ? Absolute upper-left Y:? 25????????????????????? Absolute upper-left Y:? 25 >> ? Relative upper-left X:? 0?????????????????????? Relative upper-left X:? 0 >> ? Relative upper-left Y:? 0?????????????????????? Relative upper-left Y:? 0 >> ? Width: 492????????????????????????????????????? Width: 492 >> ? Height: 571???????????????????????????????????? Height: 571 >> ? Depth: 24?????????????????????????????????????? Depth: 24 >> ? Visual: 0x169???????????????????????????? |???? Visual: 0x21 >> ? Visual Class: TrueColor???????????????????????? Visual Class: TrueColor >> ? Border width: 0???????????????????????????????? Border width: 0 >> ? Class: InputOutput????????????????????????????? Class: InputOutput >> ? Colormap: 0x4000008 (not installed)?????? |???? Colormap: 0x20 (installed) >> ? Bit Gravity State: NorthWestGravity???????????? Bit Gravity State: >> NorthWestGravity >> ? Window Gravity State: NorthWestGravity????????? Window Gravity >> State: NorthWestGravity >> ? Backing Store State: NotUseful????????????????? Backing Store State: NotUseful >> ? Save Under State: no??????????????????????????? Save Under State: no >> ? Map State: IsViewable?????????????????????????? Map State: IsViewable >> ? Override Redirect State: no???????????????????? Override Redirect State: no >> ? Corners:? +4+25? -528+25? -528-172? +4-1??????? Corners:? +4+25 >> -528+25? -528-172? +4-1 >> ? -geometry 492x571+0+0?????????????????????????? -geometry 492x571+0+0 >> ======= >> >> So main window's visual also changed by this fix. >> >>> Similarly for the fontset change .. this might change what others get. >>> The fontset spec. there seems very loose to me .. >> >> Without fix >> ======= >> $ java -jar Notepad.jar >> status window id = 0x4000055 >> [M][0] JISX0208.1983-0 >> [M][1] GB2312.1980-0 >> [L][0] -misc-fixed-medium-r-normal--13-120-75-75-c-70-iso8859-1 >> [L][1] -misc-fixed-medium-r-normal--13-120-75-75-c-70-iso8859-1 >> [L][2] -daewoo-gothic-medium-r-normal--16-120-100-100-c-160-ksc5601.1987-0 >> [L][3] -sony-fixed-medium-r-normal--16-120-100-100-c-80-jisx0201.1976-0 >> [L][4] -misc-fixed-medium-r-normal--13-120-75-75-c-70-iso10646-1 >> ======= >> >> With fix >> ======= >> $ java -jar Notepad.jar >> status window id = 0x40000CA >> [M][0] GB2312.1980-0 >> [L][0] -misc-fixed-medium-r-normal--13-120-75-75-c-70-iso8859-1 >> [L][1] -misc-fixed-medium-r-normal--13-120-75-75-c-70-iso8859-1 >> [L][2] -misc-fixed-medium-r-normal--14-130-75-75-c-140-jisx0208.1983-0 >> [L][3] -daewoo-gothic-medium-r-normal--16-120-100-100-c-160-ksc5601.1987-0 >> [L][4] -sony-fixed-medium-r-normal--16-120-100-100-c-80-jisx0201.1976-0 >> [L][5] -misc-fixed-medium-r-normal--13-120-75-75-c-70-iso10646-1 >> ======= >> >> [M] means "Missing" font, [L] means "Loaded". >> >> On 2018-06-20 23:14, Philip Race wrote: >>> My question has not been answered. I don't think this is ready to go in. >>> >>> -phil. >>> >>> On 6/20/18, 4:23 AM, Ichiroh Takiguchi wrote: >>>> Hello. >>>> >>>> New fixed code is in: >>>> http://cr.openjdk.java.net/~aleonard/defvis/webrev.02/ >>>> >>>> Could you check fixed files again ? >>>> >>>> I only updated following part between webrev.01 and webrev.02 >>>> ====== >>>> diff -r 70a582d110a1 -r 6f04164a9d62 src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c >>>> --- a/src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c ? Wed Jun 06 21:03:25 2018 +0900 >>>> +++ b/src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c ? Wed Jun 20 16:54:24 2018 +0900 >>>> @@ -677,7 +677,7 @@ >>>> ???????? return NULL; >>>> ???? } >>>> ???? statusWindow->w = status; >>>> -??? //12-point font >>>> +??? //12, 13-point fonts >>>> ???? statusWindow->fontset = XCreateFontSet(dpy, >>>> "-*-*-medium-r-normal-*-*-120-*-*-*-*," \ >>>> "-*-*-medium-r-normal-*-*-130-*-*-*-*", >>>> ====== >>>> >>>> >>>> Please create bugid and handle it. >>>> >>>> Thanks, >>>> Ichiroh Takiguchi >>>> IBM Japan, Ltd. >>>> >>>> On 2018-06-20 04:59, Naoto Sato wrote: >>>>> Please change the comment in line 680, which should also mention 13 point font. >>>>> >>>>> Naoto >>>>> >>>>> On 6/19/18 12:54 PM, Naoto Sato wrote: >>>>>> Looks OK wrt awt_InputMethod.c change. >>>>>> >>>>>> Naoto >>>>>> >>>>>> On 6/19/18 11:32 AM, Phil Race wrote: >>>>>>> Where's the bug ID ? >>>>>>> >>>>>>> The review should have a bug ID in the subject line so we can all find it later ! >>>>>>> >>>>>>> Is this changing the default visual? for all WIndows, not just the IM status window? >>>>>>> I think we need to understand the implications before this can be accepted. >>>>>>> >>>>>>> Similarly for the fontset change .. this might change what others get. >>>>>>> The fontset spec. there seems very loose to me .. >>>>>>> >>>>>>> I think I18N-DEV should be asked about this too. >>>>>>> >>>>>>> -phil. >>>>>>> >>>>>>> On 06/19/2018 11:07 AM, Sergey Bylokhov wrote: >>>>>>>> Looks fine, if there are no other comments I'll push the fix using the new bugid. >>>>>>>> >>>>>>>> On 06/06/2018 17:54, Ichiroh Takiguchi wrote: >>>>>>>>> Hello Sergey. >>>>>>>>> Thank you for your review. >>>>>>>>> >>>>>>>>> Could you review following patch ? >>>>>>>>> http://cr.openjdk.java.net/~aleonard/defvis/webrev.01/ >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Ichiroh Takiguchi >>>>>>>>> IBM Japan, Ltd. >>>>>>>>> >>>>>>>>> On 2018-06-06 07:15, Sergey Bylokhov wrote: >>>>>>>>>> Hi, Ichiroh. >>>>>>>>>> The approach looks fine, but maybe it is possible to decrees code >>>>>>>>>> duplication in findWithTemplate(). After the fix it will have two >>>>>>>>>> similar loops. >>>>>>>>>> >>>>>>>>>> On 24/05/2018 22:24, Ichiroh Takiguchi wrote: >>>>>>>>>>> Hello, >>>>>>>>>>> IBM would like to contribute X11 default visual support for IM status window patch to OpenJDK project. >>>>>>>>>>> >>>>>>>>>>> Issue: >>>>>>>>>>> Java's Native IM status window is not displayed even if it's there. >>>>>>>>>>> Because of this issue, user cannot get proper visual feedback during key input operation. >>>>>>>>>>> We found this issue on Tiger VNC. >>>>>>>>>>> >>>>>>>>>>> Reason: >>>>>>>>>>> Java may pick up unexpected visual for Java's Native IM status window when? Xserver supports multiple visual. >>>>>>>>>>> >>>>>>>>>>> Workaround: >>>>>>>>>>> X11 default visual can be changed by FORCEDEFVIS environment variable, but it's not easy to find out default visual id. >>>>>>>>>>> >>>>>>>>>>> I'd like contribute following 2 files: >>>>>>>>>>> M src/java.desktop/unix/native/libawt_xawt/awt/awt_GraphicsEnv.c >>>>>>>>>>> (Change X11 visual setting) >>>>>>>>>>> M src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c >>>>>>>>>>> (Support 13 point X11 misc fonts (like k14 font for Japanese), since the fonts may defined for unscaled fonts.) >>>>>>>>>>> >>>>>>>>>>> webrev files are in >>>>>>>>>>> http://cr.openjdk.java.net/~aleonard/defvis/ >>>>>>>>>>> >>>>>>>>>>> I appreciate any feedback please, and how I would go about obtaining a sponsor and contributor? >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Ichiroh Takiguchi >>>>>>>>>>> IBM Japan, Ltd. >>>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>> > -- Best regards, Sergey. From takiguc at linux.vnet.ibm.com Tue Dec 4 02:22:37 2018 From: takiguc at linux.vnet.ibm.com (Ichiroh Takiguchi) Date: Tue, 04 Dec 2018 11:22:37 +0900 Subject: RFR: 8213232 Unix/X11 setCompositionEnableNative issue In-Reply-To: <9ad6f2166ea8eabcf7391feccf9d8915@linux.vnet.ibm.com> References: <9ad6f2166ea8eabcf7391feccf9d8915@linux.vnet.ibm.com> Message-ID: <0a651f1099a96e314573b6b8c9f60e6c@linux.vnet.ibm.com> Hello. Could you review the fix ? Bug: https://bugs.openjdk.java.net/browse/JDK-8213232 Change: https://cr.openjdk.java.net/~itakiguchi/8213232/webrev.00/ This issue is related by wrong usage of XNPreeditState on XSetICValues(). Because of wrong usage, UnsupportedOperationException exception happened with Xlib bundled input method. Test instructions is in JDK-8213232. I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-06-19 02:15, Ichiroh Takiguchi wrote: > Hello, > IBM would like to contribute Unix/X11 setCompositionEnableNative issue > patch to OpenJDK project. > > Issue: > To turn on or turn off IME via Java, XNPreeditState should be used > with XSetValues(). > But it should be nested via XVaCreateNestedList() since XNPreeditState > is a part of XNPreeditAttributes. > Current code is, like: > - ret = XSetICValues(pX11IMData->current_ic, XNPreeditState, > - (enable ? XIMPreeditEnable : > XIMPreeditDisable), NULL); > But it should be, like: > + pr_atrb = XVaCreateNestedList(0, > + XNPreeditState, (enable ? XIMPreeditEnable : > XIMPreeditDisable), > + NULL); > + ret = XSetICValues(pX11IMData->current_ic, XNPreeditAttributes, > pr_atrb, NULL); > > On Linux platform, the issue can check with following test program and > kinput2 XIM server and > Wnn8 for Linux/BSD (htt). > ================== > import java.awt.*; > import java.awt.event.*; > import javax.swing.*; > > public class CompositionEnabledTest extends JFrame { > CompositionEnabledTest() { > Container c = getContentPane(); > c.setLayout(new GridLayout(0,2)); > JButton btn; > JTextField tf; > btn = new JButton("Undefined"); > c.add(btn); > tf = new JTextField("Undefined"); > c.add(tf); > btn = new JButton("Disabled"); > btn.addFocusListener(new MyFocusListener(false)); > c.add(btn); > tf = new JTextField("Disabled"); > tf.addFocusListener(new MyFocusListener(false)); > c.add(tf); > btn = new JButton("Enabled"); > btn.addFocusListener(new MyFocusListener(true)); > c.add(btn); > tf = new JTextField("Enabled"); > tf.addFocusListener(new MyFocusListener(true)); > c.add(tf); > setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); > pack(); > setVisible(true); > } > class MyFocusListener implements FocusListener { > boolean state; > MyFocusListener(boolean state) { > this.state = state; > } > public void focusGained(FocusEvent fe) { > fe.getComponent().getInputContext().setCompositionEnabled(state); > } > public void focusLost(FocusEvent fe) { } > } > public static void main(String[] args) { > new CompositionEnabledTest(); > } > } > ================== > > Click JTextField and JButton, then XIM server status may be changed. > If XIM server does not support XNPreeditState, it does not work. > > I'd like contribute following 3 files: > M src/java.desktop/share/classes/sun/awt/im/InputContext.java > M src/java.desktop/unix/classes/sun/awt/X11InputMethod.java > M src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c > > http://cr.openjdk.java.net/~aleonard/set_composition_enabled/webrev.00/ > > I appreciate any feedback please, and how I would go about obtaining a > sponsor and contributor? > > Thanks, > Ichiroh Takiguchi > IBM Japan, Ltd. From takiguc at linux.vnet.ibm.com Tue Dec 4 16:53:18 2018 From: takiguc at linux.vnet.ibm.com (Ichiroh Takiguchi) Date: Wed, 05 Dec 2018 01:53:18 +0900 Subject: RFR: 8212676 AIX's CDE/MWM support In-Reply-To: References: <5f309d9c612f2c16aef75846e0ff14fa@linux.vnet.ibm.com> <0ede447e30ed05ce7a52f6d133b2c15b@linux.vnet.ibm.com> <180114e58e98f339332e3a781a34126b@linux.vnet.ibm.com> Message-ID: <5a4f9f5c7a80a5abda9edd150e19a11f@linux.vnet.ibm.com> Hello again. Could you give me review comment and/or suggestion ? Bug: https://bugs.openjdk.java.net/browse/JDK-8212676 Change: https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.00/ Thanks, Ichiroh Takiguchi On 2018-11-26 21:27, Ichiroh Takiguchi wrote: > Hello. > > Could you review the fix ? > > Bug: https://bugs.openjdk.java.net/browse/JDK-8212676 > Change: https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.00/ > > Test instructions and screen shots are in JDK-8212676. > > GUI environment for AIX platform still needs CDE support. > This fix is required to avoid unexpected working behavior on AIX > platform. > > I'd like to obtain a sponsor for this issue. > > Thanks, > Ichiroh Takiguchi > IBM Japan, Ltd. > > On 2018-06-18 18:57, Ichiroh Takiguchi wrote: >> Hello. >> >> This fix is really required for AIX's GUI. >> System color setting and window manager's working behavior are very >> important. >> >> I appreciate any feedback, and how I would go about obtaining a >> sponsor and contributor ? >> >> On 2018-05-25 11:02, Ichiroh Takiguchi wrote: >>> Hello Phil. >>> >>> webrev file was extracted. >>> Please see >>> http://cr.openjdk.java.net/~aleonard/AIX_GUI/webrev.00/ >>> >>> On 2018-05-19 02:48, Ichiroh Takiguchi wrote: >>>> Hello Phil. >>>> >>>> Webrev.zip file is stored into >>>> http://cr.openjdk.java.net/~aleonard/AIX_GUI/webrev-aixgui.zip >>>> >>>> Test programs are also stored: >>>> No testcase is available for FontUtilities.java and >>>> XDecoratedPeer.java. >>>> >>>> MotifColorUtilities.java >>>> http://cr.openjdk.java.net/~aleonard/AIX_GUI/SystemColorTest2.java >>>> Run SystemColorTest2, system colors should be displayed >>>> AIX sample is >>>> http://cr.openjdk.java.net/~aleonard/AIX_GUI/aix_systemcolor.txt >>>> >>>> XWM.java >>>> http://cr.openjdk.java.net/~aleonard/AIX_GUI/XWMTest1.java >>>> On AIX CDE, isMotif and isCDE were true. >>>> On AIX MWM, every entry is false. >>>> >>>> XWindowPeer.java >>>> http://cr.openjdk.java.net/~aleonard/AIX_GUI/JFrameTest.java >>>> On AIX CDE, click inside of "Non-Focusable" window (not window >>>> frame). >>>> Window focus should not be changed because of "click on focus" >>>> feature. >>>> But input focus is moved to "Non-Focusable" window. >>>> >>>> >>>> On 2018-05-18 01:00, Phil Race wrote: >>>>> I think we'd need to see the actual proposed changes and understand >>>>> the implications >>>>> for ongoing support as we no longer support any platform which has >>>>> a >>>>> CDE desktop. >>>>> Solaris 11.3 uses Gnome, so we'd be more inclined to be ripping out >>>>> such support rather >>>>> than adding to it. >>>>> >>>>> -phil. >>>>> >>>>> On 05/17/2018 04:18 AM, Ichiroh Takiguchi wrote: >>>>>> Hello, >>>>>> IBM would like to contribute AIX's CDE (Common Desktop >>>>>> Environment) DTWM (Desktop Window Manager) /MWM (Motif Window >>>>>> Manager) support to OpenJDK project. >>>>>> >>>>>> I'd like contribute following 5 files: >>>>>> >>>>>> M src/java.desktop/share/classes/sun/font/FontUtilities.java >>>>>> (Add isAIX flag to determine AIX platform for GUI environment) >>>>>> M >>>>>> src/java.desktop/unix/classes/sun/awt/X11/MotifColorUtilities.java >>>>>> (Add High Color support on CDE, OpenJDK just supports Medium >>>>>> Color) [1] >>>>>> M src/java.desktop/unix/classes/sun/awt/X11/XDecoratedPeer.java >>>>>> (Avoid miss calculation for window position under DTWM/MWM by >>>>>> XMapRaised/XMapWindow) >>>>>> M src/java.desktop/unix/classes/sun/awt/X11/XWM.java >>>>>> (Detect MWM on AIX platform) >>>>>> M src/java.desktop/unix/classes/sun/awt/X11/XWindowPeer.java >>>>>> (Add non-focusable window support on DTWM/MWM for AIX, because >>>>>> DTWM/MWM does not have enough features for ICCCM) >>>>>> >>>>>> I appreciate any feedback please, and how I would go about >>>>>> obtaining a sponsor and contributor ? >>>>>> >>>>>> Thanks, >>>>>> Ichiroh Takiguchi >>>>>> IBM Japan, Ltd. >>>>>> >>>>>> [1] >>>>>> https://docs.oracle.com/cd/E19253-01/806-7492/fontsandcolors-15233/index.html >>>>>> From philip.race at oracle.com Tue Dec 4 18:06:52 2018 From: philip.race at oracle.com (Phil Race) Date: Tue, 4 Dec 2018 10:06:52 -0800 Subject: RFR: 8212676 AIX's CDE/MWM support In-Reply-To: <5a4f9f5c7a80a5abda9edd150e19a11f@linux.vnet.ibm.com> References: <5f309d9c612f2c16aef75846e0ff14fa@linux.vnet.ibm.com> <0ede447e30ed05ce7a52f6d133b2c15b@linux.vnet.ibm.com> <180114e58e98f339332e3a781a34126b@linux.vnet.ibm.com> <5a4f9f5c7a80a5abda9edd150e19a11f@linux.vnet.ibm.com> Message-ID: <4addeebf-9ed8-bb63-5920-49ae6fb429b1@oracle.com> I haven't evaluated the merits of this proposal but this https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.00/src/java.desktop/share/classes/sun/font/FontUtilities.java.udiff.html is not the right place to support a flag used in all these X11 files. And why is i18n-dev on the review ? I can't see any I18N related changes. -phil. On 12/4/18 8:53 AM, Ichiroh Takiguchi wrote: > Hello again. > > Could you give me review comment and/or suggestion ? > > Bug:??? https://bugs.openjdk.java.net/browse/JDK-8212676 > Change: https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.00/ > > Thanks, > Ichiroh Takiguchi > > On 2018-11-26 21:27, Ichiroh Takiguchi wrote: >> Hello. >> >> Could you review the fix ? >> >> Bug:??? https://bugs.openjdk.java.net/browse/JDK-8212676 >> Change: https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.00/ >> >> Test instructions and screen shots are in JDK-8212676. >> >> GUI environment for AIX platform still needs CDE support. >> This fix is required to avoid unexpected working behavior on AIX >> platform. >> >> I'd like to obtain a sponsor for this issue. >> >> Thanks, >> Ichiroh Takiguchi >> IBM Japan, Ltd. >> >> On 2018-06-18 18:57, Ichiroh Takiguchi wrote: >>> Hello. >>> >>> This fix is really required for AIX's GUI. >>> System color setting and window manager's working behavior are very >>> important. >>> >>> I appreciate any feedback, and how I would go about obtaining a >>> sponsor and contributor ? >>> >>> On 2018-05-25 11:02, Ichiroh Takiguchi wrote: >>>> Hello Phil. >>>> >>>> webrev file was extracted. >>>> Please see >>>> ? http://cr.openjdk.java.net/~aleonard/AIX_GUI/webrev.00/ >>>> >>>> On 2018-05-19 02:48, Ichiroh Takiguchi wrote: >>>>> Hello Phil. >>>>> >>>>> Webrev.zip file is stored into >>>>> http://cr.openjdk.java.net/~aleonard/AIX_GUI/webrev-aixgui.zip >>>>> >>>>> Test programs are also stored: >>>>> No testcase is available for FontUtilities.java and >>>>> XDecoratedPeer.java. >>>>> >>>>> MotifColorUtilities.java >>>>> http://cr.openjdk.java.net/~aleonard/AIX_GUI/SystemColorTest2.java >>>>> Run SystemColorTest2, system colors should be displayed >>>>> AIX sample is >>>>> http://cr.openjdk.java.net/~aleonard/AIX_GUI/aix_systemcolor.txt >>>>> >>>>> XWM.java >>>>> http://cr.openjdk.java.net/~aleonard/AIX_GUI/XWMTest1.java >>>>> On AIX CDE, isMotif and isCDE were true. >>>>> On AIX MWM, every entry is false. >>>>> >>>>> XWindowPeer.java >>>>> http://cr.openjdk.java.net/~aleonard/AIX_GUI/JFrameTest.java >>>>> On AIX CDE, click inside of "Non-Focusable" window (not window >>>>> frame). >>>>> Window focus should not be changed because of "click on focus" >>>>> feature. >>>>> But input focus is moved to "Non-Focusable" window. >>>>> >>>>> >>>>> On 2018-05-18 01:00, Phil Race wrote: >>>>>> I think we'd need to see the actual proposed changes and understand >>>>>> the implications >>>>>> for ongoing support as we no longer support any platform which has a >>>>>> CDE desktop. >>>>>> Solaris 11.3 uses Gnome, so we'd be more inclined to be ripping out >>>>>> such support rather >>>>>> than adding to it. >>>>>> >>>>>> -phil. >>>>>> >>>>>> On 05/17/2018 04:18 AM, Ichiroh Takiguchi wrote: >>>>>>> Hello, >>>>>>> IBM would like to contribute AIX's CDE (Common Desktop >>>>>>> Environment) DTWM (Desktop Window Manager) /MWM (Motif Window >>>>>>> Manager) support to OpenJDK project. >>>>>>> >>>>>>> I'd like contribute following 5 files: >>>>>>> >>>>>>> M src/java.desktop/share/classes/sun/font/FontUtilities.java >>>>>>> (Add isAIX flag to determine AIX platform for GUI environment) >>>>>>> M >>>>>>> src/java.desktop/unix/classes/sun/awt/X11/MotifColorUtilities.java >>>>>>> (Add High Color support on CDE, OpenJDK just supports Medium >>>>>>> Color) [1] >>>>>>> M src/java.desktop/unix/classes/sun/awt/X11/XDecoratedPeer.java >>>>>>> (Avoid miss calculation for window position under DTWM/MWM by >>>>>>> XMapRaised/XMapWindow) >>>>>>> M src/java.desktop/unix/classes/sun/awt/X11/XWM.java >>>>>>> (Detect MWM on AIX platform) >>>>>>> M src/java.desktop/unix/classes/sun/awt/X11/XWindowPeer.java >>>>>>> (Add non-focusable window support on DTWM/MWM for AIX, because >>>>>>> DTWM/MWM does not have enough features for ICCCM) >>>>>>> >>>>>>> I appreciate any feedback please, and how I would go about >>>>>>> obtaining a sponsor and contributor ? >>>>>>> >>>>>>> Thanks, >>>>>>> Ichiroh Takiguchi >>>>>>> IBM Japan, Ltd. >>>>>>> >>>>>>> [1] >>>>>>> https://docs.oracle.com/cd/E19253-01/806-7492/fontsandcolors-15233/index.html >>>>>>> > From naoto.sato at oracle.com Tue Dec 4 18:52:45 2018 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Tue, 4 Dec 2018 10:52:45 -0800 Subject: [12] RFR: 8214770: java/time/test/java/time/format/TestNonIsoFormatter.java failed in non-english locales. Message-ID: <1e9dfd21-0dd2-241a-c2c5-2dfdbb34d29f@oracle.com> Hello, Please review this simple fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8214770 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8214770/webrev.00/ It is simply specifying Locale.ROOT to expect the locale independent era names. Naoto From lance.andersen at oracle.com Tue Dec 4 18:59:13 2018 From: lance.andersen at oracle.com (Lance Andersen) Date: Tue, 4 Dec 2018 13:59:13 -0500 Subject: [12] RFR: 8214770: java/time/test/java/time/format/TestNonIsoFormatter.java failed in non-english locales. In-Reply-To: <1e9dfd21-0dd2-241a-c2c5-2dfdbb34d29f@oracle.com> References: <1e9dfd21-0dd2-241a-c2c5-2dfdbb34d29f@oracle.com> Message-ID: <7280BA48-FFE0-4E33-969A-F9E12B31BFF4@oracle.com> Looks OK Naoto > On Dec 4, 2018, at 1:52 PM, naoto.sato at oracle.com wrote: > > Hello, > > Please review this simple fix to the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8214770 > > The proposed fix is located at: > > http://cr.openjdk.java.net/~naoto/8214770/webrev.00/ > > It is simply specifying Locale.ROOT to expect the locale independent era names. > > Naoto Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com From brian.burkhalter at oracle.com Tue Dec 4 19:00:33 2018 From: brian.burkhalter at oracle.com (Brian Burkhalter) Date: Tue, 4 Dec 2018 11:00:33 -0800 Subject: [12] RFR: 8214770: java/time/test/java/time/format/TestNonIsoFormatter.java failed in non-english locales. In-Reply-To: <7280BA48-FFE0-4E33-969A-F9E12B31BFF4@oracle.com> References: <1e9dfd21-0dd2-241a-c2c5-2dfdbb34d29f@oracle.com> <7280BA48-FFE0-4E33-969A-F9E12B31BFF4@oracle.com> Message-ID: <130EE7C7-C3CD-479D-A7EE-27C0FF5321FE@oracle.com> +1 Brian > On Dec 4, 2018, at 10:59 AM, Lance Andersen wrote: > > Looks OK Naoto From TOSHIONA at jp.ibm.com Wed Dec 5 02:45:01 2018 From: TOSHIONA at jp.ibm.com (Toshio 5 Nakamura) Date: Wed, 5 Dec 2018 11:45:01 +0900 Subject: Fw: [PATCH] JDK-8213183: InputMethod cannot be used after its restarting In-Reply-To: References: Message-ID: Hello, Can anyone support this proposal? I appreciate any suggestion or comment. issue: https://bugs.openjdk.java.net/browse/JDK-8213183 webrev: http://cr.openjdk.java.net/~tnakamura/8213183/webrev.01/ Fix descriptions: - XSelectInput() in XMSelection.java may erase existing XRegisterIMInstantiateCallback entry. It should keep the current masks. - All input method data in the linked list should be cleared when DestroyXIMCallback() was called. Best regards, Toshio Nakamura "awt-dev" wrote on 2018/11/22 15:48:10: > From: "Toshio 5 Nakamura" > To: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net > Date: 2018/11/22 15:50 > Subject: Fw: [PATCH] JDK-8213183: InputMethod cannot be > used after its restarting > Sent by: "awt-dev" > > Ping. > > Thanks, > Toshio Nakamura > > "awt-dev" wrote on 2018/11/15 17:15:25: > > > From: "Toshio 5 Nakamura" > > To: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net > > Date: 2018/11/15 17:16 > > Subject: Re: [PATCH] JDK-8213183: InputMethod cannot be > > used after its restarting > > Sent by: "awt-dev" > > > > Hello, > > > > I'd like to re-propose minimized patch in this thread. > > > > The key fix of this patch is for XMSelection.java. Its initScreen() cleared > > previous XRegisterIMInstantiateCallback() entry, but it should keep the > > current mask. By this change only, we can reuse Input Method after > > changing focus. > > (Original patch didn't need focus change, but it may be hard to bereviewed.) > > > > Additionally, this change may unveil a potential problem in > awt_InputMethod.c. > > It needs to clear all pX11IMData, not only the current one. Without > > the change, > > multi-window application with IM may crash after IM restart. > > > > So, I'd like to propose only two parts in this thread. > > Can I obtain a sponsor for this minimized fix? > > > > Revised webrev: > > http://cr.openjdk.java.net/~tnakamura/8213183/webrev.01/ > > > > Thanks, > > Toshio Nakamura > > > > From: "Toshio 5 Nakamura" > > To: Sergey Bylokhov > > Cc: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net > > Date: 2018/11/12 20:22 > > Subject: Re: [PATCH] JDK-8213183: InputMethod cannot be > > used after its restarting > > Sent by: "awt-dev" > > > > > > > > Hi Sergey, > > > > Thank you for your reply. Yes, I've added the steps to the bug. > > https://bugs.openjdk.java.net/browse/JDK-8213183 > > > > Please let me know if you have any question or any advice. > > > > Thanks, > > Toshio Nakamura > > > > From: Sergey Bylokhov > > To: Toshio 5 Nakamura , awt- > > dev at openjdk.java.net, i18n-dev at openjdk.java.net > > Date: 2018/11/10 12:46 > > Subject: Re: [PATCH] JDK-8213183: InputMethod cannot be > > used after its restarting > > > > > > > > Hi, Toshio. > > > > Can you please add the steps to reproduce to the bug description. > > > > On 06/11/2018 01:19, Toshio 5 Nakamura wrote: > > > Hello, > > > > > > Can I obtain a sponsor of this proposal about InputMethod issue on Linux? > > > > > > Bug: > > > https://bugs.openjdk.java.net/browse/JDK-8213183 > > > Webrev: > > > http://cr.openjdk.java.net/~tnakamura/8213183/webrev.00/ > > > > > > I've got an author role and filled the bug report. > > > Please refer the attached mail about the detail of this patch. > > > > > > Best Regards, > > > Toshio Nakamura > > > > -- > > Best regards, Sergey. > > From dan.z.zhou at oracle.com Wed Dec 5 05:35:20 2018 From: dan.z.zhou at oracle.com (Dora Zhou) Date: Wed, 5 Dec 2018 13:35:20 +0800 Subject: [12]RFR 8213127: Refactor test/java/util/ResourceBundle/Control/MissingResourceCauseTest.sh to plain java tests Message-ID: Hello, Please help review the fix for refactor test/java/util/ResourceBundle/Control/MissingResourceCauseTest.sh to plain java tests. Thank you. Bug: https://bugs.openjdk.java.net/browse/JDK-8213127 Webrev: http://cr.openjdk.java.net/~dzhou/8213127/webrev.02/ Regards, Dora From naoto.sato at oracle.com Wed Dec 5 16:54:02 2018 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Wed, 5 Dec 2018 08:54:02 -0800 Subject: [12]RFR 8213127: Refactor test/java/util/ResourceBundle/Control/MissingResourceCauseTest.sh to plain java tests In-Reply-To: References: Message-ID: Looks good to me. Naoto On 12/4/18 9:35 PM, Dora Zhou wrote: > Hello, > > Please help review the fix for refactor > test/java/util/ResourceBundle/Control/MissingResourceCauseTest.sh to > plain java tests. Thank you. > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8213127 > > Webrev: http://cr.openjdk.java.net/~dzhou/8213127/webrev.02/ > > Regards, > Dora From ying.z.zhou at oracle.com Fri Dec 7 02:42:21 2018 From: ying.z.zhou at oracle.com (Ying Zhou) Date: Fri, 7 Dec 2018 10:42:21 +0800 Subject: [12]RFR of JDK-8213409:Refactor sun.text.IntHashtable:i18n shell tests to plain java tests Message-ID: Hello, test/jdk/sun/text/IntHashtable/Bug4170614Test.sh Please review this patch for refactoring above shell script test to java. Bug: https://bugs.openjdk.java.net/browse/JDK-8213409 Webrev: http://cr.openjdk.java.net/~yzhou/8213409/webrev.00/ Thanks, Daisy From nishit.jain at oracle.com Fri Dec 7 10:37:21 2018 From: nishit.jain at oracle.com (Nishit Jain) Date: Fri, 7 Dec 2018 16:07:21 +0530 Subject: [12] RFR JDK-8214935: Upgrade IANA LSR data Message-ID: <44f0c1a3-faa2-32a7-f966-bf1180dd2994@oracle.com> Hi, Please review the fix for JDK-8214935. The changes made through JDK-8213294 upgraded the LSR data to 2018-10-31, but there is a recent change seen in the LSR data with version 2018-11-30. The JDK-8214935 change is to stick to the latest available version for JDK12. RFE: https://bugs.openjdk.java.net/browse/JDK-8214935 Webrev: http://cr.openjdk.java.net/~nishjain/8214935/webrev.00/ Regards, Nishit Jain From naoto.sato at oracle.com Fri Dec 7 17:19:19 2018 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Fri, 7 Dec 2018 09:19:19 -0800 Subject: [12]RFR of JDK-8213409:Refactor sun.text.IntHashtable:i18n shell tests to plain java tests In-Reply-To: References: Message-ID: <7242d4b4-ce40-7dda-542f-55bcc5319503@oracle.com> Hi Daisy, Looks good to me. Naoto On 12/6/18 6:42 PM, Ying Zhou wrote: > Hello, > > test/jdk/sun/text/IntHashtable/Bug4170614Test.sh > > Please review this patch for refactoring above shell script test to java. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8213409 > > Webrev: http://cr.openjdk.java.net/~yzhou/8213409/webrev.00/ > > Thanks, > > Daisy > From naoto.sato at oracle.com Tue Dec 11 14:51:57 2018 From: naoto.sato at oracle.com (Naoto Sato) Date: Tue, 11 Dec 2018 06:51:57 -0800 Subject: [12] RFR: 8215194: Initial size of UnicodeBlock map is incorrect Message-ID: Hi, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8215194 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8215194/webrev.00/ This one line fix is for the correctness of the initial map size of Character.UnicodeBlock. Naoto From rachna.goel at oracle.com Tue Dec 11 16:49:06 2018 From: rachna.goel at oracle.com (Rachna Goel) Date: Tue, 11 Dec 2018 22:19:06 +0530 Subject: [12] RFR: 8215194: Initial size of UnicodeBlock map is incorrect In-Reply-To: References: Message-ID: <800dea41-f761-26f2-4209-752de6a1d516@oracle.com> Hi Naoto, Thanks for fixing this. Your fix looks good to me. Thanks, Rachna On 12/11/18 8:21 PM, Naoto Sato wrote: > Hi, > > Please review the fix for the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8215194 > > The proposed fix is located at: > > http://cr.openjdk.java.net/~naoto/8215194/webrev.00/ > > This one line fix is for the correctness of the initial map size of > Character.UnicodeBlock. > > Naoto -- Thanks, Rachna From naoto.sato at oracle.com Tue Dec 11 21:27:46 2018 From: naoto.sato at oracle.com (Naoto Sato) Date: Tue, 11 Dec 2018 13:27:46 -0800 Subject: Fw: [PATCH] JDK-8213183: InputMethod cannot be used after its restarting In-Reply-To: References: Message-ID: <689c7234-c008-f709-e630-4dff0da83233@oracle.com> Hello, I would rather not create a new test directory ReconnectTest. Instead, moving the test under InputContext would just be fine. Other than that, looks good to me. Naoto On 12/4/18 6:45 PM, Toshio 5 Nakamura wrote: > Hello, > > Can anyone support this proposal? I appreciate any suggestion or comment. > > issue: > https://bugs.openjdk.java.net/browse/JDK-8213183 > webrev: > http://cr.openjdk.java.net/~tnakamura/8213183/webrev.01/ > > Fix descriptions: > - XSelectInput() in XMSelection.java may erase existing > XRegisterIMInstantiateCallback entry. It should keep the current masks. > - All input method data in the linked list should be cleared when > DestroyXIMCallback() was called. > > Best regards, > Toshio Nakamura > > "awt-dev" wrote on 2018/11/22 15:48:10: > >> From: "Toshio 5 Nakamura" >> To: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net >> Date: 2018/11/22 15:50 >> Subject: Fw: [PATCH] JDK-8213183: InputMethod cannot be >> used after its restarting >> Sent by: "awt-dev" >> >> Ping. >> >> Thanks, >> Toshio Nakamura >> >> "awt-dev" wrote on 2018/11/15 > 17:15:25: >> >>> From: "Toshio 5 Nakamura" >>> To: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net >>> Date: 2018/11/15 17:16 >>> Subject: Re: [PATCH] JDK-8213183: InputMethod cannot be >>> used after its restarting >>> Sent by: "awt-dev" >>> >>> Hello, >>> >>> I'd like to re-propose minimized patch in this thread. >>> >>> The key fix of this patch is for XMSelection.java. Its initScreen() > cleared >>> previous XRegisterIMInstantiateCallback() entry, but it should keep the >>> current mask. By this change only, we can reuse Input Method after >>> changing focus. >>> (Original patch didn't need focus change, but it may be hard to > bereviewed.) >>> >>> Additionally, this change may unveil a potential problem in >> awt_InputMethod.c. >>> It needs to clear all pX11IMData, not only the current one. Without >>> the change, >>> multi-window application with IM may crash after IM restart. >>> >>> So, I'd like to propose only two parts in this thread. >>> Can I obtain a sponsor for this minimized fix? >>> >>> Revised webrev: >>> http://cr.openjdk.java.net/~tnakamura/8213183/webrev.01/ >>> >>> Thanks, >>> Toshio Nakamura >>> >>> From: "Toshio 5 Nakamura" >>> To: Sergey Bylokhov >>> Cc: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net >>> Date: 2018/11/12 20:22 >>> Subject: Re: [PATCH] JDK-8213183: InputMethod cannot be >>> used after its restarting >>> Sent by: "awt-dev" >>> >>> >>> >>> Hi Sergey, >>> >>> Thank you for your reply. Yes, I've added the steps to the bug. >>> https://bugs.openjdk.java.net/browse/JDK-8213183 >>> >>> Please let me know if you have any question or any advice. >>> >>> Thanks, >>> Toshio Nakamura >>> >>> From: Sergey Bylokhov >>> To: Toshio 5 Nakamura , awt- >>> dev at openjdk.java.net, i18n-dev at openjdk.java.net >>> Date: 2018/11/10 12:46 >>> Subject: Re: [PATCH] JDK-8213183: InputMethod cannot be >>> used after its restarting >>> >>> >>> >>> Hi, Toshio. >>> >>> Can you please add the steps to reproduce to the bug description. >>> >>> On 06/11/2018 01:19, Toshio 5 Nakamura wrote: >>>> Hello, >>>> >>>> Can I obtain a sponsor of this proposal about InputMethod issue on > Linux? >>>> >>>> Bug: >>>> https://bugs.openjdk.java.net/browse/JDK-8213183 >>>> Webrev: >>>> http://cr.openjdk.java.net/~tnakamura/8213183/webrev.00/ >>>> >>>> I've got an author role and filled the bug report. >>>> Please refer the attached mail about the detail of this patch. >>>> >>>> Best Regards, >>>> Toshio Nakamura >>> >>> -- >>> Best regards, Sergey. >>> From TOSHIONA at jp.ibm.com Wed Dec 12 04:32:02 2018 From: TOSHIONA at jp.ibm.com (Toshio 5 Nakamura) Date: Wed, 12 Dec 2018 13:32:02 +0900 Subject: Fw: [PATCH] JDK-8213183: InputMethod cannot be used after its restarting In-Reply-To: <689c7234-c008-f709-e630-4dff0da83233@oracle.com> References: <689c7234-c008-f709-e630-4dff0da83233@oracle.com> Message-ID: Hello Naoto, Thank you for your review. The updated webrev: http://cr.openjdk.java.net/~tnakamura/8213183/webrev.02/ Thanks, Toshio Nakamura Naoto Sato wrote on 2018/12/12 06:27:46: > From: Naoto Sato > To: Toshio 5 Nakamura , awt- > dev at openjdk.java.net, i18n-dev at openjdk.java.net > Date: 2018/12/12 06:30 > Subject: Re: Fw: [PATCH] JDK-8213183: > InputMethod cannot be used after its restarting > > Hello, > > I would rather not create a new test directory ReconnectTest. Instead, > moving the test under InputContext would just be fine. Other than that, > looks good to me. > > Naoto > > On 12/4/18 6:45 PM, Toshio 5 Nakamura wrote: > > Hello, > > > > Can anyone support this proposal? I appreciate any suggestion or comment. > > > > issue: > > INVALID URI REMOVED > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8213183&d=DwICaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=EVbFABcgo-X99_TGI2- > qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx- > KQAP0ap59aIgx7JdMXnkMf0&s=q6uPI3Ypu4juvcyBI8aEenYXLO-yGglZe9fOzYWHni4&e= > > webrev: > > INVALID URI REMOVED > u=http-3A__cr.openjdk.java.net_-7Etnakamura_8213183_webrev. > 01_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2- > qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx- > KQAP0ap59aIgx7JdMXnkMf0&s=78XQhanHugJH88R5X5xh_QIq54Wzi4ZR52f4iTjMhH8&e= > > > > Fix descriptions: > > - XSelectInput() in XMSelection.java may erase existing > > XRegisterIMInstantiateCallback entry. It should keep the current masks. > > - All input method data in the linked list should be cleared when > > DestroyXIMCallback() was called. > > > > Best regards, > > Toshio Nakamura > > > > "awt-dev" wrote on 2018/11/22 15:48:10: > > > >> From: "Toshio 5 Nakamura" > >> To: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net > >> Date: 2018/11/22 15:50 > >> Subject: Fw: [PATCH] JDK-8213183: InputMethod cannot be > >> used after its restarting > >> Sent by: "awt-dev" > >> > >> Ping. > >> > >> Thanks, > >> Toshio Nakamura > >> > >> "awt-dev" wrote on 2018/11/15 > > 17:15:25: > >> > >>> From: "Toshio 5 Nakamura" > >>> To: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net > >>> Date: 2018/11/15 17:16 > >>> Subject: Re: [PATCH] JDK-8213183: InputMethod cannot be > >>> used after its restarting > >>> Sent by: "awt-dev" > >>> > >>> Hello, > >>> > >>> I'd like to re-propose minimized patch in this thread. > >>> > >>> The key fix of this patch is for XMSelection.java. Its initScreen() > > cleared > >>> previous XRegisterIMInstantiateCallback() entry, but it should keep the > >>> current mask. By this change only, we can reuse Input Method after > >>> changing focus. > >>> (Original patch didn't need focus change, but it may be hard to > > bereviewed.) > >>> > >>> Additionally, this change may unveil a potential problem in > >> awt_InputMethod.c. > >>> It needs to clear all pX11IMData, not only the current one. Without > >>> the change, > >>> multi-window application with IM may crash after IM restart. > >>> > >>> So, I'd like to propose only two parts in this thread. > >>> Can I obtain a sponsor for this minimized fix? > >>> > >>> Revised webrev: > >>> INVALID URI REMOVED > u=http-3A__cr.openjdk.java.net_-7Etnakamura_8213183_webrev. > 01_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2- > qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx- > KQAP0ap59aIgx7JdMXnkMf0&s=78XQhanHugJH88R5X5xh_QIq54Wzi4ZR52f4iTjMhH8&e= > >>> > >>> Thanks, > >>> Toshio Nakamura > >>> > >>> From: "Toshio 5 Nakamura" > >>> To: Sergey Bylokhov > >>> Cc: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net > >>> Date: 2018/11/12 20:22 > >>> Subject: Re: [PATCH] JDK-8213183: InputMethod cannot be > >>> used after its restarting > >>> Sent by: "awt-dev" > >>> > >>> > >>> > >>> Hi Sergey, > >>> > >>> Thank you for your reply. Yes, I've added the steps to the bug. > >>> INVALID URI REMOVED > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8213183&d=DwICaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=EVbFABcgo-X99_TGI2- > qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx- > KQAP0ap59aIgx7JdMXnkMf0&s=q6uPI3Ypu4juvcyBI8aEenYXLO-yGglZe9fOzYWHni4&e= > >>> > >>> Please let me know if you have any question or any advice. > >>> > >>> Thanks, > >>> Toshio Nakamura > >>> > >>> From: Sergey Bylokhov > >>> To: Toshio 5 Nakamura , awt- > >>> dev at openjdk.java.net, i18n-dev at openjdk.java.net > >>> Date: 2018/11/10 12:46 > >>> Subject: Re: [PATCH] JDK-8213183: InputMethod cannot be > >>> used after its restarting > >>> > >>> > >>> > >>> Hi, Toshio. > >>> > >>> Can you please add the steps to reproduce to the bug description. > >>> > >>> On 06/11/2018 01:19, Toshio 5 Nakamura wrote: > >>>> Hello, > >>>> > >>>> Can I obtain a sponsor of this proposal about InputMethod issue on > > Linux? > >>>> > >>>> Bug: > >>>> INVALID URI REMOVED > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8213183&d=DwICaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=EVbFABcgo-X99_TGI2- > qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx- > KQAP0ap59aIgx7JdMXnkMf0&s=q6uPI3Ypu4juvcyBI8aEenYXLO-yGglZe9fOzYWHni4&e= > >>>> Webrev: > >>>> INVALID URI REMOVED > u=http-3A__cr.openjdk.java.net_-7Etnakamura_8213183_webrev. > 00_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2- > qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx- > KQAP0ap59aIgx7JdMXnkMf0&s=7sUCNNIiK-6T-20D0en2W-KJszmeUsMpqdngQxBDafM&e= > >>>> > >>>> I've got an author role and filled the bug report. > >>>> Please refer the attached mail about the detail of this patch. > >>>> > >>>> Best Regards, > >>>> Toshio Nakamura > >>> > >>> -- > >>> Best regards, Sergey. > >>> > From naoto.sato at oracle.com Wed Dec 12 05:23:05 2018 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Tue, 11 Dec 2018 21:23:05 -0800 Subject: Fw: [PATCH] JDK-8213183: InputMethod cannot be used after its restarting In-Reply-To: References: <689c7234-c008-f709-e630-4dff0da83233@oracle.com> Message-ID: Looks good to me. Naoto On 12/11/18 8:32 PM, Toshio 5 Nakamura wrote: > Hello Naoto, > > Thank you for your review. > > The updated webrev: > http://cr.openjdk.java.net/~tnakamura/8213183/webrev.02/ > > Thanks, > Toshio Nakamura > > Naoto Sato wrote on 2018/12/12 06:27:46: > > > From: Naoto Sato > > To: Toshio 5 Nakamura , awt- > > dev at openjdk.java.net, i18n-dev at openjdk.java.net > > Date: 2018/12/12 06:30 > > Subject: Re: Fw: [PATCH] JDK-8213183: > > InputMethod cannot be used after its restarting > > > > Hello, > > > > I would rather not create a new test directory ReconnectTest. Instead, > > moving the test under InputContext would just be fine. Other than that, > > looks good to me. > > > > Naoto > > > > On 12/4/18 6:45 PM, Toshio 5 Nakamura wrote: > > > Hello, > > > > > > Can anyone support this proposal? I appreciate any suggestion or > comment. > > > > > > issue: > > > INVALID URI REMOVED > > > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8213183&d=DwICaQ&c=jf_iaSHvJObTbx- > > siA1ZOg&r=EVbFABcgo-X99_TGI2- > > qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx- > > KQAP0ap59aIgx7JdMXnkMf0&s=q6uPI3Ypu4juvcyBI8aEenYXLO-yGglZe9fOzYWHni4&e= > > > webrev: > > > INVALID URI REMOVED > > u=http-3A__cr.openjdk.java.net_-7Etnakamura_8213183_webrev. > > 01_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2- > > qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx- > > KQAP0ap59aIgx7JdMXnkMf0&s=78XQhanHugJH88R5X5xh_QIq54Wzi4ZR52f4iTjMhH8&e= > > > > > > Fix descriptions: > > > - XSelectInput() in XMSelection.java may erase existing > > > ? ?XRegisterIMInstantiateCallback entry. It should keep the current > masks. > > > - All input method data in the linked list should be cleared when > > > ? ?DestroyXIMCallback() was called. > > > > > > Best regards, > > > Toshio Nakamura > > > > > > "awt-dev" wrote on 2018/11/22 > 15:48:10: > > > > > >> From: "Toshio 5 Nakamura" > > >> To: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net > > >> Date: 2018/11/22 15:50 > > >> Subject: Fw: [PATCH] JDK-8213183: InputMethod cannot be > > >> used after its restarting > > >> Sent by: "awt-dev" > > >> > > >> Ping. > > >> > > >> Thanks, > > >> Toshio Nakamura > > >> > > >> "awt-dev" wrote on 2018/11/15 > > > 17:15:25: > > >> > > >>> From: "Toshio 5 Nakamura" > > >>> To: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net > > >>> Date: 2018/11/15 17:16 > > >>> Subject: Re: [PATCH] JDK-8213183: InputMethod cannot be > > >>> used after its restarting > > >>> Sent by: "awt-dev" > > >>> > > >>> Hello, > > >>> > > >>> I'd like to re-propose minimized patch in this thread. > > >>> > > >>> The key fix of this patch is for XMSelection.java. Its initScreen() > > > cleared > > >>> previous XRegisterIMInstantiateCallback() entry, but it should > keep the > > >>> current mask. By this change only, we can reuse Input Method after > > >>> changing focus. > > >>> (Original patch didn't need focus change, but it may be hard to > > > bereviewed.) > > >>> > > >>> Additionally, this change may unveil a potential problem in > > >> awt_InputMethod.c. > > >>> It needs to clear all pX11IMData, not only the current one. Without > > >>> the change, > > >>> multi-window application with IM may crash after IM restart. > > >>> > > >>> So, I'd like to propose only two parts in this thread. > > >>> Can I obtain a sponsor for this minimized fix? > > >>> > > >>> Revised webrev: > > >>> INVALID URI REMOVED > > u=http-3A__cr.openjdk.java.net_-7Etnakamura_8213183_webrev. > > 01_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2- > > qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx- > > KQAP0ap59aIgx7JdMXnkMf0&s=78XQhanHugJH88R5X5xh_QIq54Wzi4ZR52f4iTjMhH8&e= > > >>> > > >>> Thanks, > > >>> Toshio Nakamura > > >>> > > >>> From: "Toshio 5 Nakamura" > > >>> To: Sergey Bylokhov > > >>> Cc: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net > > >>> Date: 2018/11/12 20:22 > > >>> Subject: Re: [PATCH] JDK-8213183: InputMethod cannot be > > >>> used after its restarting > > >>> Sent by: "awt-dev" > > >>> > > >>> > > >>> > > >>> Hi Sergey, > > >>> > > >>> Thank you for your reply. Yes, I've added the steps to the bug. > > >>> INVALID URI REMOVED > > > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8213183&d=DwICaQ&c=jf_iaSHvJObTbx- > > siA1ZOg&r=EVbFABcgo-X99_TGI2- > > qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx- > > KQAP0ap59aIgx7JdMXnkMf0&s=q6uPI3Ypu4juvcyBI8aEenYXLO-yGglZe9fOzYWHni4&e= > > >>> > > >>> Please let me know if you have any question or any advice. > > >>> > > >>> Thanks, > > >>> Toshio Nakamura > > >>> > > >>> From: Sergey Bylokhov > > >>> To: Toshio 5 Nakamura , awt- > > >>> dev at openjdk.java.net, i18n-dev at openjdk.java.net > > >>> Date: 2018/11/10 12:46 > > >>> Subject: Re: [PATCH] JDK-8213183: InputMethod cannot be > > >>> used after its restarting > > >>> > > >>> > > >>> > > >>> Hi, Toshio. > > >>> > > >>> Can you please add the steps to reproduce to the bug description. > > >>> > > >>> On 06/11/2018 01:19, Toshio 5 Nakamura wrote: > > >>>> Hello, > > >>>> > > >>>> Can I obtain a sponsor of this proposal about InputMethod issue on > > > Linux? > > >>>> > > >>>> Bug: > > >>>> INVALID URI REMOVED > > > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8213183&d=DwICaQ&c=jf_iaSHvJObTbx- > > siA1ZOg&r=EVbFABcgo-X99_TGI2- > > qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx- > > KQAP0ap59aIgx7JdMXnkMf0&s=q6uPI3Ypu4juvcyBI8aEenYXLO-yGglZe9fOzYWHni4&e= > > >>>> Webrev: > > >>>> INVALID URI REMOVED > > u=http-3A__cr.openjdk.java.net_-7Etnakamura_8213183_webrev. > > 00_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2- > > qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx- > > KQAP0ap59aIgx7JdMXnkMf0&s=7sUCNNIiK-6T-20D0en2W-KJszmeUsMpqdngQxBDafM&e= > > >>>> > > >>>> I've got an author role and filled the bug report. > > >>>> Please refer the attached mail about the detail of this patch. > > >>>> > > >>>> Best Regards, > > >>>> Toshio Nakamura > > >>> > > >>> -- > > >>> Best regards, Sergey. > > >>> > > >