<i18n dev> <AWT Dev> Fw: [PATCH] JDK-8213183: InputMethod cannot be used after its restarting

Wed Dec 12 04:32:02 UTC 2018

Hello Naoto,

Thank you for your review.

The updated webrev:
http://cr.openjdk.java.net/~tnakamura/8213183/webrev.02/

Thanks,
Toshio Nakamura

Naoto Sato <naoto.sato at oracle.com> wrote on 2018/12/12 06:27:46:

> From: Naoto Sato <naoto.sato at oracle.com>
> To: Toshio 5 Nakamura <TOSHIONA at jp.ibm.com>, awt-
> dev at openjdk.java.net, i18n-dev at openjdk.java.net
> Date: 2018/12/12 06:30
> Subject: Re: <i18n dev> <AWT Dev> Fw: [PATCH] JDK-8213183:
> InputMethod cannot be used after its restarting
>
> Hello,
>
> I would rather not create a new test directory ReconnectTest. Instead,
> moving the test under InputContext would just be fine. Other than that,
> looks good to me.
>
> Naoto
>
> On 12/4/18 6:45 PM, Toshio 5 Nakamura wrote:
> > Hello,
> >
> > Can anyone support this proposal? I appreciate any suggestion or
comment.
> >
> > issue:
> > INVALID URI REMOVED
>
u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8213183&d=DwICaQ&c=jf_iaSHvJObTbx-

> siA1ZOg&r=EVbFABcgo-X99_TGI2-
> qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx-
> KQAP0ap59aIgx7JdMXnkMf0&s=q6uPI3Ypu4juvcyBI8aEenYXLO-yGglZe9fOzYWHni4&e=
> > webrev:
> > INVALID URI REMOVED
> u=http-3A__cr.openjdk.java.net_-7Etnakamura_8213183_webrev.
> 01_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-
> qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx-
> KQAP0ap59aIgx7JdMXnkMf0&s=78XQhanHugJH88R5X5xh_QIq54Wzi4ZR52f4iTjMhH8&e=
> >
> > Fix descriptions:
> > - XSelectInput() in XMSelection.java may erase existing
> >    XRegisterIMInstantiateCallback entry. It should keep the current
masks.
> > - All input method data in the linked list should be cleared when
> >    DestroyXIMCallback() was called.
> >
> > Best regards,
> > Toshio Nakamura
> >
> > "awt-dev" <awt-dev-bounces at openjdk.java.net> wrote on 2018/11/22
15:48:10:
> >
> >> From: "Toshio 5 Nakamura" <TOSHIONA at jp.ibm.com>
> >> To: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net
> >> Date: 2018/11/22 15:50
> >> Subject: <AWT Dev> Fw: [PATCH] JDK-8213183: InputMethod cannot be
> >> used after its restarting
> >> Sent by: "awt-dev" <awt-dev-bounces at openjdk.java.net>
> >>
> >> Ping.
> >>
> >> Thanks,
> >> Toshio Nakamura
> >>
> >> "awt-dev" <awt-dev-bounces at openjdk.java.net> wrote on 2018/11/15
> > 17:15:25:
> >>
> >>> From: "Toshio 5 Nakamura" <TOSHIONA at jp.ibm.com>
> >>> To: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net
> >>> Date: 2018/11/15 17:16
> >>> Subject: Re: <AWT Dev> [PATCH] JDK-8213183: InputMethod cannot be
> >>> used after its restarting
> >>> Sent by: "awt-dev" <awt-dev-bounces at openjdk.java.net>
> >>>
> >>> Hello,
> >>>
> >>> I'd like to re-propose minimized patch in this thread.
> >>>
> >>> The key fix of this patch is for XMSelection.java. Its initScreen()
> > cleared
> >>> previous XRegisterIMInstantiateCallback() entry, but it should keep
the
> >>> current mask. By this change only, we can reuse Input Method after
> >>> changing focus.
> >>> (Original patch didn't need focus change, but it may be hard to
> > bereviewed.)
> >>>
> >>> Additionally, this change may unveil a potential problem in
> >> awt_InputMethod.c.
> >>> It needs to clear all pX11IMData, not only the current one. Without
> >>> the change,
> >>> multi-window application with IM may crash after IM restart.
> >>>
> >>> So, I'd like to propose only two parts in this thread.
> >>> Can I obtain a sponsor for this minimized fix?
> >>>
> >>> Revised webrev:
> >>> INVALID URI REMOVED
> u=http-3A__cr.openjdk.java.net_-7Etnakamura_8213183_webrev.
> 01_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-
> qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx-
> KQAP0ap59aIgx7JdMXnkMf0&s=78XQhanHugJH88R5X5xh_QIq54Wzi4ZR52f4iTjMhH8&e=
> >>>
> >>> Thanks,
> >>> Toshio Nakamura
> >>>
> >>> From: "Toshio 5 Nakamura" <TOSHIONA at jp.ibm.com>
> >>> To: Sergey Bylokhov <Sergey.Bylokhov at oracle.com>
> >>> Cc: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net
> >>> Date: 2018/11/12 20:22
> >>> Subject: Re: <AWT Dev> [PATCH] JDK-8213183: InputMethod cannot be
> >>> used after its restarting
> >>> Sent by: "awt-dev" <awt-dev-bounces at openjdk.java.net>
> >>>
> >>>
> >>>
> >>> Hi Sergey,
> >>>
> >>> Thank you for your reply. Yes, I've added the steps to the bug.
> >>> INVALID URI REMOVED
>
u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8213183&d=DwICaQ&c=jf_iaSHvJObTbx-

> siA1ZOg&r=EVbFABcgo-X99_TGI2-
> qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx-
> KQAP0ap59aIgx7JdMXnkMf0&s=q6uPI3Ypu4juvcyBI8aEenYXLO-yGglZe9fOzYWHni4&e=
> >>>
> >>> Please let me know if you have any question or any advice.
> >>>
> >>> Thanks,
> >>> Toshio Nakamura
> >>>
> >>> From: Sergey Bylokhov <Sergey.Bylokhov at oracle.com>
> >>> To: Toshio 5 Nakamura <TOSHIONA at jp.ibm.com>, awt-
> >>> dev at openjdk.java.net, i18n-dev at openjdk.java.net
> >>> Date: 2018/11/10 12:46
> >>> Subject: Re: <AWT Dev> [PATCH] JDK-8213183: InputMethod cannot be
> >>> used after its restarting
> >>>
> >>>
> >>>
> >>> Hi, Toshio.
> >>>
> >>> Can you please add the steps to reproduce to the bug description.
> >>>
> >>> On 06/11/2018 01:19, Toshio 5 Nakamura wrote:
> >>>> Hello,
> >>>>
> >>>> Can I obtain a sponsor of this proposal about InputMethod issue on
> > Linux?
> >>>>
> >>>> Bug:
> >>>> INVALID URI REMOVED
>
u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8213183&d=DwICaQ&c=jf_iaSHvJObTbx-

> siA1ZOg&r=EVbFABcgo-X99_TGI2-
> qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx-
> KQAP0ap59aIgx7JdMXnkMf0&s=q6uPI3Ypu4juvcyBI8aEenYXLO-yGglZe9fOzYWHni4&e=
> >>>> Webrev:
> >>>> INVALID URI REMOVED
> u=http-3A__cr.openjdk.java.net_-7Etnakamura_8213183_webrev.
> 00_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-
> qsMtyulHUruf8lAzMlVpVRqw&m=D3pwA4uBvfYfcVDh8rx-
> KQAP0ap59aIgx7JdMXnkMf0&s=7sUCNNIiK-6T-20D0en2W-KJszmeUsMpqdngQxBDafM&e=
> >>>>
> >>>> I've got an author role and filled the bug report.
> >>>> Please refer the attached mail about the detail of this patch.
> >>>>
> >>>> Best Regards,
> >>>> Toshio Nakamura
> >>>
> >>> --
> >>> Best regards, Sergey.
> >>>
>