From rmannibucau at gmail.com  Wed Jan 10 08:48:02 2018
From: rmannibucau at gmail.com (Romain Manni-Bucau)
Date: Wed, 10 Jan 2018 09:48:02 +0100
Subject: <i18n dev> ResourceBundleControlProvider replacement for java 9?
Message-ID: <CACLE=7M7Oq=vHiQFkgMk_SznEbfuyYeAhO1OA5E-PKvdjtW3dQ@mail.gmail.com>

Hi guys,

Opened https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8193680 and
it got closed - not fully sure what was missing - but I got the
recommandation to contact that list on that topic.

The issue is simple: java 8 introduced ResourceBundleControlProvider which
is really nice and allows to replace the resource bundle lookup for all the
app transparently. Concretely in my case I get the translations from a rest
service in one case or - as a fallback - from a specific folder on the
filesystem. You will note that both are outside the application.

I didn't find a way to migrate my application to named modules because
there is no replacement for that feature in java 9 if you are outside
unamed modules. The ResourceBundleProvider was looking like a good
candidate but is too impacting and requires to modify the bundle itself.

Any way to avoid functional regressions and migrate to java 9 named modules?

Thanks,
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau>

From naoto.sato at oracle.com  Wed Jan 10 19:04:30 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Wed, 10 Jan 2018 11:04:30 -0800
Subject: <i18n dev> [11] RFR 8194148: bcp47u/SymbolsTests.java and
 FormatTests.java fail on th_TH locale
Message-ID: <2ac0bd96-3fb4-67a4-aa8d-ad38f13b1c20@oracle.com>

Hello,

Please review a simple test fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8194148

The proposed changeset is located at:

http://cr.openjdk.java.net/~naoto/8194148/webrev.00/

The gist of the issue is that on some test machine, Buddhist calendar is 
the default for th-TH locale. The test case should explicitly specify 
Gregorian for its purpose. Also, fixed an error in SymbolsTests where 
the test class was erroneously set to FormatTests.

Naoto

From naoto.sato at oracle.com  Thu Jan 11 00:39:56 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Wed, 10 Jan 2018 16:39:56 -0800
Subject: <i18n dev> ResourceBundleControlProvider replacement for java 9?
In-Reply-To: <CACLE=7M7Oq=vHiQFkgMk_SznEbfuyYeAhO1OA5E-PKvdjtW3dQ@mail.gmail.com>
References: <CACLE=7M7Oq=vHiQFkgMk_SznEbfuyYeAhO1OA5E-PKvdjtW3dQ@mail.gmail.com>
Message-ID: <a8cf85a6-b4da-e6cf-7bd4-52a1fa7c4d1c@oracle.com>

Hi Romain,

The idea of ResourceBundleControlProvider that silently intercepts 
getBundle of every application on the system is not well fit with the 
module system, especially in terms of resource encapsulation. That's one 
of the reasons behind the decision to disable ResourceBundle.Control in 
named modules. It still works fine with unnamed modules so it's not a 
regression per se.

As you noted below, ResourceBundleProvider serves as the migration path 
for applications that control the loading of resource bundles in named 
modules. I'd suggest trying to migrate your application using the 
interface. Although you need to implement this new interface, the 
contents of your existing resource bundles shouldn't be affected by this 
migration. Mandy has updated the javadoc (not in jdk10, but in the 
current jdk repository) with this issue:

http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8193767/

I hope that would be useful.

Naoto

On 1/10/18 12:48 AM, Romain Manni-Bucau wrote:
> Hi guys,
> 
> Opened https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8193680 and
> it got closed - not fully sure what was missing - but I got the
> recommandation to contact that list on that topic.
> 
> The issue is simple: java 8 introduced ResourceBundleControlProvider which
> is really nice and allows to replace the resource bundle lookup for all the
> app transparently. Concretely in my case I get the translations from a rest
> service in one case or - as a fallback - from a specific folder on the
> filesystem. You will note that both are outside the application.
> 
> I didn't find a way to migrate my application to named modules because
> there is no replacement for that feature in java 9 if you are outside
> unamed modules. The ResourceBundleProvider was looking like a good
> candidate but is too impacting and requires to modify the bundle itself.
> 
> Any way to avoid functional regressions and migrate to java 9 named modules?
> 
> Thanks,
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau>
> 

From rachna.goel at oracle.com  Thu Jan 11 08:15:07 2018
From: rachna.goel at oracle.com (Rachna Goel)
Date: Thu, 11 Jan 2018 13:45:07 +0530
Subject: <i18n dev> [11] RFR of 8146656: Wrong Months Array for
	DateFormatSymbols
In-Reply-To: <46a67401-92e4-09a2-dfdf-2c10a977a71e@oracle.com>
References: <428d88c5-8e79-bae6-f9e0-d2b8fa9c1d46@oracle.com>
 <286bbd77-08ed-bf4c-0ebe-bf7d383e0a90@oracle.com>
 <719413d5-89e4-7ecd-3420-8a2a6ff63910@oracle.com>
 <f6b77b89-1562-92fe-8d38-1bae05c5c0fc@oracle.com>
 <ce6d1824-d8ee-82b7-6a5d-2f309de2757e@oracle.com>
 <46a67401-92e4-09a2-dfdf-2c10a977a71e@oracle.com>
Message-ID: <c50a141c-5bc5-654c-f2ee-bb5902739b64@oracle.com>

Hi Joe,

I have revised this webrev to include your feedback and also updated 
this CSR.

Kindly have a look at :

CSR: https://bugs.openjdk.java.net/browse/JDK-8191414

webrev: http://cr.openjdk.java.net/~rgoel/8146656/webrev.01/

Thanks,

Rachna


On 20/12/17 10:44 PM, joe darcy wrote:
>
> Hi Rachna,
>
> I think the revised version with the @implSpec tag switch is 
> acceptable, but also think providing more text to describe this 
> situation would be helpful to programmers unaware of a 13 month 
> possibility.
>
> Cheers,
>
> -Joe
>
>
> On 12/19/2017 2:08 AM, Rachna Goel wrote:
>>
>> Hi Joe,
>>
>> Thanks for the comments.
>>
>> I have updated the CSR to have @implSpec in place of @implNote.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8191414
>>
>> Regarding  "An array with either 12 or 13 elements will be returned 
>> depending on whether or {@link Calendar.UNDECIMBER} is supported." ,  
>> I would like to go with existing statement as this method always 
>> returns 13 elements where the 13th element may be empty string or may 
>> contain Calendar.UNDECIMBER, depending upon whether its supported by 
>> the Calendar instance.
>>
>> kindly suggest whether this looks fine!
>>
>> Thanks,
>> Rachna
>>
>>
>> On 19/12/17 2:55 PM, joe darcy wrote:
>>> Hi Rachna,
>>>
>>> On 12/19/2017 1:13 AM, Rachna Goel wrote:
>>>>
>>>> Hello Joe,
>>>>
>>>> Thanks for the review.
>>>>
>>>> Reason I added @implNote is that it's the case for the default 
>>>> implementation. Not added as a part of spec, as some implementation 
>>>> can just return 12 element array for same methods through the 
>>>> "java.text.spi.DateFormatSymbolsProvider" SPI.
>>>>
>>>>
>>>
>>> That is precisely the sort of situation the @implSpec tag is 
>>> intended for. It allows the specification to say DateFormatSymbols 
>>> must behave this way while allowing subclasses to behave differently.
>>>
>>> Perhaps some general text can be added as normal specification, 
>>> something like
>>>
>>> "An array with either 12 or 13 elements will be returned depending 
>>> on whether or {@link Calendar.UNDECIMBER} is supported."
>>>
>>> paired with
>>>
>>> @implSpec This method returns 13 elements since @link 
>>> Calendar.UNDECIMBER} is supported.
>>>
>>> HTH,
>>>
>>> -Joe
>>>
>>
>> -- 
>> Thanks,
>> Rachna
>

-- 
Thanks,
Rachna


From naoto.sato at oracle.com  Thu Jan 11 18:31:06 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Thu, 11 Jan 2018 10:31:06 -0800
Subject: <i18n dev> ResourceBundleControlProvider replacement for java 9?
In-Reply-To: <CACLE=7NZugj4DueV_npn+ku8bXQaFuMN5XJ_VJt47pnjQMZ4TA@mail.gmail.com>
References: <CACLE=7M7Oq=vHiQFkgMk_SznEbfuyYeAhO1OA5E-PKvdjtW3dQ@mail.gmail.com>
 <a8cf85a6-b4da-e6cf-7bd4-52a1fa7c4d1c@oracle.com>
 <CACLE=7NZugj4DueV_npn+ku8bXQaFuMN5XJ_VJt47pnjQMZ4TA@mail.gmail.com>
Message-ID: <8c9ad5cf-dc48-cc5e-4476-df6eb9d09a63@oracle.com>

So your use case of RBControlProvider is basically to direct third party 
libraries, not the application itself, to load their resource bundles as 
your app desires? What kind of alteration does your Control do to the 
original loading?

Naoto

On 1/10/18 9:49 PM, Romain Manni-Bucau wrote:
> Hello Naoto,
> 
> Some comments inline
> 
> Le?11 janv. 2018 01:40, "Naoto Sato" <naoto.sato at oracle.com 
> <mailto:naoto.sato at oracle.com>> a ?crit?:
> 
>     Hi Romain,
> 
>     The idea of ResourceBundleControlProvider that silently intercepts
>     getBundle of every application on the system is not well fit with
>     the module system, especially in terms of resource encapsulation.
>     That's one of the reasons behind the decision to disable
>     ResourceBundle.Control in named modules. It still works fine with
>     unnamed modules so it's not a regression per se.
> 
> 
> Well, being said unamed modules have been introduced to mitigate the 
> breakage java 9 modules do, not being able to migrate is a functional 
> regression (as "i can't implement it natively anymore").
> 
> Also note that it prevents applications to upgrade dependencies if they 
> now use a module-info and therefore breaks the original implementation.
> 
> Technically there is no blocker to support the java 8 API too so maybe a 
> JVM flag to support it in named module could be acceptable?
> 
> 
>     As you noted below, ResourceBundleProvider serves as the migration
>     path for applications that control the loading of resource bundles
>     in named modules. I'd suggest trying to migrate your application
>     using the interface. Although you need to implement this new
>     interface, the contents of your existing resource bundles shouldn't
>     be affected by this migration. Mandy has updated the javadoc (not in
>     jdk10, but in the current jdk repository) with this issue:
> 
>     http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8193767/
>     <http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8193767/>
> 
>     I hope that would be useful.
> 
> 
> Only way to be functionally equivalent I see - hope I miss another way - 
> is to implement a javaagent or init before the actual main and check all 
> jars to unpack/pack them adding the new provider which defeats 
> completely the original feature which can plug a lookup strategy 
> globally *for the app/JVM* without having to modify libraries packaging.
> 
> 
> 
> 
>     Naoto
> 
>     On 1/10/18 12:48 AM, Romain Manni-Bucau wrote:
> 
>         Hi guys,
> 
>         Opened
>         https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8193680
>         <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8193680>
>         and
>         it got closed - not fully sure what was missing - but I got the
>         recommandation to contact that list on that topic.
> 
>         The issue is simple: java 8 introduced
>         ResourceBundleControlProvider which
>         is really nice and allows to replace the resource bundle lookup
>         for all the
>         app transparently. Concretely in my case I get the translations
>         from a rest
>         service in one case or - as a fallback - from a specific folder
>         on the
>         filesystem. You will note that both are outside the application.
> 
>         I didn't find a way to migrate my application to named modules
>         because
>         there is no replacement for that feature in java 9 if you are
>         outside
>         unamed modules. The ResourceBundleProvider was looking like a good
>         candidate but is too impacting and requires to modify the bundle
>         itself.
> 
>         Any way to avoid functional regressions and migrate to java 9
>         named modules?
> 
>         Thanks,
>         Romain Manni-Bucau
>         @rmannibucau <https://twitter.com/rmannibucau
>         <https://twitter.com/rmannibucau>> |? Blog
>         <https://rmannibucau.metawerx.net/
>         <https://rmannibucau.metawerx.net/>> | Old Blog
>         <http://rmannibucau.wordpress.com
>         <http://rmannibucau.wordpress.com>> | Github
>         <https://github.com/rmannibucau <https://github.com/rmannibucau>> |
>         LinkedIn <https://www.linkedin.com/in/rmannibucau
>         <https://www.linkedin.com/in/rmannibucau>>
> 
> 

From naoto.sato at oracle.com  Fri Jan 12 19:01:13 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Fri, 12 Jan 2018 11:01:13 -0800
Subject: <i18n dev> ResourceBundleControlProvider replacement for java 9?
In-Reply-To: <CACLE=7Px7Z5F=TO+i9rpVE_0hKwvFwmzRGj6Qd=Onr7Ts6nGzw@mail.gmail.com>
References: <CACLE=7M7Oq=vHiQFkgMk_SznEbfuyYeAhO1OA5E-PKvdjtW3dQ@mail.gmail.com>
 <a8cf85a6-b4da-e6cf-7bd4-52a1fa7c4d1c@oracle.com>
 <CACLE=7NZugj4DueV_npn+ku8bXQaFuMN5XJ_VJt47pnjQMZ4TA@mail.gmail.com>
 <8c9ad5cf-dc48-cc5e-4476-df6eb9d09a63@oracle.com>
 <CACLE=7Px7Z5F=TO+i9rpVE_0hKwvFwmzRGj6Qd=Onr7Ts6nGzw@mail.gmail.com>
Message-ID: <46fe66f9-40df-30eb-bcb0-2fe6ca95207f@oracle.com>

I was under the impression that the libraries you mentioned were from 
third parties that you cannot get access to the source. Looks like it's 
not that case, so I still believe you can migrate your applications and 
libraries with ResourceBundleProvider. Would you prototype migrating 
your app and see if there is any technical obstacles?

Naoto

On 1/11/18 12:13 PM, Romain Manni-Bucau wrote:
> Kind of. The applications being comple ones involving N teams it handles 
> all the company code translations which is a lot of libraries in final 
> applications. Also translation being handled by a specific team, we cant 
> pollute all jars with properties.
> 
> Le?11 janv. 2018 19:33, "Naoto Sato" <naoto.sato at oracle.com 
> <mailto:naoto.sato at oracle.com>> a ?crit?:
> 
>     So your use case of RBControlProvider is basically to direct third
>     party libraries, not the application itself, to load their resource
>     bundles as your app desires? What kind of alteration does your
>     Control do to the original loading?
> 
>     Naoto
> 
>     On 1/10/18 9:49 PM, Romain Manni-Bucau wrote:
> 
>         Hello Naoto,
> 
>         Some comments inline
> 
>         Le?11 janv. 2018 01:40, "Naoto Sato" <naoto.sato at oracle.com
>         <mailto:naoto.sato at oracle.com> <mailto:naoto.sato at oracle.com
>         <mailto:naoto.sato at oracle.com>>> a ?crit?:
> 
>          ? ? Hi Romain,
> 
>          ? ? The idea of ResourceBundleControlProvider that silently
>         intercepts
>          ? ? getBundle of every application on the system is not well
>         fit with
>          ? ? the module system, especially in terms of resource
>         encapsulation.
>          ? ? That's one of the reasons behind the decision to disable
>          ? ? ResourceBundle.Control in named modules. It still works
>         fine with
>          ? ? unnamed modules so it's not a regression per se.
> 
> 
>         Well, being said unamed modules have been introduced to mitigate
>         the breakage java 9 modules do, not being able to migrate is a
>         functional regression (as "i can't implement it natively anymore").
> 
>         Also note that it prevents applications to upgrade dependencies
>         if they now use a module-info and therefore breaks the original
>         implementation.
> 
>         Technically there is no blocker to support the java 8 API too so
>         maybe a JVM flag to support it in named module could be acceptable?
> 
> 
>          ? ? As you noted below, ResourceBundleProvider serves as the
>         migration
>          ? ? path for applications that control the loading of resource
>         bundles
>          ? ? in named modules. I'd suggest trying to migrate your
>         application
>          ? ? using the interface. Although you need to implement this new
>          ? ? interface, the contents of your existing resource bundles
>         shouldn't
>          ? ? be affected by this migration. Mandy has updated the
>         javadoc (not in
>          ? ? jdk10, but in the current jdk repository) with this issue:
> 
>         http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8193767/
>         <http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8193767/>
>          ? ? <http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8193767/
>         <http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8193767/>>
> 
>          ? ? I hope that would be useful.
> 
> 
>         Only way to be functionally equivalent I see - hope I miss
>         another way - is to implement a javaagent or init before the
>         actual main and check all jars to unpack/pack them adding the
>         new provider which defeats completely the original feature which
>         can plug a lookup strategy globally *for the app/JVM* without
>         having to modify libraries packaging.
> 
> 
> 
> 
>          ? ? Naoto
> 
>          ? ? On 1/10/18 12:48 AM, Romain Manni-Bucau wrote:
> 
>          ? ? ? ? Hi guys,
> 
>          ? ? ? ? Opened
>         https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8193680
>         <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8193680>
>                 
>         <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8193680 <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8193680>>
>          ? ? ? ? and
>          ? ? ? ? it got closed - not fully sure what was missing - but I
>         got the
>          ? ? ? ? recommandation to contact that list on that topic.
> 
>          ? ? ? ? The issue is simple: java 8 introduced
>          ? ? ? ? ResourceBundleControlProvider which
>          ? ? ? ? is really nice and allows to replace the resource
>         bundle lookup
>          ? ? ? ? for all the
>          ? ? ? ? app transparently. Concretely in my case I get the
>         translations
>          ? ? ? ? from a rest
>          ? ? ? ? service in one case or - as a fallback - from a
>         specific folder
>          ? ? ? ? on the
>          ? ? ? ? filesystem. You will note that both are outside the
>         application.
> 
>          ? ? ? ? I didn't find a way to migrate my application to named
>         modules
>          ? ? ? ? because
>          ? ? ? ? there is no replacement for that feature in java 9 if
>         you are
>          ? ? ? ? outside
>          ? ? ? ? unamed modules. The ResourceBundleProvider was looking
>         like a good
>          ? ? ? ? candidate but is too impacting and requires to modify
>         the bundle
>          ? ? ? ? itself.
> 
>          ? ? ? ? Any way to avoid functional regressions and migrate to
>         java 9
>          ? ? ? ? named modules?
> 
>          ? ? ? ? Thanks,
>          ? ? ? ? Romain Manni-Bucau
>          ? ? ? ? @rmannibucau <https://twitter.com/rmannibucau
>         <https://twitter.com/rmannibucau>
>          ? ? ? ? <https://twitter.com/rmannibucau
>         <https://twitter.com/rmannibucau>>> |? Blog
>          ? ? ? ? <https://rmannibucau.metawerx.net/
>         <https://rmannibucau.metawerx.net/>
>          ? ? ? ? <https://rmannibucau.metawerx.net/
>         <https://rmannibucau.metawerx.net/>>> | Old Blog
>          ? ? ? ? <http://rmannibucau.wordpress.com
>         <http://rmannibucau.wordpress.com>
>          ? ? ? ? <http://rmannibucau.wordpress.com
>         <http://rmannibucau.wordpress.com>>> | Github
>          ? ? ? ? <https://github.com/rmannibucau
>         <https://github.com/rmannibucau> <https://github.com/rmannibucau
>         <https://github.com/rmannibucau>>> |
>          ? ? ? ? LinkedIn <https://www.linkedin.com/in/rmannibucau
>         <https://www.linkedin.com/in/rmannibucau>
>          ? ? ? ? <https://www.linkedin.com/in/rmannibucau
>         <https://www.linkedin.com/in/rmannibucau>>>
> 
> 

From mandy.chung at oracle.com  Fri Jan 12 19:07:50 2018
From: mandy.chung at oracle.com (mandy chung)
Date: Fri, 12 Jan 2018 11:07:50 -0800
Subject: <i18n dev> ResourceBundleControlProvider replacement for java 9?
In-Reply-To: <46fe66f9-40df-30eb-bcb0-2fe6ca95207f@oracle.com>
References: <CACLE=7M7Oq=vHiQFkgMk_SznEbfuyYeAhO1OA5E-PKvdjtW3dQ@mail.gmail.com>
 <a8cf85a6-b4da-e6cf-7bd4-52a1fa7c4d1c@oracle.com>
 <CACLE=7NZugj4DueV_npn+ku8bXQaFuMN5XJ_VJt47pnjQMZ4TA@mail.gmail.com>
 <8c9ad5cf-dc48-cc5e-4476-df6eb9d09a63@oracle.com>
 <CACLE=7Px7Z5F=TO+i9rpVE_0hKwvFwmzRGj6Qd=Onr7Ts6nGzw@mail.gmail.com>
 <46fe66f9-40df-30eb-bcb0-2fe6ca95207f@oracle.com>
Message-ID: <14a4a64d-eedc-606f-0f50-c906247a9000@oracle.com>

Hi Romain,

I expect no impact to the translation process. Can you give an example 
of one resource bundle and its packaged artifact and where the localized 
bundles are packaged?

As Naoto suggests, it would be helpful to migrate one resource bundle to 
ResourceBundleProvider as an exercise that will provide insight the 
migration cost you are concerned about.

Mandy

On 1/12/18 11:01 AM, Naoto Sato wrote:
> I was under the impression that the libraries you mentioned were from 
> third parties that you cannot get access to the source. Looks like 
> it's not that case, so I still believe you can migrate your 
> applications and libraries with ResourceBundleProvider. Would you 
> prototype migrating your app and see if there is any technical obstacles?
>
> Naoto
>
> On 1/11/18 12:13 PM, Romain Manni-Bucau wrote:
>> Kind of. The applications being comple ones involving N teams it 
>> handles all the company code translations which is a lot of libraries 
>> in final applications. Also translation being handled by a specific 
>> team, we cant pollute all jars with properties.
>>
>> Le?11 janv. 2018 19:33, "Naoto Sato" <naoto.sato at oracle.com 
>> <mailto:naoto.sato at oracle.com>> a ?crit?:
>>
>> ??? So your use case of RBControlProvider is basically to direct third
>> ??? party libraries, not the application itself, to load their resource
>> ??? bundles as your app desires? What kind of alteration does your
>> ??? Control do to the original loading?
>>
>> ??? Naoto
>>
>> ??? On 1/10/18 9:49 PM, Romain Manni-Bucau wrote:
>>
>> ??????? Hello Naoto,
>>
>> ??????? Some comments inline
>>
>> ??????? Le?11 janv. 2018 01:40, "Naoto Sato" <naoto.sato at oracle.com
>> ??????? <mailto:naoto.sato at oracle.com> <mailto:naoto.sato at oracle.com
>> ??????? <mailto:naoto.sato at oracle.com>>> a ?crit?:
>>
>> ???????? ? ? Hi Romain,
>>
>> ???????? ? ? The idea of ResourceBundleControlProvider that silently
>> ??????? intercepts
>> ???????? ? ? getBundle of every application on the system is not well
>> ??????? fit with
>> ???????? ? ? the module system, especially in terms of resource
>> ??????? encapsulation.
>> ???????? ? ? That's one of the reasons behind the decision to disable
>> ???????? ? ? ResourceBundle.Control in named modules. It still works
>> ??????? fine with
>> ???????? ? ? unnamed modules so it's not a regression per se.
>>
>>
>> ??????? Well, being said unamed modules have been introduced to mitigate
>> ??????? the breakage java 9 modules do, not being able to migrate is a
>> ??????? functional regression (as "i can't implement it natively 
>> anymore").
>>
>> ??????? Also note that it prevents applications to upgrade dependencies
>> ??????? if they now use a module-info and therefore breaks the original
>> ??????? implementation.
>>
>> ??????? Technically there is no blocker to support the java 8 API too so
>> ??????? maybe a JVM flag to support it in named module could be 
>> acceptable?
>>
>>
>> ???????? ? ? As you noted below, ResourceBundleProvider serves as the
>> ??????? migration
>> ???????? ? ? path for applications that control the loading of resource
>> ??????? bundles
>> ???????? ? ? in named modules. I'd suggest trying to migrate your
>> ??????? application
>> ???????? ? ? using the interface. Although you need to implement this 
>> new
>> ???????? ? ? interface, the contents of your existing resource bundles
>> ??????? shouldn't
>> ???????? ? ? be affected by this migration. Mandy has updated the
>> ??????? javadoc (not in
>> ???????? ? ? jdk10, but in the current jdk repository) with this issue:
>>
>> http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8193767/
>> <http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8193767/>
>> <http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8193767/
>> <http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8193767/>>
>>
>> ???????? ? ? I hope that would be useful.
>>
>>
>> ??????? Only way to be functionally equivalent I see - hope I miss
>> ??????? another way - is to implement a javaagent or init before the
>> ??????? actual main and check all jars to unpack/pack them adding the
>> ??????? new provider which defeats completely the original feature which
>> ??????? can plug a lookup strategy globally *for the app/JVM* without
>> ??????? having to modify libraries packaging.
>>
>>
>>
>>
>> ???????? ? ? Naoto
>>
>> ???????? ? ? On 1/10/18 12:48 AM, Romain Manni-Bucau wrote:
>>
>> ???????? ? ? ? ? Hi guys,
>>
>> ???????? ? ? ? ? Opened
>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8193680
>> <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8193680>
>> <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8193680 
>> <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8193680>>
>> ???????? ? ? ? ? and
>> ???????? ? ? ? ? it got closed - not fully sure what was missing - but I
>> ??????? got the
>> ???????? ? ? ? ? recommandation to contact that list on that topic.
>>
>> ???????? ? ? ? ? The issue is simple: java 8 introduced
>> ???????? ? ? ? ? ResourceBundleControlProvider which
>> ???????? ? ? ? ? is really nice and allows to replace the resource
>> ??????? bundle lookup
>> ???????? ? ? ? ? for all the
>> ???????? ? ? ? ? app transparently. Concretely in my case I get the
>> ??????? translations
>> ???????? ? ? ? ? from a rest
>> ???????? ? ? ? ? service in one case or - as a fallback - from a
>> ??????? specific folder
>> ???????? ? ? ? ? on the
>> ???????? ? ? ? ? filesystem. You will note that both are outside the
>> ??????? application.
>>
>> ???????? ? ? ? ? I didn't find a way to migrate my application to named
>> ??????? modules
>> ???????? ? ? ? ? because
>> ???????? ? ? ? ? there is no replacement for that feature in java 9 if
>> ??????? you are
>> ???????? ? ? ? ? outside
>> ???????? ? ? ? ? unamed modules. The ResourceBundleProvider was looking
>> ??????? like a good
>> ???????? ? ? ? ? candidate but is too impacting and requires to modify
>> ??????? the bundle
>> ???????? ? ? ? ? itself.
>>
>> ???????? ? ? ? ? Any way to avoid functional regressions and migrate to
>> ??????? java 9
>> ???????? ? ? ? ? named modules?
>>
>> ???????? ? ? ? ? Thanks,
>> ???????? ? ? ? ? Romain Manni-Bucau
>> ???????? ? ? ? ? @rmannibucau <https://twitter.com/rmannibucau
>> ??????? <https://twitter.com/rmannibucau>
>> ???????? ? ? ? ? <https://twitter.com/rmannibucau
>> ??????? <https://twitter.com/rmannibucau>>> |? Blog
>> ???????? ? ? ? ? <https://rmannibucau.metawerx.net/
>> ??????? <https://rmannibucau.metawerx.net/>
>> ???????? ? ? ? ? <https://rmannibucau.metawerx.net/
>> ??????? <https://rmannibucau.metawerx.net/>>> | Old Blog
>> ???????? ? ? ? ? <http://rmannibucau.wordpress.com
>> ??????? <http://rmannibucau.wordpress.com>
>> ???????? ? ? ? ? <http://rmannibucau.wordpress.com
>> ??????? <http://rmannibucau.wordpress.com>>> | Github
>> ???????? ? ? ? ? <https://github.com/rmannibucau
>> ??????? <https://github.com/rmannibucau> <https://github.com/rmannibucau
>> ??????? <https://github.com/rmannibucau>>> |
>> ???????? ? ? ? ? LinkedIn <https://www.linkedin.com/in/rmannibucau
>> ??????? <https://www.linkedin.com/in/rmannibucau>
>> ???????? ? ? ? ? <https://www.linkedin.com/in/rmannibucau
>> ??????? <https://www.linkedin.com/in/rmannibucau>>>
>>
>>


From mandy.chung at oracle.com  Fri Jan 12 20:06:14 2018
From: mandy.chung at oracle.com (mandy chung)
Date: Fri, 12 Jan 2018 12:06:14 -0800
Subject: <i18n dev> ResourceBundleControlProvider replacement for java 9?
In-Reply-To: <CACLE=7MYwZgsinA9ys8Noxvw9MUSfq4+bind2J5_cSqZCDVr+Q@mail.gmail.com>
References: <CACLE=7M7Oq=vHiQFkgMk_SznEbfuyYeAhO1OA5E-PKvdjtW3dQ@mail.gmail.com>
 <a8cf85a6-b4da-e6cf-7bd4-52a1fa7c4d1c@oracle.com>
 <CACLE=7NZugj4DueV_npn+ku8bXQaFuMN5XJ_VJt47pnjQMZ4TA@mail.gmail.com>
 <8c9ad5cf-dc48-cc5e-4476-df6eb9d09a63@oracle.com>
 <CACLE=7Px7Z5F=TO+i9rpVE_0hKwvFwmzRGj6Qd=Onr7Ts6nGzw@mail.gmail.com>
 <46fe66f9-40df-30eb-bcb0-2fe6ca95207f@oracle.com>
 <14a4a64d-eedc-606f-0f50-c906247a9000@oracle.com>
 <CACLE=7MYwZgsinA9ys8Noxvw9MUSfq4+bind2J5_cSqZCDVr+Q@mail.gmail.com>
Message-ID: <3e2bba41-3173-3bba-eb60-0e7551aa1433@oracle.com>



On 1/12/18 11:41 AM, Romain Manni-Bucau wrote:
> Hello
>
> Comments inline
>
> Le?12 janv. 2018 20:07, "mandy chung" <mandy.chung at oracle.com 
> <mailto:mandy.chung at oracle.com>> a ?crit?:
>
>     Hi Romain,
>
>     I expect no impact to the translation process. Can you give an
>     example of one resource bundle and its packaged artifact and where
>     the localized bundles are packaged?
>
>
> Sure
>
> /opt/App/lib
> ? |- team1.jar/com.company.team1.service
> ? |- team2.jar/com.company.team2.service
> ? `- classes/com.company.team3.service
>

Where is the root resource bundle?? Can you give a name and which is the 
application calling getBundle("abc")?

Which one you want to migrate as modules?

Mandy
>
> Assuming service packages use a resource bundle.
>
> Now translations are in http://i18n.company.com/translations and the 
> team providing the key/values is team4 with no access to team1, team2 
> and team3 sources normally.
>
> That is why the only solution I saw was a javaagent or mvn plugin 
> repackaging the app to add bundle providers on the fly but it is not 
> satisfying compared to java 8 solution :(. It is also not trivial to 
> do it at build time since it assumes you know the packages at compile 
> time which can not be the case with such an atchitecture, allowing to 
> provide translations after a deployment through the service. Doing it 
> at runtime requires to create another root classloader since you 
> recreate jars...not satisfying too.
>
> Any solution? Is adding a -XsupportControlProviderForNamedModules not 
> doable at all?
>


From mandy.chung at oracle.com  Fri Jan 12 23:21:56 2018
From: mandy.chung at oracle.com (mandy chung)
Date: Fri, 12 Jan 2018 15:21:56 -0800
Subject: <i18n dev> ResourceBundleControlProvider replacement for java 9?
In-Reply-To: <CACLE=7MRmgjd5HvHPUDQT88kJHDJw8qo0Ehhg=XVhSCtDZ8YxA@mail.gmail.com>
References: <CACLE=7M7Oq=vHiQFkgMk_SznEbfuyYeAhO1OA5E-PKvdjtW3dQ@mail.gmail.com>
 <a8cf85a6-b4da-e6cf-7bd4-52a1fa7c4d1c@oracle.com>
 <CACLE=7NZugj4DueV_npn+ku8bXQaFuMN5XJ_VJt47pnjQMZ4TA@mail.gmail.com>
 <8c9ad5cf-dc48-cc5e-4476-df6eb9d09a63@oracle.com>
 <CACLE=7Px7Z5F=TO+i9rpVE_0hKwvFwmzRGj6Qd=Onr7Ts6nGzw@mail.gmail.com>
 <46fe66f9-40df-30eb-bcb0-2fe6ca95207f@oracle.com>
 <14a4a64d-eedc-606f-0f50-c906247a9000@oracle.com>
 <CACLE=7MYwZgsinA9ys8Noxvw9MUSfq4+bind2J5_cSqZCDVr+Q@mail.gmail.com>
 <3e2bba41-3173-3bba-eb60-0e7551aa1433@oracle.com>
 <CACLE=7MRmgjd5HvHPUDQT88kJHDJw8qo0Ehhg=XVhSCtDZ8YxA@mail.gmail.com>
Message-ID: <c30325e4-477d-f2c6-50d9-4ef40a0b3df1@oracle.com>

Let me try to see if I understand your situation correctly.


On 1/12/18 12:59 PM, Romain Manni-Bucau wrote:
> All are com.company.*
>
>>
>> Assuming service packages use a resource bundle.
>>

team1, team2, team3 all uses a resource bundle.? Let's say 
com.company.team1.service calls 
ResourceBundle.getBundle("com.company.resources.Team1").



>>     Now translations are in http://i18n.company.com/translations
>>     <http://i18n.company.com/translations> and the team providing the
>>     key/values is team4 with no access to team1, team2 and team3
>>     sources normally.
>>

team4 provides the key/values of "com.company.resources.Team1". team4 
and team1 will agree on the content of this resource bundle e.g. key 
names and the value if any text format.

I assume your ResourceBundleControlProvider implementation returns a 
Control instance that implements newBundle method to return a 
ResourceBundle for
"com.company.resources.Team1".

One migration solution is to use ResourceBundleProvider.? The steps it 
takes are
(1) define a SPI for each bundle named 
com.company.resources.spi.Team1Provider
(2) reuse your existing Control.newBundle implementation to implement
ResourceBundleProvider::getBundle to return the requested 
ResourceBundle.? This assumes in team4 module
(3) when migrating team1.jar to a named module, the module definition 
declares uses com.company.resources.spi.Team1Provider

team4 module can have one single provider implementation for more than 
one resource bundle.

Does this help?? I can see it takes some amount of work.? How many 
resource bundles do your application have?? It'd be good if you give a 
try and send us feedback.

Mandy

From li.jiang at oracle.com  Sat Jan 13 02:22:57 2018
From: li.jiang at oracle.com (Leo Jiang)
Date: Sat, 13 Jan 2018 10:22:57 +0800
Subject: <i18n dev> [10] RFR: 8187946 : Support ISO 4217 Amendments 163
	and 164
In-Reply-To: <c3621505-fb49-23ae-4c63-2c6e0f2448ef@oracle.com>
References: <8f841d1a-009a-dfec-eb12-fc2b93abfa62@oracle.com>
 <c3621505-fb49-23ae-4c63-2c6e0f2448ef@oracle.com>
Message-ID: <53c151af-d34e-6991-cd6c-d42a65a1fbb1@oracle.com>

Hi Naoto,

Thank you for review.

- Added the updates for currency names, removed the cut-over time for STN.
- For compatibility reason, we don't update the historic currencies.

Test passed.

Please find the revised webrev:
http://cr.openjdk.java.net/~ljiang/8187946/webrev.01/

Thanks,
Leo


On 01/13/2018 04:13 AM, Naoto Sato wrote:
> Hi Leo,
> 
> Here are my comments:
> 
> (for amendments 163)
> 
> - Names not reflected correctly: "Azerbaijan Manat", "Lao Kip".
> 
> (for amendments 164)
> - Since it's already passed the transition date for STN, you don't need to use the transition format (at line 
> 473:CurrencyData.properties)
> 
> - Lacking the Philippines currency name change: "Amended currency name for PHILIPPINES (THE): Philippine Piso (instead 
> of Peso)"
> 
> - Lacking historic currency changes, e.g., ALBANIA-Old_Lek-ALK-008.
> 
> Naoto
> 
> On 1/12/18 6:51 AM, Leo Jiang wrote:
>> Hi,
>>
>> Please review the currency data update to support ISO 4217 Amendments 163 and 164.
>>
>> Please refer the pdf files in bug description for details of this update. In short, we need to update the STD to STN 
>> and its numeric name, as well as adding a cut-over time for them.
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8187946
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ljiang/8187946/webrev.00/
>>
>> Built and test passed on Mach5.
>>
>> Thanks,
>> Leo

From mandy.chung at oracle.com  Sat Jan 13 17:05:43 2018
From: mandy.chung at oracle.com (mandy chung)
Date: Sat, 13 Jan 2018 09:05:43 -0800
Subject: <i18n dev> ResourceBundleControlProvider replacement for java 9?
In-Reply-To: <CACLE=7O3RLZ9sbTgOie5kc3n7XyLptSpnvQc9jm9f=n+FnDhjg@mail.gmail.com>
References: <CACLE=7M7Oq=vHiQFkgMk_SznEbfuyYeAhO1OA5E-PKvdjtW3dQ@mail.gmail.com>
 <a8cf85a6-b4da-e6cf-7bd4-52a1fa7c4d1c@oracle.com>
 <CACLE=7NZugj4DueV_npn+ku8bXQaFuMN5XJ_VJt47pnjQMZ4TA@mail.gmail.com>
 <8c9ad5cf-dc48-cc5e-4476-df6eb9d09a63@oracle.com>
 <CACLE=7Px7Z5F=TO+i9rpVE_0hKwvFwmzRGj6Qd=Onr7Ts6nGzw@mail.gmail.com>
 <46fe66f9-40df-30eb-bcb0-2fe6ca95207f@oracle.com>
 <14a4a64d-eedc-606f-0f50-c906247a9000@oracle.com>
 <CACLE=7MYwZgsinA9ys8Noxvw9MUSfq4+bind2J5_cSqZCDVr+Q@mail.gmail.com>
 <3e2bba41-3173-3bba-eb60-0e7551aa1433@oracle.com>
 <CACLE=7MRmgjd5HvHPUDQT88kJHDJw8qo0Ehhg=XVhSCtDZ8YxA@mail.gmail.com>
 <c30325e4-477d-f2c6-50d9-4ef40a0b3df1@oracle.com>
 <CACLE=7O3RLZ9sbTgOie5kc3n7XyLptSpnvQc9jm9f=n+FnDhjg@mail.gmail.com>
Message-ID: <55cc1a33-f8f7-0032-0ab0-b3ca0b4bcbf5@oracle.com>

team1 has a dependency com.company.resources.spi.Team1Provider which can 
be in a separate module (say com.company.resources module) and the 
provider implementation will be in team4.? i.e. team1 and team4 both 
requires com.company.resources module.


Mandy

On 1/12/18 11:14 PM, Romain Manni-Bucau wrote:
> Hi Mandy,
>
> 3 is the blocker because it creates a dependency to team4 which 
> shouldnt be visible. It is provided as a container service if you want 
> and other teams have no dependency on it. This means if we need to 
> upgrade team4 code then the operation team does it and team1, 2, 3 are 
> not affected at all.
>
> In terms of costs it must stay the same. I can imagine a light SPI but 
> it already breaks this "container service" rule, plus it requires to 
> define hundreds of new classes.
>
> Using a custom classloader with no named module can be a short term 
> workaround but is broken if modules use module-info only to define a 
> SPI for instance.
>
>
> Le?13 janv. 2018 00:21, "mandy chung" <mandy.chung at oracle.com 
> <mailto:mandy.chung at oracle.com>> a ?crit?:
>
>     Let me try to see if I understand your situation correctly.
>
>
>     On 1/12/18 12:59 PM, Romain Manni-Bucau wrote:
>>     All are com.company.*
>>
>>
>>>
>>>     Assuming service packages use a resource bundle.
>>>
>
>     team1, team2, team3 all uses a resource bundle. Let's say
>     com.company.team1.service calls
>     ResourceBundle.getBundle("com.company.resources.Team1").
>
>
>
>>>         Now translations are in http://i18n.company.com/translations
>>>         <http://i18n.company.com/translations> and the team
>>>         providing the key/values is team4 with no access to team1,
>>>         team2 and team3 sources normally.
>>>
>
>     team4 provides the key/values of "com.company.resources.Team1".?
>     team4 and team1 will agree on the content of this resource bundle
>     e.g. key names and the value if any text format.
>
>     I assume your ResourceBundleControlProvider implementation returns
>     a Control instance that implements newBundle method to return a
>     ResourceBundle for
>     "com.company.resources.Team1".
>
>     One migration solution is to use ResourceBundleProvider.? The
>     steps it takes are
>     (1) define a SPI for each bundle named
>     com.company.resources.spi.Team1Provider
>     (2) reuse your existing Control.newBundle implementation to implement
>     ResourceBundleProvider::getBundle to return the requested
>     ResourceBundle. This assumes in team4 module
>     (3) when migrating team1.jar to a named module, the module
>     definition declares uses com.company.resources.spi.Team1Provider
>
>     team4 module can have one single provider implementation for more
>     than one resource bundle.
>
>     Does this help?? I can see it takes some amount of work.? How many
>     resource bundles do your application have?? It'd be good if you
>     give a try and send us feedback.
>
>     Mandy
>
>


From mandy.chung at oracle.com  Sat Jan 13 19:35:48 2018
From: mandy.chung at oracle.com (mandy chung)
Date: Sat, 13 Jan 2018 11:35:48 -0800
Subject: <i18n dev> ResourceBundleControlProvider replacement for java 9?
In-Reply-To: <CACLE=7Nf1VXfBRR0ovQnAT_L19Csufxd8fK=Zy7Qyzh_2sA6gQ@mail.gmail.com>
References: <CACLE=7M7Oq=vHiQFkgMk_SznEbfuyYeAhO1OA5E-PKvdjtW3dQ@mail.gmail.com>
 <a8cf85a6-b4da-e6cf-7bd4-52a1fa7c4d1c@oracle.com>
 <CACLE=7NZugj4DueV_npn+ku8bXQaFuMN5XJ_VJt47pnjQMZ4TA@mail.gmail.com>
 <8c9ad5cf-dc48-cc5e-4476-df6eb9d09a63@oracle.com>
 <CACLE=7Px7Z5F=TO+i9rpVE_0hKwvFwmzRGj6Qd=Onr7Ts6nGzw@mail.gmail.com>
 <46fe66f9-40df-30eb-bcb0-2fe6ca95207f@oracle.com>
 <14a4a64d-eedc-606f-0f50-c906247a9000@oracle.com>
 <CACLE=7MYwZgsinA9ys8Noxvw9MUSfq4+bind2J5_cSqZCDVr+Q@mail.gmail.com>
 <3e2bba41-3173-3bba-eb60-0e7551aa1433@oracle.com>
 <CACLE=7MRmgjd5HvHPUDQT88kJHDJw8qo0Ehhg=XVhSCtDZ8YxA@mail.gmail.com>
 <c30325e4-477d-f2c6-50d9-4ef40a0b3df1@oracle.com>
 <CACLE=7O3RLZ9sbTgOie5kc3n7XyLptSpnvQc9jm9f=n+FnDhjg@mail.gmail.com>
 <55cc1a33-f8f7-0032-0ab0-b3ca0b4bcbf5@oracle.com>
 <CACLE=7Nf1VXfBRR0ovQnAT_L19Csufxd8fK=Zy7Qyzh_2sA6gQ@mail.gmail.com>
Message-ID: <ba756669-7635-c46e-cd83-483fdd1fe3b8@oracle.com>



On 1/13/18 9:09 AM, Romain Manni-Bucau wrote:
> Which is where it doesnt work at all because team i < 4 should not 
> know anything of team4 code and they cant depend on something created 
> after they package which is the case today.
>

There must be a contract on the name of the resource bundle and the name 
and semantic of the keys.? Such dependency already exists.? I don't 
understand why it's critical to avoid any dependency on the new SPI 
classes and this new SPI class represents the bundle name you hardcoded 
in the code that calls getBundle.

Mandy

> Said otherwise: being transversal is not possible with modules which 
> should be fixed IMHO.
>
> Just for my knowledge: why adding a flag is not an option?
>
> Le?13 janv. 2018 18:05, "mandy chung" <mandy.chung at oracle.com 
> <mailto:mandy.chung at oracle.com>> a ?crit?:
>
>     team1 has a dependency com.company.resources.spi.Team1Provider
>     which can be in a separate module (say com.company.resources
>     module) and the provider implementation will be in team4.? i.e.
>     team1 and team4 both requires com.company.resources module.
>
>
>     Mandy
>
>     On 1/12/18 11:14 PM, Romain Manni-Bucau wrote:
>>     Hi Mandy,
>>
>>     3 is the blocker because it creates a dependency to team4 which
>>     shouldnt be visible. It is provided as a container service if you
>>     want and other teams have no dependency on it. This means if we
>>     need to upgrade team4 code then the operation team does it and
>>     team1, 2, 3 are not affected at all.
>>
>>     In terms of costs it must stay the same. I can imagine a light
>>     SPI but it already breaks this "container service" rule, plus it
>>     requires to define hundreds of new classes.
>>
>>     Using a custom classloader with no named module can be a short
>>     term workaround but is broken if modules use module-info only to
>>     define a SPI for instance.
>>
>>
>>     Le?13 janv. 2018 00:21, "mandy chung" <mandy.chung at oracle.com
>>     <mailto:mandy.chung at oracle.com>> a ?crit?:
>>
>>         Let me try to see if I understand your situation correctly.
>>
>>
>>         On 1/12/18 12:59 PM, Romain Manni-Bucau wrote:
>>>         All are com.company.*
>>>
>>>
>>>>
>>>>         Assuming service packages use a resource bundle.
>>>>
>>
>>         team1, team2, team3 all uses a resource bundle.? Let's say
>>         com.company.team1.service calls
>>         ResourceBundle.getBundle("com.company.resources.Team1").
>>
>>
>>
>>>>             Now translations are in
>>>>             http://i18n.company.com/translations
>>>>             <http://i18n.company.com/translations> and the team
>>>>             providing the key/values is team4 with no access to
>>>>             team1, team2 and team3 sources normally.
>>>>
>>
>>         team4 provides the key/values of
>>         "com.company.resources.Team1".? team4 and team1 will agree on
>>         the content of this resource bundle e.g. key names and the
>>         value if any text format.
>>
>>         I assume your ResourceBundleControlProvider implementation
>>         returns a Control instance that implements newBundle method
>>         to return a ResourceBundle for
>>         "com.company.resources.Team1".
>>
>>         One migration solution is to use ResourceBundleProvider.? The
>>         steps it takes are
>>         (1) define a SPI for each bundle named
>>         com.company.resources.spi.Team1Provider
>>         (2) reuse your existing Control.newBundle implementation to
>>         implement
>>         ResourceBundleProvider::getBundle to return the requested
>>         ResourceBundle.? This assumes in team4 module
>>         (3) when migrating team1.jar to a named module, the module
>>         definition declares uses com.company.resources.spi.Team1Provider
>>
>>         team4 module can have one single provider implementation for
>>         more than one resource bundle.
>>
>>         Does this help?? I can see it takes some amount of work. How
>>         many resource bundles do your application have?? It'd be good
>>         if you give a try and send us feedback.
>>
>>         Mandy
>>
>>
>


From naoto.sato at oracle.com  Tue Jan 16 21:29:41 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Tue, 16 Jan 2018 13:29:41 -0800
Subject: <i18n dev> [10] RFR: 8187946 : Support ISO 4217 Amendments 163
	and 164
In-Reply-To: <53c151af-d34e-6991-cd6c-d42a65a1fbb1@oracle.com>
References: <8f841d1a-009a-dfec-eb12-fc2b93abfa62@oracle.com>
 <c3621505-fb49-23ae-4c63-2c6e0f2448ef@oracle.com>
 <53c151af-d34e-6991-cd6c-d42a65a1fbb1@oracle.com>
Message-ID: <fbc96d17-e299-78b6-5226-a9559c3eb382@oracle.com>

Looks good to me.

Naoto

On 1/12/18 6:22 PM, Leo Jiang wrote:
> Hi Naoto,
> 
> Thank you for review.
> 
> - Added the updates for currency names, removed the cut-over time for STN.
> - For compatibility reason, we don't update the historic currencies.
> 
> Test passed.
> 
> Please find the revised webrev:
> http://cr.openjdk.java.net/~ljiang/8187946/webrev.01/
> 
> Thanks,
> Leo
> 
> 
> On 01/13/2018 04:13 AM, Naoto Sato wrote:
>> Hi Leo,
>>
>> Here are my comments:
>>
>> (for amendments 163)
>>
>> - Names not reflected correctly: "Azerbaijan Manat", "Lao Kip".
>>
>> (for amendments 164)
>> - Since it's already passed the transition date for STN, you don't 
>> need to use the transition format (at line 473:CurrencyData.properties)
>>
>> - Lacking the Philippines currency name change: "Amended currency name 
>> for PHILIPPINES (THE): Philippine Piso (instead of Peso)"
>>
>> - Lacking historic currency changes, e.g., ALBANIA-Old_Lek-ALK-008.
>>
>> Naoto
>>
>> On 1/12/18 6:51 AM, Leo Jiang wrote:
>>> Hi,
>>>
>>> Please review the currency data update to support ISO 4217 Amendments 
>>> 163 and 164.
>>>
>>> Please refer the pdf files in bug description for details of this 
>>> update. In short, we need to update the STD to STN and its numeric 
>>> name, as well as adding a cut-over time for them.
>>>
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8187946
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~ljiang/8187946/webrev.00/
>>>
>>> Built and test passed on Mach5.
>>>
>>> Thanks,
>>> Leo

From rachna.goel at oracle.com  Wed Jan 17 08:45:11 2018
From: rachna.goel at oracle.com (Rachna Goel)
Date: Wed, 17 Jan 2018 14:15:11 +0530
Subject: <i18n dev> [10] RFR: 8195478:
 sun/text/resources/LocaleDataTest.java fails with java.lang.Exception
In-Reply-To: <c95b2e38-e1f0-aca2-e998-348ea442f1ec@oracle.com>
References: <c95b2e38-e1f0-aca2-e998-348ea442f1ec@oracle.com>
Message-ID: <9e9e8ab0-d85c-b1ba-0a9d-610cf0dfcd6f@oracle.com>

Hi Hamlin,

Just one nit, Please add bug id 8195478 to 
sun/text/resources/LocaleDataTest.java.

Thanks,

Rachna


On 1/17/2018 1:37 PM, Hamlin Li wrote:
> Would you please review the following patch?
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8195478
>
> webrev as below
>
> I have tested it locally.
>
>
> Thank you
>
> -Hamlin
> ------------------------------------------------------------------------
>
> diff -r 19effb7970bc test/jdk/sun/text/resources/LocaleData
> --- a/test/jdk/sun/text/resources/LocaleData??? Thu Jan 11 20:19:50 
> 2018 -0800
> +++ b/test/jdk/sun/text/resources/LocaleData??? Wed Jan 17 16:02:25 
> 2018 +0800
> @@ -6396,7 +6396,6 @@
> ?CurrencyNames//ang=Netherlands Antillean Guilder
> ?CurrencyNames//awg=Aruban Florin
> ?CurrencyNames//azm=Azerbaijani Manat (1993-2006)
> -CurrencyNames//azn=Azerbaijani Manat
> ?CurrencyNames//bbd=Barbadian Dollar
> ?CurrencyNames//bdt=Bangladeshi Taka
> ?CurrencyNames//bgn=Bulgarian Lev


From naoto.sato at oracle.com  Wed Jan 17 13:06:25 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Wed, 17 Jan 2018 05:06:25 -0800
Subject: <i18n dev> [10] RFR: 8195478:
 sun/text/resources/LocaleDataTest.java fails with java.lang.Exception
In-Reply-To: <12bf2f0d-c1cb-5cf0-a559-5e59311d9e98@oracle.com>
References: <c95b2e38-e1f0-aca2-e998-348ea442f1ec@oracle.com>
 <9e9e8ab0-d85c-b1ba-0a9d-610cf0dfcd6f@oracle.com>
 <12bf2f0d-c1cb-5cf0-a559-5e59311d9e98@oracle.com>
Message-ID: <acb74257-ebf0-6913-d741-7d801447cc60@oracle.com>

Looks good to me. As Rachna mentioned, please add @bug to 
LocaleDataTest.java. No further review is needed.

Naoto

On 1/17/18 12:50 AM, Hamlin Li wrote:
> Hi Rachna,
> 
> I'm not sure, but I think in this case (it's a test bug) @bug 8195478 
> should not be added.
> 
> Thank you
> 
> -Hamlin
> 
> 
> On 17/01/2018 4:45 PM, Rachna Goel wrote:
>>
>> Hi Hamlin,
>>
>> Just one nit, Please add bug id 8195478 to 
>> sun/text/resources/LocaleDataTest.java.
>>
>> Thanks,
>>
>> Rachna
>>
>>
>> On 1/17/2018 1:37 PM, Hamlin Li wrote:
>>> Would you please review the following patch?
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8195478
>>>
>>> webrev as below
>>>
>>> I have tested it locally.
>>>
>>>
>>> Thank you
>>>
>>> -Hamlin
>>> ------------------------------------------------------------------------
>>>
>>> diff -r 19effb7970bc test/jdk/sun/text/resources/LocaleData
>>> --- a/test/jdk/sun/text/resources/LocaleData??? Thu Jan 11 20:19:50 
>>> 2018 -0800
>>> +++ b/test/jdk/sun/text/resources/LocaleData??? Wed Jan 17 16:02:25 
>>> 2018 +0800
>>> @@ -6396,7 +6396,6 @@
>>> ?CurrencyNames//ang=Netherlands Antillean Guilder
>>> ?CurrencyNames//awg=Aruban Florin
>>> ?CurrencyNames//azm=Azerbaijani Manat (1993-2006)
>>> -CurrencyNames//azn=Azerbaijani Manat
>>> ?CurrencyNames//bbd=Barbadian Dollar
>>> ?CurrencyNames//bdt=Bangladeshi Taka
>>> ?CurrencyNames//bgn=Bulgarian Lev
>>
> 

From huaming.li at oracle.com  Thu Jan 18 03:56:37 2018
From: huaming.li at oracle.com (Hamlin Li)
Date: Thu, 18 Jan 2018 11:56:37 +0800
Subject: <i18n dev> [10] RFR: 8195478:
 sun/text/resources/LocaleDataTest.java fails with java.lang.Exception
In-Reply-To: <acb74257-ebf0-6913-d741-7d801447cc60@oracle.com>
References: <c95b2e38-e1f0-aca2-e998-348ea442f1ec@oracle.com>
 <9e9e8ab0-d85c-b1ba-0a9d-610cf0dfcd6f@oracle.com>
 <12bf2f0d-c1cb-5cf0-a559-5e59311d9e98@oracle.com>
 <acb74257-ebf0-6913-d741-7d801447cc60@oracle.com>
Message-ID: <7a2b8500-34a3-b7f2-fe39-5e806b558142@oracle.com>

Hi Naoto,

I have pushed the code change to http://hg.openjdk.java.net/jdk/jdk10, I 
think I need to push to 11 (http://hg.openjdk.java.net/jdk/jdk) too. Do 
I need to send out for review again?

Thank you

-Hamlin


On 17/01/2018 9:06 PM, Naoto Sato wrote:
> Looks good to me. As Rachna mentioned, please add @bug to 
> LocaleDataTest.java. No further review is needed.
>
> Naoto
>
> On 1/17/18 12:50 AM, Hamlin Li wrote:
>> Hi Rachna,
>>
>> I'm not sure, but I think in this case (it's a test bug) @bug 8195478 
>> should not be added.
>>
>> Thank you
>>
>> -Hamlin
>>
>>
>> On 17/01/2018 4:45 PM, Rachna Goel wrote:
>>>
>>> Hi Hamlin,
>>>
>>> Just one nit, Please add bug id 8195478 to 
>>> sun/text/resources/LocaleDataTest.java.
>>>
>>> Thanks,
>>>
>>> Rachna
>>>
>>>
>>> On 1/17/2018 1:37 PM, Hamlin Li wrote:
>>>> Would you please review the following patch?
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8195478
>>>>
>>>> webrev as below
>>>>
>>>> I have tested it locally.
>>>>
>>>>
>>>> Thank you
>>>>
>>>> -Hamlin
>>>> ------------------------------------------------------------------------ 
>>>>
>>>>
>>>> diff -r 19effb7970bc test/jdk/sun/text/resources/LocaleData
>>>> --- a/test/jdk/sun/text/resources/LocaleData??? Thu Jan 11 20:19:50 
>>>> 2018 -0800
>>>> +++ b/test/jdk/sun/text/resources/LocaleData??? Wed Jan 17 16:02:25 
>>>> 2018 +0800
>>>> @@ -6396,7 +6396,6 @@
>>>> ?CurrencyNames//ang=Netherlands Antillean Guilder
>>>> ?CurrencyNames//awg=Aruban Florin
>>>> ?CurrencyNames//azm=Azerbaijani Manat (1993-2006)
>>>> -CurrencyNames//azn=Azerbaijani Manat
>>>> ?CurrencyNames//bbd=Barbadian Dollar
>>>> ?CurrencyNames//bdt=Bangladeshi Taka
>>>> ?CurrencyNames//bgn=Bulgarian Lev
>>>
>>


From joe.darcy at oracle.com  Thu Jan 18 17:58:26 2018
From: joe.darcy at oracle.com (joe darcy)
Date: Thu, 18 Jan 2018 09:58:26 -0800
Subject: <i18n dev> [10] RFR: 8195478:
 sun/text/resources/LocaleDataTest.java fails with java.lang.Exception
In-Reply-To: <7a2b8500-34a3-b7f2-fe39-5e806b558142@oracle.com>
References: <c95b2e38-e1f0-aca2-e998-348ea442f1ec@oracle.com>
 <9e9e8ab0-d85c-b1ba-0a9d-610cf0dfcd6f@oracle.com>
 <12bf2f0d-c1cb-5cf0-a559-5e59311d9e98@oracle.com>
 <acb74257-ebf0-6913-d741-7d801447cc60@oracle.com>
 <7a2b8500-34a3-b7f2-fe39-5e806b558142@oracle.com>
Message-ID: <0b677472-9a12-5b3e-9837-88c66a067bfe@oracle.com>

In general, if you've pushed to JDK 10, you don't need to do anything 
else since there will be 10 -> 11 sync which will propagate the fix into 11.

HTH,

-Joe


On 1/17/2018 7:56 PM, Hamlin Li wrote:
> Hi Naoto,
>
> I have pushed the code change to http://hg.openjdk.java.net/jdk/jdk10, 
> I think I need to push to 11 (http://hg.openjdk.java.net/jdk/jdk) too. 
> Do I need to send out for review again?
>
> Thank you
>
> -Hamlin
>


From rachna.goel at oracle.com  Tue Jan 23 06:15:34 2018
From: rachna.goel at oracle.com (Rachna Goel)
Date: Tue, 23 Jan 2018 11:45:34 +0530
Subject: <i18n dev> [11] RFR of 8146656: Wrong Months Array for
	DateFormatSymbols
In-Reply-To: <46a67401-92e4-09a2-dfdf-2c10a977a71e@oracle.com>
References: <428d88c5-8e79-bae6-f9e0-d2b8fa9c1d46@oracle.com>
 <286bbd77-08ed-bf4c-0ebe-bf7d383e0a90@oracle.com>
 <719413d5-89e4-7ecd-3420-8a2a6ff63910@oracle.com>
 <f6b77b89-1562-92fe-8d38-1bae05c5c0fc@oracle.com>
 <ce6d1824-d8ee-82b7-6a5d-2f309de2757e@oracle.com>
 <46a67401-92e4-09a2-dfdf-2c10a977a71e@oracle.com>
Message-ID: <dd6e4764-4ea1-3857-18a5-53d27359ff35@oracle.com>

Hi,

Kindly review updated patch for this doc fix:

patch: http://cr.openjdk.java.net/%7Ergoel/8146656/webrev.02/

Approved CSR : https://bugs.openjdk.java.net/browse/JDK-8191414

Thanks,

Rachna


On 20/12/17 10:44 PM, joe darcy wrote:
>
> Hi Rachna,
>
> I think the revised version with the @implSpec tag switch is 
> acceptable, but also think providing more text to describe this 
> situation would be helpful to programmers unaware of a 13 month 
> possibility.
>
> Cheers,
>
> -Joe
>
>
> On 12/19/2017 2:08 AM, Rachna Goel wrote:
>>
>> Hi Joe,
>>
>> Thanks for the comments.
>>
>> I have updated the CSR to have @implSpec in place of @implNote.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8191414
>>
>> Regarding  "An array with either 12 or 13 elements will be returned 
>> depending on whether or {@link Calendar.UNDECIMBER} is supported." ,  
>> I would like to go with existing statement as this method always 
>> returns 13 elements where the 13th element may be empty string or may 
>> contain Calendar.UNDECIMBER, depending upon whether its supported by 
>> the Calendar instance.
>>
>> kindly suggest whether this looks fine!
>>
>> Thanks,
>> Rachna
>>
>>
>> On 19/12/17 2:55 PM, joe darcy wrote:
>>> Hi Rachna,
>>>
>>> On 12/19/2017 1:13 AM, Rachna Goel wrote:
>>>>
>>>> Hello Joe,
>>>>
>>>> Thanks for the review.
>>>>
>>>> Reason I added @implNote is that it's the case for the default 
>>>> implementation. Not added as a part of spec, as some implementation 
>>>> can just return 12 element array for same methods through the 
>>>> "java.text.spi.DateFormatSymbolsProvider" SPI.
>>>>
>>>>
>>>
>>> That is precisely the sort of situation the @implSpec tag is 
>>> intended for. It allows the specification to say DateFormatSymbols 
>>> must behave this way while allowing subclasses to behave differently.
>>>
>>> Perhaps some general text can be added as normal specification, 
>>> something like
>>>
>>> "An array with either 12 or 13 elements will be returned depending 
>>> on whether or {@link Calendar.UNDECIMBER} is supported."
>>>
>>> paired with
>>>
>>> @implSpec This method returns 13 elements since @link 
>>> Calendar.UNDECIMBER} is supported.
>>>
>>> HTH,
>>>
>>> -Joe
>>>
>>
>> -- 
>> Thanks,
>> Rachna
>

-- 
Thanks,
Rachna


From naoto.sato at oracle.com  Tue Jan 23 18:12:11 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Tue, 23 Jan 2018 10:12:11 -0800
Subject: <i18n dev> [11] RFR of 8146656: Wrong Months Array for
	DateFormatSymbols
In-Reply-To: <dd6e4764-4ea1-3857-18a5-53d27359ff35@oracle.com>
References: <428d88c5-8e79-bae6-f9e0-d2b8fa9c1d46@oracle.com>
 <286bbd77-08ed-bf4c-0ebe-bf7d383e0a90@oracle.com>
 <719413d5-89e4-7ecd-3420-8a2a6ff63910@oracle.com>
 <f6b77b89-1562-92fe-8d38-1bae05c5c0fc@oracle.com>
 <ce6d1824-d8ee-82b7-6a5d-2f309de2757e@oracle.com>
 <46a67401-92e4-09a2-dfdf-2c10a977a71e@oracle.com>
 <dd6e4764-4ea1-3857-18a5-53d27359ff35@oracle.com>
Message-ID: <c18f207d-20bd-5b59-475e-88eb316c2043@oracle.com>

+1

Naoto

On 1/22/18 10:15 PM, Rachna Goel wrote:
> Hi,
> 
> Kindly review updated patch for this doc fix:
> 
> patch: http://cr.openjdk.java.net/%7Ergoel/8146656/webrev.02/
> 
> Approved CSR : https://bugs.openjdk.java.net/browse/JDK-8191414
> 
> Thanks,
> 
> Rachna
> 
> 
> On 20/12/17 10:44 PM, joe darcy wrote:
>>
>> Hi Rachna,
>>
>> I think the revised version with the @implSpec tag switch is 
>> acceptable, but also think providing more text to describe this 
>> situation would be helpful to programmers unaware of a 13 month 
>> possibility.
>>
>> Cheers,
>>
>> -Joe
>>
>>
>> On 12/19/2017 2:08 AM, Rachna Goel wrote:
>>>
>>> Hi Joe,
>>>
>>> Thanks for the comments.
>>>
>>> I have updated the CSR to have @implSpec in place of @implNote.
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8191414
>>>
>>> Regarding? "An array with either 12 or 13 elements will be returned 
>>> depending on whether or {@link Calendar.UNDECIMBER} is supported." ,  
>>> I would like to go with existing statement as this method always 
>>> returns 13 elements where the 13th element may be empty string or may 
>>> contain Calendar.UNDECIMBER, depending upon whether its supported by 
>>> the Calendar instance.
>>>
>>> kindly suggest whether this looks fine!
>>>
>>> Thanks,
>>> Rachna
>>>
>>>
>>> On 19/12/17 2:55 PM, joe darcy wrote:
>>>> Hi Rachna,
>>>>
>>>> On 12/19/2017 1:13 AM, Rachna Goel wrote:
>>>>>
>>>>> Hello Joe,
>>>>>
>>>>> Thanks for the review.
>>>>>
>>>>> Reason I added @implNote is that it's the case for the default 
>>>>> implementation. Not added as a part of spec, as some implementation 
>>>>> can just return 12 element array for same methods through the 
>>>>> "java.text.spi.DateFormatSymbolsProvider" SPI.
>>>>>
>>>>>
>>>>
>>>> That is precisely the sort of situation the @implSpec tag is 
>>>> intended for. It allows the specification to say DateFormatSymbols 
>>>> must behave this way while allowing subclasses to behave differently.
>>>>
>>>> Perhaps some general text can be added as normal specification, 
>>>> something like
>>>>
>>>> "An array with either 12 or 13 elements will be returned depending 
>>>> on whether or {@link Calendar.UNDECIMBER} is supported."
>>>>
>>>> paired with
>>>>
>>>> @implSpec This method returns 13 elements since @link 
>>>> Calendar.UNDECIMBER} is supported.
>>>>
>>>> HTH,
>>>>
>>>> -Joe
>>>>
>>>
>>> -- 
>>> Thanks,
>>> Rachna
>>
> 
> -- 
> Thanks,
> Rachna
> 

From ramanand.patil at oracle.com  Mon Jan 29 08:49:37 2018
From: ramanand.patil at oracle.com (Ramanand Patil)
Date: Mon, 29 Jan 2018 00:49:37 -0800 (PST)
Subject: <i18n dev> RFR[JDK10]: 8195837: (tz) Support tzdata2018c
Message-ID: <0d83a571-fa8b-4f47-8487-c6dff6fd5a03@default>

Hi all,
Please review the latest TZDATA integration (tzdata2018c) into JDK10.
Bug: https://bugs.openjdk.java.net/browse/JDK-8195837
Webrev: http://cr.openjdk.java.net/~rpatil/8195837/webrev.00/

All the TimeZone related tests are passed after integration.

Regards,
Ramanand.

From sean.coffey at oracle.com  Mon Jan 29 14:42:11 2018
From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=)
Date: Mon, 29 Jan 2018 14:42:11 +0000
Subject: <i18n dev> RFR[JDK10]: 8195837: (tz) Support tzdata2018c
In-Reply-To: <0d83a571-fa8b-4f47-8487-c6dff6fd5a03@default>
References: <0d83a571-fa8b-4f47-8487-c6dff6fd5a03@default>
Message-ID: <2f58265e-fd81-39e8-b1d5-ef0bcad7550f@oracle.com>

The changes look fine to me Ramanand. The europe file contains some 
interesting comments about the rolled back changes that have been made 
for 2018c. A plan on how to resolve these pending changes can be 
followed up via JDK-8195595

Regards,
Sean.

On 29/01/18 08:49, Ramanand Patil wrote:
> Hi all,
> Please review the latest TZDATA integration (tzdata2018c) into JDK10.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8195837
> Webrev: http://cr.openjdk.java.net/~rpatil/8195837/webrev.00/
>
> All the TimeZone related tests are passed after integration.
>
> Regards,
> Ramanand.


From gnu.andrew at redhat.com  Mon Jan 29 16:26:37 2018
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Mon, 29 Jan 2018 16:26:37 +0000
Subject: <i18n dev> RFR[JDK10]: 8195837: (tz) Support tzdata2018c
In-Reply-To: <2f58265e-fd81-39e8-b1d5-ef0bcad7550f@oracle.com>
References: <0d83a571-fa8b-4f47-8487-c6dff6fd5a03@default>
 <2f58265e-fd81-39e8-b1d5-ef0bcad7550f@oracle.com>
Message-ID: <CABi63P6FUPUwE_1SEmc_GUHQv4JJWTk-Zh4NaV2j+H1CpNqjTw@mail.gmail.com>

On 29 January 2018 at 14:42, Se?n Coffey <sean.coffey at oracle.com> wrote:
> The changes look fine to me Ramanand. The europe file contains some
> interesting comments about the rolled back changes that have been made for
> 2018c. A plan on how to resolve these pending changes can be followed up via
> JDK-8195595
>

Yes... I've been following the discussion on the tzdb list about these
changes to the
Irish timezone and the breakage they cause. It's good to see that, at
least for now,
these changes will be reverted locally for OpenJDK.

My thanks to those who've put forward the case on that list for the
compatibility issues
these changes cause, particularly Stephen Colebourne.

> Regards,
> Sean.
>
>

-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

From martinrb at google.com  Mon Jan 29 16:47:42 2018
From: martinrb at google.com (Martin Buchholz)
Date: Mon, 29 Jan 2018 08:47:42 -0800
Subject: <i18n dev> RFR[JDK10]: 8195837: (tz) Support tzdata2018c
In-Reply-To: <0d83a571-fa8b-4f47-8487-c6dff6fd5a03@default>
References: <0d83a571-fa8b-4f47-8487-c6dff6fd5a03@default>
Message-ID: <CA+kOe0-TTx1fzyWaJ+xmdTVt4Vyq4Y+rW7eeqLCpe1TFzP3M0Q@mail.gmail.com>

Google has been successfully running jdk8 and jdk9 with 2018c.

On Mon, Jan 29, 2018 at 12:49 AM, Ramanand Patil <ramanand.patil at oracle.com>
wrote:

> Hi all,
> Please review the latest TZDATA integration (tzdata2018c) into JDK10.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8195837
> Webrev: http://cr.openjdk.java.net/~rpatil/8195837/webrev.00/
>
> All the TimeZone related tests are passed after integration.
>
> Regards,
> Ramanand.
>

From naoto.sato at oracle.com  Mon Jan 29 20:56:14 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Mon, 29 Jan 2018 12:56:14 -0800
Subject: <i18n dev> RFR[JDK10]: 8195837: (tz) Support tzdata2018c
In-Reply-To: <0d83a571-fa8b-4f47-8487-c6dff6fd5a03@default>
References: <0d83a571-fa8b-4f47-8487-c6dff6fd5a03@default>
Message-ID: <3dde2e36-3c7a-6a65-cb80-30e0dcfc59fb@oracle.com>

Looks good to me.

Naoto

On 1/29/18 12:49 AM, Ramanand Patil wrote:
> Hi all,
> Please review the latest TZDATA integration (tzdata2018c) into JDK10.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8195837
> Webrev: http://cr.openjdk.java.net/~rpatil/8195837/webrev.00/
> 
> All the TimeZone related tests are passed after integration.
> 
> Regards,
> Ramanand.
> 

From huaming.li at oracle.com  Wed Jan 17 08:10:03 2018
From: huaming.li at oracle.com (Hamlin Li)
Date: Wed, 17 Jan 2018 08:10:03 -0000
Subject: <i18n dev> [10] RFR: 8195478:
 sun/text/resources/LocaleDataTest.java fails with java.lang.Exception
Message-ID: <8a507e28-c8f1-f4b4-881d-00bd97b77b1b@oracle.com>

Would you please review the following patch?

bug: https://bugs.openjdk.java.net/browse/JDK-8195478

webrev as below

I have tested it locally.


Thank you

-Hamlin
------------------------------------------------------------------------

diff -r 19effb7970bc test/jdk/sun/text/resources/LocaleData
--- a/test/jdk/sun/text/resources/LocaleData??? Thu Jan 11 20:19:50 2018 
-0800
+++ b/test/jdk/sun/text/resources/LocaleData??? Wed Jan 17 16:02:25 2018 
+0800
@@ -6396,7 +6396,6 @@
 ?CurrencyNames//ang=Netherlands Antillean Guilder
 ?CurrencyNames//awg=Aruban Florin
 ?CurrencyNames//azm=Azerbaijani Manat (1993-2006)
-CurrencyNames//azn=Azerbaijani Manat
 ?CurrencyNames//bbd=Barbadian Dollar
 ?CurrencyNames//bdt=Bangladeshi Taka
 ?CurrencyNames//bgn=Bulgarian Lev


From huaming.li at oracle.com  Wed Jan 17 08:12:04 2018
From: huaming.li at oracle.com (Hamlin Li)
Date: Wed, 17 Jan 2018 08:12:04 -0000
Subject: <i18n dev> [10] RFR: 8195478:
 sun/text/resources/LocaleDataTest.java fails with java.lang.Exception
Message-ID: <c95b2e38-e1f0-aca2-e998-348ea442f1ec@oracle.com>

Would you please review the following patch?

bug: https://bugs.openjdk.java.net/browse/JDK-8195478

webrev as below

I have tested it locally.


Thank you

-Hamlin
------------------------------------------------------------------------

diff -r 19effb7970bc test/jdk/sun/text/resources/LocaleData
--- a/test/jdk/sun/text/resources/LocaleData??? Thu Jan 11 20:19:50 2018 
-0800
+++ b/test/jdk/sun/text/resources/LocaleData??? Wed Jan 17 16:02:25 2018 
+0800
@@ -6396,7 +6396,6 @@
 ?CurrencyNames//ang=Netherlands Antillean Guilder
 ?CurrencyNames//awg=Aruban Florin
 ?CurrencyNames//azm=Azerbaijani Manat (1993-2006)
-CurrencyNames//azn=Azerbaijani Manat
 ?CurrencyNames//bbd=Barbadian Dollar
 ?CurrencyNames//bdt=Bangladeshi Taka
 ?CurrencyNames//bgn=Bulgarian Lev

From huaming.li at oracle.com  Wed Jan 17 08:55:04 2018
From: huaming.li at oracle.com (Hamlin Li)
Date: Wed, 17 Jan 2018 08:55:04 -0000
Subject: <i18n dev> [10] RFR: 8195478:
 sun/text/resources/LocaleDataTest.java fails with java.lang.Exception
In-Reply-To: <9e9e8ab0-d85c-b1ba-0a9d-610cf0dfcd6f@oracle.com>
References: <c95b2e38-e1f0-aca2-e998-348ea442f1ec@oracle.com>
 <9e9e8ab0-d85c-b1ba-0a9d-610cf0dfcd6f@oracle.com>
Message-ID: <12bf2f0d-c1cb-5cf0-a559-5e59311d9e98@oracle.com>

Hi Rachna,

I'm not sure, but I think in this case (it's a test bug) @bug 8195478 
should not be added.

Thank you

-Hamlin


On 17/01/2018 4:45 PM, Rachna Goel wrote:
>
> Hi Hamlin,
>
> Just one nit, Please add bug id 8195478 to 
> sun/text/resources/LocaleDataTest.java.
>
> Thanks,
>
> Rachna
>
>
> On 1/17/2018 1:37 PM, Hamlin Li wrote:
>> Would you please review the following patch?
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8195478
>>
>> webrev as below
>>
>> I have tested it locally.
>>
>>
>> Thank you
>>
>> -Hamlin
>> ------------------------------------------------------------------------
>>
>> diff -r 19effb7970bc test/jdk/sun/text/resources/LocaleData
>> --- a/test/jdk/sun/text/resources/LocaleData??? Thu Jan 11 20:19:50 
>> 2018 -0800
>> +++ b/test/jdk/sun/text/resources/LocaleData??? Wed Jan 17 16:02:25 
>> 2018 +0800
>> @@ -6396,7 +6396,6 @@
>> ?CurrencyNames//ang=Netherlands Antillean Guilder
>> ?CurrencyNames//awg=Aruban Florin
>> ?CurrencyNames//azm=Azerbaijani Manat (1993-2006)
>> -CurrencyNames//azn=Azerbaijani Manat
>> ?CurrencyNames//bbd=Barbadian Dollar
>> ?CurrencyNames//bdt=Bangladeshi Taka
>> ?CurrencyNames//bgn=Bulgarian Lev
>