<i18n dev> [10] RFR: 8187946 : Support ISO 4217 Amendments 163 and 164

[Naoto Sato]

Looks good to me.

Naoto

On 1/12/18 6:22 PM, Leo Jiang wrote:
> Hi Naoto,
> 
> Thank you for review.
> 
> - Added the updates for currency names, removed the cut-over time for STN.
> - For compatibility reason, we don't update the historic currencies.
> 
> Test passed.
> 
> Please find the revised webrev:
> http://cr.openjdk.java.net/~ljiang/8187946/webrev.01/
> 
> Thanks,
> Leo
> 
> 
> On 01/13/2018 04:13 AM, Naoto Sato wrote:
>> Hi Leo,
>>
>> Here are my comments:
>>
>> (for amendments 163)
>>
>> - Names not reflected correctly: "Azerbaijan Manat", "Lao Kip".
>>
>> (for amendments 164)
>> - Since it's already passed the transition date for STN, you don't 
>> need to use the transition format (at line 473:CurrencyData.properties)
>>
>> - Lacking the Philippines currency name change: "Amended currency name 
>> for PHILIPPINES (THE): Philippine Piso (instead of Peso)"
>>
>> - Lacking historic currency changes, e.g., ALBANIA-Old_Lek-ALK-008.
>>
>> Naoto
>>
>> On 1/12/18 6:51 AM, Leo Jiang wrote:
>>> Hi,
>>>
>>> Please review the currency data update to support ISO 4217 Amendments 
>>> 163 and 164.
>>>
>>> Please refer the pdf files in bug description for details of this 
>>> update. In short, we need to update the STD to STN and its numeric 
>>> name, as well as adding a cut-over time for them.
>>>
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8187946
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~ljiang/8187946/webrev.00/
>>>
>>> Built and test passed on Mach5.
>>>
>>> Thanks,
>>> Leo