From naoto.sato at oracle.com  Mon Jul  2 17:52:26 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Mon, 2 Jul 2018 10:52:26 -0700
Subject: <i18n dev> [12] RFR: 8206120: Add test cases for lenient Japanese
	era parsing
Message-ID: <1139b79a-e600-a1dc-f03f-928203ed10e3@oracle.com>

Hello,

Please review the changes to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8206120

The proposed changeset is located at:

http://cr.openjdk.java.net/~naoto/8206120/webrev.00/

This is a test case only fix to ensure the new Japanese era 
implementation introduced with JDK-8202088 accepts lenient era/year, 
such as "Heisei 32."

Naoto

From dipak.kumar at oracle.com  Tue Jul  3 08:40:00 2018
From: dipak.kumar at oracle.com (Dipak Kumar)
Date: Tue, 3 Jul 2018 01:40:00 -0700 (PDT)
Subject: <i18n dev> [8u-backport] Review Request: 8202696 Remove
 exclusion range for phonetic chars in windows fontconfig.properties
In-Reply-To: <70d9b877-9ce4-4965-89cc-72703071cbb5@default>
References: <70d9b877-9ce4-4965-89cc-72703071cbb5@default>
Message-ID: <35dae94e-939e-497a-aaa3-85a4f9b8a645@default>

Just a gentle reminder. Requesting to review the changes for 8u-backport.

Thanks,
Dipak

-----Original Message-----
From: Dipak Kumar 
Sent: 28 June 2018 14:43
To: 2d-dev at openjdk.java.net; i18n-dev at openjdk.java.net; Philip Race <philip.race at oracle.com>; Naoto Sato <naoto.sato at oracle.com>
Subject: <i18n dev> [8u-backport] Review Request: 8202696 Remove exclusion range for phonetic chars in windows fontconfig.properties

Hi,

Please review below patch for 8u-backport:

Main JBS bug: https://bugs.openjdk.java.net/browse/JDK-8202696 
Webrev for 8u-backport: http://cr.openjdk.java.net/~dkumar/8202696/8u-backport/webrev.00/ 
JDK-11 changeset - http://hg.openjdk.java.net/jdk/client/rev/b9456394d24f 

Patch from JDK-11 doesn't apply cleanly because of file name and file path differences.
Moreover there are some additional ranges added to font exclusion in JDK-11 config file.

JPRT and font related Jtreg tests are fine.

Thanks,
Dipak

From rachna.goel at oracle.com  Tue Jul  3 09:58:35 2018
From: rachna.goel at oracle.com (Rachna Goel)
Date: Tue, 3 Jul 2018 15:28:35 +0530
Subject: <i18n dev> [11] Review Request: 8204603: Short week days,
 NaN value and timezone name are inconsistent between CLDR and Java
 in zh_CN, zh_TW locales.
Message-ID: <551e9c56-6ef0-8e16-197f-63595698a640@oracle.com>

Hi,

Kindly review fix to JDK-8204603.

Bug: https://bugs.openjdk.java.net/browse/JDK-8204603

Fix: http://cr.openjdk.java.net/~rgoel/JDK-8204603/webrev.04/

This is a regression caused by JDK-8179071, where locale data is getting 
incorrectly retrieved (not following languageAliases of CLDR) for some 
locales. Handling of languageAliases for CLDR provider will solve the issue.

-- 
Thanks,
Rachna


From naoto.sato at oracle.com  Tue Jul  3 16:15:28 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Tue, 3 Jul 2018 09:15:28 -0700
Subject: <i18n dev> [11] Review Request: 8204603: Short week days,
 NaN value and timezone name are inconsistent between CLDR and Java
 in zh_CN, zh_TW locales.
In-Reply-To: <551e9c56-6ef0-8e16-197f-63595698a640@oracle.com>
References: <551e9c56-6ef0-8e16-197f-63595698a640@oracle.com>
Message-ID: <bf05a6f9-44f6-56b0-b02b-a70bc0a644b8@oracle.com>

Looks good to me.

Naoto

On 7/3/18 2:58 AM, Rachna Goel wrote:
> Hi,
> 
> Kindly review fix to JDK-8204603.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8204603
> 
> Fix: http://cr.openjdk.java.net/~rgoel/JDK-8204603/webrev.04/
> 
> This is a regression caused by JDK-8179071, where locale data is getting 
> incorrectly retrieved (not following languageAliases of CLDR) for some 
> locales. Handling of languageAliases for CLDR provider will solve the 
> issue.
> 

From naoto.sato at oracle.com  Thu Jul  5 15:48:24 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Thu, 5 Jul 2018 08:48:24 -0700
Subject: <i18n dev> [8u-backport] Review Request: 8202696 Remove
 exclusion range for phonetic chars in windows fontconfig.properties
In-Reply-To: <35dae94e-939e-497a-aaa3-85a4f9b8a645@default>
References: <70d9b877-9ce4-4965-89cc-72703071cbb5@default>
 <35dae94e-939e-497a-aaa3-85a4f9b8a645@default>
Message-ID: <51f6b779-2cb7-ed37-c417-3ddd4190184b@oracle.com>

Looks good to me.

Naoto

On 7/3/18 1:40 AM, Dipak Kumar wrote:
> Just a gentle reminder. Requesting to review the changes for 8u-backport.
> 
> Thanks,
> 
> Dipak
> 
> -----Original Message-----
> From:Dipak Kumar
> Sent:28 June 2018 14:43
> To:2d-dev at openjdk.java.net; i18n-dev at openjdk.java.net; Philip Race 
> <philip.race at oracle.com>; Naoto Sato <naoto.sato at oracle.com>
> Subject:<i18n dev> [8u-backport] Review Request: 8202696 Remove 
> exclusion range for phonetic chars in windows fontconfig.properties
> 
> Hi,
> 
> Please review below patch for 8u-backport:
> 
> Main JBS bug:_https://bugs.openjdk.java.net/browse/JDK-8202696_
> 
> Webrev for 
> 8u-backport:_http://cr.openjdk.java.net/~dkumar/8202696/8u-backport/webrev.00/_
> 
> JDK-11 changeset 
> -_http://hg.openjdk.java.net/jdk/client/rev/b9456394d24f_<http://hg.openjdk.java.net/jdk/client/rev/b9456394d24f>
> 
> Patch from JDK-11 doesn't apply cleanly because of file name and file 
> path differences.
> 
> Moreover there are some additional ranges added to font exclusion in 
> JDK-11 config file.
> 
> JPRT and font related Jtreg tests are fine.
> 
> Thanks,
> 
> Dipak
> 

From naoto.sato at oracle.com  Thu Jul  5 20:16:21 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Thu, 5 Jul 2018 13:16:21 -0700
Subject: <i18n dev> [12] RFR: 8206350:
 java/util/Locale/bcp47u/SystemPropertyTests.java failed on Mac 10.13 with
 zh_CN and zh_TW locales.
Message-ID: <7db8f039-1e5d-9fa3-2068-ed28611345c5@oracle.com>

Hello,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8206350

The proposed changeset is located at:

http://cr.openjdk.java.net/~naoto/8206350/webrev.00/

The fix is to set the script property explicitly empty so that the test 
works on platforms that provide the default locales with scripts 
involved (e.g., zh-Hans-CN).

Naoto


From naoto.sato at oracle.com  Wed Jul 11 17:42:58 2018
From: naoto.sato at oracle.com (naoto.sato at oracle.com)
Date: Wed, 11 Jul 2018 10:42:58 -0700
Subject: <i18n dev> [11] RFR: 8206980: DateTimeFormatter throws parsing a
 valid string depending on the locale
Message-ID: <9834dcbe-d8e8-2469-0743-c5e07f66c173@oracle.com>

Hello,

Please review the changes to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8206980

The proposed fix is located at:

http://cr.openjdk.java.net/~naoto/8206980/webrev.00/

CLDR time zone names in "en" bundle are expected to be pre-populated for 
performance. This is not the case for locales that have "en-001" (World 
English) as the parent bundle, such as Locale.CANADA. The fast path 
determining logic was incorrectly assumed all English locales are using 
pre-populated bundles. Limiting the assumption to only "en" and "en-US" 
will solve the problem.

Naoto

From nishit.jain at oracle.com  Thu Jul 12 08:26:23 2018
From: nishit.jain at oracle.com (Nishit Jain)
Date: Thu, 12 Jul 2018 13:56:23 +0530
Subject: <i18n dev> [12] RFR: 8193444: SimpleDateFormat throws
 ArrayIndexOutOfBoundsException when format contains long sequences of
 unicode characters
Message-ID: <800c0442-b44e-4353-22cd-25bf2a8b5916@oracle.com>

Hi,

Please review the fix for JDK-8193444

Bug: https://bugs.openjdk.java.net/browse/JDK-8193444
Webrev: http://cr.openjdk.java.net/~nishjain/8193444/webrev.02/

Cause: If a format pattern contains a sequence of over 256 non-ASCII 
unicode characters, the length field overflows as it is stored as 8-bit.
Fix: The handling of long_length (> 254) for non-ASCII unicode 
characters is missing in the compilation phase of the format pattern, 
added that in the fix.

Regards,
Nishit Jain

From naoto.sato at oracle.com  Thu Jul 12 17:28:18 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Thu, 12 Jul 2018 10:28:18 -0700
Subject: <i18n dev> [12] RFR: 8193444: SimpleDateFormat throws
 ArrayIndexOutOfBoundsException when format contains long sequences of
 unicode characters
In-Reply-To: <800c0442-b44e-4353-22cd-25bf2a8b5916@oracle.com>
References: <800c0442-b44e-4353-22cd-25bf2a8b5916@oracle.com>
Message-ID: <4b7c0243-1d64-4540-c649-0a27b42954d5@oracle.com>

Looks good to me.

Naoto

On 7/12/18 1:26 AM, Nishit Jain wrote:
> Hi,
> 
> Please review the fix for JDK-8193444
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8193444
> Webrev: http://cr.openjdk.java.net/~nishjain/8193444/webrev.02/
> 
> Cause: If a format pattern contains a sequence of over 256 non-ASCII 
> unicode characters, the length field overflows as it is stored as 8-bit.
> Fix: The handling of long_length (> 254) for non-ASCII unicode 
> characters is missing in the compilation phase of the format pattern, 
> added that in the fix.
> 
> Regards,
> Nishit Jain

From naoto.sato at oracle.com  Thu Jul 12 17:51:39 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Thu, 12 Jul 2018 10:51:39 -0700
Subject: <i18n dev> [11] RFR: 8207152: Placeholder for Japanese new era
 should be two characters
Message-ID: <89660abe-519a-a07b-8d31-4145dc088501@oracle.com>

Hello,

Please review the changes to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8207152

The proposed fix is located at:

http://cr.openjdk.java.net/~naoto/8207152/webrev.00/

The fix is to simply change the name from "???" to "??". From the API 
standpoint, there is no restriction on the length of a Era name (in 
fact, era names in English localization have more than 2 characters even 
for existing eras). However, it would be desirable to avoid any possible 
unwanted regressions in customer's apps even for the placeholder.

Naoto

From naoto.sato at oracle.com  Thu Jul 19 16:57:42 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Thu, 19 Jul 2018 09:57:42 -0700
Subject: <i18n dev> [12] RFR: 8206886: Java does not set the default format
 locale correctly on mac10.13
Message-ID: <461d0a63-051d-cd59-a95a-b13768ed27d2@oracle.com>

Hello,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8206886

The proposed changeset is located at:

http://cr.openjdk.java.net/~naoto/8206886/webrev.00/

macOS has removed the locale selection for formats since 10.12 (detail 
in the bug report). The fix intends to use the user's preferred language 
for Java's default format locale on 10.12 or later.

Naoto

From takiguc at linux.vnet.ibm.com  Mon Jul 23 12:24:53 2018
From: takiguc at linux.vnet.ibm.com (Ichiroh Takiguchi)
Date: Mon, 23 Jul 2018 21:24:53 +0900
Subject: <i18n dev> <AWT Dev> [12] Proposal: Memory leak issue on
	awt_InputMethod.c
In-Reply-To: <eec2e84fff7ef747cb4e80eadbcebedb@linux.vnet.ibm.com>
References: <e568e8afdb224c03de6d21a1f8814b00@linux.vnet.ibm.com>
 <e40d54b4-6eca-caa6-219c-5c802fe27863@oracle.com>
 <eec2e84fff7ef747cb4e80eadbcebedb@linux.vnet.ibm.com>
Message-ID: <5d0494712cee97fcf0e310d0ec330b46@linux.vnet.ibm.com>

Hello.

I'd like to change target to "JDK12".
I'd like to obtain a sponsor for this patch.

Thanks,
Ichiroh Takiguchi
IBM Japan, Ltd.

On 2018-06-28 22:13, Ichiroh Takiguchi wrote:
> Hello.
> In my investigation, this issue only happens on 64 bit build only...
> 
> On 2018-06-28 06:06, Phil Race wrote:
>> On 06/27/2018 06:45 AM, Ichiroh Takiguchi wrote:
>>> Hello,
>>> 
>>> I should post this mail before starting JDK11 RDP1.
>> 
>> Already too too late for that, but although this looks like a bug -
>> and the correct fix -
>> the bug has been there forever .. since JDK 1.2  in 1998 !
>> That makes it a 20 year old bug, so I don't think we need to treat it 
>> as urgent
>> for JDK 11.
>> 
>> -phil.
>> 
>>> 
>>> I found memory leak issue on awt_InputMethod.c.
>>> 
>>> See src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c.
>>> On line 1117, memory area was allocated by malloc(), but free() is 
>>> missing
>>> ===========================================
>>>   1099          if (text->feedback != NULL) {
>>>   1100              int cnt;
>>>   1101              jint *tmpstyle;
>>>   1102
>>>   1103              style = (*env)->NewIntArray(env, text->length);
>>>   1104              if (JNU_IsNull(env, style)) {
>>>   1105                  (*env)->ExceptionClear(env);
>>>   1106                  THROW_OUT_OF_MEMORY_ERROR();
>>>   1107                  goto finally;
>>>   1108              }
>>>   1109
>>>   1110              if (sizeof(XIMFeedback) == sizeof(jint)) {
>>>   1111                  /*
>>>   1112                   * Optimization to avoid copying the array
>>>   1113                   */
>>>   1114                  (*env)->SetIntArrayRegion(env, style, 0,
>>>   1115                                            text->length, (jint 
>>> *)text->feedback);
>>>   1116              } else {
>>>   1117                  tmpstyle  = (jint 
>>> *)malloc(sizeof(jint)*(text->length));
>>>   1118                  if (tmpstyle == (jint *) NULL) {
>>>   1119                      THROW_OUT_OF_MEMORY_ERROR();
>>>   1120                      goto finally;
>>>   1121                  }
>>>   1122                  for (cnt = 0; cnt < (int)text->length; cnt++)
>>>   1123                          tmpstyle[cnt] = text->feedback[cnt];
>>>   1124                  (*env)->SetIntArrayRegion(env, style, 0,
>>>   1125                                            text->length, (jint 
>>> *)tmpstyle);
>>>   1126              }
>>>   1127          }
>>> ===========================================
>>> In my investigation, malloc() was called on RHEL7 x86_64 with 
>>> Japanese Input Method.
>>> 
>>> I'd like to obtain a sponsor for this patch.
>>> --------
>>> --- old/src/java.desktop/aix/native/libawt_xawt/awt/awt_InputMethod.c 
>>> 2018-06-27 02:03:48.134991703 +0900
>>> +++ new/src/java.desktop/aix/native/libawt_xawt/awt/awt_InputMethod.c 
>>> 2018-06-27 02:03:47.493005265 +0900
>>> @@ -1148,6 +1148,7 @@
>>>                          tmpstyle[cnt] = text->feedback[cnt];
>>>                  (*env)->SetIntArrayRegion(env, style, 0,
>>>                                            text->length, (jint 
>>> *)tmpstyle);
>>> +                free(tmpstyle);
>>>              }
>>>          }
>>>      }
>>> --- 
>>> old/src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c  
>>> 2018-06-27 02:03:49.040972563 +0900
>>> +++ 
>>> new/src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c  
>>> 2018-06-27 02:03:48.391986274 +0900
>>> @@ -1123,6 +1123,7 @@
>>>                          tmpstyle[cnt] = text->feedback[cnt];
>>>                  (*env)->SetIntArrayRegion(env, style, 0,
>>>                                            text->length, (jint 
>>> *)tmpstyle);
>>> +                free(tmpstyle);
>>>              }
>>>          }
>>>      }
>>> --------
>>> 
>>> Thanks,
>>> Ichiroh Takiguchi
>>> IBM Japan, Ltd.
>>> 


From rachna.goel at oracle.com  Wed Jul 25 17:03:12 2018
From: rachna.goel at oracle.com (Rachna Goel)
Date: Wed, 25 Jul 2018 22:33:12 +0530
Subject: <i18n dev> [11]RFR:JDK-8206965: java/util/TimeZone/Bug8149452.java
 failed on de_DE and ja_JP locale.
Message-ID: <174d08ae-e6d6-af55-e814-096c7f6a58be@oracle.com>

Hi,

Kindly review fix for JDK-8206965.

Bug: https://bugs.openjdk.java.net/browse/JDK-8206965
patch: http://cr.openjdk.java.net/~rgoel/JDK-8206965/webrev.06/

This is a regression caused by JDK-8181157 due to which for some 
locales,  timezone display names were not getting generated.
Generating fallback names for missing timezones at runtime would solve 
this issue.

-- 
Thanks,
Rachna


From naoto.sato at oracle.com  Wed Jul 25 17:46:30 2018
From: naoto.sato at oracle.com (naoto.sato at oracle.com)
Date: Wed, 25 Jul 2018 10:46:30 -0700
Subject: <i18n dev> [11]RFR:JDK-8206965:
 java/util/TimeZone/Bug8149452.java failed on de_DE and ja_JP locale.
In-Reply-To: <174d08ae-e6d6-af55-e814-096c7f6a58be@oracle.com>
References: <174d08ae-e6d6-af55-e814-096c7f6a58be@oracle.com>
Message-ID: <87966df3-e147-f177-096a-d293ee3e8b03@oracle.com>

Looks good.

Naoto

On 7/25/18 10:03 AM, Rachna Goel wrote:
> Hi,
> 
> Kindly review fix for JDK-8206965.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8206965
> patch: http://cr.openjdk.java.net/~rgoel/JDK-8206965/webrev.06/
> 
> This is a regression caused by JDK-8181157 due to which for some 
> locales,? timezone display names were not getting generated.
> Generating fallback names for missing timezones at runtime would solve 
> this issue.
> 

From nishit.jain at oracle.com  Thu Jul 26 08:34:15 2018
From: nishit.jain at oracle.com (Nishit Jain)
Date: Thu, 26 Jul 2018 14:04:15 +0530
Subject: <i18n dev> [12] RFR 8021322: [Fmt-Ch] Implementation of
 ChoiceFormat math methods should delegate to java.lang.Math methods
Message-ID: <f5bc17e4-7a50-51a5-2047-c37882b9b125@oracle.com>

Hi,

Please review the fix for JDK-8021322. CSR for the spec changes has been 
approved.

Bug: https://bugs.openjdk.java.net/browse/JDK-8021322
Webrev: http://cr.openjdk.java.net/~nishjain/8021322/webrev.01/
CSR: https://bugs.openjdk.java.net/browse/JDK-8208071

Fix: Changed the ChoiceFormat's nextDouble(double), 
previousDouble(double), nextDouble(double, boolean) APIs implementation 
to delegate the execution to the equivalent Math APIs

Regards,
Nishit Jain

From naoto.sato at oracle.com  Thu Jul 26 16:26:39 2018
From: naoto.sato at oracle.com (Naoto Sato)
Date: Thu, 26 Jul 2018 09:26:39 -0700
Subject: <i18n dev> [12] RFR 8021322: [Fmt-Ch] Implementation of
 ChoiceFormat math methods should delegate to java.lang.Math methods
In-Reply-To: <f5bc17e4-7a50-51a5-2047-c37882b9b125@oracle.com>
References: <f5bc17e4-7a50-51a5-2047-c37882b9b125@oracle.com>
Message-ID: <77c2ebf2-4743-3ac3-be98-e282a132623b@oracle.com>

Looks good.

Naoto

On 7/26/18 1:34 AM, Nishit Jain wrote:
> Hi,
> 
> Please review the fix for JDK-8021322. CSR for the spec changes has been 
> approved.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8021322
> Webrev: http://cr.openjdk.java.net/~nishjain/8021322/webrev.01/
> CSR: https://bugs.openjdk.java.net/browse/JDK-8208071
> 
> Fix: Changed the ChoiceFormat's nextDouble(double), 
> previousDouble(double), nextDouble(double, boolean) APIs implementation 
> to delegate the execution to the equivalent Math APIs
> 
> Regards,
> Nishit Jain

From joe.darcy at oracle.com  Thu Jul 26 20:35:48 2018
From: joe.darcy at oracle.com (Joseph D. Darcy)
Date: Thu, 26 Jul 2018 13:35:48 -0700
Subject: <i18n dev> [12] RFR 8021322: [Fmt-Ch] Implementation of
 ChoiceFormat math methods should delegate to java.lang.Math methods
In-Reply-To: <77c2ebf2-4743-3ac3-be98-e282a132623b@oracle.com>
References: <f5bc17e4-7a50-51a5-2047-c37882b9b125@oracle.com>
 <77c2ebf2-4743-3ac3-be98-e282a132623b@oracle.com>
Message-ID: <5B5A30A4.4080902@oracle.com>

Looks fine; cheers,

-Joe

On 7/26/2018 9:26 AM, Naoto Sato wrote:
> Looks good.
>
> Naoto
>
> On 7/26/18 1:34 AM, Nishit Jain wrote:
>> Hi,
>>
>> Please review the fix for JDK-8021322. CSR for the spec changes has 
>> been approved.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8021322
>> Webrev: http://cr.openjdk.java.net/~nishjain/8021322/webrev.01/
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8208071
>>
>> Fix: Changed the ChoiceFormat's nextDouble(double), 
>> previousDouble(double), nextDouble(double, boolean) APIs 
>> implementation to delegate the execution to the equivalent Math APIs
>>
>> Regards,
>> Nishit Jain


From nishit.jain at oracle.com  Tue Jul 31 11:27:40 2018
From: nishit.jain at oracle.com (Nishit Jain)
Date: Tue, 31 Jul 2018 16:57:40 +0530
Subject: <i18n dev> [12] RFR 8208560: ChoiceFormat class has unused
 constants needs cleanup
Message-ID: <606a0a30-895c-bc38-35d2-cb92b94cd348@oracle.com>

Hi,

Please review this cleanup fix for 8208560

Bug: https://bugs.openjdk.java.net/browse/JDK-8208560
Webrev: http://cr.openjdk.java.net/~nishjain/8208560/webrev.00/

Cause and Fix: Changes made for JDK-8021322 has left some unused static 
fields, not sure why these fields have package private access, but they 
are not getting used elsewhere in the package. Removed them from 
ChoiceFormat class.

Regards,
Nishit Jain