<i18n dev> [11] RFR: 8202026 8193552 8204269 : ISO 4217 Amendment #165 # 166 #167 Update

li.jiang at oracle.com li.jiang at oracle.com
Tue Jun 5 06:30:16 UTC 2018


Hi Naoto,

I removed the obsoleted currency LTL and LVL from tablea1.txt, added 
them into otherCodes in ValidateISO4217.java.

new webrev as below:
http://cr.openjdk.java.net/~ljiang/8202026/webrev.03/

Thanks,
Leo

On 05/06/2018 2:27 AM, naoto.sato at oracle.com wrote:
> Hi Leo,
> 
> Change looks good. One leftover from the previous:
> 
>  >> in CurrencyData.properties. This applies to tabela1.txt as well.
> 
> Can you please clean those LV/LT entries in tablea1.txt as well?
> 
> Naoto
> 
> On 6/4/18 7:41 AM, li.jiang at oracle.com wrote:
>> Hi Naoto,
>>
>> Pls review the updated code:
>>
>> http://cr.openjdk.java.net/~ljiang/8202026/webrev.02/
>>
>> - As suggested, clean up the old transition dates.
>> - Update copyright year.
>> - ISO 4217 Amendment #167 was published today, which discards the 
>> #166, so withdraw the change for #166 in webrev.02.
>>
>> Bug for #167:
>> https://bugs.openjdk.java.net/browse/JDK-8204269
>>
>> Test passed on mach5.
>>
>> Thanks,
>> Leo
>>
>> On 26/04/2018 1:00 AM, naoto.sato at oracle.com wrote:
>>> Hi Leo,
>>>
>>> Although JDK11 is slated in 09/2018, enabling amendment 166 now is 
>>> technically a bug, as it will be effective from June 4. Please use 
>>> the transition mechanism in 
>>> make/data/currency/CurrencyData.properties and 
>>> test/jdk/java/util/Currency/tablea1.txt.
>>>
>>> OTOH, there are old (past) transition entries. I would clean up those 
>>> entries, such as:
>>>
>>>   326 # LATVIA
>>>   327 LV=LVL;2013-12-31-22-00-00;EUR
>>>
>>> in CurrencyData.properties. This applies to tabela1.txt as well.
>>>
>>> Naoto
>>>
>>> On 4/24/18 8:52 PM, Leo Jiang wrote:
>>>> Forgot to mention, the tests in Currency fold are passed on Mach5.
>>>>
>>>> -Leo
>>>>
>>>> On 04/25/2018 09:33 AM, Leo Jiang wrote:
>>>>> Hi,
>>>>>
>>>>> Please review the changes to address the ISO 4217 Amendment 165 166 
>>>>> update.
>>>>>
>>>>> Bug:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8193552  165
>>>>> https://bugs.openjdk.java.net/browse/JDK-8202026  166
>>>>>
>>>>> CR:
>>>>> http://cr.openjdk.java.net/~ljiang/8202026/webrev.00/
>>>>>
>>>>>
>>>>> Detail:
>>>>> #165
>>>>> From:
>>>>> MAURITANIA    Ouguiya    MRO    478    2
>>>>> To:
>>>>> MAURITANIA    Ouguiya    MRU    929    2
>>>>>
>>>>> #166
>>>>> From:
>>>>> VENEZUELA (BOLIVARIAN REPUBLIC OF)    Bolívar    VEF    937    2
>>>>> To:
>>>>> VENEZUELA (BOLIVARIAN REPUBLIC OF)    Bolívar Soberano    VES 928    2
>>>>>
>>>>>
>>>>> Thanks,
>>>>> Leo


More information about the i18n-dev mailing list