From mark.reinhold at oracle.com Wed Mar 7 22:58:03 2018 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 7 Mar 2018 14:58:03 -0800 (PST) Subject: JEP 327: Unicode 10 Message-ID: <20180307225803.68F4F17AFF7@eggemoggin.niobe.net> New JEP Candidate: http://openjdk.java.net/jeps/327 - Mark From srl at icu-project.org Thu Mar 8 02:45:08 2018 From: srl at icu-project.org (Steven R. Loomis) Date: Thu, 08 Mar 2018 02:45:08 +0000 Subject: JEP 327: Unicode 10 In-Reply-To: <20180307225803.68F4F17AFF7@eggemoggin.niobe.net> References: <20180307225803.68F4F17AFF7@eggemoggin.niobe.net> Message-ID: Unicode 11 is scheduled for June. http://www.unicode.org/versions/Unicode11.0.0/ El El mi?, mar. 7, 2018 a las 2:58 PM, escribi?: > New JEP Candidate: http://openjdk.java.net/jeps/327 > > - Mark > From rachna.goel at oracle.com Thu Mar 8 11:56:39 2018 From: rachna.goel at oracle.com (Rachna Goel) Date: Thu, 8 Mar 2018 17:26:39 +0530 Subject: [11] RFR: 8191410 : Unicode 10.0.0 Message-ID: Hi, Please review the proposed changes for JDK-819410. Bug : https://bugs.openjdk.java.net/browse/JDK-8191410 proposed changeset is located at : http://cr.openjdk.java.net/~rgoel/JDK-8191410/webrev/ This serves as the implementation for JEP 327. -- Thanks, Rachna From ivan.gerasimov at oracle.com Thu Mar 8 18:52:27 2018 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Thu, 8 Mar 2018 10:52:27 -0800 Subject: [11] RFR: 8191410 : Unicode 10.0.0 In-Reply-To: References: Message-ID: Hi Rachna! Just minor comments: You may want to update the initial capacity for the HashMaps: 1) private static Map map = new HashMap<>((int)(638 / 0.75f + 1.0f)); (the number 638 was determined as `cat Character.java | grep -A 2 'new UnicodeBlock' | grep '"' | wc -l`) 2) aliases = new HashMap<>((int)(142 / 0.75f + 1.0f)); (the number 142 was determined as `cat Character.java | grep '\saliases.put' | wc -l`) Also, I noticed that Character.java has got trailing spaces at some lines (e.g. at the line 2938). I assume these can be caught by `hg jcheck`. With kind regards, Ivan On 3/8/18 3:56 AM, Rachna Goel wrote: > Hi, > > Please review the proposed changes for JDK-819410. > > Bug : https://bugs.openjdk.java.net/browse/JDK-8191410 > > proposed changeset is located at : > > http://cr.openjdk.java.net/~rgoel/JDK-8191410/webrev/ > > This serves as the implementation for JEP 327. > -- With kind regards, Ivan Gerasimov From naoto.sato at oracle.com Thu Mar 8 19:27:30 2018 From: naoto.sato at oracle.com (Naoto Sato) Date: Thu, 8 Mar 2018 11:27:30 -0800 Subject: JEP 327: Unicode 10 In-Reply-To: References: <20180307225803.68F4F17AFF7@eggemoggin.niobe.net> Message-ID: Hi Steven, Since JDK now has shorter release cycle, Unicode 11 may not make it for JDK 11. Naoto On 3/7/18 6:45 PM, Steven R. Loomis wrote: > Unicode 11 is scheduled for June. > http://www.unicode.org/versions/Unicode11.0.0/ > > El El mi?, mar. 7, 2018 a las 2:58 PM, escribi?: > >> New JEP Candidate: http://openjdk.java.net/jeps/327 >> >> - Mark >> From srl at icu-project.org Thu Mar 8 20:13:13 2018 From: srl at icu-project.org (Steven R. Loomis) Date: Thu, 8 Mar 2018 12:13:13 -0800 Subject: JEP 327: Unicode 10 In-Reply-To: References: <20180307225803.68F4F17AFF7@eggemoggin.niobe.net> Message-ID: OK great. It would be good to mention this. Unicode 10.0 was released 9 month ago, and is released every June. So it is not too early to start the process on Unicode 11.0, it will be in alpha and then beta before too long. On Thu, Mar 8, 2018 at 11:27 AM, Naoto Sato wrote: > Hi Steven, > > Since JDK now has shorter release cycle, Unicode 11 may not make it for > JDK 11. > > Naoto > > > On 3/7/18 6:45 PM, Steven R. Loomis wrote: > >> Unicode 11 is scheduled for June. >> http://www.unicode.org/versions/Unicode11.0.0/ >> >> El El mi?, mar. 7, 2018 a las 2:58 PM, >> escribi?: >> >> New JEP Candidate: http://openjdk.java.net/jeps/327 >>> >>> - Mark >>> >>> From nishit.jain at oracle.com Tue Mar 20 17:37:26 2018 From: nishit.jain at oracle.com (Nishit Jain) Date: Tue, 20 Mar 2018 23:07:26 +0530 Subject: [11] RFR JDK-8196399, JDK-8199672: Formatting a decimal using locale-specific grouping..., ClassCastException is thrown... Message-ID: <9f714734-ddc5-22f8-0acf-2872689f7e77@oracle.com> Hi, Please review the fix for JDK-8196399 & JDK-8199672 Bug: https://bugs.openjdk.java.net/browse/JDK-8196399 https://bugs.openjdk.java.net/browse/JDK-8199672 Webrev: http://cr.openjdk.java.net/~nishjain/8196399_8199672/webrev.01/ Issue: 8196399: Locales such as hy_AM do not use grouping, but specify a grouping separator. Formatter throws ArithmeticException / by zero while identifying the position, as the grouping size is zero. 8199672: Unconditional casting of NumberFormat instance to DecimalFormat Fix: 8196399: Reset the grouping separator to null character, so that grouping separator position identification is skipped. 8199672: Check if the instance returned is DecimalFormat; else, use DecimalFormat constructor to obtain the instance. Regards, Nishit Jain From naoto.sato at oracle.com Tue Mar 20 17:58:43 2018 From: naoto.sato at oracle.com (Naoto Sato) Date: Tue, 20 Mar 2018 10:58:43 -0700 Subject: [11] RFR JDK-8196399, JDK-8199672: Formatting a decimal using locale-specific grouping..., ClassCastException is thrown... In-Reply-To: <9f714734-ddc5-22f8-0acf-2872689f7e77@oracle.com> References: <9f714734-ddc5-22f8-0acf-2872689f7e77@oracle.com> Message-ID: <5a9fd28d-e345-fe13-09c2-b76cf9594ce0@oracle.com> Looks good to me. Naoto On 3/20/18 10:37 AM, Nishit Jain wrote: > Hi, > > Please review the fix for JDK-8196399 & JDK-8199672 > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196399 > https://bugs.openjdk.java.net/browse/JDK-8199672 > Webrev: http://cr.openjdk.java.net/~nishjain/8196399_8199672/webrev.01/ > > Issue: > 8196399: Locales such as hy_AM do not use grouping, but specify a > grouping separator. Formatter throws ArithmeticException / by zero while > identifying the position, as the grouping size is zero. > 8199672: Unconditional casting of NumberFormat instance to DecimalFormat > > Fix: > 8196399: Reset the grouping separator to null character, so that > grouping separator position identification is skipped. > 8199672: Check if the instance returned is DecimalFormat; else, use > DecimalFormat constructor to obtain the instance. > > > Regards, > Nishit Jain From ramanand.patil at oracle.com Fri Mar 30 12:35:52 2018 From: ramanand.patil at oracle.com (Ramanand Patil) Date: Fri, 30 Mar 2018 05:35:52 -0700 (PDT) Subject: RFR: 8200359: (tz) Upgrade time-zone data to tzdata2018d Message-ID: <8cc4d720-e231-42d0-ab34-7b56b58b5b74@default> Hi all, Please review the latest TZDATA integration (tzdata2018d) into JDK11. Bug: https://bugs.openjdk.java.net/browse/JDK-8200359 Webrev: http://cr.openjdk.java.net/~rpatil/8200359/webrev.00/ All the TimeZone related tests are passed after integration. Regards, Ramanand. From naoto.sato at oracle.com Fri Mar 30 17:18:42 2018 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Fri, 30 Mar 2018 10:18:42 -0700 Subject: RFR: 8200359: (tz) Upgrade time-zone data to tzdata2018d In-Reply-To: <8cc4d720-e231-42d0-ab34-7b56b58b5b74@default> References: <8cc4d720-e231-42d0-ab34-7b56b58b5b74@default> Message-ID: <7e9b81c0-df92-32da-7bdb-6baaca0b6be1@oracle.com> Looks good. Naoto On 3/30/18 5:35 AM, Ramanand Patil wrote: > Hi all, > Please review the latest TZDATA integration (tzdata2018d) into JDK11. > Bug: https://bugs.openjdk.java.net/browse/JDK-8200359 > Webrev: http://cr.openjdk.java.net/~rpatil/8200359/webrev.00/ > > All the TimeZone related tests are passed after integration. > > Regards, > Ramanand. >