<i18n dev> [11] RFR: 8191410 : Unicode 10.0.0

[Ivan Gerasimov]

Hi Rachna!

Just minor comments:  You may want to update the initial capacity for 
the HashMaps:

1)
        private static Map<String, UnicodeBlock> map =
                 new HashMap<>((int)(638 / 0.75f + 1.0f));
(the number 638 was determined as `cat Character.java | grep -A 2 'new 
UnicodeBlock' | grep '"' | wc -l`)

2)
             aliases = new HashMap<>((int)(142 / 0.75f + 1.0f));
(the number 142 was determined as `cat Character.java | grep 
'\saliases.put' | wc -l`)

Also, I noticed that Character.java has got trailing spaces at some 
lines (e.g. at the line 2938).
I assume these can be caught by `hg jcheck`.

With kind regards,
Ivan

On 3/8/18 3:56 AM, Rachna Goel wrote:
> Hi,
>
> Please review the proposed changes for JDK-819410.
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8191410
>
> proposed changeset is located at :
>
> http://cr.openjdk.java.net/~rgoel/JDK-8191410/webrev/
>
> This serves as the implementation for JEP 327.
>

-- 
With kind regards,
Ivan Gerasimov