<i18n dev> [11] RFR: JDK-8202582 : DateTimeFormatterBuilder.parseOffsetBased unnecessarily calls toString()

Claes Redestad claes.redestad at oracle.com
Fri May 4 10:16:07 UTC 2018


Hi Rachna,

On 2018-05-04 10:59, Rachna Goel wrote:
> Hi,
>
> Kindly review this small patch for JDK-8202582.
>
> https://bugs.openjdk.java.net/browse/JDK-8202582
>
> http://cr.openjdk.java.net/~rgoel/JDK-8202582/webrev/
>
> Fix is to call text.subSequence() before calling toString() on input 
> string, for more performance.
>

this looks fine and should be a performance gain on most non-String 
CharSequences.

/Claes


More information about the i18n-dev mailing list