<i18n dev> Fwd: Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

[Ichiroh Takiguchi]

I'm very sorry for your confusion, please ignore previous mail.
I posted it on wrong mailing list.

Ichiroh Takiguchi

On 2018-11-15 03:11, Ichiroh Takiguchi wrote:
> Hello.
> 
> Martin Buchholz suggested me via bugs.openjdk.java.net,
> I should not touch non AIX side.
> So I rewrote another code.
> Could you review the fix again ?
> 
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8212794
> Change: https://cr.openjdk.java.net/~itakiguchi/8212794/webrev.01/
> 
> I don't want to touch non AIX side code, but I need to rename 3 files
> to avoid compilation issue.
> IBM33722.java -> IBM33722.java.template
> IBM964.java -> IBM964.java.template
> SimpleEUCEncoder.java -> SimpleEUCEncoder.java.template
> 
> Thanks,
> Ichiroh Takiguchi
> IBM Japan, Ltd.
> 
> -------- Original Message --------
> Subject: Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX
> default charset
> Date: 2018-11-08 20:13
> From: Volker Simonis <volker.simonis at gmail.com>
> To: Ichiroh Takiguchi <takiguc at linux.vnet.ibm.com>
> Cc: Java Core Libs <core-libs-dev at openjdk.java.net>,
> ppc-aix-port-dev at openjdk.java.net, "SHEN, XUEMING"
> <xueming.shen at oracle.com>,        Alan Bateman
> <Alan.Bateman at oracle.com>
> 
> Hi Ichiroh,
> 
> sorry, but unfortunately, this change is way beyond my level of 
> expertise :)
> 
> You should try to get a review from Sherman or Alan.
> 
> Regards,
> Volker
> On Fri, Oct 26, 2018 at 3:33 PM Ichiroh Takiguchi
> <takiguc at linux.vnet.ibm.com> wrote:
>> 
>> Hello.
>> 
>> Could you review the fix ?
>> 
>> Bug:    https://bugs.openjdk.java.net/browse/JDK-8212794
>> Change: https://cr.openjdk.java.net/~itakiguchi/8212794/webrev.00/
>> 
>> I'd like to obtain a sponsor for this issue.
>> 
>> 
>> IBM964 charset and IBM29626C charset are required for default charset
>> on AIX zh_TW and ja_JP locale.
>> OpenJDK already has IBM964, but it could not be configured for default
>> charset.
>> IBM29626C is new one.
>> (IBM33722 extends IBM29626C class)
>> 
>> I knew IBM charsets would need to move to somewhere.
>> The discussion was started by "Adding new IBM extended charsets". [1]
>> But it's related default charset issue.
>> Please put them inside of OpenJDK.
>> 
>> About IBM964,
>> Bhaktavatsal started the discussion [2].
>> Sherman said that [3]
>>    the new model (open/make/data/charetmapping), instead of 
>> hard-coding
>> the map
>>    into the source code.
>> 
>> This fix only has small sized hard-coded mapping,
>> IBM964/IBM29626C/IBM33722 refer other charsets conversion table
>> which are using the new model.
>> And class file is smaller then before.
>> Still I used SimpleEUCEncoder class because it's stable.
>> I think we may re-write it by IBM charsets renewal.
>> 
>> Thanks,
>> Ichiroh Takiguchi
>> IBM Japan, Ltd.
>> 
>> [1]
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-July/054248.html
>> [2]
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-May/053050.html
>> [3]
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-May/053096.html
>>