<i18n dev> [12]: RFR: Use CLDR's time zone mappings for Windows

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Sep 12 10:19:59 UTC 2018

On 2018-09-10 23:34, Naoto Sato wrote:
> Hello,
> Please review the fix to the following issue:
> https://bugs.openjdk.java.net/browse/JDK-8209167
> The proposed changeset is located at:
> http://cr.openjdk.java.net/~naoto/8209167/webrev.01/

Some comments:
In make/copy/Copy-java.base.gmk:
+ifneq ($(findstring $(OPENJDK_TARGET_OS), aix),)

The findstring construct is hard to read and only needed when we test 
more than one OS. Please rewrite as a single ifeq test for aix.

In GensrcCLDR.gmk:
I don't understand the CLDR_WINTZMAPPINGS file? There's no rule to 
generate it, there's just a dependency..?

The removal of the duplicate "common", that seems like a separate bug fix?


> This fix is to remove the hand crafted map file (lib/tzmappings) on 
> Windows, which maps Windows time zones to Java's tzid. It is now 
> dynamically generated at the build time, using CLDR's data file 
> (windowsZones.xml)
> Naoto

More information about the i18n-dev mailing list