<i18n dev> [RFR] [7u] 8202088: Japanese new era implementation

Andrew John Hughes gnu.andrew at redhat.com
Tue Apr 16 15:34:11 UTC 2019

On 15/04/2019 18:47, Andrew Haley wrote:
> On 4/13/19 3:03 AM, Andrew John Hughes wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8202088
>> Webrev: https://cr.openjdk.java.net/~andrew/openjdk7/8202088/webrev.01/
>> This is the backport of the Japanese new era placeholder implementation
>> to OpenJDK 7u. It is significantly smaller than the versions for 8u &
>> 11u, as 7u does not contain the java.time.* API and is also not subject
>> to the maintenance review [0] which adds the new code point support in
>> java.lang.Character.
>> What remains is the addition of the new era to the Japanese imperial
>> calendar implementation. Although this lives in java.util, the class is
>> package-private so there is no API change.
>> The remaining elements applied largely as is, with some whitespace
>> adjustments and differing copyright notices. The new tests were altered
>> to work around the lack of Calendar.Builder in OpenJDK 7.
>> Both new tests fail on the unpatched codebase with an
>> ArrayIndexOutOfBoundsException and pass on the patched version.
>> The second @run line is also removed from JapaneseEraNameTest.java as
>> OpenJDK 7 does not have multiple locale providers.
> Yes, thanks.

Thanks. Pushed:

Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

More information about the i18n-dev mailing list