<i18n dev> RFR(S): 8226869: Test java/util/Locale/LocaleProvidersRun.java should enable assertions (and reporting an issue that's unveiled by this)

[Langer, Christoph]

Thanks Naoto.

I'll hold back the push (in JDK13) until JDK-8226876 is in.

/Christoph

> -----Original Message-----
> From: naoto.sato at oracle.com <naoto.sato at oracle.com>
> Sent: Donnerstag, 27. Juni 2019 18:03
> To: Langer, Christoph <christoph.langer at sap.com>; i18n-
> dev at openjdk.java.net; Java Core Libs <core-libs-dev at openjdk.java.net>
> Cc: Ying Zhou <ying.z.zhou at oracle.com>
> Subject: Re: RFR(S): 8226869: Test java/util/Locale/LocaleProvidersRun.java
> should enable assertions (and reporting an issue that's unveiled by this)
> 
> Hi Christoph,
> 
> Thanks for discovering the issue and resolving it. Your change looks
> good to me. We will work on the actual issue you raised shortly.
> 
> Naoto
> 
> On 6/27/19 1:51 AM, Langer, Christoph wrote:
> > Hi,
> >
> > Please, first of all, review a little test fix. Java level assertions
> > should be enabled in test java/util/Locale/LocaleProvidersRun.java. It
> > was (probably inadvertently) removed by refactoring the test with
> > JDK-8210403 (Refactor java.util.Locale:i18n shell tests to plain java
> > tests).
> >
> > Resolving this bug will unveil a regression on Windows caused by
> > JDK-8218960 (CONFIG level logging statements printed in
> > CLDRCalendarDataProviderImpl.java even when default log Level is INFO)
> > for which I just created a bug report:
> > https://bugs.openjdk.java.net/browse/JDK-8226876. I discovered this
> > because I backported JDK-8218960 to JDK11u and encountered the
> assertion
> > in the old test.
> >
> > Since this test fix will open up a new test failure, I’m not sure
> > whether it should be pushed to JDK13. If JDK-8226876 could be resolved
> > quickly, the fix for this issue could be pushed after it. Or I add a
> > temporary exclusion for Windows to the test list – however that would
> > probably disable other important regression tests. Please advise.
> >
> > That said, please assign JDK-8226876 to the right engineer - it’s not my
> > area of expertise ��
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8226869
> >
> > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8226869.0/
> >
> > Thanks
> >
> > Christoph
> >