<i18n dev> [13] RFR: 8221432: Upgrade CLDR to Version 35.1

naoto.sato at oracle.com naoto.sato at oracle.com
Tue May 7 20:43:54 UTC 2019

Hi Steven,

Thanks for your comments. My comments are embedded below.

On 5/7/19 1:32 PM, Steven R. Loomis wrote:
> Hi Naoto,
>    The comment in 
> http://cr.openjdk.java.net/~naoto/8221432/webrev.02/make/jdk/src/classes/build/tools/cldrconverter/Bundle.java.udiff.html 
> "fix up 'Reiwa' era, which can be missing in some locales” seems to 
> imply that fallback resolution isn’t working properly, because that data 
> (R) is present in root.xml.

Right. Currently it is a known restriction, as Java holds the Japanese 
era names as a string array in the resource bundle, and it won't 
fallback per array elements. Thus it is fixed using the names in root on 
resource bundle generation.

>   The deleted comment in the same file, "Some locale data has no default 
> script for numbering even with mutiple scripts” is not true for the same 
> reason.

Contrary to the above, now this is working as you would expect as this 
is a single resource bundle element. If the default numbering system is 
missing, it is retrieved from the parent resource bundle (thus the 
comment is deleted).


>   Otherwise the changes look as expected on a spot check.
> --
> Steven R. Loomis | @srl295 | git.io/srl295 <http://git.io/srl295>
>> El may. 7, 2019, a las 1:12 p. m., naoto.sato at oracle.com 
>> <mailto:naoto.sato at oracle.com> escribió:
>> Hello,
>> Please review the fix to the following issue:
>> https://bugs.openjdk.java.net/browse/JDK-8221432
>> The proposed changeset is located at:
>> http://cr.openjdk.java.net/~naoto/8221432/webrev.02/
>> The webrev is big, but the large amount of the changes is simply 
>> replacing the CLDR data files from v33 to v35.1, which includes the 
>> translations for the Japanese new era, Reiwa.
>> Naoto

More information about the i18n-dev mailing list