<i18n dev> [14] RFR: 8231273: Upgrade CLDR to v36

naoto.sato at oracle.com naoto.sato at oracle.com
Fri Oct 25 23:31:00 UTC 2019

Hi Roger,

Thanks for the review.

On 10/25/2019 AD 11:57 午前, Roger Riggs wrote:
> HI Naoto,
> cldrconverter/Bundle.java:
> 233-246:  If there is a parent list, it seems to ignore/drop patterns 
> greater than plist.size().
> This would be clearer if it always processed all the patterns and used 
> the parent
> if the pattern[i] was empty and i < plist.size().  Switching around the 
> range size leads to confusion.
> (Or I misunderstand the intent).

The code assumed that parents' lists are always longer than self, which 
is true, but you are right that it can be more readable. Corrected as 


Bundle:233-246 is the only change since 00.

> Is the algorithm intended to produce the longest list (parent and pattern)?

Since at runtime, there's no way to fallback element by element basis, 
the array should always contain all the elements (i.e., longest) possible.


> Otherwise, looks fine.
> Thanks, Roger
> On 10/9/19 6:39 PM, naoto.sato at oracle.com wrote:
>> Hi,
>> Please review the fix to the following issue:
>> https://bugs.openjdk.java.net/browse/JDK-8231273
>> The proposed changeset is located at:
>> https://cr.openjdk.java.net/~naoto/8231273/webrev.00/
>> The webrev is huge, but majority of the changes is just to replace the 
>> CLDR source locale data from version 35.1 to 36. The real code changes 
>> are under make/jdk/src/classes/build/tools/cldrconverter, where it now 
>> handles aliases for currency/percent formats, and retrieves 
>> per-element fallback strings for compact number patterns. Also 
>> relevant tests are modified accordingly.
>> Naoto

More information about the i18n-dev mailing list