<i18n dev> RFR: 8242541: Small charset issues (ISO8859-16, x-eucJP-Open, x-IBM834 and x-IBM949C)
Ichiroh Takiguchi
takiguc at linux.vnet.ibm.com
Tue Apr 28 18:41:42 UTC 2020
Hello Naoto.
Thank you for your attention.
And I'm sorry about bad response.
I added ISO8859_16 entry into
test/jdk/java/nio/charset/Charset/RegisteredCharsets.java
Could you review the fix again ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8242541
Change: https://cr.openjdk.java.net/~itakiguchi/8242541/webrev.01/
Thanks,
Ichiroh Takiguchi
On 2020-04-23 00:54, naoto.sato at oracle.com wrote:
> Hi Takiguchi-san,
>
> Change looks good. I'd expect a test case in
> open/test/jdk/java/nio/charset/Charset/RegisteredCharsets.java for the
> added "ISO8859_16" alias.
>
> Naoto
>
> On 4/20/20 6:37 PM, Ichiroh Takiguchi wrote:
>> Hello.
>>
>> Could you review the fix ?
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8242541
>> Change: https://cr.openjdk.java.net/~itakiguchi/8242541/webrev.00/
>>
>> I applied following changes:
>> * Missing historical name alias in ISO8859-16
>> * Typo hisname on x-eucJP-Open
>> * x-IBM834 and x-IBM949C charset source codes should be template style
>>
>> I appreciate your feedback and suggestions.
>>
>> Thanks,
>> Ichiroh Takiguchi
>> IBM Japan, Ltd.
More information about the i18n-dev
mailing list