<i18n dev> RFR: 8251499: no-placeholder compact number patterns throw IllegalArgumentException

Joe Wang huizhe.wang at oracle.com
Sat Aug 15 01:21:15 UTC 2020

Hi Naoto,

Looks good to me.

While a negative divisor representing no zeros is newly introduced, the 
"divisor > 0" checks seem to have always been beneficial.  I had to 
count the number of ""s in COMPACT_PATTERN13 :-)

Have a great weekend!

On 8/14/2020 3:20 PM, naoto.sato at oracle.com wrote:
> Hello,
> Please review the fix for the following issue:
> https://bugs.openjdk.java.net/browse/JDK-8251499
> The proposed changeset is located at:
> https://cr.openjdk.java.net/~naoto/8251499/webrev.00/
> The current implementation of CompactNumberFormat assumes that there 
> is always the number placeholder part in compact patterns. This is not 
> always true. In fact, upcoming CLDR 38 resurrects such patterns, so 
> this fix is a precursor to support CLDR 38.
> Naoto

More information about the i18n-dev mailing list