<i18n dev> RFR: 8252497: Incorrect numeric currency code for ROL

Naoto Sato naoto.sato at oracle.com
Sat Aug 29 21:26:40 UTC 2020


Looks good. I believe you can push the fix through hg till Sep. 3 COB 
(hg repository becomes read only on Sep. 4) [0]

Naoto

[0] https://mail.openjdk.java.net/pipermail/jdk-dev/2020-August/004588.html

On 8/29/20 1:07 AM, Yuri Nesterenko wrote:
> And, how about push? Would it be possible to push to Mercurial repo of jdk 16 on or before Sep 1
> or will it be the new Git repo soon after Sep 5, or is it a matter of later decision?
> 
> --yan
> 
> On 29.08.2020 10:55, Yuri Nesterenko wrote:
>> Thank you, Naoto!
>>
>> Yes, you are right, while some sites insist on 2: for instance,
>> https://help.sap.com/saphelp_pos22/helpdata/en/4f/efa63a9bb04d94a0ae4c32fd6cd827/content.htm?no_cache=true
>>   -- so I have been confused -- the official amendment fax on www.currency-iso.org
>> https://www.currency-iso.org/dam/downloads/dl_currency_iso_amendment_126.pdf
>> states minor unit 0 (no wonder with denomination 10000 to 1).
>>
>> Updated webrev is
>> http://cr.openjdk.java.net/~yan/8252497/webrev.1/
>>
>> Thank you again!
>> --yan
>>
>> On 28.08.2020 19:41, Naoto Sato wrote:
>>> Sorry, another comment here. The ROL currency seemed to have no minor unit (minor digit is zero). So
>>> it should be listed in "minor0" property.
>>>
>>> Naoto
>>>
>>> On 8/28/20 9:30 AM, Naoto Sato wrote:
>>>> Hi Yuri,
>>>>
>>>> Thanks for the catch! Looks good to me. Please update the copyright year to 2020 before the push.
>>>>
>>>> Naoto
>>>>
>>>> On 8/28/20 3:32 AM, Yuri Nesterenko wrote:
>>>>> Hi,
>>>>>
>>>>> I have a customer requiring an obsolete currency ROL for something.
>>>>> They pointed that numeric code for it should be 642, and they cannot
>>>>> change that value using java.util.currency.data file.
>>>>>
>>>>> Bug is: https://bugs.openjdk.java.net/browse/JDK-8252497
>>>>> The trivial fix is in CurrencyData.properties:
>>>>> http://cr.openjdk.java.net/~yan/8252497/webrev.0/
>>>>>
>>>>> I'll put there noreg-trivial label.
>>>>>
>>>>> Thanks,
>>>>> --yan
>>>>>
> 


More information about the i18n-dev mailing list