<i18n dev> [15] RFR: 8174270: Consolidate ICU sources in one location

[Steven R. Loomis]

approve

--
Steven R. Loomis | @srl295 | git.io/srl295



> El ene. 10, 2020, a las 4:02 p. m., naoto.sato at oracle.com escribió:
> 
> Hi Steven,
> 
> On 1/10/20 2:26 PM, Steven R. Loomis wrote:
>> in Norm2AllModes.java and UBiDiProps.java  and UCharacterProperty.java the stub name (icudt64b) should be calculated from the version number.   At least put “icudt64b” in one place and refer to it.
> 
> Good point. Modified as suggested:
> 
> https://cr.openjdk.java.net/~naoto/8174270/webrev.01/
> 
> Naoto
> 
>> OR keep the data file names unversioned, such as src/java.base/share/classes/jdk/internal/icu/impl/data/nfc.nrm
>> otherwise looks good
>> --
>> Steven R. Loomis | @srl295 | git.io/srl295 <http://git.io/srl295>
>>> El ene. 10, 2020, a las 2:02 p. m., naoto.sato at oracle.com <mailto:naoto.sato at oracle.com> escribió:
>>> 
>>> Hi,
>>> 
>>> Please review the fix to the following issue:
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8174270
>>> 
>>> The proposed changeset is located at:
>>> 
>>> https://cr.openjdk.java.net/~naoto/8174270/webrev.00/
>>> 
>>> Although the number of modified files are huge, the change is simply moving the scattered ICU sources in various locations under jdk.internal.icu package, keeping the original ICU's source tree structure.
>>> 
>>> Naoto