<i18n dev> RFR 8232161: Align some one-way conversion in MS950 charset with Windows

naoto.sato at oracle.com naoto.sato at oracle.com
Tue Mar 3 01:31:14 UTC 2020


Hi Takiguchi-san,

A few comments:

- I'd recommend sorting the entries in MS950.nr and test data in 
TestMS950.java for readability.

- Add some comment about the objective in the test. It'd be hard for 
engineers who have no previous knowledge to these bytes.

Naoto



On 3/2/20 9:33 AM, Ichiroh Takiguchi wrote:
> Hello.
> 
> Could you review the fix ?
> 
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8232161
> Change: https://cr.openjdk.java.net/~itakiguchi/8232161/webrev.01/
> 
> CSR 8233385 [1] was approved.
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8233385
> 
> Thanks,
> Ichiroh Takiguchi
> IBM Japan, Ltd.


More information about the i18n-dev mailing list