<i18n dev> RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

[Yasumasa Suenaga]

Hi Nakamura-san,

Your change almost looks good, but I have one question.
Length of exeName (1024) is enough?

According to Microsoft Doc [1], exeName might not be null-terminated if it failed.
I concern buffer overrun might occur when QueryFullProcessImageNameW failed.


Thanks,

Yasumasa


[1] https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-queryfullprocessimagenamew


On 2020/03/26 17:58, Toshio 5 Nakamura wrote:
> 
> Hi All,
> 
> Could you review this change? Additionally, I'd like to ask a sponsor for
> it, since I'm not a committer.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8232846
> Webrev: http://cr.openjdk.java.net/~tnakamura/8232846/webrev.00
> 
> Under Windows environments, ProcessHandle.Info.command shows question marks
> if the command has non-English characters. I'd like to change the
> underlying API to Unicode version.
> Tier1 tests passed.
> 
> Best regards,
> Toshio Nakamura
>