<i18n dev> [15]: RFR: 8244245: localizedBy() should override localized values with default values

naoto.sato at oracle.com naoto.sato at oracle.com
Thu May 7 16:06:02 UTC 2020


Hi Roger,

Thank you for the review. Wrapped the long lines as suggested, along 
with some typo fixes in the comments:

https://cr.openjdk.java.net/~naoto/8244245/webrev.01/

Naoto

On 5/7/20 7:43 AM, Roger Riggs wrote:
> Hi Naoto,
> 
> Looks fine with a small source edit below.
> 
> TestUnicodeExtension.java: Please wrap the excessively long lines; 
> string concatination will put them together for the test.
> 
> Thanks, Roger
> 
> 
> On 5/6/20 4:44 PM, naoto.sato at oracle.com wrote:
>> Hello,
>>
>> Please review the fix to the following issue:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8244245
>>
>> The CSR and proposed changeset are located at:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8244246
>> https://cr.openjdk.java.net/~naoto/8244245/webrev.00/
>>
>> This stems from the closed issue 
>> (https://bugs.openjdk.java.net/browse/JDK-8243162), and the rationale 
>> for this fix is discussed there.
>>
>> Naoto
>>
> 


More information about the i18n-dev mailing list