<i18n dev> RFR: 8247781: Day periods support [v3]
Stephen Colebourne
scolebourne at openjdk.java.net
Mon Nov 2 17:44:02 UTC 2020
On Fri, 30 Oct 2020 22:03:08 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Hi,
>>
>> Please review the changes for the subject issue. This is to enhance the java.time package to support day periods, such as "in the morning", defined in CLDR. It will add a new pattern character 'B' and its supporting builder method. The motivation and its spec are in this CSR:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8254629
>>
>> Naoto
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>
> Fixed exception messages.
test/jdk/java/time/test/java/time/format/TestDateTimeFormatterBuilder.java line 656:
> 654: {"h B", "11 at night", 23},
> 655: {"h B", "3 at night", 3},
> 656: {"h B", "11 in the morning", 11},
Need tests for "51 in the morning" (which should parse in LENIENT as "3 in the morning" plus 2 days, see how HOUR_OF_DAY=51 works in general.
Similar issue with HOUR_OF_AMPM=3 and AMPM_OF_DAY=4.
-------------
PR: https://git.openjdk.java.net/jdk/pull/938
More information about the i18n-dev
mailing list