<i18n dev> RFR: 8247781: Day periods support [v4]

Naoto Sato naoto at openjdk.java.net
Mon Nov 2 23:23:57 UTC 2020


On Mon, 2 Nov 2020 17:08:10 GMT, Stephen Colebourne <scolebourne at openjdk.org> wrote:

>> src/java.base/share/classes/java/time/format/Parsed.java line 497:
>> 
>>> 495:                         AMPM_OF_DAY.checkValidValue(ap);
>>> 496:                     }
>>> 497:                     updateCheckDayPeriodConflict(AMPM_OF_DAY, midpoint / 720);
>> 
>> No need to put `AMPM_OF_DAY` back in here because you've already resolved it to `HOUR_OF_DAY` and `MINUTE_OF_HOUR`. There probably does need to be validation to check that the day period agrees with the AM/PM value.
>
> Line can still be removed AFAICT

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/938


More information about the i18n-dev mailing list