<i18n dev> RFR: 8255086: Update the root locale display names [v2]

Joe Wang joehw at openjdk.java.net
Fri Oct 23 00:24:25 UTC 2020

On Thu, 22 Oct 2020 23:20:08 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Hi Joe,
> > Do we need a test similar to ISO3166 where display names of Locale.ROOT and Locale.US are compared? I see LocaleEnhanceTest.java has references to Locale.ROOT and a few selected names were updated. But we don't seem to have a test like ISO3166 that does a straight-forward comparison.
> test/jdk/sun/text/resources/LocaleData validates all the changes with this changeset (added lines at the end), by checking the names in the resource bundle.

Saw the test and thought ISO3166 would be more direct. But you're right, as you said below, since it's one-off thing, can't really use a test like ISO3166 for a complete comparison.
> > The code you used to generate the updated LocaleNames.properties (in the comment section), that seems to be valuable. I wonder if there's a better way to preserve it, as part of the manual tool, or maybe put it back into the repo as part of a test?
> Yeah, but I cannot think of a better location to preserve it. The reason is that it cannot be used as a test because CLDR's English names and COMPAT's root names can inherently be different. I just regard the code to be one-off to retrieve authentic English names for those language ids.

I see. Thanks.


> Naoto


PR: https://git.openjdk.java.net/jdk/pull/786

More information about the i18n-dev mailing list