From github.com+471021+marschall at openjdk.java.net  Mon Sep  7 17:08:40 2020
From: github.com+471021+marschall at openjdk.java.net (Philippe Marschall)
Date: Mon, 7 Sep 2020 17:08:40 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
Message-ID: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>

Hello, newbie here

I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.

- I tried to update the copyright year to 2020 in every file.
- I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.
- I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
  imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.
- All tier1 tests pass.
- One jpackage/jlink tier2 test fails but I don't believe it is related.
- Some tier3 Swing tests fail but I don't think they are related.

-------------

Commit messages:
 - 8138732: Rename HotSpotIntrinsicCandidate to IntrinsicCandidate

Changes: https://git.openjdk.java.net/jdk/pull/45/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=45&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8138732
  Stats: 747 lines in 63 files changed: 149 ins; 148 del; 450 mod
  Patch: https://git.openjdk.java.net/jdk/pull/45.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/45/head:pull/45

PR: https://git.openjdk.java.net/jdk/pull/45

From alanb at openjdk.java.net  Mon Sep  7 17:53:50 2020
From: alanb at openjdk.java.net (Alan Bateman)
Date: Mon, 7 Sep 2020 17:53:50 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
In-Reply-To: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
Message-ID: <ItYAhauIRGS7WUhbX-arCKt8GsHDlvH72Gg8nabO49o=.2b94da4b-6e69-41b3-baed-555c6f62cfc2@github.com>

On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall <github.com+471021+marschall at openjdk.org> wrote:

> Hello, newbie here
> 
> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
> 
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.
> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
>   imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.
> - All tier1 tests pass.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.

This one probably needs discussion on hotspot-dev to get agreement on the rename/move. It might need coordination with
Graal. If the change does go ahead then please check if java.base's module-info.java still needs to export jdk.internal
to jdk.jfr, I suspect that qualified export can be removed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/45

From david.holmes at oracle.com  Tue Sep  8 01:11:09 2020
From: david.holmes at oracle.com (David Holmes)
Date: Tue, 8 Sep 2020 11:11:09 +1000
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
In-Reply-To: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
Message-ID: <369201b2-087d-44c5-d020-26c239d172aa@oracle.com>

Hi Philippe,

On 8/09/2020 3:08 am, Philippe Marschall wrote:
> Hello, newbie here

Welcome aboard!

> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
> 
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.

That's somewhat debatable, but I don't think @since really serves any 
useful purpose on non-public APIs, so I'm fine either way.

> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
>    imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.

The changes all look good to me.

Thanks,
David
-----

> - All tier1 tests pass.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.
> 
> -------------
> 
> Commit messages:
>   - 8138732: Rename HotSpotIntrinsicCandidate to IntrinsicCandidate
> 
> Changes: https://git.openjdk.java.net/jdk/pull/45/files
>   Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=45&range=00
>    Issue: https://bugs.openjdk.java.net/browse/JDK-8138732
>    Stats: 747 lines in 63 files changed: 149 ins; 148 del; 450 mod
>    Patch: https://git.openjdk.java.net/jdk/pull/45.diff
>    Fetch: git fetch https://git.openjdk.java.net/jdk pull/45/head:pull/45
> 
> PR: https://git.openjdk.java.net/jdk/pull/45
> 

From dholmes at openjdk.java.net  Tue Sep  8 01:13:41 2020
From: dholmes at openjdk.java.net (David Holmes)
Date: Tue, 8 Sep 2020 01:13:41 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
In-Reply-To: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
Message-ID: <7422UelQpc0A_Q-YQ_TIQ-ihtR0d-7lTmQVaG2o0owg=.fea1ee30-463d-44e2-b63a-26b6baa2559b@github.com>

On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall <github.com+471021+marschall at openjdk.org> wrote:

> Hello, newbie here
> 
> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
> 
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.
> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
>   imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.
> - All tier1 tests pass.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.

The changes all look good to me.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/45

From github.com+471021+marschall at openjdk.java.net  Wed Sep  9 09:49:44 2020
From: github.com+471021+marschall at openjdk.java.net (Philippe Marschall)
Date: Wed, 9 Sep 2020 09:49:44 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v2]
In-Reply-To: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
Message-ID: <HGsatCKpnNbiuasm8cuzQI43pSP8i6zy8TwbXY7tZHY=.e83599d8-69c0-4f04-b34e-26d64b23a04e@github.com>

> Hello, newbie here
> 
> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
> 
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.
> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
>   imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.
> - All tier1 tests pass.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.

Philippe Marschall has refreshed the contents of this pull request, and previous commits have been removed. The
incremental views will show differences compared to the previous content of the PR. The pull request contains one new
commit since the last revision:

  8138732: Rename HotSpotIntrinsicCandidate to IntrinsicCandidate

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/45/files
  - new: https://git.openjdk.java.net/jdk/pull/45/files/47328f4b..1c9dd9da

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=45&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=45&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/45.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/45/head:pull/45

PR: https://git.openjdk.java.net/jdk/pull/45

From alanb at openjdk.java.net  Thu Sep 10 06:58:57 2020
From: alanb at openjdk.java.net (Alan Bateman)
Date: Thu, 10 Sep 2020 06:58:57 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v2]
In-Reply-To: <HGsatCKpnNbiuasm8cuzQI43pSP8i6zy8TwbXY7tZHY=.e83599d8-69c0-4f04-b34e-26d64b23a04e@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
 <HGsatCKpnNbiuasm8cuzQI43pSP8i6zy8TwbXY7tZHY=.e83599d8-69c0-4f04-b34e-26d64b23a04e@github.com>
Message-ID: <J64b0nTpS6gQRu5UZ23yVBLt0LfBeZnaBg6o5w-Gkb8=.373ca47c-be15-4d59-9e6b-f338944cccab@github.com>

On Wed, 9 Sep 2020 09:49:44 GMT, Philippe Marschall <github.com+471021+marschall at openjdk.org> wrote:

>> Hello, newbie here
>> 
>> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
>> 
>> - I tried to update the copyright year to 2020 in every file.
>> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.
>> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
>>   imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.
>> - All tier1 tests pass.
>> - One jpackage/jlink tier2 test fails but I don't believe it is related.
>> - Some tier3 Swing tests fail but I don't think they are related.
>
> Philippe Marschall has refreshed the contents of this pull request, and previous commits have been removed. The
> incremental views will show differences compared to the previous content of the PR. The pull request contains one new
> commit since the last revision:
>   8138732: Rename HotSpotIntrinsicCandidate to IntrinsicCandidate

Marked as reviewed by alanb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/45

From github.com+2210496+thatsIch at openjdk.java.net  Thu Sep 10 08:52:25 2020
From: github.com+2210496+thatsIch at openjdk.java.net (thatsIch)
Date: Thu, 10 Sep 2020 08:52:25 GMT
Subject: <i18n dev> RFR: 8252999: replace all String.equals("") usages
 with String.isEmpty()
In-Reply-To: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
Message-ID: <Uz2OHmxIsEUSXJlmN2DC3dMpXKNLK05hHBTmWUuFzbA=.ee49cee4-90eb-4335-b3ef-129f6fdf1fdd@github.com>

On Sun, 6 Sep 2020 13:57:19 GMT, Dmitriy Dumanskiy <github.com+1536494+doom369 at openjdk.org> wrote:

> **isEmpty** is faster + has less byte code + easier to read. Benchmarks could be found
>   [here](https://medium.com/javarevisited/micro-optimizations-in-java-string-equals-22be19fd8416).

@doom369 jcheck requires an associated issue

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From github.com+1536494+doom369 at openjdk.java.net  Thu Sep 10 08:52:21 2020
From: github.com+1536494+doom369 at openjdk.java.net (Dmitriy Dumanskiy)
Date: Thu, 10 Sep 2020 08:52:21 GMT
Subject: <i18n dev> RFR: 8252999: replace all String.equals("") usages with
 String.isEmpty()
Message-ID: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>

**isEmpty** is faster + has less byte code + easier to read. Benchmarks could be found
  [here](https://medium.com/javarevisited/micro-optimizations-in-java-string-equals-22be19fd8416).

-------------

Commit messages:
 - Merge branch 'master' of https://github.com/doom369/jdk into reaplce_equals_with_is_empty
 - revert change in classes that maintain jdk 1.4 compatibility
 - Improvement: replace all occurrences of the .equals("") usages with .isEmpty()

Changes: https://git.openjdk.java.net/jdk/pull/29/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=29&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8252999
  Stats: 234 lines in 150 files changed: 0 ins; 0 del; 234 mod
  Patch: https://git.openjdk.java.net/jdk/pull/29.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/29/head:pull/29

PR: https://git.openjdk.java.net/jdk/pull/29

From kcr at openjdk.java.net  Thu Sep 10 08:52:25 2020
From: kcr at openjdk.java.net (Kevin Rushforth)
Date: Thu, 10 Sep 2020 08:52:25 GMT
Subject: <i18n dev> RFR: 8252999: replace all String.equals("") usages
 with String.isEmpty()
In-Reply-To: <s4Dpfxc4ztYVytcmpoJ8o8CVGF-keaYhlZ6F6nZyFTA=.7fe47c15-9c79-4002-982e-5b6323b5b992@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
 <Uz2OHmxIsEUSXJlmN2DC3dMpXKNLK05hHBTmWUuFzbA=.ee49cee4-90eb-4335-b3ef-129f6fdf1fdd@github.com>
 <s4Dpfxc4ztYVytcmpoJ8o8CVGF-keaYhlZ6F6nZyFTA=.7fe47c15-9c79-4002-982e-5b6323b5b992@github.com>
Message-ID: <bZGWCYL6PaL9aChWvRqeg3ivhnI57L34vwbq3ZVe5II=.12655cbd-205d-43b2-9d7f-d522643c4180@github.com>

On Wed, 9 Sep 2020 07:57:48 GMT, Dmitriy Dumanskiy <github.com+1536494+doom369 at openjdk.org> wrote:

>> @doom369 jcheck requires an associated issue
>
> @mrserb hello. Thanks for the review. Any further actions required from me?

Before this Enhancement can be formally reviewed, you will need a JBS bug ID. If you are already working with a
Committer or Reviewer in the `jdk` project who has agreed to sponsor your change, they can file the Enhancement
request. Otherwise, you can file it using the web interface at [bugreport.java.com](https://bugreport.java.com/). Once
you have a JBS bug ID, you need to edit the PR title to include that bug ID (without the `JDK-`) replacing
"Improvement".

Since this PR cuts across many functional areas (each gray label represents a functional area), you should expect a
longer review process, since someone from each functional area will need to look at the changes in their area (like
@mrserb started to do for the `2d` area).

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From github.com+1536494+doom369 at openjdk.java.net  Thu Sep 10 08:52:25 2020
From: github.com+1536494+doom369 at openjdk.java.net (Dmitriy Dumanskiy)
Date: Thu, 10 Sep 2020 08:52:25 GMT
Subject: <i18n dev> RFR: 8252999: replace all String.equals("") usages
 with String.isEmpty()
In-Reply-To: <Uz2OHmxIsEUSXJlmN2DC3dMpXKNLK05hHBTmWUuFzbA=.ee49cee4-90eb-4335-b3ef-129f6fdf1fdd@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
 <Uz2OHmxIsEUSXJlmN2DC3dMpXKNLK05hHBTmWUuFzbA=.ee49cee4-90eb-4335-b3ef-129f6fdf1fdd@github.com>
Message-ID: <s4Dpfxc4ztYVytcmpoJ8o8CVGF-keaYhlZ6F6nZyFTA=.7fe47c15-9c79-4002-982e-5b6323b5b992@github.com>

On Sun, 6 Sep 2020 18:08:15 GMT, thatsIch <github.com+2210496+thatsIch at openjdk.org> wrote:

>> **isEmpty** is faster + has less byte code + easier to read. Benchmarks could be found
>>   [here](https://medium.com/javarevisited/micro-optimizations-in-java-string-equals-22be19fd8416).
>
> @doom369 jcheck requires an associated issue

@mrserb hello. Thanks for the review. Any further actions required from me?

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From serb at openjdk.java.net  Thu Sep 10 08:52:29 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Thu, 10 Sep 2020 08:52:29 GMT
Subject: <i18n dev> RFR: 8252999: replace all String.equals("") usages
 with String.isEmpty()
In-Reply-To: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
Message-ID: <aEysicdznhelazv6VnUAtKnv9CGn-Mrkuk5ym3GQXJU=.1187719b-9d05-4038-955a-698b13f1a22e@github.com>

On Sun, 6 Sep 2020 13:57:19 GMT, Dmitriy Dumanskiy <github.com+1536494+doom369 at openjdk.org> wrote:

> **isEmpty** is faster + has less byte code + easier to read. Benchmarks could be found
>   [here](https://medium.com/javarevisited/micro-optimizations-in-java-string-equals-22be19fd8416).

src/demo/share/java2d/J2DBench/src/j2dbench/tests/iio/InputImageTests.java line 187:

> 185:             String format = spi.getFormatNames()[0].toLowerCase();
> 186:             String suffix = spi.getFileSuffixes()[0].toLowerCase();
> 187:             if (suffix == null || suffix.equals("")) {

This file intentionally maintains compatibility to jdk1.4, so equals("") should be used.

src/demo/share/java2d/J2DBench/src/j2dbench/tests/iio/OutputImageTests.java line 146:

> 144:             String format = spi.getFormatNames()[0].toLowerCase();
> 145:             String suffix = spi.getFileSuffixes()[0].toLowerCase();
> 146:             if (suffix == null || suffix.equals("")) {

This file intentionally maintains compatibility to jdk1.4, so equals("") should be used.

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From github.com+1536494+doom369 at openjdk.java.net  Thu Sep 10 08:52:26 2020
From: github.com+1536494+doom369 at openjdk.java.net (Dmitriy Dumanskiy)
Date: Thu, 10 Sep 2020 08:52:26 GMT
Subject: <i18n dev> RFR: 8252999: replace all String.equals("") usages
 with String.isEmpty()
In-Reply-To: <bZGWCYL6PaL9aChWvRqeg3ivhnI57L34vwbq3ZVe5II=.12655cbd-205d-43b2-9d7f-d522643c4180@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
 <Uz2OHmxIsEUSXJlmN2DC3dMpXKNLK05hHBTmWUuFzbA=.ee49cee4-90eb-4335-b3ef-129f6fdf1fdd@github.com>
 <s4Dpfxc4ztYVytcmpoJ8o8CVGF-keaYhlZ6F6nZyFTA=.7fe47c15-9c79-4002-982e-5b6323b5b992@github.com>
 <bZGWCYL6PaL9aChWvRqeg3ivhnI57L34vwbq3ZVe5II=.12655cbd-205d-43b2-9d7f-d522643c4180@github.com>
Message-ID: <EG2AaHulAbDCWaUXKTM2SYyYKJAlyv4wPH8vMD7YN4I=.13747b8b-193f-4897-bb1f-cdea88788c19@github.com>

On Wed, 9 Sep 2020 20:21:44 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> @mrserb hello. Thanks for the review. Any further actions required from me?
>
> Before this Enhancement can be formally reviewed, you will need a JBS bug ID. If you are already working with a
> Committer or Reviewer in the `jdk` project who has agreed to sponsor your change, they can file the Enhancement
> request. Otherwise, you can file it using the web interface at [bugreport.java.com](https://bugreport.java.com/). Once
> you have a JBS bug ID, you need to edit the PR title to include that bug ID (without the `JDK-`) replacing
> "Improvement".   Since this PR cuts across many functional areas (each gray label represents a functional area), you
> should expect a longer review process, since someone from each functional area will need to look at the changes in
> their area (like @mrserb started to do for the `2d` area).

@kevinrushforth thanks. Done.

Similar issues:
https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8215014
https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8251246
https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8223237

could be joined somehow?

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From alanb at openjdk.java.net  Thu Sep 10 10:42:57 2020
From: alanb at openjdk.java.net (Alan Bateman)
Date: Thu, 10 Sep 2020 10:42:57 GMT
Subject: <i18n dev> RFR: 8252999: Cleanup: replace .equals("") with
 .isEmpty() within all codebase
In-Reply-To: <EG2AaHulAbDCWaUXKTM2SYyYKJAlyv4wPH8vMD7YN4I=.13747b8b-193f-4897-bb1f-cdea88788c19@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
 <Uz2OHmxIsEUSXJlmN2DC3dMpXKNLK05hHBTmWUuFzbA=.ee49cee4-90eb-4335-b3ef-129f6fdf1fdd@github.com>
 <s4Dpfxc4ztYVytcmpoJ8o8CVGF-keaYhlZ6F6nZyFTA=.7fe47c15-9c79-4002-982e-5b6323b5b992@github.com>
 <bZGWCYL6PaL9aChWvRqeg3ivhnI57L34vwbq3ZVe5II=.12655cbd-205d-43b2-9d7f-d522643c4180@github.com>
 <EG2AaHulAbDCWaUXKTM2SYyYKJAlyv4wPH8vMD7YN4I=.13747b8b-193f-4897-bb1f-cdea88788c19@github.com>
Message-ID: <RhgVZZkdjYZ23msG0z90uDYpRCDZAYOXHkuMCB4myIA=.0407f304-8900-4442-81db-206e5c28e94f@github.com>

On Thu, 10 Sep 2020 08:47:35 GMT, Dmitriy Dumanskiy <github.com+1536494+doom369 at openjdk.org> wrote:

>> Before this Enhancement can be formally reviewed, you will need a JBS bug ID. If you are already working with a
>> Committer or Reviewer in the `jdk` project who has agreed to sponsor your change, they can file the Enhancement
>> request. Otherwise, you can file it using the web interface at [bugreport.java.com](https://bugreport.java.com/). Once
>> you have a JBS bug ID, you need to edit the PR title to include that bug ID (without the `JDK-`) replacing
>> "Improvement".   Since this PR cuts across many functional areas (each gray label represents a functional area), you
>> should expect a longer review process, since someone from each functional area will need to look at the changes in
>> their area (like @mrserb started to do for the `2d` area).
>
> @kevinrushforth thanks. Done.
> 
> Similar issues:
> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8215014
> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8251246
> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8223237
> 
> could be joined somehow?

The code in java.base was updated to use String::isEmpty in JDK 12 (JDK-8215281). There was follow-up in JDK 13 to do
the same in the java.desktop module (JDK-8223237). Changing the remaining usages make sense although I see that more
more than half are in tests.

It would be good to hear from security-dev on the changes to the Apache Santuario code (in java.xml.crypto module) in
case it would be better to contribute those upstream instead. Ditto for the Apache Xalan code (in the java.xml module)
but it may be significantly forked already that it doesn't matter.

I assume you can use JDK-8215014 rather than creating a new issue.

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From dholmes at openjdk.java.net  Thu Sep 10 11:24:10 2020
From: dholmes at openjdk.java.net (David Holmes)
Date: Thu, 10 Sep 2020 11:24:10 GMT
Subject: <i18n dev> RFR: 8252999: Cleanup: replace .equals("") with
 .isEmpty() within all codebase
In-Reply-To: <RhgVZZkdjYZ23msG0z90uDYpRCDZAYOXHkuMCB4myIA=.0407f304-8900-4442-81db-206e5c28e94f@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
 <Uz2OHmxIsEUSXJlmN2DC3dMpXKNLK05hHBTmWUuFzbA=.ee49cee4-90eb-4335-b3ef-129f6fdf1fdd@github.com>
 <s4Dpfxc4ztYVytcmpoJ8o8CVGF-keaYhlZ6F6nZyFTA=.7fe47c15-9c79-4002-982e-5b6323b5b992@github.com>
 <bZGWCYL6PaL9aChWvRqeg3ivhnI57L34vwbq3ZVe5II=.12655cbd-205d-43b2-9d7f-d522643c4180@github.com>
 <EG2AaHulAbDCWaUXKTM2SYyYKJAlyv4wPH8vMD7YN4I=.13747b8b-193f-4897-bb1f-cdea88788c19@github.com>
 <RhgVZZkdjYZ23msG0z90uDYpRCDZAYOXHkuMCB4myIA=.0407f304-8900-4442-81db-206e5c28e94f@github.com>
Message-ID: <vf6XOpFruWkQM31EotFH9neaVYUYCAeHgl7UiZ3O86w=.6170d7ed-9e5e-4a30-a263-e9935d534cb1@github.com>

On Thu, 10 Sep 2020 10:40:15 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> @kevinrushforth thanks. Done.
>> 
>> Similar issues:
>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8215014
>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8251246
>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8223237
>> 
>> could be joined somehow?
>
> The code in java.base was updated to use String::isEmpty in JDK 12 (JDK-8215281). There was follow-up in JDK 13 to do
> the same in the java.desktop module (JDK-8223237). Changing the remaining usages make sense although I see that more
> more than half are in tests.  It would be good to hear from security-dev on the changes to the Apache Santuario code
> (in java.xml.crypto module) in case it would be better to contribute those upstream instead. Ditto for the Apache Xalan
> code (in the java.xml module) but it may be significantly forked already that it doesn't matter.  I assume you can use
> JDK-8215014 rather than creating a new issue.

This should be broken up to deal with the files in different functional areas under different bugids and PRs. Otherwise
the cross-posting to so many lists is prohibitive. Files in different areas need to be reviewed by different teams.
Thank you.

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From github.com+1536494+doom369 at openjdk.java.net  Thu Sep 10 12:07:57 2020
From: github.com+1536494+doom369 at openjdk.java.net (Dmitriy Dumanskiy)
Date: Thu, 10 Sep 2020 12:07:57 GMT
Subject: <i18n dev> RFR: 8252999: Cleanup: replace .equals("") with
 .isEmpty() within all codebase
In-Reply-To: <vf6XOpFruWkQM31EotFH9neaVYUYCAeHgl7UiZ3O86w=.6170d7ed-9e5e-4a30-a263-e9935d534cb1@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
 <Uz2OHmxIsEUSXJlmN2DC3dMpXKNLK05hHBTmWUuFzbA=.ee49cee4-90eb-4335-b3ef-129f6fdf1fdd@github.com>
 <s4Dpfxc4ztYVytcmpoJ8o8CVGF-keaYhlZ6F6nZyFTA=.7fe47c15-9c79-4002-982e-5b6323b5b992@github.com>
 <bZGWCYL6PaL9aChWvRqeg3ivhnI57L34vwbq3ZVe5II=.12655cbd-205d-43b2-9d7f-d522643c4180@github.com>
 <EG2AaHulAbDCWaUXKTM2SYyYKJAlyv4wPH8vMD7YN4I=.13747b8b-193f-4897-bb1f-cdea88788c19@github.com>
 <RhgVZZkdjYZ23msG0z90uDYpRCDZAYOXHkuMCB4myIA=.0407f304-8900-4442-81db-206e5c28e94f@github.com>
 <vf6XOpFruWkQM31EotFH9neaVYUYCAeHgl7UiZ3O86w=.6170d7ed-9e5e-4a30-a263-e9935d534cb1@github.com>
Message-ID: <UmOwAZdDjRUy8bDiA_JOHuuleuCqay-vBLNQ0FNsX0s=.f890cd55-60df-4f5a-a04b-8279ccbc6d74@github.com>

On Thu, 10 Sep 2020 11:21:28 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> The code in java.base was updated to use String::isEmpty in JDK 12 (JDK-8215281). There was follow-up in JDK 13 to do
>> the same in the java.desktop module (JDK-8223237). Changing the remaining usages make sense although I see that more
>> more than half are in tests.  It would be good to hear from security-dev on the changes to the Apache Santuario code
>> (in java.xml.crypto module) in case it would be better to contribute those upstream instead. Ditto for the Apache Xalan
>> code (in the java.xml module) but it may be significantly forked already that it doesn't matter.  I assume you can use
>> JDK-8215014 rather than creating a new issue.
>
> This should be broken up to deal with the files in different functional areas under different bugids and PRs. Otherwise
> the cross-posting to so many lists is prohibitive. Files in different areas need to be reviewed by different teams.
> Thank you.

I have in mind dozens of improvements all over the code like this one. I already did some further review and in most
cases, those tiny changes go trough all codebase. I can create PR for every separate module, but in general, it would
multiply x5 the number of PRs in total. If you think it's a better way to go, no problem, I can do that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From kcr at openjdk.java.net  Thu Sep 10 12:21:25 2020
From: kcr at openjdk.java.net (Kevin Rushforth)
Date: Thu, 10 Sep 2020 12:21:25 GMT
Subject: <i18n dev> RFR: 8252999: Cleanup: replace .equals("") with
 .isEmpty() within all codebase
In-Reply-To: <vf6XOpFruWkQM31EotFH9neaVYUYCAeHgl7UiZ3O86w=.6170d7ed-9e5e-4a30-a263-e9935d534cb1@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
 <Uz2OHmxIsEUSXJlmN2DC3dMpXKNLK05hHBTmWUuFzbA=.ee49cee4-90eb-4335-b3ef-129f6fdf1fdd@github.com>
 <s4Dpfxc4ztYVytcmpoJ8o8CVGF-keaYhlZ6F6nZyFTA=.7fe47c15-9c79-4002-982e-5b6323b5b992@github.com>
 <bZGWCYL6PaL9aChWvRqeg3ivhnI57L34vwbq3ZVe5II=.12655cbd-205d-43b2-9d7f-d522643c4180@github.com>
 <EG2AaHulAbDCWaUXKTM2SYyYKJAlyv4wPH8vMD7YN4I=.13747b8b-193f-4897-bb1f-cdea88788c19@github.com>
 <RhgVZZkdjYZ23msG0z90uDYpRCDZAYOXHkuMCB4myIA=.0407f304-8900-4442-81db-206e5c28e94f@github.com>
 <vf6XOpFruWkQM31EotFH9neaVYUYCAeHgl7UiZ3O86w=.6170d7ed-9e5e-4a30-a263-e9935d534cb1@github.com>
Message-ID: <6drWa_0thvT1k2sn1DI5b-0dHKXc1M7UL2gfwDGb894=.5f2f6415-9b4b-4cfb-a271-96ed185d7018@github.com>

On Thu, 10 Sep 2020 11:21:28 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> The code in java.base was updated to use String::isEmpty in JDK 12 (JDK-8215281). There was follow-up in JDK 13 to do
>> the same in the java.desktop module (JDK-8223237). Changing the remaining usages make sense although I see that more
>> more than half are in tests.  It would be good to hear from security-dev on the changes to the Apache Santuario code
>> (in java.xml.crypto module) in case it would be better to contribute those upstream instead. Ditto for the Apache Xalan
>> code (in the java.xml module) but it may be significantly forked already that it doesn't matter.  I assume you can use
>> JDK-8215014 rather than creating a new issue.
>
> This should be broken up to deal with the files in different functional areas under different bugids and PRs. Otherwise
> the cross-posting to so many lists is prohibitive. Files in different areas need to be reviewed by different teams.
> Thank you.

@dholmes-ora raises a good point. Hopefully there is a balance point between a dozen different bugs / pull requests
each targeting one area and one bug / PR targeting a dozen separate areas. I don't have a good general rule to suggest.
Maybe @AlanBateman or @jddarcy can offer some advice?

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From dholmes at openjdk.java.net  Thu Sep 10 13:56:10 2020
From: dholmes at openjdk.java.net (David Holmes)
Date: Thu, 10 Sep 2020 13:56:10 GMT
Subject: <i18n dev> RFR: 8252999: Cleanup: replace .equals("") with
 .isEmpty() within all codebase
In-Reply-To: <6drWa_0thvT1k2sn1DI5b-0dHKXc1M7UL2gfwDGb894=.5f2f6415-9b4b-4cfb-a271-96ed185d7018@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
 <Uz2OHmxIsEUSXJlmN2DC3dMpXKNLK05hHBTmWUuFzbA=.ee49cee4-90eb-4335-b3ef-129f6fdf1fdd@github.com>
 <s4Dpfxc4ztYVytcmpoJ8o8CVGF-keaYhlZ6F6nZyFTA=.7fe47c15-9c79-4002-982e-5b6323b5b992@github.com>
 <bZGWCYL6PaL9aChWvRqeg3ivhnI57L34vwbq3ZVe5II=.12655cbd-205d-43b2-9d7f-d522643c4180@github.com>
 <EG2AaHulAbDCWaUXKTM2SYyYKJAlyv4wPH8vMD7YN4I=.13747b8b-193f-4897-bb1f-cdea88788c19@github.com>
 <RhgVZZkdjYZ23msG0z90uDYpRCDZAYOXHkuMCB4myIA=.0407f304-8900-4442-81db-206e5c28e94f@github.com>
 <vf6XOpFruWkQM31EotFH9neaVYUYCAeHgl7UiZ3O86w=.6170d7ed-9e5e-4a30-a263-e9935d534cb1@github.com>
 <6drWa_0thvT1k2sn1DI5b-0dHKXc1M7UL2gfwDGb894=.5f2f6415-9b4b-4cfb-a271-96ed185d7018@github.com>
Message-ID: <hxHaq469yWas5NkTBoPcq3fNY0agxVZm-qyjb46fWKw=.9f84d74d-5a27-4f06-ac0d-40d3955db517@github.com>

On Thu, 10 Sep 2020 12:18:51 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> This should be broken up to deal with the files in different functional areas under different bugids and PRs. Otherwise
>> the cross-posting to so many lists is prohibitive. Files in different areas need to be reviewed by different teams.
>> Thank you.
>
> @dholmes-ora raises a good point. Hopefully there is a balance point between a dozen different bugs / pull requests
> each targeting one area and one bug / PR targeting a dozen separate areas. I don't have a good general rule to suggest.
> Maybe @AlanBateman or @jddarcy can offer some advice?

14 cc'd mailing lists is unworkable. You need to be subscribed to lists to post, but even if you are a reply-all will
be delayed due to all of the mails being held up for moderator approval due to:

" Too many recipients to the message"

I have a longer email coming once it gets through the moderator approval delay. :(

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From alanb at openjdk.java.net  Thu Sep 10 15:53:05 2020
From: alanb at openjdk.java.net (Alan Bateman)
Date: Thu, 10 Sep 2020 15:53:05 GMT
Subject: <i18n dev> RFR: 8252999: Cleanup: replace .equals("") with
 .isEmpty() within all codebase
In-Reply-To: <hxHaq469yWas5NkTBoPcq3fNY0agxVZm-qyjb46fWKw=.9f84d74d-5a27-4f06-ac0d-40d3955db517@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
 <Uz2OHmxIsEUSXJlmN2DC3dMpXKNLK05hHBTmWUuFzbA=.ee49cee4-90eb-4335-b3ef-129f6fdf1fdd@github.com>
 <s4Dpfxc4ztYVytcmpoJ8o8CVGF-keaYhlZ6F6nZyFTA=.7fe47c15-9c79-4002-982e-5b6323b5b992@github.com>
 <bZGWCYL6PaL9aChWvRqeg3ivhnI57L34vwbq3ZVe5II=.12655cbd-205d-43b2-9d7f-d522643c4180@github.com>
 <EG2AaHulAbDCWaUXKTM2SYyYKJAlyv4wPH8vMD7YN4I=.13747b8b-193f-4897-bb1f-cdea88788c19@github.com>
 <RhgVZZkdjYZ23msG0z90uDYpRCDZAYOXHkuMCB4myIA=.0407f304-8900-4442-81db-206e5c28e94f@github.com>
 <vf6XOpFruWkQM31EotFH9neaVYUYCAeHgl7UiZ3O86w=.6170d7ed-9e5e-4a30-a263-e9935d534cb1@github.com>
 <6drWa_0thvT1k2sn1DI5b-0dHKXc1M7UL2gfwDGb894=.5f2f6415-9b4b-4cfb-a271-96ed185d7018@github.com>
 <hxHaq469yWas5NkTBoPcq3fNY0agxVZm-qyjb46fWKw=.9f84d74d-5a27-4f06-ac0d-40d3955db517@github.com>
Message-ID: <50JcAGF8QbzHSjiilInuGqZqR4A1eil1uYZPH21gcjY=.52e6da5f-de51-4457-9dc0-cfb4c5fc043c@github.com>

On Thu, 10 Sep 2020 13:53:10 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> @dholmes-ora raises a good point. Hopefully there is a balance point between a dozen different bugs / pull requests
>> each targeting one area and one bug / PR targeting a dozen separate areas. I don't have a good general rule to suggest.
>> Maybe @AlanBateman or @jddarcy can offer some advice?
>
> 14 cc'd mailing lists is unworkable. You need to be subscribed to lists to post, but even if you are a reply-all will
> be delayed due to all of the mails being held up for moderator approval due to:
> " Too many recipients to the message"
> 
> I have a longer email coming once it gets through the moderator approval delay. :(

Patches that do global replace are always awkward. In this case, there are 150 files changed and most seem to be tests
or changes to tools used in the build (includes src/hotspot/share/prims/jvmtiEnvFill.java). If these are dropped from
the patch then it leaves just 43 files, many of which are from 3rd party code that can also be dropped. This should
reduce the patch down to a manageable 24 or so files that should be trivial to review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From jvernee at openjdk.java.net  Thu Sep 10 16:40:57 2020
From: jvernee at openjdk.java.net (Jorn Vernee)
Date: Thu, 10 Sep 2020 16:40:57 GMT
Subject: <i18n dev> RFR: 8252999: Cleanup: replace .equals("") with
 .isEmpty() within all codebase
In-Reply-To: <50JcAGF8QbzHSjiilInuGqZqR4A1eil1uYZPH21gcjY=.52e6da5f-de51-4457-9dc0-cfb4c5fc043c@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
 <Uz2OHmxIsEUSXJlmN2DC3dMpXKNLK05hHBTmWUuFzbA=.ee49cee4-90eb-4335-b3ef-129f6fdf1fdd@github.com>
 <s4Dpfxc4ztYVytcmpoJ8o8CVGF-keaYhlZ6F6nZyFTA=.7fe47c15-9c79-4002-982e-5b6323b5b992@github.com>
 <bZGWCYL6PaL9aChWvRqeg3ivhnI57L34vwbq3ZVe5II=.12655cbd-205d-43b2-9d7f-d522643c4180@github.com>
 <EG2AaHulAbDCWaUXKTM2SYyYKJAlyv4wPH8vMD7YN4I=.13747b8b-193f-4897-bb1f-cdea88788c19@github.com>
 <RhgVZZkdjYZ23msG0z90uDYpRCDZAYOXHkuMCB4myIA=.0407f304-8900-4442-81db-206e5c28e94f@github.com>
 <vf6XOpFruWkQM31EotFH9neaVYUYCAeHgl7UiZ3O86w=.6170d7ed-9e5e-4a30-a263-e9935d534cb1@github.com>
 <6drWa_0thvT1k2sn1DI5b-0dHKXc1M7UL2gfwDGb894=.5f2f6415-9b4b-4cfb-a271-96ed185d7018@github.com>
 <hxHaq469yWas5NkTBoPcq3fNY0agxVZm-qyjb46fWKw=.9f84d74d-5a27-4f06-ac0d-40d3955db517@github.com>
 <50JcAGF8QbzHSjiilInuGqZqR4A1eil1uYZPH21gcjY=.52e6da5f-de51-4457-9dc0-cfb4c5fc043c@github.com>
Message-ID: <sqVZp_6QZM6fNGnBf1aPZzIUcp1nAnxMqiXc79Gcivg=.0ca2205a-496a-43ff-8ed2-3b9158947565@github.com>

On Thu, 10 Sep 2020 15:50:39 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> 14 cc'd mailing lists is unworkable. You need to be subscribed to lists to post, but even if you are a reply-all will
>> be delayed due to all of the mails being held up for moderator approval due to:
>> " Too many recipients to the message"
>> 
>> I have a longer email coming once it gets through the moderator approval delay. :(
>
> Patches that do global replace are always awkward. In this case, there are 150 files changed and most seem to be tests
> or changes to tools used in the build (includes src/hotspot/share/prims/jvmtiEnvFill.java). If these are dropped from
> the patch then it leaves just 43 files, many of which are from 3rd party code that can also be dropped. This should
> reduce the patch down to a manageable 24 or so files that should be trivial to review.

Since one of the motivations for this change is micro benchmark performance, please add a benchmark to the JDKs micro
benchmark suite as well. (see e.g. https://github.com/openjdk/jdk/tree/master/test/micro/org/openjdk/bench/java/lang).

Also, what testing has been done for these changes?

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From psandoz at openjdk.java.net  Thu Sep 10 18:02:26 2020
From: psandoz at openjdk.java.net (Paul Sandoz)
Date: Thu, 10 Sep 2020 18:02:26 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v2]
In-Reply-To: <HGsatCKpnNbiuasm8cuzQI43pSP8i6zy8TwbXY7tZHY=.e83599d8-69c0-4f04-b34e-26d64b23a04e@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
 <HGsatCKpnNbiuasm8cuzQI43pSP8i6zy8TwbXY7tZHY=.e83599d8-69c0-4f04-b34e-26d64b23a04e@github.com>
Message-ID: <9vXfRW4SRrizofvC6H9WecRjoXNNMwvscj7I5nlfj1Q=.c3760baf-604b-4a61-ae24-59500edca721@github.com>

On Wed, 9 Sep 2020 09:49:44 GMT, Philippe Marschall <github.com+471021+marschall at openjdk.org> wrote:

>> Hello, newbie here
>> 
>> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
>> 
>> - I tried to update the copyright year to 2020 in every file.
>> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.
>> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
>>   imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.
>> - All tier1 tests pass.
>> - One jpackage/jlink tier2 test fails but I don't believe it is related.
>> - Some tier3 Swing tests fail but I don't think they are related.
>
> Philippe Marschall has refreshed the contents of this pull request, and previous commits have been removed. The
> incremental views will show differences compared to the previous content of the PR. The pull request contains one new
> commit since the last revision:
>   8138732: Rename HotSpotIntrinsicCandidate to IntrinsicCandidate

Marked as reviewed by psandoz (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/45

From jjg at openjdk.java.net  Thu Sep 10 23:31:29 2020
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Thu, 10 Sep 2020 23:31:29 GMT
Subject: <i18n dev> RFR: 8252999: Cleanup: replace .equals("") with
 .isEmpty() within all codebase
In-Reply-To: <UmOwAZdDjRUy8bDiA_JOHuuleuCqay-vBLNQ0FNsX0s=.f890cd55-60df-4f5a-a04b-8279ccbc6d74@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
 <Uz2OHmxIsEUSXJlmN2DC3dMpXKNLK05hHBTmWUuFzbA=.ee49cee4-90eb-4335-b3ef-129f6fdf1fdd@github.com>
 <s4Dpfxc4ztYVytcmpoJ8o8CVGF-keaYhlZ6F6nZyFTA=.7fe47c15-9c79-4002-982e-5b6323b5b992@github.com>
 <bZGWCYL6PaL9aChWvRqeg3ivhnI57L34vwbq3ZVe5II=.12655cbd-205d-43b2-9d7f-d522643c4180@github.com>
 <EG2AaHulAbDCWaUXKTM2SYyYKJAlyv4wPH8vMD7YN4I=.13747b8b-193f-4897-bb1f-cdea88788c19@github.com>
 <RhgVZZkdjYZ23msG0z90uDYpRCDZAYOXHkuMCB4myIA=.0407f304-8900-4442-81db-206e5c28e94f@github.com>
 <vf6XOpFruWkQM31EotFH9neaVYUYCAeHgl7UiZ3O86w=.6170d7ed-9e5e-4a30-a263-e9935d534cb1@github.com>
 <UmOwAZdDjRUy8bDiA_JOHuuleuCqay-vBLNQ0FNsX0s=.f890cd55-60df-4f5a-a04b-8279ccbc6d74@github.com>
Message-ID: <RuK66AvDU9XlrIII6VIYPIZNQt5xty-Z2gkJZZGaRP0=.6306e1fa-3549-434b-a7f6-64fcbf2ca9a9@github.com>

On Thu, 10 Sep 2020 12:04:48 GMT, Dmitriy Dumanskiy <github.com+1536494+doom369 at openjdk.org> wrote:

> I have in mind dozens of improvements all over the code like this one.

That sounds scary. Broad updates like these cause unnecessary churn in the codebase, and can make merging and back
porting harder.  Changes should be discussed ahead of time with the appropriate teams.

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From prr at openjdk.java.net  Fri Sep 11 00:00:15 2020
From: prr at openjdk.java.net (Phil Race)
Date: Fri, 11 Sep 2020 00:00:15 GMT
Subject: <i18n dev> RFR: 8252999: Cleanup: replace .equals("") with
 .isEmpty() within all codebase
In-Reply-To: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
Message-ID: <ixnZDnRQQk_8EUg-xd1yjRdJwziB5BPXsjcvDe65mTY=.9caade8e-d002-4eba-b30f-a0dd640556f5@github.com>

On Sun, 6 Sep 2020 13:57:19 GMT, Dmitriy Dumanskiy <github.com+1536494+doom369 at openjdk.org> wrote:

> **isEmpty** is faster + has less byte code + easier to read. Benchmarks could be found
>   [here](https://medium.com/javarevisited/micro-optimizations-in-java-string-equals-22be19fd8416).

1) This is un-necessary churn.
2) I can't even be sure I am finding the ones in my area because there's so much here
3) The ones I can find have no need of whatever performance improvement this might bring.
I think this whole PR should be withdrawn, and there may an attempt at measuring the benefits of this for the various
cases before submitting in appropriate smaller chunks. But I'll tell you now I don't see a need for the test updates
you are making.

-------------

Changes requested by prr (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/29

From github.com+1536494+doom369 at openjdk.java.net  Fri Sep 11 07:18:17 2020
From: github.com+1536494+doom369 at openjdk.java.net (Dmitriy Dumanskiy)
Date: Fri, 11 Sep 2020 07:18:17 GMT
Subject: <i18n dev> Withdrawn: 8252999: Cleanup: replace .equals("") with
 .isEmpty() within all codebase
In-Reply-To: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
Message-ID: <SoRJWuPi6M1TQzIgq1tc0LrOm_kxedJLJ3s4bDt3FDc=.93684533-25d5-4204-ae41-614c60138b02@github.com>

On Sun, 6 Sep 2020 13:57:19 GMT, Dmitriy Dumanskiy <github.com+1536494+doom369 at openjdk.org> wrote:

> **isEmpty** is faster + has less byte code + easier to read. Benchmarks could be found
>   [here](https://medium.com/javarevisited/micro-optimizations-in-java-string-equals-22be19fd8416).

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From github.com+1536494+doom369 at openjdk.java.net  Fri Sep 11 07:18:17 2020
From: github.com+1536494+doom369 at openjdk.java.net (Dmitriy Dumanskiy)
Date: Fri, 11 Sep 2020 07:18:17 GMT
Subject: <i18n dev> RFR: 8252999: Cleanup: replace .equals("") with
 .isEmpty() within all codebase
In-Reply-To: <ixnZDnRQQk_8EUg-xd1yjRdJwziB5BPXsjcvDe65mTY=.9caade8e-d002-4eba-b30f-a0dd640556f5@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
 <ixnZDnRQQk_8EUg-xd1yjRdJwziB5BPXsjcvDe65mTY=.9caade8e-d002-4eba-b30f-a0dd640556f5@github.com>
Message-ID: <sxPCBvVvKws7tJgaBigC2uhhopnJ8QTSi0EOaJHE0tM=.2a3cfee3-d472-4601-9a47-e220c7fe8f65@github.com>

On Thu, 10 Sep 2020 23:57:38 GMT, Phil Race <prr at openjdk.org> wrote:

>> **isEmpty** is faster + has less byte code + easier to read. Benchmarks could be found
>>   [here](https://medium.com/javarevisited/micro-optimizations-in-java-string-equals-22be19fd8416).
>
> 1) This is un-necessary churn.
> 2) I can't even be sure I am finding the ones in my area because there's so much here
> 3) The ones I can find have no need of whatever performance improvement this might bring.
> I think this whole PR should be withdrawn, and there may an attempt at measuring the benefits of this for the various
> cases before submitting in appropriate smaller chunks. But I'll tell you now I don't see a need for the test updates
> you are making.

Ok, sorry for the distraction.

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From wetmore at openjdk.java.net  Fri Sep 11 15:20:36 2020
From: wetmore at openjdk.java.net (Bradford Wetmore)
Date: Fri, 11 Sep 2020 15:20:36 GMT
Subject: <i18n dev> RFR: 8252999: Cleanup: replace .equals("") with
 .isEmpty() within all codebase
In-Reply-To: <sxPCBvVvKws7tJgaBigC2uhhopnJ8QTSi0EOaJHE0tM=.2a3cfee3-d472-4601-9a47-e220c7fe8f65@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
 <ixnZDnRQQk_8EUg-xd1yjRdJwziB5BPXsjcvDe65mTY=.9caade8e-d002-4eba-b30f-a0dd640556f5@github.com>
 <sxPCBvVvKws7tJgaBigC2uhhopnJ8QTSi0EOaJHE0tM=.2a3cfee3-d472-4601-9a47-e220c7fe8f65@github.com>
Message-ID: <GUdSjk78l7ZplBebkhUDAgQ4zUewkfpaVfUR1bGQzkc=.9b8a5876-06ea-4009-9d7d-a07a8887e534@github.com>

On Fri, 11 Sep 2020 07:15:26 GMT, Dmitriy Dumanskiy <github.com+1536494+doom369 at openjdk.org> wrote:

>> 1) This is un-necessary churn.
>> 2) I can't even be sure I am finding the ones in my area because there's so much here
>> 3) The ones I can find have no need of whatever performance improvement this might bring.
>> I think this whole PR should be withdrawn, and there may an attempt at measuring the benefits of this for the various
>> cases before submitting in appropriate smaller chunks. But I'll tell you now I don't see a need for the test updates
>> you are making.
>
> Ok, sorry for the distraction.

Our local Santuario maintainer says:

In general, changes to Apache Santuario should also be made at Apache so we stay in sync.

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From naoto.sato at oracle.com  Fri Sep 11 16:33:57 2020
From: naoto.sato at oracle.com (Naoto Sato)
Date: Fri, 11 Sep 2020 09:33:57 -0700
Subject: <i18n dev> Case insensitive regexes and collators
In-Reply-To: <CAEotdwnVA3QdA7JKdUEE8dhMZ8fOcmF-HguyqgkhgrADJVRmtg@mail.gmail.com>
References: <CAEotdwnVA3QdA7JKdUEE8dhMZ8fOcmF-HguyqgkhgrADJVRmtg@mail.gmail.com>
Message-ID: <6f7d07ad-a8e0-dc68-b7ce-a5b774adf228@oracle.com>

Hi David,

Glad to hear that you are delighted with the recent fix (JDK-8248655). 
The scope of the fix is limited to the String class, so it may or may 
not affect the said RegEx and/or Collator case insensitive operations. I 
created the following two issues to track your observations:

https://bugs.openjdk.java.net/browse/JDK-8253058
https://bugs.openjdk.java.net/browse/JDK-8253059

And happy to take a look at them.

PS. "jdk-dev" is for the technical discussion related to the "JDK 
Project", so I'd recommend choosing either core-libs and/or i18n-dev 
mailing lists for the further discussion.

Naoto

On 9/10/20 3:52 PM, Dai Conrad wrote:
> I was delighted to hear the longstanding problem with
> case-insensitive comparisons of strings with astral
> characters (ones outside the basic multilingual plane)
> was fixed in JDK 16 build 8. Methods equalsIgnoreCase,
> regionMatches, and compareToIgnoreCase all work
> correctly now.
> 
> I had assumed this would also fix case-insensitive regular
> expressions and java.text.Collator, since I guessed they
> boiled down to a call to regionMatches somewhere under
> the covers. But this appears not to be the... case.
> 
> For scripts Deseret, Osage, Old Hungarian, Warang Citi,
> Medefaidrin, and Adlam, for strings with upper- and
> lowercase variants of the same letter, the following
> code fails:
> 
> Pattern pattern = Pattern.compile(lower, Pattern.CASE_INSENSITIVE);
> Matcher matcher = pattern.matcher(upper);
> assertThat(matcher.matches()).isTrue();
> 
> Collator collator = Collator.getInstance();
> collator.setStrength(Collator.PRIMARY);
> assertThat(collator.compare(lower, upper)).isEqualTo(0);
> 
> I'm not sure why the fix didn't fix these, but it would be
> a shame to overlook them while fixing it in other places.
> 
> David
> 

From kvn at openjdk.java.net  Fri Sep 11 21:57:54 2020
From: kvn at openjdk.java.net (Vladimir Kozlov)
Date: Fri, 11 Sep 2020 21:57:54 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v2]
In-Reply-To: <zzU4Q3HcnKoXLcx3C9OK_9snDjbaSaPgajTReIKH6So=.22ccc55c-665b-4a13-b8e5-0a7373e56a9f@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
 <HGsatCKpnNbiuasm8cuzQI43pSP8i6zy8TwbXY7tZHY=.e83599d8-69c0-4f04-b34e-26d64b23a04e@github.com>
 <9vXfRW4SRrizofvC6H9WecRjoXNNMwvscj7I5nlfj1Q=.c3760baf-604b-4a61-ae24-59500edca721@github.com>
 <zzU4Q3HcnKoXLcx3C9OK_9snDjbaSaPgajTReIKH6So=.22ccc55c-665b-4a13-b8e5-0a7373e56a9f@github.com>
Message-ID: <pBQFF064cVceI6ZiMfdTX4WcJG4MpWcr9R1sqacGVOI=.56e4d2d9-0722-4bf7-a194-6ebd82e2bd73@github.com>

On Fri, 11 Sep 2020 21:53:12 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Marked as reviewed by psandoz (Reviewer).
>
> You should consider upstreaming Graal changes (jdk.internal.vm.compiler) into https://github.com/oracle/graal
> Otherwise next time we do "Update Graal" in JDK they will be overwritten.

Changes look good. I ran hs-tier1 and hs-tier3 test jobs which run Graal tests and they passed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/45

From kvn at openjdk.java.net  Fri Sep 11 21:57:54 2020
From: kvn at openjdk.java.net (Vladimir Kozlov)
Date: Fri, 11 Sep 2020 21:57:54 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v2]
In-Reply-To: <9vXfRW4SRrizofvC6H9WecRjoXNNMwvscj7I5nlfj1Q=.c3760baf-604b-4a61-ae24-59500edca721@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
 <HGsatCKpnNbiuasm8cuzQI43pSP8i6zy8TwbXY7tZHY=.e83599d8-69c0-4f04-b34e-26d64b23a04e@github.com>
 <9vXfRW4SRrizofvC6H9WecRjoXNNMwvscj7I5nlfj1Q=.c3760baf-604b-4a61-ae24-59500edca721@github.com>
Message-ID: <zzU4Q3HcnKoXLcx3C9OK_9snDjbaSaPgajTReIKH6So=.22ccc55c-665b-4a13-b8e5-0a7373e56a9f@github.com>

On Thu, 10 Sep 2020 17:59:54 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Philippe Marschall has refreshed the contents of this pull request, and previous commits have been removed. The
>> incremental views will show differences compared to the previous content of the PR.
>
> Marked as reviewed by psandoz (Reviewer).

You should consider upstreaming Graal changes (jdk.internal.vm.compiler) into https://github.com/oracle/graal
Otherwise next time we do "Update Graal" in JDK they will be overwritten.

-------------

PR: https://git.openjdk.java.net/jdk/pull/45

From kvn at openjdk.java.net  Sat Sep 12 00:21:29 2020
From: kvn at openjdk.java.net (Vladimir Kozlov)
Date: Sat, 12 Sep 2020 00:21:29 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v2]
In-Reply-To: <HGsatCKpnNbiuasm8cuzQI43pSP8i6zy8TwbXY7tZHY=.e83599d8-69c0-4f04-b34e-26d64b23a04e@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
 <HGsatCKpnNbiuasm8cuzQI43pSP8i6zy8TwbXY7tZHY=.e83599d8-69c0-4f04-b34e-26d64b23a04e@github.com>
Message-ID: <BLuZ7WSu8-JWFdqRPuGRObrSizRQxepj928eU9taifY=.e2cf4679-a25c-4ff0-9d0c-f7c91f34461c@github.com>

On Wed, 9 Sep 2020 09:49:44 GMT, Philippe Marschall <github.com+471021+marschall at openjdk.org> wrote:

>> Hello, newbie here
>> 
>> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
>> 
>> - I tried to update the copyright year to 2020 in every file.
>> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.
>> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
>>   imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.
>> - All tier1 tests pass.
>> - One jpackage/jlink tier2 test fails but I don't believe it is related.
>> - Some tier3 Swing tests fail but I don't think they are related.
>
> Philippe Marschall has refreshed the contents of this pull request, and previous commits have been removed. The
> incremental views will show differences compared to the previous content of the PR.

Marked as reviewed by kvn (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/45

From naoto at openjdk.java.net  Mon Sep 14 22:24:11 2020
From: naoto at openjdk.java.net (Naoto Sato)
Date: Mon, 14 Sep 2020 22:24:11 GMT
Subject: <i18n dev> RFR: 8220483: Calendar.setTime(Date date) throws NPE
 with Date date = null
Message-ID: <PW4rjRSnFVv-4bl8LEGF6CDarTfy4CvY0_xvZwpxWmA=.25b9341b-3be9-431e-b6bc-2fb3df064300@github.com>

Hi,

Please review this simple doc fix.

-------------

Commit messages:
 - 8220483: Calendar.setTime(Date date) throws NPE with Date date = null

Changes: https://git.openjdk.java.net/jdk/pull/159/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=159&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8220483
  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/159.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/159/head:pull/159

PR: https://git.openjdk.java.net/jdk/pull/159

From lancea at openjdk.java.net  Mon Sep 14 22:44:37 2020
From: lancea at openjdk.java.net (Lance Andersen)
Date: Mon, 14 Sep 2020 22:44:37 GMT
Subject: <i18n dev> RFR: 8220483: Calendar.setTime(Date date) throws NPE
 with Date date = null
In-Reply-To: <PW4rjRSnFVv-4bl8LEGF6CDarTfy4CvY0_xvZwpxWmA=.25b9341b-3be9-431e-b6bc-2fb3df064300@github.com>
References: <PW4rjRSnFVv-4bl8LEGF6CDarTfy4CvY0_xvZwpxWmA=.25b9341b-3be9-431e-b6bc-2fb3df064300@github.com>
Message-ID: <lthE8VPaRe0xFrZ88LGWiYk03YcRkm7UPrwkSUtRC_Q=.b69813b8-a49b-4310-af03-2d4b1fed2dfe@github.com>

On Mon, 14 Sep 2020 22:18:34 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Hi,
> 
> Please review this simple doc fix.

Hi Naoto,

The change looks fine.  I might have created a CSR just to track the doc change.

-------------

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/159

From joehw at openjdk.java.net  Mon Sep 14 22:55:16 2020
From: joehw at openjdk.java.net (Joe Wang)
Date: Mon, 14 Sep 2020 22:55:16 GMT
Subject: <i18n dev> RFR: 8220483: Calendar.setTime(Date date) throws NPE
 with Date date = null
In-Reply-To: <lthE8VPaRe0xFrZ88LGWiYk03YcRkm7UPrwkSUtRC_Q=.b69813b8-a49b-4310-af03-2d4b1fed2dfe@github.com>
References: <PW4rjRSnFVv-4bl8LEGF6CDarTfy4CvY0_xvZwpxWmA=.25b9341b-3be9-431e-b6bc-2fb3df064300@github.com>
 <lthE8VPaRe0xFrZ88LGWiYk03YcRkm7UPrwkSUtRC_Q=.b69813b8-a49b-4310-af03-2d4b1fed2dfe@github.com>
Message-ID: <iqaFRtL6kmwsXNNwkGyyJrCO-dM5s4bJquLYtsCJPLI=.2c72b74d-9429-444e-a6cc-d9e1e4a19cb2@github.com>

On Mon, 14 Sep 2020 22:41:55 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Hi,
>> 
>> Please review this simple doc fix.
>
> Hi Naoto,
> 
> The change looks fine.  I might have created a CSR just to track the doc change.

The change looks fine. However, are other methods in the same situation, e.g. void setTimeZone?(TimeZone?value),
getInstance?(Locale aLocale), etc.?  Or, would it better to add a general statement about passing in null values?

-------------

PR: https://git.openjdk.java.net/jdk/pull/159

From naoto at openjdk.java.net  Mon Sep 14 23:17:58 2020
From: naoto at openjdk.java.net (Naoto Sato)
Date: Mon, 14 Sep 2020 23:17:58 GMT
Subject: <i18n dev> RFR: 8220483: Calendar.setTime(Date date) throws NPE
 with Date date = null
In-Reply-To: <rA4k9EANXMr4qzJOVk8hH4P1FZQlY4qJRxr1wO3VW9E=.87cf50a9-4209-4d00-ae7b-9cef007963a1@github.com>
References: <PW4rjRSnFVv-4bl8LEGF6CDarTfy4CvY0_xvZwpxWmA=.25b9341b-3be9-431e-b6bc-2fb3df064300@github.com>
 <lthE8VPaRe0xFrZ88LGWiYk03YcRkm7UPrwkSUtRC_Q=.b69813b8-a49b-4310-af03-2d4b1fed2dfe@github.com>
 <iqaFRtL6kmwsXNNwkGyyJrCO-dM5s4bJquLYtsCJPLI=.2c72b74d-9429-444e-a6cc-d9e1e4a19cb2@github.com>
 <rA4k9EANXMr4qzJOVk8hH4P1FZQlY4qJRxr1wO3VW9E=.87cf50a9-4209-4d00-ae7b-9cef007963a1@github.com>
Message-ID: <HGHP6z7ui9qHRjVxRwXzXLc8eG8KEtmk6lXE8Q0EibU=.ddd37e5b-3a39-4b24-b936-990a3219ffae@github.com>

On Mon, 14 Sep 2020 23:13:25 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> The change looks fine. However, are other methods in the same situation, e.g. void setTimeZone?(TimeZone?value),
>> getInstance?(Locale aLocale), etc.?  Or, would it better to add a general statement about passing in null values?
>
> Thanks, Lance,
> 
>> The change looks fine. I might have created a CSR just to track the doc change.
> 
> Yes, and thanks for the CSR review too!

Thanks, Joe.

> The change looks fine. However, are other methods in the same situation, e.g. void setTimeZone?(TimeZone?value),
> getInstance?(Locale aLocale), etc.? Or, would it better to add a general statement about passing in null values?

Those two methods describe the NPE correctly. There are other locations that may have missed the @throws tag, but I
would rather fix this specific one this time (for my GitHub training :-)

-------------

PR: https://git.openjdk.java.net/jdk/pull/159

From naoto at openjdk.java.net  Mon Sep 14 23:17:58 2020
From: naoto at openjdk.java.net (Naoto Sato)
Date: Mon, 14 Sep 2020 23:17:58 GMT
Subject: <i18n dev> RFR: 8220483: Calendar.setTime(Date date) throws NPE
 with Date date = null
In-Reply-To: <iqaFRtL6kmwsXNNwkGyyJrCO-dM5s4bJquLYtsCJPLI=.2c72b74d-9429-444e-a6cc-d9e1e4a19cb2@github.com>
References: <PW4rjRSnFVv-4bl8LEGF6CDarTfy4CvY0_xvZwpxWmA=.25b9341b-3be9-431e-b6bc-2fb3df064300@github.com>
 <lthE8VPaRe0xFrZ88LGWiYk03YcRkm7UPrwkSUtRC_Q=.b69813b8-a49b-4310-af03-2d4b1fed2dfe@github.com>
 <iqaFRtL6kmwsXNNwkGyyJrCO-dM5s4bJquLYtsCJPLI=.2c72b74d-9429-444e-a6cc-d9e1e4a19cb2@github.com>
Message-ID: <rA4k9EANXMr4qzJOVk8hH4P1FZQlY4qJRxr1wO3VW9E=.87cf50a9-4209-4d00-ae7b-9cef007963a1@github.com>

On Mon, 14 Sep 2020 22:52:50 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> Hi Naoto,
>> 
>> The change looks fine.  I might have created a CSR just to track the doc change.
>
> The change looks fine. However, are other methods in the same situation, e.g. void setTimeZone?(TimeZone?value),
> getInstance?(Locale aLocale), etc.?  Or, would it better to add a general statement about passing in null values?

Thanks, Lance,

> The change looks fine. I might have created a CSR just to track the doc change.

Yes, and thanks for the CSR review too!

-------------

PR: https://git.openjdk.java.net/jdk/pull/159

From joehw at openjdk.java.net  Mon Sep 14 23:41:22 2020
From: joehw at openjdk.java.net (Joe Wang)
Date: Mon, 14 Sep 2020 23:41:22 GMT
Subject: <i18n dev> RFR: 8220483: Calendar.setTime(Date date) throws NPE
 with Date date = null
In-Reply-To: <PW4rjRSnFVv-4bl8LEGF6CDarTfy4CvY0_xvZwpxWmA=.25b9341b-3be9-431e-b6bc-2fb3df064300@github.com>
References: <PW4rjRSnFVv-4bl8LEGF6CDarTfy4CvY0_xvZwpxWmA=.25b9341b-3be9-431e-b6bc-2fb3df064300@github.com>
Message-ID: <anqiOJP1eLhNGvqA4HyvVXBJavt0Wkh577CYxBdmMNY=.e33b1296-8238-401a-bb04-fe9be3db8410@github.com>

On Mon, 14 Sep 2020 22:18:34 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Hi,
> 
> Please review this simple doc fix.

Marked as reviewed by joehw (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/159

From joehw at openjdk.java.net  Mon Sep 14 23:41:23 2020
From: joehw at openjdk.java.net (Joe Wang)
Date: Mon, 14 Sep 2020 23:41:23 GMT
Subject: <i18n dev> RFR: 8220483: Calendar.setTime(Date date) throws NPE
 with Date date = null
In-Reply-To: <HGHP6z7ui9qHRjVxRwXzXLc8eG8KEtmk6lXE8Q0EibU=.ddd37e5b-3a39-4b24-b936-990a3219ffae@github.com>
References: <PW4rjRSnFVv-4bl8LEGF6CDarTfy4CvY0_xvZwpxWmA=.25b9341b-3be9-431e-b6bc-2fb3df064300@github.com>
 <lthE8VPaRe0xFrZ88LGWiYk03YcRkm7UPrwkSUtRC_Q=.b69813b8-a49b-4310-af03-2d4b1fed2dfe@github.com>
 <iqaFRtL6kmwsXNNwkGyyJrCO-dM5s4bJquLYtsCJPLI=.2c72b74d-9429-444e-a6cc-d9e1e4a19cb2@github.com>
 <rA4k9EANXMr4qzJOVk8hH4P1FZQlY4qJRxr1wO3VW9E=.87cf50a9-4209-4d00-ae7b-9cef007963a1@github.com>
 <HGHP6z7ui9qHRjVxRwXzXLc8eG8KEtmk6lXE8Q0EibU=.ddd37e5b-3a39-4b24-b936-990a3219ffae@github.com>
Message-ID: <234r42V_BtfzhAVKcO7e5QeDy0JkC8rZpuNNSEji-Ls=.6fbef8b0-b2b3-4e5f-88f1-8e161e68a5e6@github.com>

On Mon, 14 Sep 2020 23:15:10 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Thanks, Lance,
>> 
>>> The change looks fine. I might have created a CSR just to track the doc change.
>> 
>> Yes, and thanks for the CSR review too!
>
> Thanks, Joe.
> 
>> The change looks fine. However, are other methods in the same situation, e.g. void setTimeZone?(TimeZone?value),
>> getInstance?(Locale aLocale), etc.? Or, would it better to add a general statement about passing in null values?
> 
> Those two methods describe the NPE correctly. There are other locations that may have missed the @throws tag, but I
> would rather fix this specific one this time (for my GitHub training :-)

That makes sense (good start for the 1st PR ;-)).

-------------

PR: https://git.openjdk.java.net/jdk/pull/159

From naoto at openjdk.java.net  Tue Sep 15 22:17:22 2020
From: naoto at openjdk.java.net (Naoto Sato)
Date: Tue, 15 Sep 2020 22:17:22 GMT
Subject: <i18n dev> Integrated: 8220483: Calendar.setTime(Date date) throws
 NPE with Date date = null
In-Reply-To: <PW4rjRSnFVv-4bl8LEGF6CDarTfy4CvY0_xvZwpxWmA=.25b9341b-3be9-431e-b6bc-2fb3df064300@github.com>
References: <PW4rjRSnFVv-4bl8LEGF6CDarTfy4CvY0_xvZwpxWmA=.25b9341b-3be9-431e-b6bc-2fb3df064300@github.com>
Message-ID: <aupNbXShtG4hRyo-Ddg5Ex8GxoS-2wCBVUUVMGd6xBw=.697209d1-24e9-43d4-93f9-f88a2075ab53@github.com>

On Mon, 14 Sep 2020 22:18:34 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Hi,
> 
> Please review this simple doc fix.

This pull request has now been integrated.

Changeset: 57f92d23
Author:    Naoto Sato <naoto at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/57f92d23
Stats:     2 lines in 1 file changed: 0 ins; 2 del; 0 mod

8220483: Calendar.setTime(Date date) throws NPE with Date date = null

Reviewed-by: lancea, joehw

-------------

PR: https://git.openjdk.java.net/jdk/pull/159

From naoto.sato at oracle.com  Wed Sep 16 13:31:53 2020
From: naoto.sato at oracle.com (Naoto Sato)
Date: Wed, 16 Sep 2020 06:31:53 -0700
Subject: <i18n dev> [BUG] Java 15: DecimalFormatSymbols overrides equals
 but not hashCode
In-Reply-To: <171521A1-5C59-44A8-BBCF-5856DEA3A3B6@oracle.com>
References: <bebebc9b-c0ca-e61d-f5a1-bfcd7b5d584d@icemanx.nl>
 <F775FB80-9D88-4155-A677-DBF5C088C442@oracle.com>
 <222adabf-094c-d739-396a-c2c8587fe185@icemanx.nl>
 <7EE2F402-D21D-4592-B416-ED350A7103AD@oracle.com>
 <12130176-A6E7-406C-9F80-5702E366901B@oracle.com>
 <dde67317-54d0-ca95-ceda-74ad6b5b7468@icemanx.nl>
 <171521A1-5C59-44A8-BBCF-5856DEA3A3B6@oracle.com>
Message-ID: <cb65d4c1-ba3d-f3ae-0f0a-0c5f825900f9@oracle.com>

I created a JIRA issue for this:

https://bugs.openjdk.java.net/browse/JDK-8253240

Naoto

On 9/16/20 2:11 AM, Pavel Rappo wrote:
> 
> 
>> On 15 Sep 2020, at 21:50, Rob Spoor <openjdk at icemanx.nl> wrote:
>>
>> On 15/09/2020 22:02, Pavel Rappo wrote:
>>>> On 15 Sep 2020, at 20:50, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
>>>>
>>>>> On Sep 15, 2020, at 12:38 PM, Kevin Rushforth <kevin.rushforth at oracle.com> wrote:
>>>>>
>>>>> I see this in DecimalFormatSymbols:
>>>>>
>>>>>
>>>>>      /**
>>>>>       * Override hashCode.
>>>>>       */
>>>>>>>>    private volatile int hashCode;
>>>>>      @Override
>>>>>      public int hashCode() {
>>>>>
>>>>> Although, I'm not sure why the intervening private field would prevent javadoc from generating at least a method with an empty doc
>>> https://bugs.openjdk.java.net/browse/JDK-8187386
>>
>> So in this case, the solution would be to remove the superfluous "Override equals." comment from the equals method, right?
> 
> It depends on what you want to achieve. On the one hand, if you 'remove the superfluous "Override equals."' it will eliminate the discrepancy that you described in your original email. On the other hand, a reader might no longer have a clear indication that equals and hashCode are meaningfully overridden.
> 
> I would simply return "/** Override hashCode */" to its original place, as it is clearly a bug that affects documentation.
> 
> -Pavel
> 

From naoto at openjdk.java.net  Wed Sep 16 17:35:45 2020
From: naoto at openjdk.java.net (Naoto Sato)
Date: Wed, 16 Sep 2020 17:35:45 GMT
Subject: <i18n dev> RFR: 8253240: No javadoc for
 DecimalFormatSymbols.hashCode()
Message-ID: <IJZu3IoKF1IIe0wJyoG2L2vh_JbUFQiW1ZZY4g44sPc=.a232343b-b4a4-405e-ba43-ab8cb21ede40@github.com>

Hi,

Please review the fix to the issue wrt missing hashCode() javadoc, which was recently discussed in core-libs ml.

-------------

Commit messages:
 - 8253240: No javadoc for DecimalFormatSymbols.hashCode()

Changes: https://git.openjdk.java.net/jdk/pull/208/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=208&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8253240
  Stats: 6 lines in 1 file changed: 5 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/208.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/208/head:pull/208

PR: https://git.openjdk.java.net/jdk/pull/208

From rriggs at openjdk.java.net  Wed Sep 16 17:50:05 2020
From: rriggs at openjdk.java.net (Roger Riggs)
Date: Wed, 16 Sep 2020 17:50:05 GMT
Subject: <i18n dev> RFR: 8253240: No javadoc for
 DecimalFormatSymbols.hashCode()
In-Reply-To: <IJZu3IoKF1IIe0wJyoG2L2vh_JbUFQiW1ZZY4g44sPc=.a232343b-b4a4-405e-ba43-ab8cb21ede40@github.com>
References: <IJZu3IoKF1IIe0wJyoG2L2vh_JbUFQiW1ZZY4g44sPc=.a232343b-b4a4-405e-ba43-ab8cb21ede40@github.com>
Message-ID: <LHXgxgxEtSnIic8TDRjyq83dtJbWnit-svC-tDfCl38=.88e45a51-8ba9-4320-8e0e-80b90f1ffc34@github.com>

On Wed, 16 Sep 2020 17:29:52 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Hi,
> 
> Please review the fix to the issue wrt missing hashCode() javadoc, which was recently discussed in core-libs ml.

Changes requested by rriggs (Reviewer).

src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 1153:

> 1151:      * Cached hash code
> 1152:      */
> 1153:     private volatile int hashCode;

I'm thinking the cached hashcode should be / should have been transient (not serialized).
And add a period at the end of the sentence above.

-------------

PR: https://git.openjdk.java.net/jdk/pull/208

From lancea at openjdk.java.net  Wed Sep 16 17:53:46 2020
From: lancea at openjdk.java.net (Lance Andersen)
Date: Wed, 16 Sep 2020 17:53:46 GMT
Subject: <i18n dev> RFR: 8253240: No javadoc for
 DecimalFormatSymbols.hashCode()
In-Reply-To: <IJZu3IoKF1IIe0wJyoG2L2vh_JbUFQiW1ZZY4g44sPc=.a232343b-b4a4-405e-ba43-ab8cb21ede40@github.com>
References: <IJZu3IoKF1IIe0wJyoG2L2vh_JbUFQiW1ZZY4g44sPc=.a232343b-b4a4-405e-ba43-ab8cb21ede40@github.com>
Message-ID: <iMyfjukq7eDTdFNnYfRmyrHNf1Sr_Gf5aWkQ57CI-AQ=.7bcfaed1-ec2a-4559-90e9-41d9c59854ea@github.com>

On Wed, 16 Sep 2020 17:29:52 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Hi,
> 
> Please review the fix to the issue wrt missing hashCode() javadoc, which was recently discussed in core-libs ml.

Looks in line with the discussion on core-libs.

-------------

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/208

From naoto at openjdk.java.net  Wed Sep 16 18:02:48 2020
From: naoto at openjdk.java.net (Naoto Sato)
Date: Wed, 16 Sep 2020 18:02:48 GMT
Subject: <i18n dev> RFR: 8253240: No javadoc for
 DecimalFormatSymbols.hashCode() [v2]
In-Reply-To: <LHXgxgxEtSnIic8TDRjyq83dtJbWnit-svC-tDfCl38=.88e45a51-8ba9-4320-8e0e-80b90f1ffc34@github.com>
References: <IJZu3IoKF1IIe0wJyoG2L2vh_JbUFQiW1ZZY4g44sPc=.a232343b-b4a4-405e-ba43-ab8cb21ede40@github.com>
 <LHXgxgxEtSnIic8TDRjyq83dtJbWnit-svC-tDfCl38=.88e45a51-8ba9-4320-8e0e-80b90f1ffc34@github.com>
Message-ID: <5MQBzJy7R7iathIJxcEpQjc2BL2vn-jOx7lEqN_-q9s=.4fbfa43e-3e81-4b46-b2a5-b216887397ff@github.com>

On Wed, 16 Sep 2020 17:47:17 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressing Roger's comments.
>
> src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 1153:
> 
>> 1151:      * Cached hash code
>> 1152:      */
>> 1153:     private volatile int hashCode;
> 
> I'm thinking the cached hashcode should be / should have been transient (not serialized).
> And add a period at the end of the sentence above.

Good point. Addressed both comments.

-------------

PR: https://git.openjdk.java.net/jdk/pull/208

From naoto at openjdk.java.net  Wed Sep 16 18:02:42 2020
From: naoto at openjdk.java.net (Naoto Sato)
Date: Wed, 16 Sep 2020 18:02:42 GMT
Subject: <i18n dev> RFR: 8253240: No javadoc for
 DecimalFormatSymbols.hashCode() [v2]
In-Reply-To: <IJZu3IoKF1IIe0wJyoG2L2vh_JbUFQiW1ZZY4g44sPc=.a232343b-b4a4-405e-ba43-ab8cb21ede40@github.com>
References: <IJZu3IoKF1IIe0wJyoG2L2vh_JbUFQiW1ZZY4g44sPc=.a232343b-b4a4-405e-ba43-ab8cb21ede40@github.com>
Message-ID: <cB8HhxLchwGnSpSLyCgUUeFCZv6FVbX9ixZG8UzB-c0=.bc0ef94b-2957-41e1-ba5e-6be2772acdaa@github.com>

> Hi,
> 
> Please review the fix to the issue wrt missing hashCode() javadoc, which was recently discussed in core-libs ml.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  Addressing Roger's comments.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/208/files
  - new: https://git.openjdk.java.net/jdk/pull/208/files/3276598e..2f9d0c3a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=208&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=208&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/208.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/208/head:pull/208

PR: https://git.openjdk.java.net/jdk/pull/208

From rriggs at openjdk.java.net  Wed Sep 16 19:56:21 2020
From: rriggs at openjdk.java.net (Roger Riggs)
Date: Wed, 16 Sep 2020 19:56:21 GMT
Subject: <i18n dev> RFR: 8253240: No javadoc for
 DecimalFormatSymbols.hashCode() [v2]
In-Reply-To: <iMyfjukq7eDTdFNnYfRmyrHNf1Sr_Gf5aWkQ57CI-AQ=.7bcfaed1-ec2a-4559-90e9-41d9c59854ea@github.com>
References: <IJZu3IoKF1IIe0wJyoG2L2vh_JbUFQiW1ZZY4g44sPc=.a232343b-b4a4-405e-ba43-ab8cb21ede40@github.com>
 <iMyfjukq7eDTdFNnYfRmyrHNf1Sr_Gf5aWkQ57CI-AQ=.7bcfaed1-ec2a-4559-90e9-41d9c59854ea@github.com>
Message-ID: <c0q03Y_mvBpdp9c9kQQVkcoD9ozB63fHpJisCZKCHyU=.0fde8d41-e3bf-45d5-9b2d-6a5e2b02767d@github.com>

On Wed, 16 Sep 2020 17:51:18 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressing Roger's comments.
>
> Looks in line with the discussion on core-libs.

Removing hashcode from the serialized form needs a CSR because it was non-transient in JDK 15.
The intent is to not use the serialized value, so the readObject method should zero it out
so it can be computed on first use.

-------------

PR: https://git.openjdk.java.net/jdk/pull/208

From naoto at openjdk.java.net  Wed Sep 16 22:05:58 2020
From: naoto at openjdk.java.net (Naoto Sato)
Date: Wed, 16 Sep 2020 22:05:58 GMT
Subject: <i18n dev> RFR: 8253240: No javadoc for
 DecimalFormatSymbols.hashCode() [v2]
In-Reply-To: <c0q03Y_mvBpdp9c9kQQVkcoD9ozB63fHpJisCZKCHyU=.0fde8d41-e3bf-45d5-9b2d-6a5e2b02767d@github.com>
References: <IJZu3IoKF1IIe0wJyoG2L2vh_JbUFQiW1ZZY4g44sPc=.a232343b-b4a4-405e-ba43-ab8cb21ede40@github.com>
 <iMyfjukq7eDTdFNnYfRmyrHNf1Sr_Gf5aWkQ57CI-AQ=.7bcfaed1-ec2a-4559-90e9-41d9c59854ea@github.com>
 <c0q03Y_mvBpdp9c9kQQVkcoD9ozB63fHpJisCZKCHyU=.0fde8d41-e3bf-45d5-9b2d-6a5e2b02767d@github.com>
Message-ID: <YAX5Cyem_qVkAuuSP49537KRY42BsZiJNV18Ou44cZo=.668ac99d-50f6-4e67-8a95-0df5370a2ed4@github.com>

On Wed, 16 Sep 2020 19:53:26 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Looks in line with the discussion on core-libs.
>
> Removing hashcode from the serialized form needs a CSR because it was non-transient in JDK 15.
> The intent is to not use the serialized value, so the readObject method should zero it out
> so it can be computed on first use.

Drafted a CSR for this PR. Please review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/208

From naoto at openjdk.java.net  Fri Sep 18 01:56:32 2020
From: naoto at openjdk.java.net (Naoto Sato)
Date: Fri, 18 Sep 2020 01:56:32 GMT
Subject: <i18n dev> RFR: 8253153: Mentioning of "hour-of-minute" in
 java.time.temporal.TemporalField JavaDoc
Message-ID: <4kK021a4Jr7xCNaCWzzSdnTKQISigN0WCqLb8hWF9y4=.ef3cd288-bf9b-4385-863c-0082b542c131@github.com>

Hi,

Please review this simple doc fix.

-------------

Commit messages:
 - 8253153: Mentioning of "hour-of-minute" in java.time.temporal.TemporalField JavaDoc

Changes: https://git.openjdk.java.net/jdk/pull/234/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=234&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8253153
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/234.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/234/head:pull/234

PR: https://git.openjdk.java.net/jdk/pull/234

From smarks at openjdk.java.net  Fri Sep 18 02:50:45 2020
From: smarks at openjdk.java.net (Stuart Marks)
Date: Fri, 18 Sep 2020 02:50:45 GMT
Subject: <i18n dev> RFR: 8252999: Cleanup: replace .equals("") with
 .isEmpty() within all codebase
In-Reply-To: <GUdSjk78l7ZplBebkhUDAgQ4zUewkfpaVfUR1bGQzkc=.9b8a5876-06ea-4009-9d7d-a07a8887e534@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
 <ixnZDnRQQk_8EUg-xd1yjRdJwziB5BPXsjcvDe65mTY=.9caade8e-d002-4eba-b30f-a0dd640556f5@github.com>
 <sxPCBvVvKws7tJgaBigC2uhhopnJ8QTSi0EOaJHE0tM=.2a3cfee3-d472-4601-9a47-e220c7fe8f65@github.com>
 <GUdSjk78l7ZplBebkhUDAgQ4zUewkfpaVfUR1bGQzkc=.9b8a5876-06ea-4009-9d7d-a07a8887e534@github.com>
Message-ID: <TsAjcGfmVOc5FHSeOSEPoaOOPlCvJ6udsQmSXe733zM=.fddca1b7-8b97-41fb-b439-12cba2e929dc@github.com>

On Fri, 11 Sep 2020 15:17:58 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> Ok, sorry for the distraction.
>
> Our local Santuario maintainer says:
> 
> In general, changes to Apache Santuario should also be made at Apache so we stay in sync.

Hi @doom369, I hope we didn't end up wasting too much of your time with this. I wanted to respond to a comment you made
earlier in this PR,

> I have in mind dozens of improvements all over the code like this one.

It's hard to see, but as you discovered, the JDK has different groups of people maintaining different areas, and
sometimes there are hidden constraints on those different areas, for example, to avoid divergence with upstream source
bases. And as you discovered, sometimes those source bases might need to maintain compatibility with an older JDK ...
so we don't want to update this code even though it's IN the JDK.

Those kind of constraints generally don't apply to code in the java.base module, since there's nothing upstream of it,
and by definition it cannot depend on anything outside the JDK. Generally -- though there are exceptions -- we're more
receptive to keeping stuff in java.base (and sometimes related modules close to the core) on the latest and greatest
stuff. There are some constraints, however. There are some things we can't use too early during initialization of the
JDK, such as lambdas. Also, there is some code lurking around that is sometimes executed by the boot JDK, which is
typically one release behind. (This is definitely the case for tools like javac, but I think it might also apply to
some things in base.)

Anyway, if you'd like to pursue some of these improvements, drop a note to core-libs-dev at openjdk and we can talk about
it.

Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From joehw at openjdk.java.net  Fri Sep 18 05:00:29 2020
From: joehw at openjdk.java.net (Joe Wang)
Date: Fri, 18 Sep 2020 05:00:29 GMT
Subject: <i18n dev> RFR: 8253153: Mentioning of "hour-of-minute" in
 java.time.temporal.TemporalField JavaDoc
In-Reply-To: <4kK021a4Jr7xCNaCWzzSdnTKQISigN0WCqLb8hWF9y4=.ef3cd288-bf9b-4385-863c-0082b542c131@github.com>
References: <4kK021a4Jr7xCNaCWzzSdnTKQISigN0WCqLb8hWF9y4=.ef3cd288-bf9b-4385-863c-0082b542c131@github.com>
Message-ID: <IpfnDPV5hGO1JO3ImhEdePwd1n_vDiJKr27tG-K3eyA=.1cdc2d48-cb34-4a52-add7-ecc2f5cc1450@github.com>

On Fri, 18 Sep 2020 01:49:09 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Hi,
> 
> Please review this simple doc fix.

Marked as reviewed by joehw (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/234

From lancea at openjdk.java.net  Fri Sep 18 10:51:29 2020
From: lancea at openjdk.java.net (Lance Andersen)
Date: Fri, 18 Sep 2020 10:51:29 GMT
Subject: <i18n dev> RFR: 8253153: Mentioning of "hour-of-minute" in
 java.time.temporal.TemporalField JavaDoc
In-Reply-To: <4kK021a4Jr7xCNaCWzzSdnTKQISigN0WCqLb8hWF9y4=.ef3cd288-bf9b-4385-863c-0082b542c131@github.com>
References: <4kK021a4Jr7xCNaCWzzSdnTKQISigN0WCqLb8hWF9y4=.ef3cd288-bf9b-4385-863c-0082b542c131@github.com>
Message-ID: <6qRTwL0bzx4VxJiVwmrWSDXPADkAmyRu9EtPYcHYBtE=.ac08244f-ce3c-4eab-ad0d-3dd0ab26ea90@github.com>

On Fri, 18 Sep 2020 01:49:09 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Hi,
> 
> Please review this simple doc fix.

Marked as reviewed by lancea (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/234

From github.com+1536494+doom369 at openjdk.java.net  Fri Sep 18 11:07:46 2020
From: github.com+1536494+doom369 at openjdk.java.net (Dmitriy Dumanskiy)
Date: Fri, 18 Sep 2020 11:07:46 GMT
Subject: <i18n dev> RFR: 8252999: Cleanup: replace .equals("") with
 .isEmpty() within all codebase
In-Reply-To: <TsAjcGfmVOc5FHSeOSEPoaOOPlCvJ6udsQmSXe733zM=.fddca1b7-8b97-41fb-b439-12cba2e929dc@github.com>
References: <MtwBO5I5bHv3mM6d22dOGx5vL9GnzEmWhEUkgUILbH0=.e7a048e1-c0fa-4925-b73f-fd87bab3df02@github.com>
 <ixnZDnRQQk_8EUg-xd1yjRdJwziB5BPXsjcvDe65mTY=.9caade8e-d002-4eba-b30f-a0dd640556f5@github.com>
 <sxPCBvVvKws7tJgaBigC2uhhopnJ8QTSi0EOaJHE0tM=.2a3cfee3-d472-4601-9a47-e220c7fe8f65@github.com>
 <GUdSjk78l7ZplBebkhUDAgQ4zUewkfpaVfUR1bGQzkc=.9b8a5876-06ea-4009-9d7d-a07a8887e534@github.com>
 <TsAjcGfmVOc5FHSeOSEPoaOOPlCvJ6udsQmSXe733zM=.fddca1b7-8b97-41fb-b439-12cba2e929dc@github.com>
Message-ID: <668fR1wEZWaC0TDCyRIeOZ4AddXZXnKQhyHQdXtOab8=.6cb419cb-632b-4524-980e-18a6e06958e8@github.com>

On Fri, 18 Sep 2020 02:48:15 GMT, Stuart Marks <smarks at openjdk.org> wrote:

>> Our local Santuario maintainer says:
>> 
>> In general, changes to Apache Santuario should also be made at Apache so we stay in sync.
>
> Hi @doom369, I hope we didn't end up wasting too much of your time with this. I wanted to respond to a comment you made
> earlier in this PR,
>> I have in mind dozens of improvements all over the code like this one.
> 
> It's hard to see, but as you discovered, the JDK has different groups of people maintaining different areas, and
> sometimes there are hidden constraints on those different areas, for example, to avoid divergence with upstream source
> bases. And as you discovered, sometimes those source bases might need to maintain compatibility with an older JDK ...
> so we don't want to update this code even though it's IN the JDK.  Those kind of constraints generally don't apply to
> code in the java.base module, since there's nothing upstream of it, and by definition it cannot depend on anything
> outside the JDK. Generally -- though there are exceptions -- we're more receptive to keeping stuff in java.base (and
> sometimes related modules close to the core) on the latest and greatest stuff. There are some constraints, however.
> There are some things we can't use too early during initialization of the JDK, such as lambdas. Also, there is some
> code lurking around that is sometimes executed by the boot JDK, which is typically one release behind. (This is
> definitely the case for tools like javac, but I think it might also apply to some things in base.)  Anyway, if you'd
> like to pursue some of these improvements, drop a note to core-libs-dev at openjdk and we can talk about it.  Thanks.

@stuart-marks thanks. Sure, I understand that maintaining OpenJDK is not a simple task. I thought as change is super
simple without any side effects it can go through. But I was wrong. That's fine. I'll focus on `java.base` when I have
some free time.

-------------

PR: https://git.openjdk.java.net/jdk/pull/29

From rriggs at openjdk.java.net  Fri Sep 18 14:23:18 2020
From: rriggs at openjdk.java.net (Roger Riggs)
Date: Fri, 18 Sep 2020 14:23:18 GMT
Subject: <i18n dev> RFR: 8253153: Mentioning of "hour-of-minute" in
 java.time.temporal.TemporalField JavaDoc
In-Reply-To: <4kK021a4Jr7xCNaCWzzSdnTKQISigN0WCqLb8hWF9y4=.ef3cd288-bf9b-4385-863c-0082b542c131@github.com>
References: <4kK021a4Jr7xCNaCWzzSdnTKQISigN0WCqLb8hWF9y4=.ef3cd288-bf9b-4385-863c-0082b542c131@github.com>
Message-ID: <Ox31f8_UwyDN5ZgchHamB3fgRYmyqvYcKT-ixBMjmwI=.f72de3f2-acd6-4389-bb1e-5eb9fd2b7884@github.com>

On Fri, 18 Sep 2020 01:49:09 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Hi,
> 
> Please review this simple doc fix.

Marked as reviewed by rriggs (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/234

From naoto at openjdk.java.net  Fri Sep 18 15:43:37 2020
From: naoto at openjdk.java.net (Naoto Sato)
Date: Fri, 18 Sep 2020 15:43:37 GMT
Subject: <i18n dev> Integrated: 8253153: Mentioning of "hour-of-minute" in
 java.time.temporal.TemporalField JavaDoc
In-Reply-To: <4kK021a4Jr7xCNaCWzzSdnTKQISigN0WCqLb8hWF9y4=.ef3cd288-bf9b-4385-863c-0082b542c131@github.com>
References: <4kK021a4Jr7xCNaCWzzSdnTKQISigN0WCqLb8hWF9y4=.ef3cd288-bf9b-4385-863c-0082b542c131@github.com>
Message-ID: <LExrfZhN3hGVwJhg0me7_ToBPX_3WXcV9I3wDg9_vQE=.b78eff37-1171-4086-890b-a4e2f72ba882@github.com>

On Fri, 18 Sep 2020 01:49:09 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Hi,
> 
> Please review this simple doc fix.

This pull request has now been integrated.

Changeset: 89044200
Author:    Naoto Sato <naoto at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/89044200
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8253153: Mentioning of "hour-of-minute" in java.time.temporal.TemporalField JavaDoc

Reviewed-by: joehw, lancea, rriggs

-------------

PR: https://git.openjdk.java.net/jdk/pull/234

From naoto at openjdk.java.net  Fri Sep 18 23:33:08 2020
From: naoto at openjdk.java.net (Naoto Sato)
Date: Fri, 18 Sep 2020 23:33:08 GMT
Subject: <i18n dev> RFR: 8253321: java.util.Locale.LanguageRange#equals is
 inconsistent after calling hashCode
Message-ID: <2-y_g5PvWat4frQ_-6XHFSx2QcZvQns4YzwInyhTemU=.ad69a573-0209-4c9e-b747-60590e3cf798@github.com>

Hi,

Please review the fix to JDK-8253321. As in the issue, uninitialized (cached) hash code was incorrectly referenced in
equals() method. Removing it will correct the problem. Also, unrelated to the issue, I fixed a parameter description in
a private method.

Naoto

-------------

Commit messages:
 - fixed noeol
 - Merge branch 'master' into JDK-8253321
 - added test case
 - Merge branch 'master' into JDK-8253321
 - 8253321: java.util.Locale.LanguageRange#equals is inconsistent after calling hashCode

Changes: https://git.openjdk.java.net/jdk/pull/260/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=260&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8253321
  Stats: 51 lines in 2 files changed: 48 ins; 1 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/260.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/260/head:pull/260

PR: https://git.openjdk.java.net/jdk/pull/260

From minqi at openjdk.java.net  Fri Sep 18 23:54:11 2020
From: minqi at openjdk.java.net (Yumin Qi)
Date: Fri, 18 Sep 2020 23:54:11 GMT
Subject: <i18n dev> RFR: 8253208: Move CDS related code to a separate class
Message-ID: <F5TpL55P21vmeZsyjWfFiLEUkKjp6-XcvKd-RttQ6bc=.104dc1be-4bb5-4bd7-9f4e-4aea6a551c8f@github.com>

With more CDS related code added to VM, it is time to move CDS code to a separate class. CDS is the new class which is
specific to CDS.

Tests: tier1-4

-------------

Commit messages:
 - 8253208: Move CDS related code to a separate class
 - Merge branch 'master' of https://github.com/yminqi/jdk into jdk-8253208
 - Merge remote-tracking branch 'origin/jdk-8252689'
 - 8252689: Classes are loaded from jrt:/java.base even when CDS is used
 - 8252689: Classes are loaded from jrt:/java.base even when CDS is used
 - 8252689: Classes are loaded from jrt:/java.base even when CDS is used

Changes: https://git.openjdk.java.net/jdk/pull/261/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=261&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8253208
  Stats: 196 lines in 20 files changed: 110 ins; 53 del; 33 mod
  Patch: https://git.openjdk.java.net/jdk/pull/261.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/261/head:pull/261

PR: https://git.openjdk.java.net/jdk/pull/261

From joehw at openjdk.java.net  Sat Sep 19 01:14:38 2020
From: joehw at openjdk.java.net (Joe Wang)
Date: Sat, 19 Sep 2020 01:14:38 GMT
Subject: <i18n dev> RFR: 8253321: java.util.Locale.LanguageRange#equals
 is inconsistent after calling hashCode
In-Reply-To: <2-y_g5PvWat4frQ_-6XHFSx2QcZvQns4YzwInyhTemU=.ad69a573-0209-4c9e-b747-60590e3cf798@github.com>
References: <2-y_g5PvWat4frQ_-6XHFSx2QcZvQns4YzwInyhTemU=.ad69a573-0209-4c9e-b747-60590e3cf798@github.com>
Message-ID: <FdJUP5ng2HM4lGzooCy6TMDekWfUYQtW2zs_Gn-CXEM=.c8beb107-2e1e-4d97-a09c-b10e9ad4808e@github.com>

On Fri, 18 Sep 2020 23:26:39 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Hi,
> 
> Please review the fix to JDK-8253321. As in the issue, uninitialized (cached) hash code was incorrectly referenced in
> equals() method. Removing it will correct the problem. Also, unrelated to the issue, I fixed a parameter description in
> a private method.  Naoto

test/jdk/java/util/Locale/LanguageRangeTest.java line 27:

> 25:  * @bug 8253321
> 26:  * @summary test LanguageRange class
> 27:  * @run testng/othervm LanguageRangeTest

Is it necessary to run in othervm?

-------------

PR: https://git.openjdk.java.net/jdk/pull/260

From joehw at openjdk.java.net  Sat Sep 19 01:21:31 2020
From: joehw at openjdk.java.net (Joe Wang)
Date: Sat, 19 Sep 2020 01:21:31 GMT
Subject: <i18n dev> RFR: 8253321: java.util.Locale.LanguageRange#equals
 is inconsistent after calling hashCode
In-Reply-To: <2-y_g5PvWat4frQ_-6XHFSx2QcZvQns4YzwInyhTemU=.ad69a573-0209-4c9e-b747-60590e3cf798@github.com>
References: <2-y_g5PvWat4frQ_-6XHFSx2QcZvQns4YzwInyhTemU=.ad69a573-0209-4c9e-b747-60590e3cf798@github.com>
Message-ID: <1MG0zbbwZ3usNHHZoUVOGfKWdL2-MZ1vdxKlbUrWjQ0=.6e53e445-8a7a-4ee2-b25b-9b71b14c46dd@github.com>

On Fri, 18 Sep 2020 23:26:39 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Hi,
> 
> Please review the fix to JDK-8253321. As in the issue, uninitialized (cached) hash code was incorrectly referenced in
> equals() method. Removing it will correct the problem. Also, unrelated to the issue, I fixed a parameter description in
> a private method.  Naoto

Marked as reviewed by joehw (Reviewer).

Also, copyright year may need to be updated to 2020 for Locale.java.

-------------

PR: https://git.openjdk.java.net/jdk/pull/260

From naoto at openjdk.java.net  Sat Sep 19 01:36:38 2020
From: naoto at openjdk.java.net (Naoto Sato)
Date: Sat, 19 Sep 2020 01:36:38 GMT
Subject: <i18n dev> RFR: 8253321: java.util.Locale.LanguageRange#equals
 is inconsistent after calling hashCode [v2]
In-Reply-To: <1MG0zbbwZ3usNHHZoUVOGfKWdL2-MZ1vdxKlbUrWjQ0=.6e53e445-8a7a-4ee2-b25b-9b71b14c46dd@github.com>
References: <2-y_g5PvWat4frQ_-6XHFSx2QcZvQns4YzwInyhTemU=.ad69a573-0209-4c9e-b747-60590e3cf798@github.com>
 <1MG0zbbwZ3usNHHZoUVOGfKWdL2-MZ1vdxKlbUrWjQ0=.6e53e445-8a7a-4ee2-b25b-9b71b14c46dd@github.com>
Message-ID: <R1M2Kd6HxEojheOd19Wg1acIyJfXQbLl_GAHyfxupyo=.ad0cac2a-27c3-4bf8-bada-4795414d538d@github.com>

On Sat, 19 Sep 2020 01:19:04 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressing Joe's comments
>
> Marked as reviewed by joehw (Reviewer).

> Also, copyright year may need to be updated to 2020 for Locale.java.

Thanks, Joe. Updated.

> test/jdk/java/util/Locale/LanguageRangeTest.java line 27:
> 
>> 25:  * @bug 8253321
>> 26:  * @summary test LanguageRange class
>> 27:  * @run testng/othervm LanguageRangeTest
> 
> Is it necessary to run in othervm?

Removed "othervm"

-------------

PR: https://git.openjdk.java.net/jdk/pull/260

From naoto at openjdk.java.net  Sat Sep 19 01:36:38 2020
From: naoto at openjdk.java.net (Naoto Sato)
Date: Sat, 19 Sep 2020 01:36:38 GMT
Subject: <i18n dev> RFR: 8253321: java.util.Locale.LanguageRange#equals
 is inconsistent after calling hashCode [v2]
In-Reply-To: <2-y_g5PvWat4frQ_-6XHFSx2QcZvQns4YzwInyhTemU=.ad69a573-0209-4c9e-b747-60590e3cf798@github.com>
References: <2-y_g5PvWat4frQ_-6XHFSx2QcZvQns4YzwInyhTemU=.ad69a573-0209-4c9e-b747-60590e3cf798@github.com>
Message-ID: <ETjaOd76_m2b44UZpE1CS8tHGy4CN6Dt4Bgrv2NPF2g=.874b196a-360f-44ed-8491-12e14ecf13f7@github.com>

> Hi,
> 
> Please review the fix to JDK-8253321. As in the issue, uninitialized (cached) hash code was incorrectly referenced in
> equals() method. Removing it will correct the problem. Also, unrelated to the issue, I fixed a parameter description in
> a private method.  Naoto

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  Addressing Joe's comments

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/260/files
  - new: https://git.openjdk.java.net/jdk/pull/260/files/cb594a5e..0bbf58da

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=260&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=260&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/260.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/260/head:pull/260

PR: https://git.openjdk.java.net/jdk/pull/260

From joehw at openjdk.java.net  Sat Sep 19 03:46:13 2020
From: joehw at openjdk.java.net (Joe Wang)
Date: Sat, 19 Sep 2020 03:46:13 GMT
Subject: <i18n dev> RFR: 8253321: java.util.Locale.LanguageRange#equals
 is inconsistent after calling hashCode [v2]
In-Reply-To: <ETjaOd76_m2b44UZpE1CS8tHGy4CN6Dt4Bgrv2NPF2g=.874b196a-360f-44ed-8491-12e14ecf13f7@github.com>
References: <2-y_g5PvWat4frQ_-6XHFSx2QcZvQns4YzwInyhTemU=.ad69a573-0209-4c9e-b747-60590e3cf798@github.com>
 <ETjaOd76_m2b44UZpE1CS8tHGy4CN6Dt4Bgrv2NPF2g=.874b196a-360f-44ed-8491-12e14ecf13f7@github.com>
Message-ID: <VtC0yGaBFAPkRU0rlUXOWjwGOJdyznX1U5vp77OtLSA=.63ae8c4c-7c06-436d-951d-4a6884bc3acd@github.com>

On Sat, 19 Sep 2020 01:36:38 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Hi,
>> 
>> Please review the fix to JDK-8253321. As in the issue, uninitialized (cached) hash code was incorrectly referenced in
>> equals() method. Removing it will correct the problem. Also, unrelated to the issue, I fixed a parameter description in
>> a private method.  Naoto
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Addressing Joe's comments

Marked as reviewed by joehw (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/260

From rriggs at openjdk.java.net  Sat Sep 19 14:15:29 2020
From: rriggs at openjdk.java.net (Roger Riggs)
Date: Sat, 19 Sep 2020 14:15:29 GMT
Subject: <i18n dev> RFR: 8253321: java.util.Locale.LanguageRange#equals
 is inconsistent after calling hashCode [v2]
In-Reply-To: <ETjaOd76_m2b44UZpE1CS8tHGy4CN6Dt4Bgrv2NPF2g=.874b196a-360f-44ed-8491-12e14ecf13f7@github.com>
References: <2-y_g5PvWat4frQ_-6XHFSx2QcZvQns4YzwInyhTemU=.ad69a573-0209-4c9e-b747-60590e3cf798@github.com>
 <ETjaOd76_m2b44UZpE1CS8tHGy4CN6Dt4Bgrv2NPF2g=.874b196a-360f-44ed-8491-12e14ecf13f7@github.com>
Message-ID: <9u8Osix3B5HCH7uNSfyHJidACv1HDvtkXAR65a5BXH4=.b245a107-5ed9-41af-9937-7c37b6d2a72e@github.com>

On Sat, 19 Sep 2020 01:36:38 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Hi,
>> 
>> Please review the fix to JDK-8253321. As in the issue, uninitialized (cached) hash code was incorrectly referenced in
>> equals() method. Removing it will correct the problem. Also, unrelated to the issue, I fixed a parameter description in
>> a private method.  Naoto
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Addressing Joe's comments

Marked as reviewed by rriggs (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/260

From alanb at openjdk.java.net  Sat Sep 19 15:54:25 2020
From: alanb at openjdk.java.net (Alan Bateman)
Date: Sat, 19 Sep 2020 15:54:25 GMT
Subject: <i18n dev> RFR: 8253208: Move CDS related code to a separate
 class
In-Reply-To: <F5TpL55P21vmeZsyjWfFiLEUkKjp6-XcvKd-RttQ6bc=.104dc1be-4bb5-4bd7-9f4e-4aea6a551c8f@github.com>
References: <F5TpL55P21vmeZsyjWfFiLEUkKjp6-XcvKd-RttQ6bc=.104dc1be-4bb5-4bd7-9f4e-4aea6a551c8f@github.com>
Message-ID: <ZOLHYCXIHl_s7STSxngue1Wt9Q6b0L5A8orMNtROdvI=.a1d9ca1c-632a-4e7f-b1eb-c3519cf2ec84@github.com>

On Fri, 18 Sep 2020 23:47:56 GMT, Yumin Qi <minqi at openjdk.org> wrote:

> With more CDS related code added to VM, it is time to move CDS code to a separate class. CDS is the new class which is
> specific to CDS.
> Tests: tier1-4

src/java.base/share/classes/jdk/internal/misc/CDS.java line 42:

> 40:     public static native void defineArchivedModules(ClassLoader platformLoader, ClassLoader systemLoader);
> 41:
> 42:     public static native long getRandomSeedForCDSDump();

The moving of the archive methods to CDS looks okay but inconsistent to only comment 3 of the 5 methods.

-------------

PR: https://git.openjdk.java.net/jdk/pull/261

From iklam at openjdk.java.net  Sun Sep 20 06:13:47 2020
From: iklam at openjdk.java.net (Ioi Lam)
Date: Sun, 20 Sep 2020 06:13:47 GMT
Subject: <i18n dev> RFR: 8253208: Move CDS related code to a separate
 class
In-Reply-To: <F5TpL55P21vmeZsyjWfFiLEUkKjp6-XcvKd-RttQ6bc=.104dc1be-4bb5-4bd7-9f4e-4aea6a551c8f@github.com>
References: <F5TpL55P21vmeZsyjWfFiLEUkKjp6-XcvKd-RttQ6bc=.104dc1be-4bb5-4bd7-9f4e-4aea6a551c8f@github.com>
Message-ID: <WCAMMW3LKXilOS8LROgfVvIw0WyhxuKd9MDo_Ln9O_E=.515e0032-a7a2-4a7c-9ce2-a6c21d2cd533@github.com>

On Fri, 18 Sep 2020 23:47:56 GMT, Yumin Qi <minqi at openjdk.org> wrote:

> With more CDS related code added to VM, it is time to move CDS code to a separate class. CDS is the new class which is
> specific to CDS.
> Tests: tier1-4

src/java.base/share/classes/jdk/internal/misc/CDS.java line 52:

> 50:      * Check if CDS sharing is enabled by via the UseSharedSpaces flag.
> 51:      */
> 52:     public static native boolean isCDSSharingEnabled();

I think the word CDS is redundant in the method names. How about

getRandomSeedForCDSDump() -> getRandomSeedForDumping()
isCDSDumpingEnabled() -> isDynamicDumpingEnabled()  // doesn't return true if we're doing a static dump
isCDSSharingEnabled() -> isSharingEnabled()

src/java.base/share/native/libjava/CDS.c line 49:

> 47: JNIEXPORT jboolean JNICALL
> 48: Java_jdk_internal_misc_CDS_isCDSDumpingEnabled(JNIEnv *env, jclass jcls) {
> 49:     return JVM_IsCDSDumpingEnabled(env);

Maybe: return JVM_IsCDSDynamicDumpingEnabled(env)

-------------

PR: https://git.openjdk.java.net/jdk/pull/261

From naoto at openjdk.java.net  Mon Sep 21 12:37:14 2020
From: naoto at openjdk.java.net (Naoto Sato)
Date: Mon, 21 Sep 2020 12:37:14 GMT
Subject: <i18n dev> Integrated: 8253321:
 java.util.Locale.LanguageRange#equals is inconsistent after calling
 hashCode
In-Reply-To: <2-y_g5PvWat4frQ_-6XHFSx2QcZvQns4YzwInyhTemU=.ad69a573-0209-4c9e-b747-60590e3cf798@github.com>
References: <2-y_g5PvWat4frQ_-6XHFSx2QcZvQns4YzwInyhTemU=.ad69a573-0209-4c9e-b747-60590e3cf798@github.com>
Message-ID: <29smkrDc7arlhkemAvvViCKV85MyG7-T_eBj8Si9atM=.de0af37d-0d02-4892-ad20-92e125d8fa21@github.com>

On Fri, 18 Sep 2020 23:26:39 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Hi,
> 
> Please review the fix to JDK-8253321. As in the issue, uninitialized (cached) hash code was incorrectly referenced in
> equals() method. Removing it will correct the problem. Also, unrelated to the issue, I fixed a parameter description in
> a private method.  Naoto

This pull request has now been integrated.

Changeset: dad6edbf
Author:    Naoto Sato <naoto at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/dad6edbf
Stats:     52 lines in 2 files changed: 1 ins; 48 del; 3 mod

8253321: java.util.Locale.LanguageRange#equals is inconsistent after calling hashCode

Reviewed-by: joehw, rriggs

-------------

PR: https://git.openjdk.java.net/jdk/pull/260

From minqi at openjdk.java.net  Mon Sep 21 18:17:55 2020
From: minqi at openjdk.java.net (Yumin Qi)
Date: Mon, 21 Sep 2020 18:17:55 GMT
Subject: <i18n dev> RFR: 8253208: Move CDS related code to a separate
 class [v2]
In-Reply-To: <F5TpL55P21vmeZsyjWfFiLEUkKjp6-XcvKd-RttQ6bc=.104dc1be-4bb5-4bd7-9f4e-4aea6a551c8f@github.com>
References: <F5TpL55P21vmeZsyjWfFiLEUkKjp6-XcvKd-RttQ6bc=.104dc1be-4bb5-4bd7-9f4e-4aea6a551c8f@github.com>
Message-ID: <Kg4KHzYx9CEpGtNcg3k4WcrrwXDQyJebzh963bkmXjk=.8c0787be-e2f0-4f2b-8cce-7e579892b403@github.com>

> With more CDS related code added to VM, it is time to move CDS code to a separate class. CDS is the new class which is
> specific to CDS.
> Tests: tier1-4

Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:

  8253208: Move CDS related code to a separate class

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/261/files
  - new: https://git.openjdk.java.net/jdk/pull/261/files/b9789c8b..c01deec7

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=261&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=261&range=00-01

  Stats: 27 lines in 7 files changed: 0 ins; 0 del; 27 mod
  Patch: https://git.openjdk.java.net/jdk/pull/261.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/261/head:pull/261

PR: https://git.openjdk.java.net/jdk/pull/261

From minqi at openjdk.java.net  Mon Sep 21 18:25:55 2020
From: minqi at openjdk.java.net (Yumin Qi)
Date: Mon, 21 Sep 2020 18:25:55 GMT
Subject: <i18n dev> RFR: 8253208: Move CDS related code to a separate
 class [v2]
In-Reply-To: <WCAMMW3LKXilOS8LROgfVvIw0WyhxuKd9MDo_Ln9O_E=.515e0032-a7a2-4a7c-9ce2-a6c21d2cd533@github.com>
References: <F5TpL55P21vmeZsyjWfFiLEUkKjp6-XcvKd-RttQ6bc=.104dc1be-4bb5-4bd7-9f4e-4aea6a551c8f@github.com>
 <WCAMMW3LKXilOS8LROgfVvIw0WyhxuKd9MDo_Ln9O_E=.515e0032-a7a2-4a7c-9ce2-a6c21d2cd533@github.com>
Message-ID: <7rL3zSJi28q_2LUdGaxlpMg8b2fFh1IHNF07U3uaaeU=.b4a7e852-9c61-43bf-aadf-30b5d5d6af32@github.com>

On Sun, 20 Sep 2020 06:10:53 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8253208: Move CDS related code to a separate class
>
> src/java.base/share/native/libjava/CDS.c line 49:
> 
>> 47: JNIEXPORT jboolean JNICALL
>> 48: Java_jdk_internal_misc_CDS_isCDSDumpingEnabled(JNIEnv *env, jclass jcls) {
>> 49:     return JVM_IsCDSDumpingEnabled(env);
> 
> Maybe: return JVM_IsCDSDynamicDumpingEnabled(env)

updated with comments.

-------------

PR: https://git.openjdk.java.net/jdk/pull/261

From mchung at openjdk.java.net  Mon Sep 21 19:00:33 2020
From: mchung at openjdk.java.net (Mandy Chung)
Date: Mon, 21 Sep 2020 19:00:33 GMT
Subject: <i18n dev> RFR: 8253208: Move CDS related code to a separate
 class [v2]
In-Reply-To: <Kg4KHzYx9CEpGtNcg3k4WcrrwXDQyJebzh963bkmXjk=.8c0787be-e2f0-4f2b-8cce-7e579892b403@github.com>
References: <F5TpL55P21vmeZsyjWfFiLEUkKjp6-XcvKd-RttQ6bc=.104dc1be-4bb5-4bd7-9f4e-4aea6a551c8f@github.com>
 <Kg4KHzYx9CEpGtNcg3k4WcrrwXDQyJebzh963bkmXjk=.8c0787be-e2f0-4f2b-8cce-7e579892b403@github.com>
Message-ID: <UMjG3MIGQR_WyMvW-_uYNRKsQ9la96Id1lcXPl77Ojs=.c81e0e73-130d-4deb-ac8c-bc10d4b8514e@github.com>

On Mon, 21 Sep 2020 18:17:55 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> With more CDS related code added to VM, it is time to move CDS code to a separate class. CDS is the new class which is
>> specific to CDS.
>> Tests: tier1-4
>
> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8253208: Move CDS related code to a separate class

This patch looks okay.   Please add the javadoc for `CDS::getRandomSeedForDumping` and `CDS::defineArchiveModules` for
completeness.

-------------

PR: https://git.openjdk.java.net/jdk/pull/261

From erikj at openjdk.java.net  Mon Sep 21 19:07:13 2020
From: erikj at openjdk.java.net (Erik Joelsson)
Date: Mon, 21 Sep 2020 19:07:13 GMT
Subject: <i18n dev> RFR: 8253208: Move CDS related code to a separate
 class [v2]
In-Reply-To: <Kg4KHzYx9CEpGtNcg3k4WcrrwXDQyJebzh963bkmXjk=.8c0787be-e2f0-4f2b-8cce-7e579892b403@github.com>
References: <F5TpL55P21vmeZsyjWfFiLEUkKjp6-XcvKd-RttQ6bc=.104dc1be-4bb5-4bd7-9f4e-4aea6a551c8f@github.com>
 <Kg4KHzYx9CEpGtNcg3k4WcrrwXDQyJebzh963bkmXjk=.8c0787be-e2f0-4f2b-8cce-7e579892b403@github.com>
Message-ID: <65z5iR9UPXmBfCEVJkOgnegcyctdCIOZJ_tMl0bEdAI=.0457ea07-f4ff-48e4-b793-2e8011ee1a45@github.com>

On Mon, 21 Sep 2020 18:17:55 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> With more CDS related code added to VM, it is time to move CDS code to a separate class. CDS is the new class which is
>> specific to CDS.
>> Tests: tier1-4
>
> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8253208: Move CDS related code to a separate class

Build changes look good.

-------------

PR: https://git.openjdk.java.net/jdk/pull/261

From prr at openjdk.java.net  Mon Sep 21 20:51:31 2020
From: prr at openjdk.java.net (Phil Race)
Date: Mon, 21 Sep 2020 20:51:31 GMT
Subject: <i18n dev> RFR: 8252195: AWT Accessibility API nested classes rely
 on default constructors
Message-ID: <cohQ_AUK79-j-xTPRTby6gS1emhPqL6h4idWbs47o_8=.11867db2-e9a0-4af1-9dd9-26456bdcb85c@github.com>

https://bugs.openjdk.java.net/browse/JDK-8252195
is another one of the issues adding missing explicit no-args constructors in the desktop module.

As well as being nested, these are all concrete, but protected, classes and so the constructors
are protected.

CSR here https://bugs.openjdk.java.net/browse/JDK-8253450 needs a reviewer too.

-------------

Commit messages:
 - 8252195: AWT Accessibility API nested classes rely on default constructors
 - 8252195: AWT Accessibility API nested classes rely on default constructors

Changes: https://git.openjdk.java.net/jdk/pull/288/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=288&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8252195
  Stats: 117 lines in 19 files changed: 117 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/288.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/288/head:pull/288

PR: https://git.openjdk.java.net/jdk/pull/288

From iklam at openjdk.java.net  Mon Sep 21 21:57:01 2020
From: iklam at openjdk.java.net (Ioi Lam)
Date: Mon, 21 Sep 2020 21:57:01 GMT
Subject: <i18n dev> RFR: 8253208: Move CDS related code to a separate
 class [v2]
In-Reply-To: <Kg4KHzYx9CEpGtNcg3k4WcrrwXDQyJebzh963bkmXjk=.8c0787be-e2f0-4f2b-8cce-7e579892b403@github.com>
References: <F5TpL55P21vmeZsyjWfFiLEUkKjp6-XcvKd-RttQ6bc=.104dc1be-4bb5-4bd7-9f4e-4aea6a551c8f@github.com>
 <Kg4KHzYx9CEpGtNcg3k4WcrrwXDQyJebzh963bkmXjk=.8c0787be-e2f0-4f2b-8cce-7e579892b403@github.com>
Message-ID: <ItpXTPPoo2XzpoPthwLWVRummjaY0KJnCSY_dNhoKQo=.9e47210b-d862-4b6d-a317-53fcb16dbc89@github.com>

On Mon, 21 Sep 2020 18:17:55 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> With more CDS related code added to VM, it is time to move CDS code to a separate class. CDS is the new class which is
>> specific to CDS.
>> Tests: tier1-4
>
> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8253208: Move CDS related code to a separate class

Marked as reviewed by iklam (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/261

From minqi at openjdk.java.net  Mon Sep 21 22:24:15 2020
From: minqi at openjdk.java.net (Yumin Qi)
Date: Mon, 21 Sep 2020 22:24:15 GMT
Subject: <i18n dev> RFR: 8253208: Move CDS related code to a separate
 class [v3]
In-Reply-To: <F5TpL55P21vmeZsyjWfFiLEUkKjp6-XcvKd-RttQ6bc=.104dc1be-4bb5-4bd7-9f4e-4aea6a551c8f@github.com>
References: <F5TpL55P21vmeZsyjWfFiLEUkKjp6-XcvKd-RttQ6bc=.104dc1be-4bb5-4bd7-9f4e-4aea6a551c8f@github.com>
Message-ID: <7yHEh89XlpTGoXfHw85_SVEKEBM0t03tQlkZ7tKm4P0=.399d9d6c-c375-4892-a92c-3cd6806e51d6@github.com>

> With more CDS related code added to VM, it is time to move CDS code to a separate class. CDS is the new class which is
> specific to CDS.
> Tests: tier1-4

Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:

  8253208: Move CDS related code to a separate class

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/261/files
  - new: https://git.openjdk.java.net/jdk/pull/261/files/c01deec7..953b6bac

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=261&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=261&range=01-02

  Stats: 10 lines in 1 file changed: 9 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/261.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/261/head:pull/261

PR: https://git.openjdk.java.net/jdk/pull/261

From serb at openjdk.java.net  Tue Sep 22 03:06:31 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Tue, 22 Sep 2020 03:06:31 GMT
Subject: <i18n dev> RFR: 8252195: AWT Accessibility API nested classes
 rely on default constructors
In-Reply-To: <cohQ_AUK79-j-xTPRTby6gS1emhPqL6h4idWbs47o_8=.11867db2-e9a0-4af1-9dd9-26456bdcb85c@github.com>
References: <cohQ_AUK79-j-xTPRTby6gS1emhPqL6h4idWbs47o_8=.11867db2-e9a0-4af1-9dd9-26456bdcb85c@github.com>
Message-ID: <ECW7jExr2YkFDTxblGrZ0YMjbjLEJxk-M_T8QgsmIU0=.7375125a-528b-494a-b17b-853dd864c90b@github.com>

On Mon, 21 Sep 2020 20:17:36 GMT, Phil Race <prr at openjdk.org> wrote:

> https://bugs.openjdk.java.net/browse/JDK-8252195
> is another one of the issues adding missing explicit no-args constructors in the desktop module.
> 
> As well as being nested, these are all concrete, but protected, classes and so the constructors
> are protected.
> 
> CSR here https://bugs.openjdk.java.net/browse/JDK-8253450 needs a reviewer too.

src/java.desktop/share/classes/java/LS line 1:

> 1: -rw-r--r--   1 prrace  staff   22640 Sep 21 12:12 CheckboxMenuItem.java

This extra file seems accidentally added

-------------

PR: https://git.openjdk.java.net/jdk/pull/288

From github.com+471021+marschall at openjdk.java.net  Tue Sep 22 05:26:31 2020
From: github.com+471021+marschall at openjdk.java.net (Philippe Marschall)
Date: Tue, 22 Sep 2020 05:26:31 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v3]
In-Reply-To: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
Message-ID: <MEdUZhCiz93Fz_9KzCU1ypgPjc5XGofwCwdHprlKVVI=.ae0cc75e-c5d4-4eac-8d33-2ffefecf9d2d@github.com>

> Hello, newbie here
> 
> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
> 
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.
> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
>   imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.
> - All tier1 tests pass.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.

Philippe Marschall has updated the pull request with a new target base due to a merge or a rebase. The pull request now
contains one commit:

  8138732: Rename HotSpotIntrinsicCandidate to IntrinsicCandidate

-------------

Changes: https://git.openjdk.java.net/jdk/pull/45/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=45&range=02
  Stats: 748 lines in 64 files changed: 149 ins; 149 del; 450 mod
  Patch: https://git.openjdk.java.net/jdk/pull/45.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/45/head:pull/45

PR: https://git.openjdk.java.net/jdk/pull/45

From egahlin at openjdk.java.net  Tue Sep 22 08:45:52 2020
From: egahlin at openjdk.java.net (Erik Gahlin)
Date: Tue, 22 Sep 2020 08:45:52 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v2]
In-Reply-To: <BLuZ7WSu8-JWFdqRPuGRObrSizRQxepj928eU9taifY=.e2cf4679-a25c-4ff0-9d0c-f7c91f34461c@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
 <HGsatCKpnNbiuasm8cuzQI43pSP8i6zy8TwbXY7tZHY=.e83599d8-69c0-4f04-b34e-26d64b23a04e@github.com>
 <BLuZ7WSu8-JWFdqRPuGRObrSizRQxepj928eU9taifY=.e2cf4679-a25c-4ff0-9d0c-f7c91f34461c@github.com>
Message-ID: <N0RROm5O7dd7XCgz9hVt1YB90WWha7euJDO0W3AqRs0=.2c8d3fe1-ae14-4935-818f-25d80d1c4797@github.com>

On Sat, 12 Sep 2020 00:19:00 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Philippe Marschall has refreshed the contents of this pull request, and previous commits have been removed. The
>> incremental views will show differences compared to the previous content of the PR. The pull request contains one new
>> commit since the last revision:
>>   8138732: Rename HotSpotIntrinsicCandidate to IntrinsicCandidate
>
> Marked as reviewed by kvn (Reviewer).

Have you run the JFR tests in test/jdk/jdk/jfr?

-------------

PR: https://git.openjdk.java.net/jdk/pull/45

From mchung at openjdk.java.net  Tue Sep 22 16:03:07 2020
From: mchung at openjdk.java.net (Mandy Chung)
Date: Tue, 22 Sep 2020 16:03:07 GMT
Subject: <i18n dev> RFR: 8253208: Move CDS related code to a separate
 class [v3]
In-Reply-To: <7yHEh89XlpTGoXfHw85_SVEKEBM0t03tQlkZ7tKm4P0=.399d9d6c-c375-4892-a92c-3cd6806e51d6@github.com>
References: <F5TpL55P21vmeZsyjWfFiLEUkKjp6-XcvKd-RttQ6bc=.104dc1be-4bb5-4bd7-9f4e-4aea6a551c8f@github.com>
 <7yHEh89XlpTGoXfHw85_SVEKEBM0t03tQlkZ7tKm4P0=.399d9d6c-c375-4892-a92c-3cd6806e51d6@github.com>
Message-ID: <8hwfOa6oYGE3dZPVcdltbIO_lVzRHFeztiTrFAFaIr0=.f4082018-d17a-40ee-94f7-14fef9872579@github.com>

On Mon, 21 Sep 2020 22:24:15 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> With more CDS related code added to VM, it is time to move CDS code to a separate class. CDS is the new class which is
>> specific to CDS.
>> Tests: tier1-4
>
> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8253208: Move CDS related code to a separate class

Marked as reviewed by mchung (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/261

From prr at openjdk.java.net  Tue Sep 22 16:08:12 2020
From: prr at openjdk.java.net (Phil Race)
Date: Tue, 22 Sep 2020 16:08:12 GMT
Subject: <i18n dev> RFR: 8252195: AWT Accessibility API nested classes
 rely on default constructors [v2]
In-Reply-To: <cohQ_AUK79-j-xTPRTby6gS1emhPqL6h4idWbs47o_8=.11867db2-e9a0-4af1-9dd9-26456bdcb85c@github.com>
References: <cohQ_AUK79-j-xTPRTby6gS1emhPqL6h4idWbs47o_8=.11867db2-e9a0-4af1-9dd9-26456bdcb85c@github.com>
Message-ID: <mqPChrLosKzUAM5qj6qMst5oT3gyASrMU3ODXQ5t6TM=.db8d0441-3b8f-4a98-b679-e637a57cbfc8@github.com>

> https://bugs.openjdk.java.net/browse/JDK-8252195
> is another one of the issues adding missing explicit no-args constructors in the desktop module.
> 
> As well as being nested, these are all concrete, but protected, classes and so the constructors
> are protected.
> 
> CSR here https://bugs.openjdk.java.net/browse/JDK-8253450 needs a reviewer too.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8252195: AWT Accessibility API nested classes rely on default constructors

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/288/files
  - new: https://git.openjdk.java.net/jdk/pull/288/files/8dab932c..c57687ea

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=288&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=288&range=00-01

  Stats: 17 lines in 1 file changed: 0 ins; 17 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/288.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/288/head:pull/288

PR: https://git.openjdk.java.net/jdk/pull/288

From prr at openjdk.java.net  Tue Sep 22 16:08:13 2020
From: prr at openjdk.java.net (Phil Race)
Date: Tue, 22 Sep 2020 16:08:13 GMT
Subject: <i18n dev> RFR: 8252195: AWT Accessibility API nested classes
 rely on default constructors
In-Reply-To: <cohQ_AUK79-j-xTPRTby6gS1emhPqL6h4idWbs47o_8=.11867db2-e9a0-4af1-9dd9-26456bdcb85c@github.com>
References: <cohQ_AUK79-j-xTPRTby6gS1emhPqL6h4idWbs47o_8=.11867db2-e9a0-4af1-9dd9-26456bdcb85c@github.com>
Message-ID: <A2Vk9zqmlhqv22J8tJuqwTS2hTkoIjJliejs7tNO2R8=.de92f65e-7e42-447f-8fc5-d8366992522e@github.com>

On Mon, 21 Sep 2020 20:17:36 GMT, Phil Race <prr at openjdk.org> wrote:

> https://bugs.openjdk.java.net/browse/JDK-8252195
> is another one of the issues adding missing explicit no-args constructors in the desktop module.
> 
> As well as being nested, these are all concrete, but protected, classes and so the constructors
> are protected.
> 
> CSR here https://bugs.openjdk.java.net/browse/JDK-8253450 needs a reviewer too.

extra file deleted. That'll teach me not to do 'git add <folder>'

-------------

PR: https://git.openjdk.java.net/jdk/pull/288

From minqi at openjdk.java.net  Tue Sep 22 16:14:40 2020
From: minqi at openjdk.java.net (Yumin Qi)
Date: Tue, 22 Sep 2020 16:14:40 GMT
Subject: <i18n dev> Integrated: 8253208: Move CDS related code to a separate
 class
In-Reply-To: <F5TpL55P21vmeZsyjWfFiLEUkKjp6-XcvKd-RttQ6bc=.104dc1be-4bb5-4bd7-9f4e-4aea6a551c8f@github.com>
References: <F5TpL55P21vmeZsyjWfFiLEUkKjp6-XcvKd-RttQ6bc=.104dc1be-4bb5-4bd7-9f4e-4aea6a551c8f@github.com>
Message-ID: <gdphpxkAMphL2qBsNMBbFZwcVExCjdjGk3PfUoW5veg=.ecd42835-b123-4a9f-b0de-bc5aebe767de@github.com>

On Fri, 18 Sep 2020 23:47:56 GMT, Yumin Qi <minqi at openjdk.org> wrote:

> With more CDS related code added to VM, it is time to move CDS code to a separate class. CDS is the new class which is
> specific to CDS.
> Tests: tier1-4

This pull request has now been integrated.

Changeset: c1df13b8
Author:    Yumin Qi <minqi at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/c1df13b8
Stats:     218 lines in 23 files changed: 53 ins; 119 del; 46 mod

8253208: Move CDS related code to a separate class

Reviewed-by: mchung, iklam

-------------

PR: https://git.openjdk.java.net/jdk/pull/261

From serb at openjdk.java.net  Tue Sep 22 19:52:59 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Tue, 22 Sep 2020 19:52:59 GMT
Subject: <i18n dev> RFR: 8252195: AWT Accessibility API nested classes
 rely on default constructors [v2]
In-Reply-To: <mqPChrLosKzUAM5qj6qMst5oT3gyASrMU3ODXQ5t6TM=.db8d0441-3b8f-4a98-b679-e637a57cbfc8@github.com>
References: <cohQ_AUK79-j-xTPRTby6gS1emhPqL6h4idWbs47o_8=.11867db2-e9a0-4af1-9dd9-26456bdcb85c@github.com>
 <mqPChrLosKzUAM5qj6qMst5oT3gyASrMU3ODXQ5t6TM=.db8d0441-3b8f-4a98-b679-e637a57cbfc8@github.com>
Message-ID: <TyHOxIEu_8fp41JZPomG8xDM2_FxYzoCVT_69T58Wtc=.a10673ee-0cb4-4218-a5d6-a0595fe705de@github.com>

On Tue, 22 Sep 2020 16:08:12 GMT, Phil Race <prr at openjdk.org> wrote:

>> https://bugs.openjdk.java.net/browse/JDK-8252195
>> is another one of the issues adding missing explicit no-args constructors in the desktop module.
>> 
>> As well as being nested, these are all concrete, but protected, classes and so the constructors
>> are protected.
>> 
>> CSR here https://bugs.openjdk.java.net/browse/JDK-8253450 needs a reviewer too.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8252195: AWT Accessibility API nested classes rely on default constructors

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/288

From rriggs at openjdk.java.net  Tue Sep 22 21:27:40 2020
From: rriggs at openjdk.java.net (Roger Riggs)
Date: Tue, 22 Sep 2020 21:27:40 GMT
Subject: <i18n dev> RFR: 8253240: No javadoc for
 DecimalFormatSymbols.hashCode() [v2]
In-Reply-To: <cB8HhxLchwGnSpSLyCgUUeFCZv6FVbX9ixZG8UzB-c0=.bc0ef94b-2957-41e1-ba5e-6be2772acdaa@github.com>
References: <IJZu3IoKF1IIe0wJyoG2L2vh_JbUFQiW1ZZY4g44sPc=.a232343b-b4a4-405e-ba43-ab8cb21ede40@github.com>
 <cB8HhxLchwGnSpSLyCgUUeFCZv6FVbX9ixZG8UzB-c0=.bc0ef94b-2957-41e1-ba5e-6be2772acdaa@github.com>
Message-ID: <rht8iqi4WWL9NxCVbp2fwjZOQMeaxAiL7pDFOkyNBGc=.ba61ee91-8afb-461e-9daf-939b6d393edb@github.com>

On Wed, 16 Sep 2020 18:02:42 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Hi,
>> 
>> Please review the fix to the issue wrt missing hashCode() javadoc, which was recently discussed in core-libs ml.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Addressing Roger's comments.

Looks fine.  Thanks

-------------

Marked as reviewed by rriggs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/208

From prr at openjdk.java.net  Tue Sep 22 22:17:46 2020
From: prr at openjdk.java.net (Phil Race)
Date: Tue, 22 Sep 2020 22:17:46 GMT
Subject: <i18n dev> Integrated: 8252195: AWT Accessibility API nested
 classes rely on default constructors
In-Reply-To: <cohQ_AUK79-j-xTPRTby6gS1emhPqL6h4idWbs47o_8=.11867db2-e9a0-4af1-9dd9-26456bdcb85c@github.com>
References: <cohQ_AUK79-j-xTPRTby6gS1emhPqL6h4idWbs47o_8=.11867db2-e9a0-4af1-9dd9-26456bdcb85c@github.com>
Message-ID: <YyOIxIhErVqvU_r6fZJ7nYIT1w9O0nW7nyj2lY-XpEw=.6d015a4a-e1c6-4674-a61e-360c09b67d13@github.com>

On Mon, 21 Sep 2020 20:17:36 GMT, Phil Race <prr at openjdk.org> wrote:

> https://bugs.openjdk.java.net/browse/JDK-8252195
> is another one of the issues adding missing explicit no-args constructors in the desktop module.
> 
> As well as being nested, these are all concrete, but protected, classes and so the constructors
> are protected.
> 
> CSR here https://bugs.openjdk.java.net/browse/JDK-8253450 needs a reviewer too.

This pull request has now been integrated.

Changeset: 93a2018d
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/93a2018d
Stats:     100 lines in 18 files changed: 0 ins; 100 del; 0 mod

8252195: AWT Accessibility API nested classes rely on default constructors

Reviewed-by: serb

-------------

PR: https://git.openjdk.java.net/jdk/pull/288

From naoto at openjdk.java.net  Tue Sep 22 23:01:46 2020
From: naoto at openjdk.java.net (Naoto Sato)
Date: Tue, 22 Sep 2020 23:01:46 GMT
Subject: <i18n dev> Integrated: 8253240: No javadoc for
 DecimalFormatSymbols.hashCode()
In-Reply-To: <IJZu3IoKF1IIe0wJyoG2L2vh_JbUFQiW1ZZY4g44sPc=.a232343b-b4a4-405e-ba43-ab8cb21ede40@github.com>
References: <IJZu3IoKF1IIe0wJyoG2L2vh_JbUFQiW1ZZY4g44sPc=.a232343b-b4a4-405e-ba43-ab8cb21ede40@github.com>
Message-ID: <R3iGdHtK0EZCN_khDkXQIDaEoFMQl1sfpc6vmF5FpDA=.0729bdd8-ed1e-4b7f-bbdb-965468bd78b5@github.com>

On Wed, 16 Sep 2020 17:29:52 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Hi,
> 
> Please review the fix to the issue wrt missing hashCode() javadoc, which was recently discussed in core-libs ml.

This pull request has now been integrated.

Changeset: bddb8225
Author:    Naoto Sato <naoto at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/bddb8225
Stats:     6 lines in 1 file changed: 1 ins; 5 del; 0 mod

8253240: No javadoc for DecimalFormatSymbols.hashCode()

Reviewed-by: rriggs, lancea

-------------

PR: https://git.openjdk.java.net/jdk/pull/208

From github.com+471021+marschall at openjdk.java.net  Wed Sep 23 04:03:05 2020
From: github.com+471021+marschall at openjdk.java.net (Philippe Marschall)
Date: Wed, 23 Sep 2020 04:03:05 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v4]
In-Reply-To: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
Message-ID: <urUr2jvbS5oB8Ulhwl_sqFX1RrX9ctFr5kLo01LC_oI=.ad1412de-515a-4dc9-aaff-af368099fb78@github.com>

> Hello, newbie here
> 
> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
> 
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.
> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
>   imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.
> - All tier1 tests pass.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.

Philippe Marschall has updated the pull request with a new target base due to a merge or a rebase. The pull request now
contains one commit:

  8138732: Rename HotSpotIntrinsicCandidate to IntrinsicCandidate

-------------

Changes: https://git.openjdk.java.net/jdk/pull/45/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=45&range=03
  Stats: 753 lines in 65 files changed: 153 ins; 149 del; 451 mod
  Patch: https://git.openjdk.java.net/jdk/pull/45.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/45/head:pull/45

PR: https://git.openjdk.java.net/jdk/pull/45

From dholmes at openjdk.java.net  Wed Sep 23 05:13:17 2020
From: dholmes at openjdk.java.net (David Holmes)
Date: Wed, 23 Sep 2020 05:13:17 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v2]
In-Reply-To: <N0RROm5O7dd7XCgz9hVt1YB90WWha7euJDO0W3AqRs0=.2c8d3fe1-ae14-4935-818f-25d80d1c4797@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
 <HGsatCKpnNbiuasm8cuzQI43pSP8i6zy8TwbXY7tZHY=.e83599d8-69c0-4f04-b34e-26d64b23a04e@github.com>
 <BLuZ7WSu8-JWFdqRPuGRObrSizRQxepj928eU9taifY=.e2cf4679-a25c-4ff0-9d0c-f7c91f34461c@github.com>
 <N0RROm5O7dd7XCgz9hVt1YB90WWha7euJDO0W3AqRs0=.2c8d3fe1-ae14-4935-818f-25d80d1c4797@github.com>
Message-ID: <PPFbx3pHsVZvsuSEw57dPtECEGMN9wKSv3lg5L8FnUc=.030c07ab-9c93-406d-89c3-f94f111f9ae7@github.com>

On Tue, 22 Sep 2020 08:43:04 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Marked as reviewed by kvn (Reviewer).
>
> Have you run the JFR tests in test/jdk/jdk/jfr?

@marschall Please do not force-push anything as it breaks the commit history in the PR and renders previous
reviews/comments obsolete. There is no way for the reviewers to see what changed between the commit they reviewed and
the commit now in the PR.

To update to latest changes you should have just merged your branch with your (up-to-date) local master, committed that
merge in your local branch and then pushed that commit to your Personal Fork. The skara tooling will flatten the series
of commits in a PR into one single well-formed commit that is pushed to the master branch of the repo.

-------------

PR: https://git.openjdk.java.net/jdk/pull/45

From serb at openjdk.java.net  Wed Sep 23 07:54:19 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Wed, 23 Sep 2020 07:54:19 GMT
Subject: <i18n dev> RFR: 8253322 : Update the specification added to some of
 some newly added constructors
Message-ID: <GluQTJDpxp8CvIhjXFJcGqWpod1elu5XE333b5LdUQI=.55ea063c-2d86-4ab8-8d07-cfcb4fbd8929@github.com>

Looks like different people use a different style for the new constructors, it will be good to unify them.
I have started from https://bugs.openjdk.java.net/browse/JDK-8252721
See
https://bugs.openjdk.java.net/browse/JDK-8252908?focusedCommentId=14370006&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14370006

But since I already touched a bunch of classes, I decided to update some other fixes as well.

This will update the changes for:
https://bugs.openjdk.java.net/browse/JDK-8252721
https://bugs.openjdk.java.net/browse/JDK-8252195
https://bugs.openjdk.java.net/browse/JDK-8250858

-------------

Commit messages:
 - update the JDK-8250858
 - Update the JDK-8252195
 - update the JDK-8252721

Changes: https://git.openjdk.java.net/jdk/pull/315/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=315&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8253322
  Stats: 152 lines in 67 files changed: 15 ins; 0 del; 137 mod
  Patch: https://git.openjdk.java.net/jdk/pull/315.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/315/head:pull/315

PR: https://git.openjdk.java.net/jdk/pull/315

From psadhukhan at openjdk.java.net  Wed Sep 23 08:45:24 2020
From: psadhukhan at openjdk.java.net (Prasanta Sadhukhan)
Date: Wed, 23 Sep 2020 08:45:24 GMT
Subject: <i18n dev> RFR: 8253322 : Update the specification in the newly
 added constructors
In-Reply-To: <GluQTJDpxp8CvIhjXFJcGqWpod1elu5XE333b5LdUQI=.55ea063c-2d86-4ab8-8d07-cfcb4fbd8929@github.com>
References: <GluQTJDpxp8CvIhjXFJcGqWpod1elu5XE333b5LdUQI=.55ea063c-2d86-4ab8-8d07-cfcb4fbd8929@github.com>
Message-ID: <5DsJaueJzOQ7k0uf9c5TtcJWMeH-E6jcOyXiP1QE9G8=.8e38909f-248e-4c45-a117-5a55e4f70541@github.com>

On Wed, 23 Sep 2020 07:03:59 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Looks like different people use a different style for the new constructors, it will be good to unify them.
> I have started from https://bugs.openjdk.java.net/browse/JDK-8252721
> See
> https://bugs.openjdk.java.net/browse/JDK-8252908?focusedCommentId=14370006&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14370006
> 
> But since I already touched a bunch of classes, I decided to update some other fixes as well.
> 
> This will update the changes for:
> https://bugs.openjdk.java.net/browse/JDK-8252721
> https://bugs.openjdk.java.net/browse/JDK-8252195
> https://bugs.openjdk.java.net/browse/JDK-8250858

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/315

From github.com+471021+marschall at openjdk.java.net  Wed Sep 23 18:41:06 2020
From: github.com+471021+marschall at openjdk.java.net (Philippe Marschall)
Date: Wed, 23 Sep 2020 18:41:06 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v5]
In-Reply-To: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
Message-ID: <zugaqht-Za6mHPKWtaEq-YydzjtdY7uRwR_YWXF7l2w=.4da083f3-d7bd-42d0-99c9-316e9bcae6be@github.com>

> Hello, newbie here
> 
> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
> 
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.
> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
>   imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.
> - All tier1 tests pass.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.

Philippe Marschall has updated the pull request with a new target base due to a merge or a rebase. The pull request now
contains one commit:

  8138732: Rename HotSpotIntrinsicCandidate to IntrinsicCandidate

-------------

Changes: https://git.openjdk.java.net/jdk/pull/45/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=45&range=04
  Stats: 749 lines in 65 files changed: 149 ins; 149 del; 451 mod
  Patch: https://git.openjdk.java.net/jdk/pull/45.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/45/head:pull/45

PR: https://git.openjdk.java.net/jdk/pull/45

From kvn at openjdk.java.net  Wed Sep 23 18:55:29 2020
From: kvn at openjdk.java.net (Vladimir Kozlov)
Date: Wed, 23 Sep 2020 18:55:29 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v5]
In-Reply-To: <zugaqht-Za6mHPKWtaEq-YydzjtdY7uRwR_YWXF7l2w=.4da083f3-d7bd-42d0-99c9-316e9bcae6be@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
 <zugaqht-Za6mHPKWtaEq-YydzjtdY7uRwR_YWXF7l2w=.4da083f3-d7bd-42d0-99c9-316e9bcae6be@github.com>
Message-ID: <lGizFJloKlDCBOe1jJl_3fAcdNKNqaeMbGHRE3hHpPY=.aea4f185-f983-489f-8253-19c416b4eadb@github.com>

On Wed, 23 Sep 2020 18:41:06 GMT, Philippe Marschall <github.com+471021+marschall at openjdk.org> wrote:

>> Hello, newbie here
>> 
>> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
>> 
>> - I tried to update the copyright year to 2020 in every file.
>> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.
>> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
>>   imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.
>> - All tier1 tests pass.
>> - One jpackage/jlink tier2 test fails but I don't believe it is related.
>> - Some tier3 Swing tests fail but I don't think they are related.
>
> Philippe Marschall has updated the pull request with a new target base due to a merge or a rebase. The pull request now
> contains one commit:
>   8138732: Rename HotSpotIntrinsicCandidate to IntrinsicCandidate

Update seems fine. Thanks for JFR testing and fixing.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/45

From prr at openjdk.java.net  Wed Sep 23 19:34:50 2020
From: prr at openjdk.java.net (Phil Race)
Date: Wed, 23 Sep 2020 19:34:50 GMT
Subject: <i18n dev> RFR: 8253322 : Update the specification in the newly
 added constructors
In-Reply-To: <GluQTJDpxp8CvIhjXFJcGqWpod1elu5XE333b5LdUQI=.55ea063c-2d86-4ab8-8d07-cfcb4fbd8929@github.com>
References: <GluQTJDpxp8CvIhjXFJcGqWpod1elu5XE333b5LdUQI=.55ea063c-2d86-4ab8-8d07-cfcb4fbd8929@github.com>
Message-ID: <69P7vOGOUOX8tI47cIO-4G3lbjXN25_gVdPUHMER644=.839e4271-b133-4a30-903c-628f5926b660@github.com>

On Wed, 23 Sep 2020 07:03:59 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Looks like different people use a different style for the new constructors, it will be good to unify them.
> I have started from https://bugs.openjdk.java.net/browse/JDK-8252721
> See
> https://bugs.openjdk.java.net/browse/JDK-8252908?focusedCommentId=14370006&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14370006
> 
> But since I already touched a bunch of classes, I decided to update some other fixes as well.
> 
> This will update the changes for:
> https://bugs.openjdk.java.net/browse/JDK-8252721
> https://bugs.openjdk.java.net/browse/JDK-8252195
> https://bugs.openjdk.java.net/browse/JDK-8250858

I don't think we should have to deduce what are all the "styles" you are proposing.
The PR AND the bug should both say things like
1. Add a period (full stop) to the end of all javadoc comments.
.. and so forth.

otherwise where will be the record other than the scattered changes themselves ?
Please summarise along those lines.

-------------

PR: https://git.openjdk.java.net/jdk/pull/315

From egahlin at openjdk.java.net  Wed Sep 23 20:05:14 2020
From: egahlin at openjdk.java.net (Erik Gahlin)
Date: Wed, 23 Sep 2020 20:05:14 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v5]
In-Reply-To: <zugaqht-Za6mHPKWtaEq-YydzjtdY7uRwR_YWXF7l2w=.4da083f3-d7bd-42d0-99c9-316e9bcae6be@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
 <zugaqht-Za6mHPKWtaEq-YydzjtdY7uRwR_YWXF7l2w=.4da083f3-d7bd-42d0-99c9-316e9bcae6be@github.com>
Message-ID: <UCxcU0tRwEz8xXYlW9Hg0wEaKX2JCusvbbCatWV2964=.98b1ef2e-9acd-4e29-84dc-11cad7efdd0a@github.com>

On Wed, 23 Sep 2020 18:41:06 GMT, Philippe Marschall <github.com+471021+marschall at openjdk.org> wrote:

>> Hello, newbie here
>> 
>> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
>> 
>> - I tried to update the copyright year to 2020 in every file.
>> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.
>> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
>>   imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.
>> - All tier1 tests pass.
>> - One jpackage/jlink tier2 test fails but I don't believe it is related.
>> - Some tier3 Swing tests fail but I don't think they are related.
>
> Philippe Marschall has updated the pull request with a new target base due to a merge or a rebase. The pull request now
> contains one commit:
>   8138732: Rename HotSpotIntrinsicCandidate to IntrinsicCandidate

Marked as reviewed by egahlin (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/45

From kvn at openjdk.java.net  Wed Sep 23 22:50:52 2020
From: kvn at openjdk.java.net (Vladimir Kozlov)
Date: Wed, 23 Sep 2020 22:50:52 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v5]
In-Reply-To: <UCxcU0tRwEz8xXYlW9Hg0wEaKX2JCusvbbCatWV2964=.98b1ef2e-9acd-4e29-84dc-11cad7efdd0a@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
 <zugaqht-Za6mHPKWtaEq-YydzjtdY7uRwR_YWXF7l2w=.4da083f3-d7bd-42d0-99c9-316e9bcae6be@github.com>
 <UCxcU0tRwEz8xXYlW9Hg0wEaKX2JCusvbbCatWV2964=.98b1ef2e-9acd-4e29-84dc-11cad7efdd0a@github.com>
Message-ID: <MracV-9jG9bjyTmqAYhWD25TSe_-wmxLbpgUAmljM-o=.d4f69d34-a88f-4132-9d35-a1ce7a6f6e19@github.com>

On Wed, 23 Sep 2020 20:02:45 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Philippe Marschall has updated the pull request with a new target base due to a merge or a rebase. The pull request now
>> contains one commit:
>>   8138732: Rename HotSpotIntrinsicCandidate to IntrinsicCandidate
>
> Marked as reviewed by egahlin (Reviewer).

@marschall  I will sponsor it after you integrate the latest update.

-------------

PR: https://git.openjdk.java.net/jdk/pull/45

From serb at openjdk.java.net  Wed Sep 23 22:52:19 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Wed, 23 Sep 2020 22:52:19 GMT
Subject: <i18n dev> RFR: 8253322 : Update the specification in the newly
 added constructors
In-Reply-To: <69P7vOGOUOX8tI47cIO-4G3lbjXN25_gVdPUHMER644=.839e4271-b133-4a30-903c-628f5926b660@github.com>
References: <GluQTJDpxp8CvIhjXFJcGqWpod1elu5XE333b5LdUQI=.55ea063c-2d86-4ab8-8d07-cfcb4fbd8929@github.com>
 <69P7vOGOUOX8tI47cIO-4G3lbjXN25_gVdPUHMER644=.839e4271-b133-4a30-903c-628f5926b660@github.com>
Message-ID: <qaBhlOmG5m69l3jQ9N2KRJTrrubgcaA0yAn3iM8tRR8=.5b4164ab-22c8-494e-b064-db6fe1f711e1@github.com>

On Wed, 23 Sep 2020 19:31:28 GMT, Phil Race <prr at openjdk.org> wrote:

> otherwise where will be the record other than the scattered changes themselves ?
> Please summarise along those lines.

The description is updated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/315

From prr at openjdk.java.net  Wed Sep 23 23:24:49 2020
From: prr at openjdk.java.net (Phil Race)
Date: Wed, 23 Sep 2020 23:24:49 GMT
Subject: <i18n dev> RFR: 8253322 : Update the specification in the newly
 added constructors
In-Reply-To: <GluQTJDpxp8CvIhjXFJcGqWpod1elu5XE333b5LdUQI=.55ea063c-2d86-4ab8-8d07-cfcb4fbd8929@github.com>
References: <GluQTJDpxp8CvIhjXFJcGqWpod1elu5XE333b5LdUQI=.55ea063c-2d86-4ab8-8d07-cfcb4fbd8929@github.com>
Message-ID: <_Pac9-OCb-L3zYjzB1WPcs_ugW5-ksqdbwnmLgTiaWk=.3e2d4212-65b4-4d15-98aa-8bb05bca3bda@github.com>

On Wed, 23 Sep 2020 07:03:59 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Looks like different people use a different style for the new constructors, it will be good to unify them.
> 
> The text "Constructor for subclasses to call." should be used in the protected constructors in the abstract classes
> In all other cases the text "Constructs an {@code ClassName}." should be used
> A period (full stop) to the end of all javadoc comments, should be added if it is missing
> 
> I have started from https://bugs.openjdk.java.net/browse/JDK-8252721
> See
> https://bugs.openjdk.java.net/browse/JDK-8252908?focusedCommentId=14370006&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14370006
> 
> But since I already touched a bunch of classes, I decided to update some other fixes as well.
> 
> This will update the changes for:
> https://bugs.openjdk.java.net/browse/JDK-8252721
> https://bugs.openjdk.java.net/browse/JDK-8252195
> https://bugs.openjdk.java.net/browse/JDK-8250858

Marked as reviewed by prr (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/315

From serb at openjdk.java.net  Thu Sep 24 22:52:50 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Thu, 24 Sep 2020 22:52:50 GMT
Subject: <i18n dev> Integrated: 8253322 : Update the specification in the
 newly added constructors
In-Reply-To: <GluQTJDpxp8CvIhjXFJcGqWpod1elu5XE333b5LdUQI=.55ea063c-2d86-4ab8-8d07-cfcb4fbd8929@github.com>
References: <GluQTJDpxp8CvIhjXFJcGqWpod1elu5XE333b5LdUQI=.55ea063c-2d86-4ab8-8d07-cfcb4fbd8929@github.com>
Message-ID: <eIRgslx8a1FdRTefXqxNLQmoDvVtLneixYNXCBCoHbU=.a938f372-0361-4ac0-a54c-0fa00db0d9a5@github.com>

On Wed, 23 Sep 2020 07:03:59 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Looks like different people use a different style for the new constructors, it will be good to unify them.
> 
> The text "Constructor for subclasses to call." should be used in the protected constructors in the abstract classes
> In all other cases the text "Constructs an {@code ClassName}." should be used
> A period (full stop) to the end of all javadoc comments, should be added if it is missing
> 
> I have started from https://bugs.openjdk.java.net/browse/JDK-8252721
> See
> https://bugs.openjdk.java.net/browse/JDK-8252908?focusedCommentId=14370006&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14370006
> 
> But since I already touched a bunch of classes, I decided to update some other fixes as well.
> 
> This will update the changes for:
> https://bugs.openjdk.java.net/browse/JDK-8252721
> https://bugs.openjdk.java.net/browse/JDK-8252195
> https://bugs.openjdk.java.net/browse/JDK-8250858

This pull request has now been integrated.

Changeset: 8239b67d
Author:    Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/8239b67d
Stats:     152 lines in 67 files changed: 15 ins; 0 del; 137 mod

8253322: Update the specification in the newly added constructors

Reviewed-by: psadhukhan, prr

-------------

PR: https://git.openjdk.java.net/jdk/pull/315

From serb at openjdk.java.net  Fri Sep 25 22:00:42 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Fri, 25 Sep 2020 22:00:42 GMT
Subject: <i18n dev> RFR: 8251123: doclint warnings about missing javadoc
 tags and comments
Message-ID: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>

We have a number of missing javadoc tags and comments in the desktop module.
Most of the missing comments are related to the serialized form.

The fix:
  - Adds missing comments to the non-static/non-transient fields(even private) of the "serializable" classes
  - Adds comments to the "serializable" classes even if those classes are non-public
  - Fixes references/adds missing tags to the special methods(like readObject/writeObject)
  - Delete the java.awt.PeerFixer class.

I need advice about what exact change should be reviewed in  the CSR(except PeerFixer removal)

Note that in some cases I added the comments to the "implementation details", so I did not specify it fully.

The old review request:
https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000423.html

-------------

Commit messages:
 - 8251123: doclint warnings about missing javadoc tags and comments

Changes: https://git.openjdk.java.net/jdk/pull/369/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=369&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8251123
  Stats: 1306 lines in 69 files changed: 810 ins; 214 del; 282 mod
  Patch: https://git.openjdk.java.net/jdk/pull/369.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/369/head:pull/369

PR: https://git.openjdk.java.net/jdk/pull/369

From github.com+471021+marschall at openjdk.java.net  Sun Sep 27 19:03:44 2020
From: github.com+471021+marschall at openjdk.java.net (Philippe Marschall)
Date: Sun, 27 Sep 2020 19:03:44 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v6]
In-Reply-To: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
Message-ID: <FZmST7PtgMiOGGdGdLJXZHwZsWDtk8D3HYE0jJM7NBA=.c7c705c5-c056-4758-942d-bc26452b2367@github.com>

> Hello, newbie here
> 
> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
> 
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.
> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
>   imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.
> - All tier1 tests pass.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.

Philippe Marschall has updated the pull request with a new target base due to a merge or a rebase. The pull request now
contains two commits:

 - Merge branch 'master' into JDK-8138732
 - 8138732: Rename HotSpotIntrinsicCandidate to IntrinsicCandidate

-------------

Changes: https://git.openjdk.java.net/jdk/pull/45/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=45&range=05
  Stats: 749 lines in 65 files changed: 149 ins; 149 del; 451 mod
  Patch: https://git.openjdk.java.net/jdk/pull/45.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/45/head:pull/45

PR: https://git.openjdk.java.net/jdk/pull/45

From jdv at openjdk.java.net  Mon Sep 28 06:33:37 2020
From: jdv at openjdk.java.net (Jayathirth D V)
Date: Mon, 28 Sep 2020 06:33:37 GMT
Subject: <i18n dev> RFR: 8251123: doclint warnings about missing javadoc
 tags and comments
In-Reply-To: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
References: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
Message-ID: <EdfJXa3kuNijOryLV3Kf259t5AjaFE7AfrC5IbnJitc=.f3f4f691-c9f8-4773-a8a8-2f6a9a9f167d@github.com>

On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
> 
> The fix:
>   - Adds missing comments to the non-static/non-transient fields(even private) of the "serializable" classes
>   - Adds comments to the "serializable" classes even if those classes are non-public
>   - Fixes references/adds missing tags to the special methods(like readObject/writeObject)
>   - Delete the java.awt.PeerFixer class.
> 
> I need advice about what exact change should be reviewed in  the CSR(except PeerFixer removal)
> 
> Note that in some cases I added the comments to the "implementation details", so I did not specify it fully.
> 
> The old review request:
> https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000423.html

Inputs from https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000424.html are incorporated or is this fresh
git review?

-------------

PR: https://git.openjdk.java.net/jdk/pull/369

From serb at openjdk.java.net  Mon Sep 28 07:52:48 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Mon, 28 Sep 2020 07:52:48 GMT
Subject: <i18n dev> RFR: 8251123: doclint warnings about missing javadoc
 tags and comments
In-Reply-To: <EdfJXa3kuNijOryLV3Kf259t5AjaFE7AfrC5IbnJitc=.f3f4f691-c9f8-4773-a8a8-2f6a9a9f167d@github.com>
References: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
 <EdfJXa3kuNijOryLV3Kf259t5AjaFE7AfrC5IbnJitc=.f3f4f691-c9f8-4773-a8a8-2f6a9a9f167d@github.com>
Message-ID: <gtUH1qU_ouOcGWZbyN2xEDNsUCoeG_ggwYeAyctxmlA=.a12f8cec-3ced-4f57-841c-44ce844b701c@github.com>

On Mon, 28 Sep 2020 06:30:31 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

> Inputs from https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000424.html are incorporated or is this fresh
> git review?

It is a fresh update, it changes from the old review request. I made it less "dangerous".

-------------

PR: https://git.openjdk.java.net/jdk/pull/369

From github.com+471021+marschall at openjdk.java.net  Mon Sep 28 19:10:41 2020
From: github.com+471021+marschall at openjdk.java.net (Philippe Marschall)
Date: Mon, 28 Sep 2020 19:10:41 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v5]
In-Reply-To: <MracV-9jG9bjyTmqAYhWD25TSe_-wmxLbpgUAmljM-o=.d4f69d34-a88f-4132-9d35-a1ce7a6f6e19@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
 <zugaqht-Za6mHPKWtaEq-YydzjtdY7uRwR_YWXF7l2w=.4da083f3-d7bd-42d0-99c9-316e9bcae6be@github.com>
 <UCxcU0tRwEz8xXYlW9Hg0wEaKX2JCusvbbCatWV2964=.98b1ef2e-9acd-4e29-84dc-11cad7efdd0a@github.com>
 <MracV-9jG9bjyTmqAYhWD25TSe_-wmxLbpgUAmljM-o=.d4f69d34-a88f-4132-9d35-a1ce7a6f6e19@github.com>
Message-ID: <UbFqxjvGg7eJrIKC1QXb9OidWtkxQOFKqMoCYUmZ3bM=.bb276fb4-dad8-417f-9a3f-1651c69bc9b5@github.com>

On Wed, 23 Sep 2020 22:47:47 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Marked as reviewed by egahlin (Reviewer).
>
> @marschall  I will sponsor it after you integrate the latest update.

@vnkozlov done, I hope I now made it correctly with a merge commit for the latest merge conflict

-------------

PR: https://git.openjdk.java.net/jdk/pull/45

From jdv at openjdk.java.net  Wed Sep 30 06:14:27 2020
From: jdv at openjdk.java.net (Jayathirth D V)
Date: Wed, 30 Sep 2020 06:14:27 GMT
Subject: <i18n dev> RFR: 8251123: doclint warnings about missing javadoc
 tags and comments
In-Reply-To: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
References: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
Message-ID: <vF69CNwfHt7ilaBRSgow7yBIEiA5EqYELdqTh-kJACk=.dd656970-24db-48fe-b111-5710f39217d1@github.com>

On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
> 
> The fix:
>   - Adds missing comments to the non-static/non-transient fields(even private) of the "serializable" classes
>   - Adds comments to the "serializable" classes even if those classes are non-public
>   - Fixes references/adds missing tags to the special methods(like readObject/writeObject)
>   - Delete the java.awt.PeerFixer class.
> 
> I need advice about what exact change should be reviewed in  the CSR(except PeerFixer removal)
> 
> Note that in some cases I added the comments to the "implementation details", so I did not specify it fully.
> 
> The old review request:
> https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000423.html

src/java.desktop/share/classes/java/awt/Window.java line 248:

> 246:      * Focus transfers for the lightweight components request should be made
> 247:      * synchronously.
> 248:      */

More simpler way "Focus transfers should be synchronous for lightweight component requests"

-------------

PR: https://git.openjdk.java.net/jdk/pull/369

From jdv at openjdk.java.net  Wed Sep 30 06:48:23 2020
From: jdv at openjdk.java.net (Jayathirth D V)
Date: Wed, 30 Sep 2020 06:48:23 GMT
Subject: <i18n dev> RFR: 8251123: doclint warnings about missing javadoc
 tags and comments
In-Reply-To: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
References: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
Message-ID: <tnHLHvl7osSB2H9rvKJArC-M1t8JqkPXqeZPBxF2LTk=.767082c2-f59a-4d23-87d7-be4fe252c4c0@github.com>

On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
> 
> The fix:
>   - Adds missing comments to the non-static/non-transient fields(even private) of the "serializable" classes
>   - Adds comments to the "serializable" classes even if those classes are non-public
>   - Fixes references/adds missing tags to the special methods(like readObject/writeObject)
>   - Delete the java.awt.PeerFixer class.
> 
> I need advice about what exact change should be reviewed in  the CSR(except PeerFixer removal)
> 
> Note that in some cases I added the comments to the "implementation details", so I did not specify it fully.
> 
> The old review request:
> https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000423.html

Marked as reviewed by jdv (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/369

From kvn at openjdk.java.net  Wed Sep 30 20:05:42 2020
From: kvn at openjdk.java.net (Vladimir Kozlov)
Date: Wed, 30 Sep 2020 20:05:42 GMT
Subject: <i18n dev> RFR: 8138732: Rename @HotSpotIntrinsicCandidate to
 @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
 [v5]
In-Reply-To: <UbFqxjvGg7eJrIKC1QXb9OidWtkxQOFKqMoCYUmZ3bM=.bb276fb4-dad8-417f-9a3f-1651c69bc9b5@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
 <zugaqht-Za6mHPKWtaEq-YydzjtdY7uRwR_YWXF7l2w=.4da083f3-d7bd-42d0-99c9-316e9bcae6be@github.com>
 <UCxcU0tRwEz8xXYlW9Hg0wEaKX2JCusvbbCatWV2964=.98b1ef2e-9acd-4e29-84dc-11cad7efdd0a@github.com>
 <MracV-9jG9bjyTmqAYhWD25TSe_-wmxLbpgUAmljM-o=.d4f69d34-a88f-4132-9d35-a1ce7a6f6e19@github.com>
 <UbFqxjvGg7eJrIKC1QXb9OidWtkxQOFKqMoCYUmZ3bM=.bb276fb4-dad8-417f-9a3f-1651c69bc9b5@github.com>
Message-ID: <dsEIZ-D_PrX3aaBsx_9a318aE3SUlGBtfXDysSOk27o=.d1ae353b-bb92-4016-9f74-22f519164d50@github.com>

On Mon, 28 Sep 2020 19:08:04 GMT, Philippe Marschall <github.com+471021+marschall at openjdk.org> wrote:

>> @marschall  I will sponsor it after you integrate the latest update.
>
> @vnkozlov done, I hope I now made it correctly with a merge commit for the latest merge conflict

hs-tier1, hs-tier3-graal testing passed

-------------

PR: https://git.openjdk.java.net/jdk/pull/45

From github.com+471021+marschall at openjdk.java.net  Wed Sep 30 20:07:31 2020
From: github.com+471021+marschall at openjdk.java.net (Philippe Marschall)
Date: Wed, 30 Sep 2020 20:07:31 GMT
Subject: <i18n dev> Integrated: 8138732: Rename @HotSpotIntrinsicCandidate
 to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation
 package
In-Reply-To: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
References: <5_VnH6nLD06u9b1-MywH8s5JuLcMpaPNsOKEEXRjFDI=.8f07c7b8-4015-4cd2-be81-e344815e2dca@github.com>
Message-ID: <GZ_dp8ZoqYV7mdU8wdrzRTRGgLytTsHOthZ5bJtEJh0=.c699e900-4f2a-40e3-8511-542f69f9fae8@github.com>

On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall <github.com+471021+marschall at openjdk.org> wrote:

> Hello, newbie here
> 
> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
> 
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.
> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
>   imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.
> - All tier1 tests pass.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.

This pull request has now been integrated.

Changeset: 2a406f3c
Author:    Philippe Marschall <philippe.marschall at gmail.com>
Committer: Vladimir Kozlov <kvn at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/2a406f3c
Stats:     749 lines in 65 files changed: 149 ins; 149 del; 451 mod

8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package

Reviewed-by: dholmes, alanb, psandoz, kvn, egahlin

-------------

PR: https://git.openjdk.java.net/jdk/pull/45