<i18n dev> RFR: 8220483: Calendar.setTime(Date date) throws NPE with Date date = null

[Joe Wang]

On Mon, 14 Sep 2020 23:15:10 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Thanks, Lance,
>> 
>>> The change looks fine. I might have created a CSR just to track the doc change.
>> 
>> Yes, and thanks for the CSR review too!
>
> Thanks, Joe.
> 
>> The change looks fine. However, are other methods in the same situation, e.g. void setTimeZone​(TimeZone value),
>> getInstance​(Locale aLocale), etc.? Or, would it better to add a general statement about passing in null values?
> 
> Those two methods describe the NPE correctly. There are other locations that may have missed the @throws tag, but I
> would rather fix this specific one this time (for my GitHub training :-)

That makes sense (good start for the 1st PR ;-)).

-------------

PR: https://git.openjdk.java.net/jdk/pull/159