<i18n dev> RFR: 8253208: Move CDS related code to a separate class

[Ioi Lam]

On Fri, 18 Sep 2020 23:47:56 GMT, Yumin Qi <minqi at openjdk.org> wrote:

> With more CDS related code added to VM, it is time to move CDS code to a separate class. CDS is the new class which is
> specific to CDS.
> Tests: tier1-4

src/java.base/share/classes/jdk/internal/misc/CDS.java line 52:

> 50:      * Check if CDS sharing is enabled by via the UseSharedSpaces flag.
> 51:      */
> 52:     public static native boolean isCDSSharingEnabled();

I think the word CDS is redundant in the method names. How about

getRandomSeedForCDSDump() -> getRandomSeedForDumping()
isCDSDumpingEnabled() -> isDynamicDumpingEnabled()  // doesn't return true if we're doing a static dump
isCDSSharingEnabled() -> isSharingEnabled()

src/java.base/share/native/libjava/CDS.c line 49:

> 47: JNIEXPORT jboolean JNICALL
> 48: Java_jdk_internal_misc_CDS_isCDSDumpingEnabled(JNIEnv *env, jclass jcls) {
> 49:     return JVM_IsCDSDumpingEnabled(env);

Maybe: return JVM_IsCDSDynamicDumpingEnabled(env)

-------------

PR: https://git.openjdk.java.net/jdk/pull/261