<i18n dev> RFR: 8263668: Update java.time to use instanceof pattern variable [v6]

Patrick Concannon pconcannon at openjdk.java.net
Tue Apr 20 17:46:49 UTC 2021

On Wed, 24 Mar 2021 10:57:11 GMT, Rémi Forax <github.com+828220+forax at openjdk.org> wrote:

>> Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision:
>>   Updated single letter pattern variable names
> src/java.base/share/classes/java/time/LocalDateTime.java line 1686:
>> 1684:     public long until(Temporal endExclusive, TemporalUnit unit) {
>> 1685:         LocalDateTime end = LocalDateTime.from(endExclusive);
>> 1686:         if (unit instanceof ChronoUnit u) {
> `chronoUnit` is perhaps a better variable name than `u`

Thanks for your comments, @forax, and apologizes for the delay in getting back to you. I was waiting for the boot JDK version to be updated to 16. Certain files changed in the PR are shared between the build tool and the JDK runtime, and were causing build issues.
I've addressed the changes you suggested, and you can find them in commit 647bd6b


PR: https://git.openjdk.java.net/jdk/pull/3170

More information about the i18n-dev mailing list