<i18n dev> RFR: 8263668: Update java.time to use instanceof pattern variable [v6]

Daniel Fuchs dfuchs at openjdk.java.net
Wed Apr 21 09:24:17 UTC 2021


On Tue, 20 Apr 2021 17:46:38 GMT, Patrick Concannon <pconcannon at openjdk.org> wrote:

>> Hi,
>> 
>> Could someone please review my code for updating the code in the `java.time` package to make use of the `instanceof` pattern variable?
>> 
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated single letter pattern variable names

src/java.base/share/classes/java/time/Duration.java line 723:

> 721:         }
> 722:         if (unit instanceof ChronoUnit u) {
> 723:             switch (u) {

Maybe `u` could be replaced with `chronoUnit` here too

-------------

PR: https://git.openjdk.java.net/jdk/pull/3170


More information about the i18n-dev mailing list