<i18n dev> RFR: 8265746: Update java.time to use instanceof pattern variable (part II) [v2]

Patrick Concannon pconcannon at openjdk.java.net
Mon Apr 26 08:35:48 UTC 2021


On Fri, 23 Apr 2021 14:29:36 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

>> Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Removed redundant braces
>>  - Merge remote-tracking branch 'origin/master' into JDK-8265746
>>  - 8265746: Update java.time to use instanceof pattern variable (part II)
>
> src/java.base/share/classes/java/time/Clock.java line 623:
> 
>> 621:             return (obj instanceof FixedClock other
>> 622:                     && instant.equals(other.instant)
>> 623:                     && zone.equals(other.zone));
> 
> The outer set of braces is redundant.

Braces removed in 7f32ddb

> src/java.base/share/classes/java/time/ZonedDateTime.java line 2191:
> 
>> 2189:             && dateTime.equals(other.dateTime)
>> 2190:             && offset.equals(other.offset)
>> 2191:             && zone.equals(other.zone));
> 
> same here.

See 7f32ddb

-------------

PR: https://git.openjdk.java.net/jdk/pull/3650


More information about the i18n-dev mailing list