<i18n dev> RFR: 8268113: Re-use Long.hashCode() where possible [v11]

Claes Redestad redestad at openjdk.java.net
Mon Aug 2 11:22:44 UTC 2021


On Mon, 26 Jul 2021 08:27:14 GMT, Сергей Цыпанов <github.com+10835776+stsypanov at openjdk.org> wrote:

>> There is a few JDK classes duplicating the contents of Long.hashCode() for hash code calculation. They should explicitly delegate to Long.hashCode().
>
> Сергей Цыпанов has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
> 
>  - Merge branch 'master' into 8268113
>  - 8270160 Revert changes in BitSet.hashCode
>  - Merge branch 'master' into 8268113
>  - 8270160 Revert changes in BitSet.hashCode
>  - Merge branch 'master' into 8268113
>  - Merge branch 'master' into 8268113
>  - Merge branch 'master' into 8268113
>  - Merge branch 'master' into 8268113
>  - Merge branch 'master' into 8268113
>  - Merge branch 'master' into 8268113
>  - ... and 3 more: https://git.openjdk.java.net/jdk/compare/1d801fa0...bd762b7d

All changes look good to me, though 3rd party sources like xerces/.../DoubleDV.java should probably be dealt with in the upstream first. @AlanBateman probably knows who maintains and downstreams this usually (or whether we are now practically maintaining a fork of xerces)?

-------------

Marked as reviewed by redestad (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4309


More information about the i18n-dev mailing list