<i18n dev> RFR: 8271302: Regex Test Refresh

[Brent Christian]

On Wed, 11 Aug 2021 18:22:42 GMT, Ian Graves <igraves at openjdk.org> wrote:

> 8271302: Regex Test Refresh

Changes requested by bchristi (Reviewer).

In the JBS issue, it looks like the Description was put in the Environment.  :)

test/jdk/java/util/regex/RegExTest.java line 291:

> 289: 
> 290:         int resultStart1 = mr.start();
> 291:         assertEquals(matcherStart1, resultStart1, "equal matchers have equal start indices");

Should the message be that they *don't* have equal start indices ?

test/jdk/java/util/regex/RegExTest.java line 2362:

> 2360: 
> 2361:         { "test\ud834\uddc0",             "test\ud834\uddc0",             "m", true },
> 2362:         //{ "test\ud834\uddbc\ud834\udd6f", "test\ud834\uddc0",             "m", true }, //problem

Should an issue be filed for these //problems ?

test/jdk/java/util/regex/RegExTest.java line 3952:

> 3950: 
> 3951:             m = Pattern.compile("\\H").matcher(matcherSubstring);
> 3952:             assertTrue(m.find() || ng.equals(m.group()));

Should this be:
`assertTrue(m.find() && ng.equals(m.group()));`

-------------

PR: https://git.openjdk.java.net/jdk/pull/5092