<i18n dev> RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

Phil Race prr at openjdk.java.net
Mon Dec 6 17:54:18 UTC 2021


On Mon, 29 Nov 2021 08:18:47 GMT, Сергей Цыпанов <duke at openjdk.java.net> wrote:

>> Instead of something like
>> 
>> long x;
>> long y;
>> return (x < y) ? -1 : ((x == y) ? 0 : 1);
>> 
>> we can use `return Long.compare(x, y);`
>> 
>> All replacements are done with IDE.
>
> Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8277868: Use Integer.signum() in BasicTableUI

src/java.desktop/share/classes/java/awt/geom/Line2D.java line 115:

> 113:          */
> 114:         public double getX1() {
> 115:             return x1;

What do these changes have to do with the subject of the PR ?

src/java.desktop/share/classes/sun/java2d/Spans.java line 322:

> 320:             float otherStart = otherSpan.getStart();
> 321: 
> 322:             return Float.compare(mStart, otherStart);

We don't need the variable any more, do we ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6575


More information about the i18n-dev mailing list