<i18n dev> RFR: JDK-8276302: Locale.filterTags methods ignore actual weight when matching "*" (as if it is 1) [v2]
Naoto Sato
naoto at openjdk.java.net
Wed Dec 22 17:52:13 UTC 2021
On Wed, 22 Dec 2021 07:33:55 GMT, Daniel Le <duke at openjdk.java.net> wrote:
>> Locale.filterTags methods ignore actual weight when matching "*" (as if
>> it is 1) because LocaleMatcher.{filterBasic,filterExtended} do so.
>>
>> Fix the bug and add regression test cases for it as well as existing
>> behavior.
>
> Daniel Le has updated the pull request incrementally with one additional commit since the last revision:
>
> Address most review comments
>
> - Include "// change to lowercase for case-insensitive matching" and "//
> preserving the case of the input tag" in the if branch in the for loop
> of LocaleMatcher.{filterBasic,filterExtended}
>
> - Remove LocaleMatcher.removeDuplicates since is it no longer used
>
> - For Bug7069824.java, add 8276302 to the @bug tag and update the
> copyright year to 2021
>
> https://github.com/openjdk/jdk/pull/6789#pullrequestreview-836689415
Thanks for the changes. Those all look good. I will sponsor this PR once it is integrated.
-------------
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6789
More information about the i18n-dev
mailing list