<i18n dev> RFR: 8268113: Re-use Long.hashCode() where possible [v9]

[Attila Szegedi]

On Wed, 2 Jun 2021 14:11:07 GMT, Сергей Цыпанов <github.com+10835776+stsypanov at openjdk.org> wrote:

>> Сергей Цыпанов has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8268113
>>  - Merge branch 'master' into 8268113
>>  - Merge branch 'master' into 8268113
>>  - Merge branch 'master' into 8268113
>>  - Merge branch 'master' into 8268113
>>  - Merge branch 'master' into 8268113
>>  - 8268113: Inline local vars where reasonable
>>  - 8268113: Delegate to Double.hashCode()
>>  - 8268113: Re-use Long.hashCode() where possible
>
> src/java.base/share/classes/java/util/BitSet.java line 1040:
> 
>> 1038:             h ^= words[i] * (i + 1);
>> 1039: 
>> 1040:         return Long.hashCode(h);
> 
> Here `>>` instead of `>>>` in original code seems to be a typo

It is specified as `>>` in JavaDoc just above the implementation. As the algorithm is part of the public API and thus part of the specification, I don't think you can change it just here in the implementation; you'd need to at least submit a CSR for it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4309