<i18n dev> RFR: 8268124: Update java.lang to use switch expressions [v4]

Patrick Concannon pconcannon at openjdk.java.net
Wed Jun 9 10:19:53 UTC 2021


On Wed, 2 Jun 2021 16:10:19 GMT, Rémi Forax <forax at openjdk.org> wrote:

>> Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/master' into JDK-8268124
>>  - 8268124: small refactoring; fixed misplaced comment and added missing lambda operator
>>  - Merge remote-tracking branch 'origin/master' into JDK-8268124
>>  - 8268124: Update java.lang to use switch expressions
>
> src/java.base/share/classes/java/lang/invoke/MemberName.java line 331:
> 
>> 329:                 assert(false) : this+" != "+MethodHandleNatives.refKindName((byte)originalRefKind);
>> 330:                 yield true;
>> 331:             }
> 
> this code always yield true, better to check if the assert are enabled, do the switch in that case and always return true

Thanks for your suggestion. I've incorporated it into commit a8706b0

-------------

PR: https://git.openjdk.java.net/jdk/pull/4312


More information about the i18n-dev mailing list