<i18n dev> RFR: 8268124: Update java.lang to use switch expressions [v3]

Patrick Concannon pconcannon at openjdk.java.net
Wed Jun 9 10:25:36 UTC 2021


On Thu, 3 Jun 2021 17:04:58 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8268124: small refactoring; fixed misplaced comment and added missing lambda operator
>
> src/java.base/share/classes/java/lang/constant/DirectMethodHandleDescImpl.java line 138:
> 
>> 136:     public String lookupDescriptor() {
>> 137:         return switch (kind) {
>> 138:             case VIRTUAL, SPECIAL,
> 
> Nit: I prefer to have each case in a separate line (in this switch and also the switch in `resolveConstantDesc`.

Hi Mandy. Thanks for your suggestion. I've now moved each case onto its own line. Please see  ccc9db7 / df5b34e

-------------

PR: https://git.openjdk.java.net/jdk/pull/4312


More information about the i18n-dev mailing list