<i18n dev> RFR: 8268469: Update java.time to use switch expressions [v3]

[Patrick Concannon]

On Wed, 9 Jun 2021 22:03:54 GMT, Stephen Colebourne <scolebourne at openjdk.org> wrote:

>> Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - 8268469: Removed excessive spacing; corrected misplaced comments
>>  - Merge remote-tracking branch 'origin/master' into JDK-8268469
>>  - Merge remote-tracking branch 'origin/master' into JDK-8268469
>>  - 8268469: Update java.time to use switch expressions
>
> src/java.base/share/classes/java/time/LocalDate.java line 608:
> 
>> 606:             if (chronoField.isDateBased()) {
>> 607:                 return switch (chronoField) {
>> 608:                     case DAY_OF_MONTH          -> ValueRange.of(1, lengthOfMonth());
> 
> For the record, I hate code that is aligned like this. It makes refactoring much more noisy, as the author has to readjust all the associated lines. I also don't believe it is within the spirit of Java's traditional coding guidelines.

Hi Stephen. Thanks for your comments. I've tried removing the excessive spacing as you suggested. Please let me know what you think. See commit 2ae4a57

> src/java.base/share/classes/java/time/format/SignStyle.java line 129:
> 
>> 127:             // valid if negative or (positive and lenient)
>> 128:             case 0      -> !positive || !strict;// NORMAL
>> 129:             case 1,   4 -> true; // ALWAYS, EXCEEDS_PAD
> 
> Extra space before `4`

Extra space removed. Please see commit 2ae4a57

-------------

PR: https://git.openjdk.java.net/jdk/pull/4433