<i18n dev> RFR: 8268469: Update java.time to use switch expressions [v3]

Patrick Concannon pconcannon at openjdk.java.net
Tue Jun 22 09:59:07 UTC 2021


On Thu, 17 Jun 2021 13:51:27 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - 8268469: Removed excessive spacing; corrected misplaced comments
>>  - Merge remote-tracking branch 'origin/master' into JDK-8268469
>>  - Merge remote-tracking branch 'origin/master' into JDK-8268469
>>  - 8268469: Update java.time to use switch expressions
>
> src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java line 2793:
> 
>> 2791:                     case NOT_NEGATIVE                -> throw new DateTimeException("Field " + field +
>> 2792:                                                             " cannot be printed as the value " + value +
>> 2793:                                                             " cannot be negative according to the SignStyle");
> 
> Maybe in this case you could revert the alignment. In this case it would allow lines 2792 to 2793 to be shorter

I've removed the alignment of arrow operators as requested. See 24ae9e5

-------------

PR: https://git.openjdk.java.net/jdk/pull/4433


More information about the i18n-dev mailing list